From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.3293.1677050522142555772 for ; Tue, 21 Feb 2023 23:22:02 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jtDTZ74e; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: andrei.warkentin@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677050522; x=1708586522; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jDD0z7jGVH/pk8KK1oO2/Bbbaz43/OutIqVtgwu4Ljw=; b=jtDTZ74epElO9RzPAVnuuF41gPeEpyopMoqWmyi9UEeYuiRrvzSQabUG KE3h3vXRiU4Rz5ulP1idtdXk5vtExEoKNGd9Bu28hkE5Dut1T7V4mqjpo x6oSq7MraCtdkHRrD4NuYOgi8omm85vEn157u8TicFhuOfyY2mA2164nK zmx7ATg4hKWTd54SjJx8H/prCxOBJd2bkgVaojj0BO7Ie6TJ177kvZ7sV gLxjjxC1bHYSbiApUiMrsTNJZ6+0a4/IOmKb7e6uzJfgwObNicBIHw5Vp XZeeVymhEbeF+xqpf5OXAEbMPeH3sDHBYoeFwOmkkYtd/4nRE1BPD7nt4 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="395337950" X-IronPort-AV: E=Sophos;i="5.97,318,1669104000"; d="scan'208";a="395337950" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 23:22:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="814821015" X-IronPort-AV: E=Sophos;i="5.97,318,1669104000"; d="scan'208";a="814821015" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 21 Feb 2023 23:22:01 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 21 Feb 2023 23:22:01 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 21 Feb 2023 23:22:01 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 21 Feb 2023 23:21:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EI88tVa+x07MTc8vv2g4mLN/zOy9yAl7kVoti/743YyWW9c7ALsPiebF6jwHcAnDH2Jt81jFXJzlu6fPB+4WPmCMWpe6rzv/KAZ9VXXyV4+pA7IEMF+6ZfeEhYNkXlleC7bMsu4Iq+8pQg11Fqj+6VZ/sTsWieH3hwh0ps+tdAdAlVa3UGRMklR7x/T3QLF8mj9glY/tet87xOjcyJZiupETO/DYxKWK6AXA6snsRssbAWuIwsl4kBuBOhDwDhtZR9MK8AbuaMZTJW5YtSEwGBm/ozyiMRJcfPwf3YNE1ltKfERJrOyvUwODO4WQthMT/yinYF7jiMa1hlPzs5HT9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/FgPJ9KcwTvQoTFQrWmWusABFylHB26GHXuDRwgRPw=; b=VO9UySmfXN7pd+ZW6nXEhnisQdkhSp+9zBtYz02eQcKBjA2/St6ce/GH5TbKSsaFWsjbGOIOi035u3GPftOmsCzhXBS0bvpSwoetW7+xGbWWjO1f716Go6yRnODjR1yPZtUOVBoBVC01vFqlPCt7yuMzW2ExKgh8XgAv3p7aMqhS25MvcEISDdEVkIsoJC/xJECQSWEg+SZuZNP7iA9kLOLQywjpr+Yhzcz5JJAzL3/v7K8R6/bcMJjB2hL9164fXIfarmqsYimbuABc2VNPZvr/4SWPngLKJ+/gXo+SPEdjW6jLflqcuZpNGZzzRHx7EKROgp65U5g4By2Kz8jdNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB6856.namprd11.prod.outlook.com (2603:10b6:510:22b::7) by PH7PR11MB6476.namprd11.prod.outlook.com (2603:10b6:510:1f0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 07:21:57 +0000 Received: from PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f480:22ed:c915:13f1]) by PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f480:22ed:c915:13f1%8]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 07:21:57 +0000 From: "Andrei Warkentin" To: Sunil V L , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" , "Gerd Hoffmann" , Heinrich Schuchardt Subject: Re: [PATCH V2 1/1] OvmfPkg/RiscVVirt: Fix SCT memory allocation test case failure Thread-Topic: [PATCH V2 1/1] OvmfPkg/RiscVVirt: Fix SCT memory allocation test case failure Thread-Index: AQHZRmaYJEni/LbueESiAEdDud+Cqq7aj7fA Date: Wed, 22 Feb 2023 07:21:57 +0000 Message-ID: References: <20230222023659.2316602-1-sunilvl@ventanamicro.com> In-Reply-To: <20230222023659.2316602-1-sunilvl@ventanamicro.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6856:EE_|PH7PR11MB6476:EE_ x-ms-office365-filtering-correlation-id: dbfaa269-bb44-486e-2aa0-08db14a57b42 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r/SCtxZ0AKx/fTIeI3n3nlCHt4bQwvMyMxdTJAsFw/x1pQtkl8MwTOonVLJIQPK/5XA1YZal5HQqOYkm6+bGdYEaeiXAlwdOa2m+WpOWRr67mE9ai1DiQoHl2BBA+4sbstUE3Io3BG+aqHY6YTlrdDadGWLYshJ0amJh4U2LHcIdwMnMebVzjDobuWzGSBGyrdpq8/Wt6DJq0bB/drRBAEOp2+Yp9AjDrzo8dJrQ9ZSYBMspwkQ8MgUz8GeSc9Gf27i7yK01+G71Ob4kP6CODT8pT60ziVpIgE9V9Kabs1pZYwPwOmsuFbCNaZUUEtk+hTOI/84YiqNWlIH1mHka7b3MyH/af9rG7RvKNsCIFaNjb2svyQztF+OJOKXIYF1OxzvXT+03h00urLGlsXpVrjlTN+QljiujszQdRzC7SGSQxY7WDqI2flAM3YZux0+ZkQVnhLOHdkyVXP+1SXnaTGpH/9N2smp2YL8gYR4TGID1wzZHltt9T2jlVDRqESE/3Mt9i+rSwfGJVAzZNhz2pPLX4COHMbjJdOS98kVQwqHUqb+BQ0K2FIXY3mM9OXTYSEIo/VGBizi5oY9Tcbu0gliCiitk4cPHMZWz2CWzRoF9dJy2Ds9tU8nzi14wIN+SKI/zjI4p3xpvQuvIjWCJwzL/AWm06UzDZTAM/s5vtzehWmAYEavj/pJRbkJiFhMcj+jvP61NArWWbEcevK3g5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB6856.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39860400002)(396003)(376002)(366004)(136003)(451199018)(186003)(8936002)(55016003)(52536014)(33656002)(38070700005)(82960400001)(86362001)(5660300002)(7696005)(478600001)(4326008)(83380400001)(6506007)(26005)(2906002)(53546011)(66556008)(66446008)(66476007)(71200400001)(41300700001)(54906003)(316002)(110136005)(66946007)(76116006)(64756008)(8676002)(9686003)(122000001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wz8RvISJSRV/AqN0PNcSxTKxGANpT2D+LnQY9WUrnsWQGjmt2OBXZEYqk4xX?= =?us-ascii?Q?V82+nPs+Mva1j8rAMUfCcFPjCVC0JjjX03U3y3VBBfooQxHhldcB7wj6OtOM?= =?us-ascii?Q?JMJo9bhgSiW2VlODNBWbzQxXtDTAAGBRet4pdq958IJUtEctSGZCAD8JWJuD?= =?us-ascii?Q?X86Cr7AMrKim/7nv/RLUHI5/bCLQdCweNOO9j7oK61IxjY9ejkECthEzfYD5?= =?us-ascii?Q?ZBwyBuxLsL4Vf0X17+uQBu21DFLzstC9NG5nfjJg8Cn4QvK/vRxzS5uG85Kk?= =?us-ascii?Q?RMElJ2pf5ApLvmlV+fRUtx1xVdR0vrn1f2RYUGyEi0MhYHWhrJyBsC4snkJO?= =?us-ascii?Q?6vJixwH5DVzjXD9HxPcUzUaoIbpTAyCBIhmSP2OszgCCCMHwpnimQ0FjDNYH?= =?us-ascii?Q?3vAEEwEcfLc7kWr1zEKbgRzk8joWdAJeCfWsVegLgMAH9k1+XpT6fVDjt9cD?= =?us-ascii?Q?ZAoIl2OFck89BytWOsbEwXN+vcvydA7e19EWukCWImpKjnAGNockggqw11IG?= =?us-ascii?Q?ayYWDQPpEq5Ngq/oFIBo3YPxHC7Gm1J25NbWP7A+0KL1XkbezLOCKAjgvRQA?= =?us-ascii?Q?tRX8nd8xVhxUQFB9PzUPQbv0A4nzl0J/ClF72iCJloQ3GUdUwJbmFIpW9g/e?= =?us-ascii?Q?CQ/dtDKBAim1y2Lr38GeFfFzi2frZhPKIJ2AyyEKGDXWS6nbTrRVZXcm9hqX?= =?us-ascii?Q?euagpjylglxB4v3/kE9Inu4Tam6QGbAg0glbWED4cqpcWS4KSsYNABn51G8G?= =?us-ascii?Q?+xAwBIyKpsmW6i9u4K6/p62o72q6fMwClauAbAFIIS/nYaYvSf0SIrkZIyym?= =?us-ascii?Q?gj2xI/gexgB0e3L7VIdiHPREJVrE+hiMxiQVLqn2/He3Nl+4mZZBF1PfnIC1?= =?us-ascii?Q?TRstZ+a/uiwlGm1N5uoUV8pmwc1gjoh6ZgYEqhXy7rFUsuU9ndyJKCEECWmi?= =?us-ascii?Q?qeBZuIQUjMkTkc49EilISvTNKVXJ8AHX854zqTMu1F4AS6Z33SiBs2tQg4H4?= =?us-ascii?Q?VsdzwF2poyP/0qCfkuPY6Og+zNTE5ciVUdoyUIpOrB5syOLNpgp7k8p64YGG?= =?us-ascii?Q?sRFsqayAj59z6h5Vl7+BfGZRtiv2diOYDW1EhALd/5f2DgckK6XIImsGVuiB?= =?us-ascii?Q?N2f8AgujjYwzB6M/ypQ21adFvHFvHsBkWfSxVmwrJJEECkq+/XD7JmcOUmdX?= =?us-ascii?Q?3Tlkbiz2zuQP0nxV99oK+qnEHZ+cCsaMj59bDyRv+oK0YgFE+EhHJi77Jc71?= =?us-ascii?Q?jBb5JBEZ7A1qwfGMRQ0TzBoVMCaIYmBqBdS9s7FX8OWNZFntZNzjrPVP9I0p?= =?us-ascii?Q?5/eBN8e+Wl4ovdBc/B01ISjK2nCNYPnTyybRudt3SWU0CoRDz86pUgBUce2H?= =?us-ascii?Q?hUvHq7dxxCIIZ4tDUBpkLg0u47WFLcTd9QZVq6Y1/KDGFOcDMxIDCh0hD/TB?= =?us-ascii?Q?ev+tbyArE1TYguoaqqMP/f5gP8GlmpIszUoqP6UoK8Jv/2wYx8vRM3KRKmkW?= =?us-ascii?Q?it55gTSOP7nFt+GshLZhmN0TjCBDYR04NEd2BN3JxT0aUw4BIgTwMigdnSY8?= =?us-ascii?Q?R66rEIqVxZwEsWvKrq4iNDTchn+io/snTWT3OkTYw74WQCVjdub6f1tN8aT6?= =?us-ascii?Q?NA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6856.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbfaa269-bb44-486e-2aa0-08db14a57b42 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2023 07:21:57.2681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pqw/+pqhmgNI/Y2irLIOy+CrrElAJLYA0bry0isKYvIrHZPrVJOGYYdpbAEqiubVS++qf93cbvXcx/BB5orf//Y4FJV3/qsz0C6igc2DNUQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6476 Return-Path: andrei.warkentin@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin -----Original Message----- From: Sunil V L =20 Sent: Tuesday, February 21, 2023 8:37 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann ; Warkentin, Andrei ; Heinrich Sch= uchardt Subject: [PATCH V2 1/1] OvmfPkg/RiscVVirt: Fix SCT memory allocation test c= ase failure Fix the UEFI memory range calculation by including the correct stack memory= range. Without this fix, SCT hangs in MemoryAllocation test cases which ca= ll AllocateAddress(). Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin Reported-by: Heinrich Schuchardt Signed-off-by: Sunil V L --- Changes since V1: 1) Fixed the inaccurate description regarding stack growth (Thanks Andrei!) 2) Simplified the fix. OvmfPkg/RiscVVirt/Sec/SecMain.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.c b/OvmfPkg/RiscVVirt/Sec/SecMai= n.c index 054e49ef0c1e..73b9b21a67ba 100644 --- a/OvmfPkg/RiscVVirt/Sec/SecMain.c +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.c @@ -71,8 +71,9 @@ SecStartup ( FirmwareContext.FlattenedDeviceTree =3D (UINT64)DeviceTreeAddress; SetFirmwareContextPointer (&FirmwareContext); =20 - StackBase =3D (UINT64)FixedPcdGet32 (PcdOvmfSecPeiTempRamBase); - UefiMemoryBase =3D StackBase + FixedPcdGet32 (PcdOvmfSecPeiTempRamSize)= - SIZE_32MB; + StackBase =3D (UINT64)FixedPcdGet32 (PcdOvmfSecPeiTempRamBase) + + FixedPcdGet32 (PcdOvmfSecPeiTempRamSize); UefiMemoryBase=20 + =3D StackBase - SIZE_32MB; =20 // Declare the PI/UEFI memory region HobList =3D HobConstructor ( -- 2.34.1