[edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value

[edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value

[Sunil V L]

Print the timeout value set in the PCD variable instead of
hard coded 10 seconds.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Andrei Warkentin <andrei.warkentin@intel.com>

Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
 OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
index be4316f320f9..964c35ee5328 100644
--- a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
@@ -936,7 +936,7 @@ PlatformBootManagerAfterConsole (
       );
   }
 
-  Print (L"Press ESCAPE within 10 seconds for boot options ");
+  Print (L"Press ESCAPE within %d seconds for boot options ", PcdGet16 (PcdPlatformBootTimeOut));
   //
   // Process QEMU's -kernel command line option. The kernel booted this way
   // will receive ACPI tables: in PlatformBootManagerBeforeConsole(), we
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106968): https://edk2.groups.io/g/devel/message/106968
Mute This Topic: https://groups.io/mt/100198952/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value

[Andrei Warkentin]

Looks good to me.

Minor nit: is that really a %d (signed) and not a %u?

Reviewed-by: Andrei Warkentin <andrei.warkentin@intel.com>

> -----Original Message-----
> From: Sunil V L <sunilvl@ventanamicro.com>
> Sent: Monday, July 17, 2023 11:59 AM
> To: devel@edk2.groups.io
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Warkentin, Andrei <andrei.warkentin@intel.com>
> Subject: [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value
> 
> Print the timeout value set in the PCD variable instead of hard coded 10 seconds.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> 
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
> b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
> index be4316f320f9..964c35ee5328 100644
> --- a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -936,7 +936,7 @@ PlatformBootManagerAfterConsole (
>        );
>    }
> 
> -  Print (L"Press ESCAPE within 10 seconds for boot options ");
> +  Print (L"Press ESCAPE within %d seconds for boot options ", PcdGet16
> + (PcdPlatformBootTimeOut));
>    //
>    // Process QEMU's -kernel command line option. The kernel booted this way
>    // will receive ACPI tables: in PlatformBootManagerBeforeConsole(), we
> --
> 2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106972): https://edk2.groups.io/g/devel/message/106972
Mute This Topic: https://groups.io/mt/100198952/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value

[Sunil V L]

On Mon, Jul 17, 2023 at 08:47:55PM +0000, Andrei Warkentin wrote:
> Looks good to me.
> 
> Minor nit: is that really a %d (signed) and not a %u?
> 
Thanks!, Andrei. Yes, let me fix it while merging.

Thanks,
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106978): https://edk2.groups.io/g/devel/message/106978
Mute This Topic: https://groups.io/mt/100198952/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-