From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CA570740033 for ; Mon, 17 Jul 2023 20:48:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mpbgUayiDlkpcr2G/Pp58hHtqzSb6zwrg3weKXOyUmg=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTe nantHeadersStamped:X-OriginatorOrg:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689626887; v=1; b=uhGha3tykPTh+6K0JOoiI3QqSR93lAiCEGMjJQu5kYE5LhrcoQHaXsA0VduCGfd3NwrzDWY3 TkwAdZBAiqjnMBgMPiW0qEofl5M/vG1plWWmoN8nMuLrCsq1Po9PJIFWQy+lk6p6ozNHs/UHkC0 qy834RiW/eo3bNElqxx18eL4= X-Received: by 127.0.0.2 with SMTP id 083NYY7687511xDcVoMlquaA; Mon, 17 Jul 2023 13:48:07 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.5896.1689626885751708251 for ; Mon, 17 Jul 2023 13:48:06 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="368676982" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="368676982" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 13:48:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="700624397" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="700624397" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2023 13:47:58 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 13:47:58 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 13:47:58 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 17 Jul 2023 13:47:58 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 17 Jul 2023 13:47:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhSpWLnNmZkSbO52rb2lx4z+uEZTWclN/BO3EAJn38a5AwkNwOE1h9hfxLJlaQp98fiy6qat3Bcr9p4yOPy1WdEFoyCCO7QjiEoKIY2xENajgLwnVAjgw5IHAouEFLUU3tz8qSd3va4uZWk00bCYsm92atB/G+JTuysfHAJ13Q6T1OFDTx96kCy9hfLMv2B80Xn48ExGU92W9oaD6iKXE013yXkdEwg7C2kx7fet9tVdJP8UormaUKQKfDDoXm6tmvMdNJnm+z5mhOIcOOBBigs6ao9UE59phMDZ+76sRiRSa/MWNuoEGvJwjj1MixNI/wwnrGf1VdwnBeUy5YMNfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kLIaI51inAc65RH71Rt28IMNtAJkaZdTelWFL5FaYSQ=; b=F+TpLJagHyLjBV9x5ygWqNc9on/clKHfCHekTgU7CNCLUQk+rfHaifgbNp4iRt2ECLLqQFYq/Wt4vxNxJ9bE/sgMF1x0+72xhTEyY7d8Z2hvYEvNdkDwLBOksGkomKTV5F3yHGUZlIBzqKakk4Dq5ud78xuG5KJyV3H0xP6oDwkJHT/w5suQD+uZVFiQ6OHB/q3EfoZJwVNjRGdN2OFMrq1sF1QduTLHicqmFBmTA/M3CRzs4sZrppvIDT+AppDndhwzLI5Tdau/c++z7RPV2szeb74Tmy2Cd8UL2js3jNW0N9P7vE7ct7FQsPjzmNhLeaRCLQDYoVWCQGd5XVenDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH8PR11MB6856.namprd11.prod.outlook.com (2603:10b6:510:22b::7) by CO1PR11MB5075.namprd11.prod.outlook.com (2603:10b6:303:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 20:47:55 +0000 X-Received: from PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f000:d423:e696:2efe]) by PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f000:d423:e696:2efe%7]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 20:47:55 +0000 From: "Andrei Warkentin" To: Sunil V L , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" , "Gerd Hoffmann" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value Thread-Topic: [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout value Thread-Index: AQHZuNAaLqTi1J/OOEqLN+iLMSMex6++bTmQ Date: Mon, 17 Jul 2023 20:47:55 +0000 Message-ID: References: <20230717165845.3958731-1-sunilvl@ventanamicro.com> In-Reply-To: <20230717165845.3958731-1-sunilvl@ventanamicro.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6856:EE_|CO1PR11MB5075:EE_ x-ms-office365-filtering-correlation-id: d697b957-b0f6-4d8b-e362-08db870718af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SxvKSfZusIg8v2GHGuioJXX6qpzfPToZc2VQKX5b0mR4qPxaPcBLAYFebf0QdJOq3qtRnLxm7ikLHDfcEGdZWDNpasxma9KPpOKKd+m8HGHhXIEh+dc1j5YCZoQsI+qOWR+kRD5bbBc7/9umV6X2Pipl1rMfwXKj1i/Rzpie9XzUCr1G3wT4xRr/sGbCR26WnITVcBgu2uRa+ZMdfwqnDEowSx5MbID2JFYoyLNTTB+ytdzfoyR5wDFS/302c5z0LmjiN15FvyKQALU4eTa5ZIB2WoduZS67u9QpfjM0F9kUed5r8Tz+wZz9IAiJexJcKuiAQGg9iA/wpc+FC1mE767/W6xCtH0Z3yOYMSP5PJQWCzkLyrpz5bp2ubs/UOSjm8/2WuKdx0LfN8rS7HwTmkXWzqCo46IbVxTgEcKackc4CyAwcuIbeiegFro2S+OVaf3MeVTwQWBNQz4ayJg1Acd8nMP0hx4JJrbsl7B4gp2Sn3Uy8imzEjhpFH4u0eFg4hDWtTjuCDeiKAQDT+0M+OxsSwb/2T7TYxyyEZ8jKk6AbA8xx2BgXiSS1xfcJzQKTXvP3GjSjawyxrQRV+xQig7h+sUe+B8eTo6gx5yXUdmqpPsiuPQCmkNsf/n9Prrk x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hPqomP9gs8EB8tPkC9QqqPWGAWz0cJHEN84DKl6x+ComeaxoFv0y9PV0cdGN?= =?us-ascii?Q?+qrNSiQsQHe6tQnr654N9MJRBIK3eBDFNJe0X9rVgTffsly4ki/hGbMyXjxI?= =?us-ascii?Q?DoAo8SUnPihKA/VGkFydsOixAOGZgCBp0Cqw+scocXVLEXHs4puV0lxtZg1w?= =?us-ascii?Q?See+iuB2orK4J+0/cMIHEqmW41VaL4lsHSZI8zhfl2qMYv6sTrqP6mTk0t7g?= =?us-ascii?Q?ZwyCj9t1UmeqOE3iAknv9OEACkj5dXtOBcOfuiOuSL/U6z3PMPMWsK56hAKE?= =?us-ascii?Q?3NmghiU+HVViX81N4drEtAfISArg6fQ9fL9AeTQ5mufLB9yn5XNxl1LktiI+?= =?us-ascii?Q?HAxoRQBdvFjB7I0HRVvzDZv++033/pW+Gvtwf0YCZYFoMDatIBntmntApBG8?= =?us-ascii?Q?SAuMhAclOHsyeS/WzC9HoQQ/j9MqauyPV1WdgsJiMxZo/Pw983bzdCJpy7KX?= =?us-ascii?Q?O1HLhRjs9oVM7mVK3TQ8myvwOL6vbkZ0n1w44lgk2FpSAy3fFSprDUX8lDrN?= =?us-ascii?Q?eNnAhlYlKkeFTZGLHr43tAgRmoIDTIrMHH88/q25PvdVfI+RlK6sTyyJDhil?= =?us-ascii?Q?JGrToTEpNZ/cSPwaUxzHRy8FYsc9V3e7YTpgHEkqq2SrkSwnRQVFz/njxaES?= =?us-ascii?Q?GxbZHFWFmWh5N6mZh3fzOIDpglMixBI0yn78m+tT0AEvBNwUND9NTrdHYDd3?= =?us-ascii?Q?Fy44T/oqyoEmIYL3rgdbmsjCIi5gvfTs2Uys4KY2XVfjmEUWVriqMWdSOCSB?= =?us-ascii?Q?T7YsLXdrwA2a3al1r7lz86bvhPiiZpmLSfL1+M0R0c8oePM3XxDdGSPiPCJ3?= =?us-ascii?Q?ij4R3xY5j3bWXO+UjCY6m4jkCw7iNGcIjCzlhGi4Ry06EGOnxO/tGbasJbES?= =?us-ascii?Q?SruLp/cr5yTwrnUFBU+RmZRqEDxve2fDfje/OlgweMJJNL2Jclt6Wk8+pDdT?= =?us-ascii?Q?wsQcIiH0FY9rrl/VQKN/QeeJ0MT0H1K4hrhQw/4uZ/H9hJ+rV+iF1TEf3KB/?= =?us-ascii?Q?NuX5wIJoBotVmLY87k2Qqsd+xt9i8EXDasGYcjgpEigogwzjC+L706B66GoJ?= =?us-ascii?Q?wBZsFD43PZY9sjvl3gEMgfyxRANRQ+t56MmfNdt7XjMcCdr/67MCrh0qSJ+X?= =?us-ascii?Q?KMGWzHSoju/UUGsFZbhU2g94+V/nYUQfZM0Q128e7Rd7YTJSHIDtCnqYk2I8?= =?us-ascii?Q?mEFTHyAFEQhKWZ9tieqgg8vAnqCguEShL4GBACyqwGtelCc6/zwRJi4nLF1L?= =?us-ascii?Q?JKgOBY6acJJkW2OfUI0NKJvHshfvmFaU6XFBDpWB6Io0TzJGxHTFjTeSGtpj?= =?us-ascii?Q?N0EuZ+H+ZnTFAw8aEVKn7KnI+r9XOcNS0WI6eX98qBB8mDx3rH16LaJTagOV?= =?us-ascii?Q?1h3X/DzhZGTBIB4F3ip0unQiXYojBKaPsR7f2bwVSZQmWGCxw3o2pT0oDjLc?= =?us-ascii?Q?dyKE7sMSltHjMn/KYON1Px0nUut8jZeXPesh/EruM3dGiOmAHQ0Uo8YmOLwo?= =?us-ascii?Q?kN8H7tq/pcZjfSqK5NejA1RTVsvrqOKJkN3L3uZKtg7qpelm89Ziq7pqHsSl?= =?us-ascii?Q?7FTvyimhvymzwtBQsbaXq5t6D5NzAYF7V2ncEPFj2WFjh8ufxNYuCap4mGbu?= =?us-ascii?Q?sg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6856.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d697b957-b0f6-4d8b-e362-08db870718af X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2023 20:47:55.1219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Up+hX95RHN2BDow9evKEfOveGtxP+Odpg7jneYp2XXzWJ94WvnqWc+4rf8uw7p7bjSkTjfxT8qAcd8V+BWsq3OMpIyhXMjuS6Vv2lMclFhI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5075 X-OriginatorOrg: intel.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,andrei.warkentin@intel.com X-Gm-Message-State: zoeoviRL3xb1o5PmSRBMHYJWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uhGha3ty; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Looks good to me. Minor nit: is that really a %d (signed) and not a %u? Reviewed-by: Andrei Warkentin > -----Original Message----- > From: Sunil V L > Sent: Monday, July 17, 2023 11:59 AM > To: devel@edk2.groups.io > Cc: Sunil V L ; Ard Biesheuvel > ; Yao, Jiewen ; Justen, > Jordan L ; Gerd Hoffmann ; > Warkentin, Andrei > Subject: [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout= value >=20 > Print the timeout value set in the PCD variable instead of hard coded 10 = seconds. >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Andrei Warkentin >=20 > Signed-off-by: Sunil V L > --- > OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.= c > b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > index be4316f320f9..964c35ee5328 100644 > --- a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > @@ -936,7 +936,7 @@ PlatformBootManagerAfterConsole ( > ); > } >=20 > - Print (L"Press ESCAPE within 10 seconds for boot options "); > + Print (L"Press ESCAPE within %d seconds for boot options ", PcdGet16 > + (PcdPlatformBootTimeOut)); > // > // Process QEMU's -kernel command line option. The kernel booted this = way > // will receive ACPI tables: in PlatformBootManagerBeforeConsole(), we > -- > 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106972): https://edk2.groups.io/g/devel/message/106972 Mute This Topic: https://groups.io/mt/100198952/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-