From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.29742.1677864609466800263 for ; Fri, 03 Mar 2023 09:30:09 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nbD/3Vb6; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: andrei.warkentin@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677864609; x=1709400609; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=mQx801TySq6E3FtIVGrplftF3lB43mXzSGuVcCQGRsc=; b=nbD/3Vb60pp0guZz10pav7PCP9SaGsHJ7O8V7ax0afIKepMKFEhYZ9W5 jMJt+0ZswP1v1bxnboxpAgpuyLGIBlV8IQlzXI+S0WBxYafcM0khfFCgR cnK19r/OXnrcurXXVhyOC6nq0OGGfJ8vmNNOMSS6XMSygMoDauqwIhczC HprBvdeqVPZ4uOwrQD3cciFSr4NfeVmi6UjXZkiLctNQlhEms7Dm5vmAI z3XwMTU9+esDH9D4t60x9SDBbkUSMNXITdoYvpnUBUVqGUg6JzD7+vqtN O5oj4lhZpL2N11mOiunEAd3QeI8IGCJcrE7w2IrGgvDDj1pgZunU0E4dK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="323398377" X-IronPort-AV: E=Sophos;i="5.98,231,1673942400"; d="scan'208";a="323398377" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 09:30:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="799294342" X-IronPort-AV: E=Sophos;i="5.98,231,1673942400"; d="scan'208";a="799294342" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 03 Mar 2023 09:30:08 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 09:30:08 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 09:30:07 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 3 Mar 2023 09:30:07 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 3 Mar 2023 09:30:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hr/oBuTNuP5VwcOswODxmNQsYFkXr+rlkZpq09jZeqZnZSAK81H3i0Nr+C8Qqn+rjFAd2cA4IvxbunYvvdyMij1qe/83NHr4rQNMWsBUahQ6IW/1KS2Pc1iudFS7Q6j0/ZPuIbTk6goOZoZwbMctBobF3Fg9+VY8rOi3lSveyJEPdD4pRJ5vFm5kOyn/CKtno/sVtwj0ewJr170mWfw4t4v7YJ1hHUHZ6MNSx/9XW/PnsxurJu9o5C0iF9D5kGNY9oCq4N/aIEYdm6+tMJhg7b+cqjg/N4QKNNgEsLs6/o9NwU60gtf5n9TW2VLHUNpsw8toWmv3/UYb7Bfxn6j5zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7zN+6U7rgmBnCLUa9ZhsNA/qXm/0MK0B9h6V0qbLSX0=; b=GHOX6sTEcdrqwHlNd+GyoE4VtHMYZVasWwaWuiyas+7QLI4spDXz4eDqvGRW4KV12CM67K4Lkv6fmH4f7TCm2MrjeVE4RgL521QFyKK3nHf/gz/Lgd396rsWSelFOr/vRtSW2YuZ7mI390W9L8lxIaGQOPm8d17aGSIUAGW2oGknEhOqltq4qqsKN6k5lOQt+rArZCV6lbudtQLzeyrvsmTZZySV5PKL9g/uhv5RJbleC6VNoj9i+6aFUOX4+1I5RyWHGXLWRFXyzj8D0aW2s5h1vvZ1yvsCygTsdS9/iTvYHOSlLhz/yMDvjJhLBvibLu3g1Bbz6wvAM3pA9i8jtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB6856.namprd11.prod.outlook.com (2603:10b6:510:22b::7) by CH3PR11MB8137.namprd11.prod.outlook.com (2603:10b6:610:15c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.22; Fri, 3 Mar 2023 17:30:05 +0000 Received: from PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f480:22ed:c915:13f1]) by PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f480:22ed:c915:13f1%4]) with mapi id 15.20.6156.019; Fri, 3 Mar 2023 17:30:05 +0000 From: "Andrei Warkentin" To: Sunil V L , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2 0/3] v2 RISC-V SBI-backed SerialLib Thread-Topic: [edk2-devel] [edk2 0/3] v2 RISC-V SBI-backed SerialLib Thread-Index: AQHZTVDguJJosfLwj0S0rB9etJfYoq7ojo0AgADA7OA= Date: Fri, 3 Mar 2023 17:30:05 +0000 Message-ID: References: <20230302214920.13817-1-andrei.warkentin@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6856:EE_|CH3PR11MB8137:EE_ x-ms-office365-filtering-correlation-id: e2b3ada8-f07f-44fb-bd82-08db1c0cedad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mFUxtStSH66wNh8DpaaCa9A5Iu0+pZGlZnrftK5dHtYQaIgco4Ck0alsVeMSpVfPiwZwfNffnmO4A6ciALl4RrrtRtIdYxUENvYdqCH5ObOV14xy1u7xGxr6BUVXe/rGSWKfj2ESF63JcD72v8KlWRG67RKqT1VGJfGh5PgDISrccny6FTvANYH35DYD5DGN8aVF3ctYMu+TyrvSD21MbKGAth+MWZA7D07AhztLWJH+oy11gHgIDtjLsY1xIXTW7gvmq40A06zA3mdop7RAWmgp7D3RBfJvacLd0s6vkqEQ1AWRKR/tKcpf/ihb6T+UxaEAEU+BjAmfW3sYVyp1BZk3dfd7pNq1/8vWv9VdzKWLogYhEQAfXvrA2988OAdqMR65bD9udtIEHlaOZudvjQk0xGwiVvkk9LKCLcn/5wSgxzC11w1cXPuMmhwR4R3LWmCObds0fCbGAfLNQ49Z2c8l5PYLo2cc/WuvXicJTwWurybXJlOtwp75lEnyzVYlcrFiG2/yxJTgcwZq1xvPLu7ZFqSuM6D8StspVes4KtMxxG3okZhKwagQYDBpF2T1QgXCw1oA1HuhyaWVOqQBuq36UFBzide9x1Q6Uvv22eb9KXc80bdVtTgrSJd+A++pFjFX0SX+NrYRAe7ud6l4tauT1ZRsCrk1R51GpXMJb/LVJZqXPD9YO13IgsHgnY01WPjDsP1zL1fbkE1UNKshL2NtdAmC0h6PkApi0/fzDEc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB6856.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199018)(66446008)(316002)(66476007)(64756008)(66556008)(66946007)(76116006)(8676002)(110136005)(83380400001)(5660300002)(8936002)(52536014)(41300700001)(26005)(478600001)(53546011)(186003)(6506007)(9686003)(55016003)(7696005)(966005)(86362001)(33656002)(2906002)(82960400001)(122000001)(38070700005)(38100700002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SbyTUKHAaqsOwtKrgwe1I5SBQSTFZHCnUEt/xjSFJch9CtFEe25HXsqwVpqW?= =?us-ascii?Q?/uQX/bV9ri8saMXumkk4hafrju+rCX2qchIGWfFniK8AuGxCvLWdmDBe58S/?= =?us-ascii?Q?3NiHP1l8ilYei3Z+L1tLGjyprzslUopHz5QvPdxx6mOHzm1M1txVwUMJW872?= =?us-ascii?Q?156coqm+RrnFC+ciLcWmWSjkhAB2pdaJiXYu4xIvgHrQAh52od7cImbnldm0?= =?us-ascii?Q?xdhaQw3iuTJnfShzrs1FgQqsl4zpa2oNTfwHqYKj9o51QT2XHxaWp79eAwfa?= =?us-ascii?Q?LtYzigdWD9jicCuenHusJMWiM/GFSmmC1XyTs09X6zKcBvT4HSiUEmEjuytZ?= =?us-ascii?Q?qFpuLlFudBjgFBs8gYe1EognI+RjWUWFC1l5nhggPRrsDKO6L7xgs/4S9fXq?= =?us-ascii?Q?zxGj12h6LFZPlXW9POmAYonJb4Ia9hhXTUlbnqbX4qikVuCrskvIppfXIVdF?= =?us-ascii?Q?gk3i4RN3mr+CG+Wx3DohDv5k+Kr70rG8H6mROxbLQWBj/O+4Jfog5jSA5VWq?= =?us-ascii?Q?sL3lh4Haz5HspkCMczIyixSPPXGhsoS8YSLRovb7KlLo54XmsSsvhNsgf4xM?= =?us-ascii?Q?ge9D8C3axwoB0WNMhxfGHbYHvkLhpPM5gt/JSgsJjBa4KrJZM/45jKadMDCI?= =?us-ascii?Q?0IdQNYtNjuP45Rm4HNaGiHtzLqOXSY+aJ1M0vcbQHuFPdzTifd0M821T8MtT?= =?us-ascii?Q?xBHaI7XU8/AhrpWOcpjeOjHDmKELE7WzinRPUGzpD4HG8bA5O2z7TEWI5Bc8?= =?us-ascii?Q?hwLgKZawsx6aBs1bo9WKZkY5nUmkHeOu5bPCn0IQBrUXADIm80IYGQHN2cX9?= =?us-ascii?Q?cGHvOCmcItJBz8WYotGrSffSLUOE6vEauNYwE8/FEnT8uPDvE0m6krlcCpRM?= =?us-ascii?Q?kxoUwwxSS91YVKGSmOEFE5DuUA2dZ8yCuZyUbvjZsGDDwBpQNtT25X0gUF4E?= =?us-ascii?Q?s9vcpjx8hq0Qwzb2ioDXfnKmyt+pRLcfZQ5mpGM99s3BPPrdDHgtPWfMR26Z?= =?us-ascii?Q?ZwkzCA5yVmdR+NPSC/LAAJwIphJKWAJX7tNPMBHhGQPFq3Fenzn9U0ukuomG?= =?us-ascii?Q?urkdjVBO7/7OMiCrq66er2ZNbp2sN3h8TGakt7ZSVL4V9H4MpyV6qJuW0Slr?= =?us-ascii?Q?9Ti4oUU6o4WEICpqyVgKokrDMLR1puNog+p1K2ur9vRjG9Plbs1KZZM6XXrq?= =?us-ascii?Q?tWui4GZ7q4ZfjLlDUnc/6Z9o2iaUFNQqlaO+vG/nt0M+POfvQ7IrzyJ5nX/l?= =?us-ascii?Q?7Pbes7ym+BnGFXRScdu1ri3+wufl9YRxBUkLIwmPpEu8yWPgW0csKY4izBLm?= =?us-ascii?Q?AeRJhsJicDDWC7tQnXhanwIh3ePJL9qhz0u36LdqD+zGvt+rhaxHEg0KU721?= =?us-ascii?Q?PK+QC+N3wVgP0fnW9zx4bqzwiwgu/WhsZjuq5XcVECSC9LyZDlNlOylUBAAG?= =?us-ascii?Q?wUsU3NDKhiM0ZqkmfApaPeWkLMd/1nlWGjh32Bnmk7wCxqeAKGY4PBxbnq8H?= =?us-ascii?Q?J7a08Wdtdc++L0QL+kVLMbcdBqjZUUQr5Hqo6Yoiv0klK6J0GFJoY+A844ek?= =?us-ascii?Q?yceYQqZLFGgP3EA4k+ftgRULTOfCHi7ekyloBuj2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6856.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2b3ada8-f07f-44fb-bd82-08db1c0cedad X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2023 17:30:05.5672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yFI6K+n6BM73CqmZ9P4BxUQy0fRRY06alM3pw0KprOuq2UkccvSnMtg5xGv/lxpNZPk2o6b4J8oGZ82axnDN/SO5ehDFopPzQB/gkOgcH9E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8137 Return-Path: andrei.warkentin@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sunil, Thanks for the feedback. I had run SetupGit, and CheckPatch doesn't find any CR/LF issues. Are you s= eeing this in the email or up on https://github.com/andreiw/edk2-rv-wip/tr= ee/patchset-2? Is it possible this is getting mangled by the mail server? I do have "trans= ferEncoding =3D 8bit" set. -----Original Message----- From: Sunil V L =20 Sent: Thursday, March 2, 2023 11:54 PM To: devel@edk2.groups.io; Warkentin, Andrei Subject: Re: [edk2-devel] [edk2 0/3] v2 RISC-V SBI-backed SerialLib On Thu, Mar 02, 2023 at 03:49:17PM -0600, Andrei Warkentin wrote: > Hello! >=20 > Here are three patches that provide a SerialLib backed by SBI console.=20 > Both legacy and DBCN mechanisms are supported in various execution enviro= nments and have been tested (with UART and HTIF). >=20 > This is also available at=20 > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2 >=20 Hi Andrei, Here are some quick comments. 1) Please run python BaseTools/Scripts/SetupGit.py -n edk2 in your clone al= ways. 2) Please run BaseTools/Scripts/PatchCheck.py on each patch/commit and fix = the errors. for ex: I see many CRLF errors * Line ending ('\n') is not CRLF File: OvmfPkg/RiscVVirt/Sec/SecMain.c 3)Since these are new INF files, it should have INF_VERSION as 1.27 (0x0001001B) https://tianocore-docs.github.io/edk2-InfSpecification/release-1.27/2_inf_o= verview/24_[defines]_section.html#24-defines-section 4) GUID should be unique for different libraries. 5) MODULE_TYPE should not be BASE but something like SEC|PEI. BASE will inc= lude DXE also. Similarly, DXE library should exclude SEC/PEI. 6) Legacy extensions can be deprecated. So, I think it is better to probe b= oth DBCN and legacy extension and then only use it. Will review in detail some time next week. Thanks, Sunil