From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1CD4AD811A4 for ; Wed, 6 Mar 2024 06:41:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=IJdWllUxJQ1jhVRQPMnmqOvrbhVXRbhJNbkFEVI1G7Q=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709707317; v=1; b=g/PSqcRmeN89a6ugYzoFRUyz4uTU4DrNSpd5Lybnjnd22X7pfN4RV7tIEbzGP29xbTb/Eh9l ysCPuIB/xs+Kj7kkJCHN48FIa42png6pvZk7lyRA3tvTzpZLSoYQfc0W5B5ZzQXU2+kLYBb9+r/ ewnNMispbZj7SD0IUPNSG65iKFbaNDWZyXmREGJWTlGMlJ55o2l/25Yo52W1+aB0BynWLl198aU yBZLw4a16Md2sJmwZCaJ0ZzdTuJDX9qHoEadAFo9IBn4Ydmo9vpnu3eikCuIBdHP4eY5F26POhe cEvqQEPrZgf2wYg9WsZhxkcdTkoAsbj7VQ5+0tbG18NUA== X-Received: by 127.0.0.2 with SMTP id UOrZYY7687511xThJL6qymZC; Tue, 05 Mar 2024 22:41:57 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.79]) by mx.groups.io with SMTP id smtpd.web11.6519.1709707317176613231 for ; Tue, 05 Mar 2024 22:41:57 -0800 X-Received: from PH8PR12MB7025.namprd12.prod.outlook.com (2603:10b6:510:1bc::22) by CY8PR12MB7434.namprd12.prod.outlook.com (2603:10b6:930:52::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Wed, 6 Mar 2024 06:41:53 +0000 X-Received: from PH8PR12MB7025.namprd12.prod.outlook.com ([fe80::c817:975f:13b:6679]) by PH8PR12MB7025.namprd12.prod.outlook.com ([fe80::c817:975f:13b:6679%7]) with mapi id 15.20.7339.035; Wed, 6 Mar 2024 06:41:53 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: support config2 protocol Thread-Topic: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: support config2 protocol Thread-Index: AQHabjewryCfRvJI70WaM2xm1OrNnLEqN6mggAAOmmA= Date: Tue, 05 Mar 2024 22:41:57 -0800 Message-ID: References: <20240304132658.41244-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f3e957b4-7f74-4703-9afb-c46e67dc008f;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-06T05:49:26Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR12MB7025:EE_|CY8PR12MB7434:EE_ x-ms-office365-filtering-correlation-id: 5f24e86f-e252-4386-3b41-08dc3da88297 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7byE7cKrAz1zNWaijBReZ+Lp1tfEOSUdTMeD0A0D6eupFh7h6p6KmFHE1EBS+yUdxi6ioSwKbiGU9nYRmicK2e0M2SBMj665S8krHPfl3WZIQBMXqWmsY6aztq2ylSZMhprLtX/CpSfyNM34uOhZ1twVhGWj+pzQ6UnOZ9+WnhmRSfTWaQtpxd41tt9TAI3WURT3c4wf95tJZLdEI1LhkULtoIa0mnv82c/Y1psnsZxjdwq761SbDfEXyhKIXWts8S0zkMfU/lSvgGC79DhNNn6ZyULItpo8vcNNsqxFWToUo2kid0TV7mF/z7VnzKy3FOCgB1PlRfPTRVHwTxh9RfTzRd2TMXpb00+MFtgKmw0NfqAffkNQdrKggqvJoQIULLq6PYBJf2CVVAOwLrMKWl214jD0R5iD02CRjJnULIxDcwdH267GgUSByA3Px2JO1UMrzTwh65QFRvghj6J50hngtkdfaT+kfcI+rUxosMqMHeVBhCMrfdK8oqmgY2306hFs4HW9QOasBwDd1cGR/2B4d8y90l0DFKOxQUHmo/DXp7SU2Ocbg5eYWE7tvmc+rht1iM6TWUkqSS/q4NAI7BcBy31cZQde+GZS2kEJaKCdpc+8bh95slVD+JYjeiKbizbEZT4ZQnLI3ocheh47N9eKSrVmX33/yPCgj5y68T8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zrz6bYF+7ZviLtW3YaV7elp0ZSmziYt2q7u4TbVuVtnN9mB7BG2YntIZXvgq?= =?us-ascii?Q?2c1RN34J3prJ4JBKGvFkdW3M3uFuG0G/sj1E4P1JGT8T6/cHDIDBYW5oN800?= =?us-ascii?Q?xkIQXxHtf1ounEqM8Sy5p+z/7i3Z3lwZmW9zZbIEq+mDn8bDRp/q6A52UFql?= =?us-ascii?Q?K0PSvA7paYzdUmDwKyyinILFQpHhnhGCMEPNLUv5EF65fj0ZoIY+bhi4gsOa?= =?us-ascii?Q?f6JGbtQSN5LwKS64UsRkh+rShJVxp/d29d45w49bkQg0HiiVrcA8f0RtXjer?= =?us-ascii?Q?7ikBoeXBuaipBOBgqqh/ONr9cNCHbT75chqH4z15rkdOg2OcPbqacB2Co5UN?= =?us-ascii?Q?AHdlu9uyxVAOpRwHUbDysHasy2V7AvkY5SGOp04jNTIRfOE00UM8wNZPgKFz?= =?us-ascii?Q?RcVtMv4bJfWn8P14wvaYIMmSMeiCWwtowLrZLQEfBpEhFa1M+Kx/pInraawC?= =?us-ascii?Q?HAX/JLCvnQXrzcKrVkzcJskPVsp/Qhxzaf8V2udtj0Dze+p+pM3ikBnfaHzK?= =?us-ascii?Q?byhGGBk6nuCuWJmFW0bYjUvex+l7NeP/WFwaug/FIta11l7/9oJFdcWurHQZ?= =?us-ascii?Q?M7EoBYDNXZaZsFPiKnQr8kH0XGGqiLN68LsxEqhVUBh6qTjKX2+qNos9L4aM?= =?us-ascii?Q?t8ZTxgFGtPouby2ZbobPXKoIDHGWcW/gJUSbeqoKYA3uCr0XBajBm6III6MT?= =?us-ascii?Q?Ra/j5CZQkfl+wxPr2ESEXR0OcSd3zWgQlOcFR/ykjF+0f9KBEs7e27z1sNTj?= =?us-ascii?Q?xcOKxTEFdiWZT+Dzu2s2PxTkoi9r6gSKPJNh4Soe+2fzd2AqYm7QiLd7N8kO?= =?us-ascii?Q?IOE91HNaeUtgWhmfyXwfEfuKUGHAEaJ/cuA2R1T1qFk22516X0XWv72GcU+E?= =?us-ascii?Q?oL/Ytf04lNUFxD4cXDFJv5ggVlUKuxUz6RyATWxR50SRPCa5a51g8k7MRfD1?= =?us-ascii?Q?GgrZ9qnu6hYCEesiDdN+HxATEP2ig7JJtrIuXkfuhSRKeiZQKD/TnP+gmerD?= =?us-ascii?Q?K9846tLpfca2skNQhODR9UK2GFsrnyFjFsJKUNfjvlcZVnNCJI38dzaCO+Is?= =?us-ascii?Q?9X7cginsRbBZPO1skQf9AqxOY6gfng1AizHS16COnqCR0GZC+sQZxQcooSzv?= =?us-ascii?Q?9lhgifLRIxFZlZkS2iJoSCGCBfA6g0rVB7MJwvoF8LSxr/t12pApPoOeSeNa?= =?us-ascii?Q?NxbttYeMaweM5IlbGe4/JojUI8JZS5PmOVc1QVcwb1bq2TOPiZ2S0/XjMIvR?= =?us-ascii?Q?/VVmVUcvFsKa/yMofx0hopVGK8542HDRi1/Qr9CRY+24/iQ2g9Sc52ShW8MU?= =?us-ascii?Q?/XzwQNrDgiWinaKhbux3sB8YmX51c/jEg+rdWdiwIB7mSeRXjLEzq4d7OmM5?= =?us-ascii?Q?F2co4EYIMg0yO80vIeG0YDBgmryf94j+QMw+k9gsqt6j/eSGtCXNovfzhW7i?= =?us-ascii?Q?PQm2XWV/r2HQ0bHjXH/C6oeDENZ8CCv0wWPCePn0rwBxjQixPkN+BfTjRLKR?= =?us-ascii?Q?zKGhXyf89MpYq5qJ129XxiLt3AA3HEaAjQOi5CoS/LRUNThQVHa34wQQsLA1?= =?us-ascii?Q?FUDtuXxjaJdVYqbqS2U=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB7025.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f24e86f-e252-4386-3b41-08dc3da88297 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2024 06:41:53.4319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sd0+/KirffXWHhS7T4m23I43MNYg8dIEg5oATjoAPdpfXI1oizRyHxIoQ7N5o+pMuO+Ykz/YJD9dzRJanzwogQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7434 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HiveHWUsvxV5LtjSXE0n2gCkx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="g/PSqcRm"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Yes that is correct. Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er > via groups.io > Sent: Wednesday, March 6, 2024 1:51 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] > RedfishClientPkg/Features: support config2 protocol >=20 > External email: Use caution opening links or attachments >=20 >=20 > [AMD Official Use Only - General] >=20 > Hi Nickle, I think we have to merge this patch with 2/3. Otherwise, the b= uild will > be failed on the commit of 2/3, right? >=20 > Thanks > Abner >=20 > > -----Original Message----- > > From: Nickle Wang > > Sent: Monday, March 4, 2024 9:27 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Igor Kulchytskyy > > ; Nick Ramirez > > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: > > support > > config2 protocol > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Because EdkIIRedfishResourceConfigLib is updated to support Redfish > > resource config2 protocol, update corresponding functions in feature > > drivers. > > > > Signed-off-by: Nickle Wang > > Cc: Abner Chang > > Cc: Igor Kulchytskyy > > Cc: Nick Ramirez > > --- > > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 14 +++++++------- > > .../BootOptionCollectionDxe.c | 14 +++++++------- > > .../ComputerSystemCollectionDxe.c | 16 ++++++++-------- > > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 16 ++++++++-------- > > 4 files changed, 30 insertions(+), 30 deletions(-) > > > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > > index 1f3c30147..1eb269a84 100644 > > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > > @@ -782,7 +782,7 @@ HandleResource ( > > > > DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", > > __func__, Uri)); > > > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, &SchemaInfo); > > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: > > %s %r\n", __func__, Uri, Status)); > > return Status; > > @@ -795,7 +795,7 @@ HandleResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri))= ; > > ConfigLang =3D RedfishGetConfigLanguage (Uri); > > if (ConfigLang =3D=3D NULL) { > > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, P= rivate- > > >InformationExchange); > > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, > > + NULL, > > Private->InformationExchange); > > if (EFI_ERROR (Status)) { > > if (Status =3D=3D EFI_UNSUPPORTED) { > > DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by > > us\n", __func__, Uri)); @@ -811,17 +811,17 @@ HandleResource ( > > } > > > > // > > - // Check and see if target property exist or not even when > > collection memeber exists. > > + // Check and see if target property exist or not even when > > + collection > > member exists. > > // If not, we sill do provision. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > > if (EFI_ERROR (Status)) { > > // > > // The target property does not exist, do the provision to create = property. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Ur= i)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Ur= i, > > Private->InformationExchange, FALSE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > + Uri, NULL, > > Private->InformationExchange, FALSE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: > > %r\n", __func__, Status)); > > } > > @@ -833,7 +833,7 @@ HandleResource ( > > // Consume first. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, > > Uri)); > > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, > > + NULL); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -842,7 +842,7 @@ HandleResource ( > > // Patch. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL)= ; > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > diff --git > > a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionD > > xe > > .c > > b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionD > > xe > > .c > > index 4f94a4495..cd1437f54 100644 > > --- > > a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionD > > xe > > .c > > +++ > > b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionD > > xe > > .c > > @@ -44,7 +44,7 @@ HandleResource ( > > > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > > process resource for: %s\n", __func__, Uri)); > > > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, &SchemaInfo); > > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to get schema information from: > > %s %r\n", __func__, Uri, Status)); > > return Status; > > @@ -58,7 +58,7 @@ HandleResource ( > > SystemRestDetected =3D FALSE; > > ConfigLang =3D RedfishGetConfigLanguage (Uri); > > if (ConfigLang =3D=3D NULL) { > > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, P= rivate- > > >InformationExchange); > > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, > > + NULL, > > Private->InformationExchange); > > if (EFI_ERROR (Status)) { > > if (Status =3D=3D EFI_UNSUPPORTED) { > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > > \"%s\" is not handled by us\n", __func__, Uri)); @@ -88,7 +88,7 @@ > > HandleResource ( > > // If not, we sill do provision. > > // > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a Check > for > > %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > > if (EFI_ERROR (Status)) { > > if (Status =3D=3D EFI_UNSUPPORTED) { > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > > \"%s\" is not handled by us\n", __func__, Uri)); @@ -99,7 +99,7 @@ > > HandleResource ( > > // The target property does not exist, do the provision to create = property. > > // > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a > provision > > for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Ur= i, > > Private->InformationExchange, FALSE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > + Uri, NULL, > > Private->InformationExchange, FALSE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to provision with GET mode: > > %r\n", __func__, Status)); > > } > > @@ -114,7 +114,7 @@ HandleResource ( > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a > system > > has been reset to default setting. ignore pending settings because > > they may be stale values\n", __func__)); > > } else { > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a > consume > > for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, > > + NULL); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to consume resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -124,7 +124,7 @@ HandleResource ( > > // Patch. > > // > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a update > for > > %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL)= ; > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to update resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -262,7 +262,7 @@ CreateCollectionResource ( > > > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > > supported schema: %a %a.%a.%a\n", __func__, SchemaInfo.Schema, > > SchemaInfo.Major, SchemaInfo.Minor, SchemaInfo.Errata)); > > > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > BootOptionUri, Private->InformationExchange, TRUE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > BootOptionUri, NULL, Private->InformationExchange, TRUE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to create resource for: %s: > > %r\n", __func__, BootOptionUri, Status)); > > } > > diff --git > > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > > mCollectionDxe.c > > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > > mCollectionDxe.c > > index 975ba0564..55a6d07db 100644 > > --- > > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > > mCollectionDxe.c > > +++ > > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > > mCollectionDxe.c > > @@ -35,7 +35,7 @@ HandleResource ( > > > > DEBUG ((REDFISH_DEBUG_TRACE, "%a: process resource for: %s\n", > > __func__, Uri)); > > > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, &SchemaInfo); > > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to get schema information from: > > %s %r\n", __func__, Uri, Status)); > > return Status; > > @@ -48,7 +48,7 @@ HandleResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri))= ; > > ConfigLang =3D RedfishGetConfigLanguage (Uri); > > if (ConfigLang =3D=3D NULL) { > > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, P= rivate- > > >InformationExchange); > > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, > > + NULL, > > Private->InformationExchange); > > if (EFI_ERROR (Status)) { > > if (Status =3D=3D EFI_UNSUPPORTED) { > > DEBUG ((DEBUG_MANAGEABILITY, "%a: \"%s\" is not handled by > > us\n", __func__, Uri)); @@ -90,11 +90,11 @@ HandleResource ( > > } > > > > // > > - // Check and see if target property exist or not even when > > collection memeber exists. > > + // Check and see if target property exist or not even when > > + collection > > member exists. > > // If not, we sill do provision. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > > if (EFI_ERROR (Status)) { > > if (Status =3D=3D EFI_UNSUPPORTED) { > > DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"%s\" is not handled by > > us\n", __func__, Uri)); @@ -105,7 +105,7 @@ HandleResource ( > > // The target property does not exist, do the provision to create = property. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Ur= i)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Ur= i, > > Private->InformationExchange, FALSE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > + Uri, NULL, > > Private->InformationExchange, FALSE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to provision with PATCH mode: > > %r\n", __func__, Status)); > > } > > @@ -117,7 +117,7 @@ HandleResource ( > > // Consume first. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, > > Uri)); > > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, > > + NULL); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to consume resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -126,7 +126,7 @@ HandleResource ( > > // Patch. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL)= ; > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to update resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -236,7 +236,7 @@ CreateCollectionResource ( > > > > DEBUG ((REDFISH_DEBUG_TRACE, "%a: supported schema: %a > %a.%a.%a\n", > > __func__, SchemaInfo.Schema, SchemaInfo.Major, SchemaInfo.Minor, > > SchemaInfo.Errata)); > > > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > Private- > > >CollectionUri, Private->InformationExchange, TRUE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > + Private- > > >CollectionUri, NULL, Private->InformationExchange, TRUE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a: failed to create resource for: %s: > > %r\n", __func__, Private->CollectionUri, Status)); > > } > > diff --git > > a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > > b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > > index 1b7d74e86..d963fb52a 100644 > > --- > > a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > > +++ > > b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > > @@ -35,7 +35,7 @@ HandleResource ( > > > > DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", > > __func__, Uri)); > > > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, &SchemaInfo); > > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: > > %s %r\n", __func__, Uri, Status)); > > return Status; > > @@ -48,7 +48,7 @@ HandleResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri))= ; > > ConfigLang =3D RedfishGetConfigLanguage (Uri); > > if (ConfigLang =3D=3D NULL) { > > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, P= rivate- > > >InformationExchange); > > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, > > + NULL, > > Private->InformationExchange); > > if (EFI_ERROR (Status)) { > > if (Status =3D=3D EFI_UNSUPPORTED) { > > DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by > > us\n", __func__, Uri)); @@ -86,17 +86,17 @@ HandleResource ( > > } > > > > // > > - // Check and see if target property exist or not even when > > collection memeber exists. > > + // Check and see if target property exist or not even when > > + collection > > member exists. > > // If not, we sill do provision. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > > if (EFI_ERROR (Status)) { > > // > > // The target property does not exist, do the provision to create = property. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Ur= i)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Ur= i, > > Private->InformationExchange, FALSE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > + Uri, NULL, > > Private->InformationExchange, FALSE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: > > %r\n", __func__, Status)); > > } > > @@ -108,7 +108,7 @@ HandleResource ( > > // Consume first. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, > > Uri)); > > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, > > + NULL); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -117,7 +117,7 @@ HandleResource ( > > // Patch. > > // > > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL)= ; > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: > > %r\n", __func__, Uri, Status)); > > } > > @@ -227,7 +227,7 @@ CreateCollectionResource ( > > > > DEBUG ((REDFISH_DEBUG_TRACE, "%a, supported schema: %a > %a.%a.%a\n", > > __func__, SchemaInfo.Schema, SchemaInfo.Major, SchemaInfo.Minor, > > SchemaInfo.Errata)); > > > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > Private- > > >CollectionUri, Private->InformationExchange, TRUE); > > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > > + Private- > > >CollectionUri, NULL, Private->InformationExchange, TRUE); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, failed to create resource for: %s: > > %r\n", __func__, Private->CollectionUri, Status)); > > } > > -- > > 2.34.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116422): https://edk2.groups.io/g/devel/message/116422 Mute This Topic: https://groups.io/mt/104721516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-