Hi @Rebecca Cran<mailto:rebecca@bsdio.com>,



I create pull request here to downgrade the message level to DEBUG_INFO: https://github.com/tianocore/edk2/pull/5897



Regards,

Nickle



> -----Original Message-----

> From: Rebecca Cran <rebecca@bsdio.com>

> Sent: Wednesday, July 10, 2024 2:48 AM

> To: Nickle Wang <nicklew@nvidia.com>; Abner Chang <abner.chang@amd.com>;

> Igor Kulchytskyy <igork@ami.com>

> Cc: devel@edk2.groups.io

> Subject: Re: RedfishPlatformConfigDxe needs Depex on

> gEfiRegularExpressionProtocolGuid?

>

> External email: Use caution opening links or attachments

>

>

> I'm ok keeping the current behavior as long as the DEBUG_ERROR message is

> removed or downgraded to DEBUG_INFO. As it is, it makes it look as though the

> driver has failed when error messages are highlighted during the boot.

>

> --

> Rebecca Cran

>

> On 7/8/24 21:53, Nickle Wang wrote:

> >> Should the following change be made to make sure RegularExpressionDxe

> >> is loaded before RedfishPlatformConfigDxe?

> >

> > It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigDxe

> because EfiCreateProtocolNotifyEvent() is used to get Regular expression

> protocol. And I don't have objection to add the dependency as you suggested to

> eliminate the false alarm.

> >

> > Regards,

> > Nickle

> >

> >> -----Original Message-----

> >> From: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>

> >> Sent: Tuesday, July 9, 2024 4:25 AM

> >> To: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Nickle Wang

> >> <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>

> >> Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>

> >> Subject: RedfishPlatformConfigDxe needs Depex on

> >> gEfiRegularExpressionProtocolGuid?

> >>

> >> External email: Use caution opening links or attachments

> >>

> >>

> >> I noticed that RedfishPlatformConfigDxe prints an error message that

> >> it can't find EFI_REGULAR_EXPRESSION_PROTOCOL.

> >>

> >> Should the following change be made to make sure RegularExpressionDxe

> >> is loaded before RedfishPlatformConfigDxe?

> >>

> >> diff --git

> >> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf

> >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf

> >> index 2db47c2cf..7490d89be 100644

> >> ---

> >> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf

> >> +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.in

> >> +++ f

> >> @@ -60,4 +60,4 @@

> >>

> >> gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty

> >>

> >>    [Depex]

> >> -  TRUE

> >> +  gEfiRegularExpressionProtocolGuid^M

> >>

> >> --

> >> Rebecca Cran




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119861): https://edk2.groups.io/g/devel/message/119861
Mute This Topic: https://groups.io/mt/107110826/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-