From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 228287803E3 for ; Thu, 22 Feb 2024 13:51:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9FyX2y9qnpxAHr4EQEtnC09peMA8LOKkmpIeY/Gseik=; c=relaxed/simple; d=groups.io; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:Feedback-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708609901; v=1; b=nHrZx0Zh23cayP30OMhnJ0szVnjCug3h8syJktbO3AIOEYjiugXVhvCLkGEo1DMDd431JuPE 88PC3La8oCEQA1dsL7DGD/UcAuhjC8jDIQFBah7p6suptcA9ZPeB+hw2dBWLMhRYeYavHJU5kkz Sp1Wm0MGq0F9iSSq7iq+fbtg= X-Received: by 127.0.0.2 with SMTP id FzUdYY7687511xcAXKdBxCm7; Thu, 22 Feb 2024 05:51:41 -0800 X-Received: from mail-40138.protonmail.ch (mail-40138.protonmail.ch [185.70.40.138]) by mx.groups.io with SMTP id smtpd.web10.13054.1708609900982216600 for ; Thu, 22 Feb 2024 05:51:41 -0800 Date: Thu, 22 Feb 2024 13:50:37 +0000 To: "Desimone, Nathaniel L" From: "memristor2 via groups.io" Cc: "devel@edk2.groups.io" , "lersek@redhat.com" Subject: Re: [edk2-devel] Peims are not gettting Dispatched in EagleStream Platform Message-ID: In-Reply-To: References: <0600b231-8baf-645a-a287-8d623f692bd8@redhat.com> Feedback-ID: 99609138:user:proton MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,memristor2@proton.me List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IsrfpUzEDs80fOQPrO7A0HRMx7686176AA= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nHrZx0Zh; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thank you. Based on what you told me (memory corruption and and the unlikel= ihood of the stack pointer being NULL) my only suspicion would be the micro= code I am using, since the only platform dependent parts up until this part= would be the microcode and the FSP-T and since I am using the FSP for Eagl= eStream only the microcode would be left to change. Up until now I was usin= g Whitley's microcode (since EagleStream's hadn't been released yet). To be= honest I still don't have a proper comprehension of the concept of the mic= rocode so I thought maybe I could use Whitley's microcode. But now that Eag= leStream's microcode has been released I'll try with that and let you know = whether it works or not. Yet I am still skeptical about it being a microcod= e issue because my thought is that the microcode is procosser architecture-= based code rather than it being platform-based code. Please correct me if I= am wrong on this matter. On Thursday, February 22nd, 2024 at 3:42 AM, Desimone, Nathaniel L wrote: > > -----Original Message----- > > From: devel@edk2.groups.io devel@edk2.groups.io On Behalf Of Laszlo > > Ersek > > Sent: Wednesday, February 21, 2024 3:59 PM > > To: devel@edk2.groups.io; memristor2@proton.me > > Subject: Re: [edk2-devel] Peims are not gettting Dispatched in EagleStr= eam > > Platform > >=20 > > On 2/21/24 07:59, memristor2 via groups.io wrote: > >=20 > > > Hi, > > > I am trying to build edk2-platforms for EagleStream Platform. The > > > problem I am facing now is that the Peims are not getting dispatched > > > when The PeiMain routine calls PeiDispatcher(). > > > After digging deeper into it it seems that the DepexSatisfied() > > > routine is always returning false. So I also checked this and realize= d > > > that the place that is returning false is inside the > > > PeimDispatchReadiness > > > function: > > > ||``` > > > case (EFI_DEP_END): DEBUG ((DEBUG_DISPATCH, " END\n")); > > > StackPtr--; > > > // > > > // Check to make sure EvalStack is balanced. If not, then > > > there is > > > // an error in the dependency grammar, so return > > > EFI_INVALID_PARAMETER. > > > // > > > if (StackPtr !=3D &EvalStack[0]) { > > >=20 > > > DEBUG ((DEBUG_DISPATCH, " RESULT =3D FALSE (Underflow > > > Error)\n")); > > > return FALSE; > > > } > > >=20 > > > DEBUG ((DEBUG_DISPATCH, " RESULT =3D %a\n", IsPpiInstalled > > > (PeiServices, StackPtr) ? "TRUE" : "FALSE")); > > >=20 > > > return IsPpiInstalled (PeiServices, StackPtr); ``` It seems > > > that when entering IsPpiInstalled StackPtr in always NULL. > > > Any thoughts on this? > >=20 > > StackPtr being NULL seems extremely unlikely; it is supposed to point t= o > > elements of the EvalStack local array (or I guess one past the last ele= ment). > >=20 > > Now, I can see two potential problems here: > >=20 > > - your depex is malformed (for whatever reason), and the eval stack is = not torn > > down entirely before reachig EFI_DEP_END. The code seems to handle that > > correctly, by returning FALSE. > >=20 > > - your depex is malformed such that it immediately starts with an > > EFI_DEP_END. The code is actually buggy for that case, because it decre= ments > > StackPtr first, before comparing it against &EvalStack[0]. > > That decrement invokes undefined behavior. However, I assume in practic= e the > > behavior will be the same as in the previous paragraph. > >=20 > > A NULL StackPtr value I cannot explain at all. >=20 >=20 > Agreed with Laszlo here... the only thing that I could think of is memory= corruption. Several people at Intel (myself included) as working on gettin= g an EaglestreamOpenBoardPkg posted to edk2-platforms right now. I would re= commend you wait for us to release our code as opposed=20 >=20 > > Laszlo > >=20 > >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115816): https://edk2.groups.io/g/devel/message/115816 Mute This Topic: https://groups.io/mt/104498510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-