From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.88]) by mx.groups.io with SMTP id smtpd.web08.2847.1620677105818134859 for ; Mon, 10 May 2021 13:05:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=0iLsR0Ru; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.88, mailfrom: garrett.kirkendall@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=borAhPP3frWvy5F+z8l7TkHAniEKc9vr+fFlhLIaB81P9CuvGDxA0el2Yd3PHum3SsDeq0lYSvz0LVQs6N8bjIuOssfoq+DTSHlr5zwkAPALhGLifLIOYQRPHOEjYA9LjIOkHz6r62tJ/tcKlm7W/q1cq22wh62xjVTv84z9MimcbobeHXkPm/sKrxXkB4Y3YL/YOhULYDWLnV+1L40+otSSmTQQmGSaiqYtgQJ8G6izhqKoUjHFvVrEW2e7yx9lD9jq/Ac6T1DPLM+C9myY3/c6WTPtgtEXhYmMx2oYeMNV/crsVjmvk5MQyMe0ii0keKEQFF/zV7lOtvNpOqxDsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGnIBlnEquXFOJoF1wFLg86iRVBeJeU95QbiZ6R+qX8=; b=FQS4Fcy4vzy035jSf9c+ih73mn47BPPvr/xWXVSAa9qw/PVi1VtXI+Jug1iWP6Or/V3Min4qXBN/o+YsXokWxaGBGmTRok+Fo55wfKpyAEblFi5B65hzff8xeNY5GBS7L6y6cAUPK8o+Hs/2ktODjoOHI/HRRNSk2Tz6gQ5mynkyM2h+gODvkxaNikJJN0qJJ/w8AihkrfLMtGPn/shws4p4GfGnScm7olH0hWEOgc1gLrfyY/Kt8J2bhu5yi5/gRNhgOtQlsWQE1+GwR42tjBtVBDVuyJOl7KuR2IUzC/g1AFqnNz9w5ZIunzBYYNZ0k6AcCw0kJryy3qtJL5E8mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGnIBlnEquXFOJoF1wFLg86iRVBeJeU95QbiZ6R+qX8=; b=0iLsR0RusEgX7C9s9juSboERQv5WwSuJegn6K8s0T+G4Ai3LTrbSBiKUMHsCdfWV9LrwrmeC1M+gwGZFdvTZhV1u3sXPuzNsoHJCDjzZVbyBCwEbNKhZtR6rgBfwTSwdz3EUCmGbwssK04lnZy7j2yZrUMCl8UYiebSSylmBOqI= Received: from SA0PR12MB4525.namprd12.prod.outlook.com (2603:10b6:806:92::10) by SN6PR12MB2717.namprd12.prod.outlook.com (2603:10b6:805:68::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 20:05:03 +0000 Received: from SA0PR12MB4525.namprd12.prod.outlook.com ([fe80::137:15ff:beb7:fdf4]) by SA0PR12MB4525.namprd12.prod.outlook.com ([fe80::137:15ff:beb7:fdf4%5]) with mapi id 15.20.4108.031; Mon, 10 May 2021 20:05:03 +0000 From: "Kirkendall, Garrett" To: "devel@edk2.groups.io" Subject: DSC POSTBUILD problem/question Thread-Topic: DSC POSTBUILD problem/question Thread-Index: AddF0p1Rh39Os/ocSKe7MSs6FXBf7g== Date: Mon, 10 May 2021 20:05:03 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_Enabled=true; MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_SetDate=2021-05-10T20:04:51Z; MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_Method=Privileged; MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_Name=Non-Business; MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_ActionId=1639740d-c760-4091-8fc4-900b61b42290; MSIP_Label_f2ed062d-8486-4f50-a4f1-3cce0dd00d64_ContentBits=0 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; x-originating-ip: [76.164.77.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a51fd10-8909-4452-7ca8-08d913eee60f x-ms-traffictypediagnostic: SN6PR12MB2717: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ukOAWPJ/suLsW62udX3j0K0EwbakTnkkjQsOTJwu3If8/dv76ElFq+bdtisOSDvONq2/1Pc7I1qH+iboQKpRx2r2J1rzZoNfekzuzYKMRjxp+tIpAlGrKzlV+3atwM6SvASnQSPxgBvHF2HJY90mKbEu7HvN5vhZfjHP+HlwBj8uJI7y3TvugMGMO0sHCZjNTuZz0SsphT12ZkEDlSdS9z9Th76yc9M+maQFFVR2li+a3uvez3p56VCwIW7vXVRnT/JL1Ief2Z/iDFbsvb1g3UjLjQEwjo3vIq3u5yBEL0ivEoR5MQBCYKU4SdotbiH5DrQmYh163LiCv/coYTnkxNJZXp9Zua9m7gR9pWVC2ZnwEoR2X2kVfCSjW/87AxWFJORBMe4rV4tibW2aJGir0HnQ5RtduG6lFV8sG3kkv2n05C/7H4W2V//SVa8ST/2ahOOXnmsBpSYeL7kHS7j7398w6De++E97qwbh1XScRyZ/3I4T8oA+pz0mZK1mpdrzpiwwRYSN/hHuffMP5OJ6jPMIVSmEshuxIaCDxZcKNaU2jrsYe1qIzXYcKjdtPHgZM8LZSi4aH4KBSyQrGWs/s7YoKipm6MPfyZIZo4Lh2bYZmALfbuadN3sm9uOmWK6lov+XUc1gLCEC+U2QWvke2v8/7WM2RQPd2fT3nYnU5LMU7z/ICMDgfQjt+l6Z3P5Ru329QVqoGNlfle9+XRRFfw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR12MB4525.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(39860400002)(396003)(346002)(66556008)(3480700007)(66476007)(71200400001)(66446008)(8936002)(33656002)(76116006)(6916009)(66946007)(966005)(64756008)(5660300002)(122000001)(316002)(26005)(166002)(9686003)(7696005)(55016002)(8676002)(83380400001)(478600001)(2906002)(86362001)(186003)(52536014)(6506007)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0QHy2kbkvGRdkmAUORNiec50bjcO+JAWzOtNZBmqdILgH8m6r4x3FrbA1cS/?= =?us-ascii?Q?rMrJ1E61ArstQAEai0FQ/XMa2iTnu+wJozTWMjHT17AH05AIbGb/f4n5P/cS?= =?us-ascii?Q?/madZDs4mhYXVt58mGKQL4ScylxH4BwanpkSIsOomrwnogJlZzkNkt1A8/zZ?= =?us-ascii?Q?B2ZCR7lhPUq0nipEdrLpd7+OUv6Xdf6yFM7ubvoQ0h4t2QPI7Rz7x4FMkVu1?= =?us-ascii?Q?QcJgWOWKMp8ptjdWRF1ceZ9on7AsZNDby+YkVKTcYbmz/uH0jCotBZ2O7zYq?= =?us-ascii?Q?W5yge18ObM/gHX3cLcF+jqXSY2m/F6p6Gt7Bh450nK203Uu94+WmM6+Yc7pz?= =?us-ascii?Q?F0bWq+MVumHQiOuJFcHeKMZCdzxJeTlLV6ZoAmfL7/PwARe8BR+UgRDvxC9b?= =?us-ascii?Q?FwBDcr+lh+QlxMRsnt3UMaRvgfADmN7v91ItqLRTKAC4a2hIgogdIHo0GxLl?= =?us-ascii?Q?cTECTYwrE8wQrYUhmDpzhzx0QtWHKkS9mTg89EbzM6hEyv9IzcCXbSplBX8G?= =?us-ascii?Q?UyafAzx6qBIObsD0pB9IsFqARtljc9h27DA2lISNwDZcXwQWsGXamoFMZbuq?= =?us-ascii?Q?qqLQJZR+moDfLwLv9cFMJS/j1n4Aq58E4DcxjKPRPTGIMbh2szK46Nuws0lt?= =?us-ascii?Q?RN8IVMsQkpxkNuFnS4BcjThCEB4pHqSGQvBv3xTA4rq1nnmjiRo1IZ0uqFX8?= =?us-ascii?Q?aLlxXn3azOo17UK7/WTrPtPoXAa9l9/du0g7kEZbf7D7DK02omcXB2KhJ45L?= =?us-ascii?Q?KAWZVnWZqHtn9c/VjjJMt4us+HThZ5wfO8zxAtMeXEWi1Y+N7qeng+5H9ln5?= =?us-ascii?Q?fahwrh4O8FWm4jiYLHbqVNJzOBDn3oL22fBZW82qeoYlrd49NPwt6btqCb2l?= =?us-ascii?Q?VjXLDtqbvJnOBXYeW4LdPonj3vgG0RVjEgPAGzZyVTuANmmL0N7ZZNH1Rgh8?= =?us-ascii?Q?oouelcQLPvOhCqHVQhjB+iul/Iq713QKR7xlM9K+L8N04HzYb5962sFJRw7l?= =?us-ascii?Q?Zo3gxv9C2/1qzKZwH9/X/9XY/yB8vbUiJPY62CT5sV49yDl9mVh48DQDx6H6?= =?us-ascii?Q?xHMZthuVeJR4n3DrbHhAQ68tDVm790zkrZEVMhZT95S2RdteydiICqrL+nAJ?= =?us-ascii?Q?deD1ibTzQ4wxpf5ozdfnaOmfBbkEmxhP2NyAEWwaUBFe2SZBZ07F7KksxQiO?= =?us-ascii?Q?6YSYRKo7YGLrD6rJX74bZMEGtkNIbTMlIDW1+K0LtvbmP+2YCEUFS0uc34RA?= =?us-ascii?Q?uTbC/MjfcQQdA5eH6UsIVSzfWphnb7DQU4RVMDkudZt3OG/CC5AKEqFMQP0i?= =?us-ascii?Q?TIJDLYsWByclOOa5P7PZR35v?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4525.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a51fd10-8909-4452-7ca8-08d913eee60f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 20:05:03.1041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 34BRI04QBlVBnrABn8Pz4mJCpcn1AejF+mRd4vzTQG/J4p5Rq75r7pmQggsNucopDN+OC/s37SkmDhEi9r9Nog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2717 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SA0PR12MB452517E8253003D72D0B8D4685549SA0PR12MB4525namp_" --_000_SA0PR12MB452517E8253003D72D0B8D4685549SA0PR12MB4525namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I'm checking out the PREBUILD and POSTBUILD option in a DSC. I can launch = my scripts, etc. When there is a POSTBUILD error, build.py properly says the build failed, = but build.py is still returning 0 (success). MyBuild.LaunchPostBuild() exe= cution does not look like it affects ReturnCode which is returned at the en= d of Main. "Conclusion" is updated though to indicate a failure. Any idea= s? I assume build.py should return non-zero if POSTBUILD fails. >>From end of edk-stable202011build.py:Main() if ReturnCode =3D=3D 0: try: MyBuild.LaunchPostbuild() Conclusion =3D "Done" except: Conclusion =3D "Failed" elif ReturnCode =3D=3D ABORT_ERROR: Conclusion =3D "Aborted" else: Conclusion =3D "Failed" FinishTime =3D time.time() BuildDuration =3D time.gmtime(int(round(FinishTime - StartTime))) BuildDurationStr =3D "" if BuildDuration.tm_yday > 1: BuildDurationStr =3D time.strftime("%H:%M:%S", BuildDuration) + ", = %d day(s)" % (BuildDuration.tm_yday - 1) else: BuildDurationStr =3D time.strftime("%H:%M:%S", BuildDuration) if MyBuild is not None: if not BuildError: MyBuild.BuildReport.GenerateReport(BuildDurationStr, LogBuildTi= me(MyBuild.AutoGenTime), LogBuildTime(MyBuild.MakeTime), LogBuildTime(MyBui= ld.GenFdsTime)) EdkLogger.SetLevel(EdkLogger.QUIET) EdkLogger.quiet("\n- %s -" % Conclusion) EdkLogger.quiet(time.strftime("Build end time: %H:%M:%S, %b.%d %Y", tim= e.localtime())) EdkLogger.quiet("Build total time: %s\n" % BuildDurationStr) Log_Agent.kill() Log_Agent.join() return ReturnCode master is the same code: https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/build= /build.py#L2738 Garrett Kirkendall SMTS Firmware Engineer 7171 Southwest Parkway, Austin, TX 78735 USA AMD facebook | amd.com --_000_SA0PR12MB452517E8253003D72D0B8D4685549SA0PR12MB4525namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I'm checking out the PREBUILD and POSTBUILD option i= n a DSC.  I can launch my scripts, etc.

 

When there is a POSTBUILD error,  build.py prop= erly says the build failed, but build.py is still returning 0 (success).&nb= sp; MyBuild.LaunchPostBuild() execution does not look like it affects Retur= nCode which is returned at the end of Main.  "Conclusion" is updated though to indicate a failure.  Any = ideas?  I assume build.py should return non-zero if POSTBUILD fails.

 

 

 

 

From end of edk-stable202011build.py:Main()

 

=     if ReturnCode =3D=3D 0:

=         try:

=             MyBuild.= LaunchPostbuild()

=             Conclusi= on =3D "Done"

=         except:

=             Conclusi= on =3D "Failed"

=     elif ReturnCode =3D=3D ABORT_ERROR:

=         Conclusion =3D "Aborted&quo= t;

=     else:

=         Conclusion =3D "Failed"= ;

=     FinishTime =3D time.time()

=     BuildDuration =3D time.gmtime(int(round(FinishTime - Sta= rtTime)))

=     BuildDurationStr =3D ""

=     if BuildDuration.tm_yday > 1:

=         BuildDurationStr =3D time.strfti= me("%H:%M:%S", BuildDuration) + ", %d day(s)" % (BuildD= uration.tm_yday - 1)

=     else:

=         BuildDurationStr =3D time.strfti= me("%H:%M:%S", BuildDuration)

=     if MyBuild is not None:

=         if not BuildError:

=             MyBuild.= BuildReport.GenerateReport(BuildDurationStr, LogBuildTime(MyBuild.AutoGenTi= me), LogBuildTime(MyBuild.MakeTime), LogBuildTime(MyBuild.GenFdsTime))=

=  

=     EdkLogger.SetLevel(EdkLogger.QUIET)

=     EdkLogger.quiet("\n- %s -" % Conclusion)<= /o:p>

=     EdkLogger.quiet(time.strftime("Build end time: %H:%= M:%S, %b.%d %Y", time.localtime()))

=     EdkLogger.quiet("Build total time: %s\n" % Bui= ldDurationStr)

=     Log_Agent.kill()

=     Log_Agent.join()

=     return ReturnCode

 

master is the same code:

https://github.com/tiano= core/edk2/blob/master/BaseTools/Source/Python/build/build.py#L2738=

 

 

Garrett Kirkendall
SMTS Firmware Engineer
7171 Southwest Parkway, Austin, TX 78735 USA
AMD   facebook  |  amd.com=

 

--_000_SA0PR12MB452517E8253003D72D0B8D4685549SA0PR12MB4525namp_--