I found a couple of extensions for Visual Studio Code that will highlight bad characters. "Highlight Dodgy Characters" seems to do the trick.
Sorry about that AMD Official Use Only thing. The wonders of modern email apps!
Garrett Kirkendall
SMTS Firmware Engineer
7171 Southwest Parkway, Austin, TX 78735 USA
AMD
facebook |
amd.com
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Friday, February 5, 2021 11:03 AM
To: Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Pham, Tony Q <tony.q.pham@intel.com>
Subject: RE: [edk2-devel] EDK2
[AMD Official Use Only - Internal Distribution Only]
[CAUTION: External Email]
One I know the file path, I usually use a Notepad++ feature:
Search-> Find Chars In Range-> Non ASCII
Mike
From: Kirkendall, Garrett <Garrett.Kirkendall@amd.com>
Sent: Friday, February 5, 2021 7:11 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish
<afish@apple.com>
Cc: Pham, Tony Q <tony.q.pham@intel.com>
Subject: RE: [edk2-devel] EDK2
[AMD Official Use Only - Internal Distribution Only]
0x9d is one of those pesky "smart quotes" many applications love to use. These are the double quote or single quote characters that slant left and right instead of the straight up and down like the ASCII versions.
They can be very hard to track down in a source file because a lot of editors have very subtle slants to the smart quotes.
This usually happens when you copy from one app like MS Word and paste into your source file.
Garrett Kirkendall
SMTS Firmware Engineer
7171 Southwest Parkway, Austin, TX 78735 USA
AMD
facebook
| amd.com
From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Bob Feng via groups.io
Sent: Thursday, February 4, 2021 11:40 PM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>
Cc: Pham, Tony Q <tony.q.pham@intel.com>
Subject: Re: [edk2-devel] EDK2
[CAUTION: External Email]
Tony,
This build failure should be caused by one of your c or header files have non-ascii characters.
You may need to change the basetools’ code to see which file has non-ascii characters
Change C:\edk2\BaseTools\Source\Python\AutoGen\StrGather.py, Line 536
except:
EdkLogger.error("UnicodeStringGather",
AUTOGEN_ERROR, "SearchString: Error while processing file", File=File, RaiseError=False)
raise
to
except:
EdkLogger.error("UnicodeStringGather",
AUTOGEN_ERROR, "SearchString: Error while processing file", File=File, RaiseError=True)
Thanks,
Bob
From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Michael D Kinney
Sent: Friday, February 5, 2021 11:30 AM
To: Andrew Fish <afish@apple.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Pham, Tony Q <tony.q.pham@intel.com>
Subject: Re: [edk2-devel] EDK2
Hi Andrew,
If the character is part of the code (not a comment), the ignoring the codec error could silently produce the incorrect FW behavior.
I prefer a failure with a correct identification of the file/line # so the file can be fixed.
The EDK II CI checks will not allow files in with these types of issues.
Mike
From: Andrew Fish <afish@apple.com>
Sent: Thursday, February 4, 2021 4:11 PM
To: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Pham, Tony Q <tony.q.pham@intel.com>
Subject: Re: [edk2-devel] EDK2