From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.1766.1661280494575463504 for ; Tue, 23 Aug 2022 11:48:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=g5LZJNkf; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661280494; x=1692816494; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4eX90AVTwWTDGln9BEX0oAp5eEFEeHA6hw8DuqU9NnM=; b=g5LZJNkfK2r771pnYIqJqKmWZ9qEMNo9CRwDxabOxsSolZgqri0N5iSt PBl8OOOnMfy5v5Tmw1YO/ULkIAWNAiMNKZCG3oLlaTQaVQr/Fzuwqfjjj v1In+AIIqwtUZhcUG4Gy6zHDZWFRoiCSwWrpYrmp/pVStj2zwL6/1K5Yk qXzsiMBZNrjxne3cxSBkX+zOIdy5YpPmlB4mxxnqrN1c9DK1kHxhIXC+K U2FrSjctNn7uEaulUJP4ft3mnsmqfT6R4l5G+nynj7cg85NYtQFGCKY3j YUTYy0GooHpHq9urHiyvTURcrL4OQR2NweL1J6Hc0JkqLIaDLdBqr3deS g==; X-IronPort-AV: E=McAfee;i="6500,9779,10448"; a="291331994" X-IronPort-AV: E=Sophos;i="5.93,258,1654585200"; d="scan'208";a="291331994" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 11:48:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,258,1654585200"; d="scan'208";a="698779521" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 23 Aug 2022 11:48:14 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 11:48:13 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 11:48:13 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 23 Aug 2022 11:48:13 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 23 Aug 2022 11:48:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VDVT806d72ZZtMWLu4BvZreV/pss17GdBIl/xYq+jnilqSM9YehfpbnopZgz8cDfNnXhohjTKHAKJ18NgntVkwXdKPdYelLeAGn1XECs13icRXreV4mPIEShwFE7/Wb6DJ+kvaeZ2eOaT8eO1IEiTOOyiPsk9zEZjcBiHKAHLa0faFc/WhW2il1f0NEeXzJINvocgp+4YHn18Hz7ka6zeKiKbl0M1tBQRZhdPRaQHRSlppYFnACjHtIjYG2jBonPkFhJwze0epdyOSumMpVRdEdMqiUo+Edf0o9TCmqjBg5aeGU+5rz5F6/qHM6rD/1Yn3rnW6gbO3rTz+FfxnsrCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MyJKLJwHSyeXwbhGaGumhBFu/72Dtlv5GTEQ8VrUoa0=; b=HVf7rnZU5NthbjWIyE8HiNOwu0KMg/BrVrAqX104fk2EXyzjuRQwmnz/rGnwq8aEKUF/f0mcjl/H/j5QZvxogQbadvrwJ5MqlLaf+ar+KwUn7ZwUxc8w2bz063GVbTC8/Qaw/gbjIgzmBdRD/OOXSQhZxcaoVr2Pb9jr1LNV2BnwLAlr+2rcPDrgTPxf/RhTpisx1SFYIAYXGaXG4XCb8FRSsuaKnroiDWcbsWOWn7AvgasJCiNwGPholnxT1fA1AvVaVCe2al73BFSm5WMIpNaV3zHVr5dIeZiHi3WSErbd90CE4OdUEahCD+o5RmRJOUzAC0c0qQG7l+Aule19kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM5PR11MB1276.namprd11.prod.outlook.com (2603:10b6:3:14::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.20; Tue, 23 Aug 2022 18:48:11 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::d1ab:10f2:3d04:2b09]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::d1ab:10f2:3d04:2b09%4]) with mapi id 15.20.5566.014; Tue, 23 Aug 2022 18:48:11 +0000 From: "Oram, Isaac W" To: "Singh, DeepakX" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "S, Ashraf Ali" , "Pir, Ovais F" Subject: Re: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments Thread-Topic: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments Thread-Index: AQHYtyDkyL/HG/lGEkiemVnNfuxHCw== Date: Tue, 23 Aug 2022 18:48:11 +0000 Message-ID: References: <2ca9fbfafd8fa1df47f001d40d0b5f5c4135a0b9.1661241884.git.deepakx.singh@intel.com> In-Reply-To: <2ca9fbfafd8fa1df47f001d40d0b5f5c4135a0b9.1661241884.git.deepakx.singh@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a70e3959-7ba8-46a3-165b-08da85380774 x-ms-traffictypediagnostic: DM5PR11MB1276:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jo1PFcvVVTxbVBn5SYUb1yeD6YCXJLX8hLI6oyaQqQo0ifCXvt1SeRYU7OitocQWenXNaVBPv5PwJ1rtXp1wN0/7Vggo9/KtRjtfKTC7V+HAns9ollZIkDC4uRKHGYL7s1Vg3t9NVxjVVf7YW7XEMxIy6VEFEt0TC6UGwNt/SoO0+Midcc766ShlqQpo5V0abqEe4ACqr5yU3gzOLvDHvH3JkysNo37NxErJY5P63kgjhKSFYQBYDHFMOfEnUOtQWT7aFTo1O03Od57LTPRo9WTNYgnCCeOap8eAGFXh10RLxTwwTLLNxabLbxFJD5kpfWToLsiACO6OdavU2Uy0PVfrhJkIe6hf7R2/ZhM/RSMnCi5RsO3Yv5puGI3i7PBQK7vLyTfvtSu1PK0S6iSAMmQDaMlN0kuULILkJa4mbE5xtG8sH/JVKTkZmpbdLVJ/nNF0lY6TyTcw+Qfbb8mwM1uJq03wmNwBJ5SX9EILTZ/LHKmc9JTJNh8Yo41rhjRLm6j5+t5mQenfVgSyJFmriZ7iMZBtVy7shS7lqxIS8oJ3E9V4Z2c1z/80ktyOw5Ds+i9cSI+iMSRh5fn9oQSHKad7ovWTsTmvmOSZYSuglYbrCA3buG7SWs9CJgErSbmyGByzkcysApxAUVcY5vbFOpzeXuc/rhhUyUy3rHqkezX5AD9B9hA6G095wkBnVhImNI3TEe2efCOYhiS5mKXo35IbK+XluViYRzgOe+KHXifk8+YPAN7mrYNn0bxtQx/gtaOVh8QA9Yo5mvRQeVm8RYmqjQ327oVCTH6TA1bmcNg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(346002)(366004)(396003)(39860400002)(66556008)(966005)(66946007)(5660300002)(41300700001)(76116006)(38100700002)(316002)(122000001)(66476007)(107886003)(71200400001)(4326008)(8676002)(55016003)(8936002)(54906003)(478600001)(66446008)(52536014)(64756008)(110136005)(2906002)(33656002)(6506007)(53546011)(26005)(9686003)(186003)(7696005)(83380400001)(86362001)(38070700005)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+ucaESVCt8vGCFKuPcmN1XjX5IQw1yCtK/n73eLPTLwIjWHNVeJDYzqtxPbp?= =?us-ascii?Q?Ma5qgpQXpYcu8+EeKZoM2NErDNX2Eh1nWtvIQif53jARGkphWo6HKw8q5Ml4?= =?us-ascii?Q?Px/s9Vf/VWiZT/C3IT8M6bZlbDwAtKyQQyUrrxZIWHajLUh+0tNQAzx54Njo?= =?us-ascii?Q?OanK66FkZAwHwIo9kPcmflhTbXYUae/kcBPvUZfSZQ8kKvntZrtRS1/96WDE?= =?us-ascii?Q?FxmIxKzneaDKNhQ7DdW73B5dt63ocNcRxSdFGqd54ieZB5f23gkmHQ+mT1DU?= =?us-ascii?Q?K+OGBpYjNAmqCI/wK3hFvKNI/rYfQ7ylWkVSZhXRuBxRz48ehIUtt1pQ500B?= =?us-ascii?Q?0c+vWigjBnJ/IvauAyE160jB6lqN0ODSIg9DBjRR/usCBv9TfYvEwBvkxAsL?= =?us-ascii?Q?3Uy6+u0tP97xdwcqiHJVqUm58RvT8GxIewOlgWZIoqxVGEIz25Gl/hI1ObDA?= =?us-ascii?Q?+MMHt9irMPIkvxGgeXWp5SAozi2cuiMOsqs6QNQBkjdh2Jtwes98FWhVdj98?= =?us-ascii?Q?8ACftO+8g5ggDfvM3fGSCc+5HRngfpTh6ZEE6yRvgEmaJl+dsU0ySV+RTl17?= =?us-ascii?Q?SvSkhECYiikPf8wjQRRs/Kwb0qsyiYlGo3gsjxFUiBOacHLzaBzJc2Jr2XbW?= =?us-ascii?Q?VbAJFo7rhQcci0iwmq+GaRMK0WL9BtQcOEUfsi/Q9nucvKGN//Xm8McqpCJz?= =?us-ascii?Q?gqj26XnqfNqxcLL1diYJ2kBqUwjfaIu0aSjeLKMyQW4Dj8bYkji4c0KE5fy8?= =?us-ascii?Q?EAU4Z+KTWM7auKX3MZkw9V7K0G4S/8hbsDCdM97zk9EtK+JOm48KJcWp7o3c?= =?us-ascii?Q?w/2XgLADrbYl0NdaQX/uUXUCY4uvDYk2GuDDSWXAF3SVvil9ezr7jiB7f2Ae?= =?us-ascii?Q?MoH0zvGPLhNvMsKq7ydMogzsksaR43kqfU5unTqCPRRZTheVDslI6Cy8GkBq?= =?us-ascii?Q?BINT5nUWHNEbkpuzTih+CZLgEcFZzjyOqEJLoTRFNzlqFOMkP3WYNfp1Ceg8?= =?us-ascii?Q?vue0EuvfWC3dIYsBMD2uZbQDIOQMaTUPgEKBS91/5Toh7gyGNA3FP48crGqB?= =?us-ascii?Q?ihi0dWUHlJ/sraMTs47bK0daoZVKxwhsKmJT1Jfo/g5T/389AtwngJNVhUrY?= =?us-ascii?Q?4Doc+4RPcYUh16ItXW733795GsZ9V+5paPVx7OgZeIES4NrMDqULVC3laKnL?= =?us-ascii?Q?O9xo7gv5Pm6Et5tjdPlCqgizbJDsZqX9Cky+jdfaMxpKBKYjjLU4AwUt1gKF?= =?us-ascii?Q?ECAgbIOvYuVrXyuZlSZABJX8iQjASqzDbTWd4flUwxUd+18aH+Q02Py+e3Pl?= =?us-ascii?Q?VzF7DLKwsmXAb70GiAuh6bULnZp26+avxO1uKJJ8KWuBiRDQ+hyJT/Fbh6DJ?= =?us-ascii?Q?L/DBttudpUp8J7BQUYiMUFwHEb+zKbvQ2Xc98oj++AfEK2BQ5G5eC0rJR0T/?= =?us-ascii?Q?Xh44saq2JdgAaZJOcRrLQas8NysTVX9HB2tHDM+lewQbKUJGR1+c99oxEnPc?= =?us-ascii?Q?cQcUz9N9dMQxzPrAXpKJlrGDJrGOFfW4BN8PH+T9Z7UQpZAClPAE5c2WJN1q?= =?us-ascii?Q?+bA1xqLlhYUwzcnE49huqFsBLIsmJljzkwfz4Pd/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a70e3959-7ba8-46a3-165b-08da85380774 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 18:48:11.5745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ys8Pg7GnDEdfg5JFL6dMAAHLY2cXfqUFed7yMo2XrVJpX/j/k73UdzXzkXklLL/LEeAU7z0Ed+qmMlW8e34ubA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1276 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram Note that comparing the two patches shows no delta other than timestamp and= title. -----Original Message----- From: Singh, DeepakX =20 Sent: Tuesday, August 23, 2022 1:44 AM To: devel@edk2.groups.io Cc: Singh, DeepakX ; Ni, Ray ; C= haganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali ; Pir, Ovais F Subject: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect numb= er of arguments REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4027 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Cc: Ovais F Pir Signed-off-by: Singh Deepak5x --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index aa2bf14fa8..7a70dc7aea 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -488,7 +488,7 @@ DoMeasurementsFromDigestRegister ( DEBUG((DEBUG_INFO, "\n")); } =20 - DEBUG((DEBUG_INFO, "ExtendDigestRegister...\n", ExtendDigestRegister))= ; + DEBUG((DEBUG_INFO, "ExtendDigestRegister...\n")); ExtendDigestRegister (PciIo, DeviceSecurityPolicy, TcgAlgId, DigestSel= , Digest, DeviceSecurityState); } } diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c= b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c index c7a56cf571..ef1737b1b6 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c @@ -642,7 +642,7 @@ DumpVtdVerRegs ( IN VTD_VER_REG *VerReg ) { - DEBUG ((DEBUG_INFO, " VerReg:\n", VerReg->Uint32)); + DEBUG ((DEBUG_INFO, " VerReg - 0x%x\n", VerReg->Uint32)); DEBUG ((DEBUG_INFO, " Major - 0x%x\n", VerReg->Bits.Major)); DEBUG ((DEBUG_INFO, " Minor - 0x%x\n", VerReg->Bits.Minor)); } @@ -657,7 +657,7 @@ DumpVtdCapRegs ( IN VTD_CAP_REG *CapReg ) { - DEBUG((DEBUG_INFO, " CapReg:\n", CapReg->Uint64)); + DEBUG((DEBUG_INFO, " CapReg - 0x%x\n", CapReg->Uint64)); DEBUG((DEBUG_INFO, " ND - 0x%x\n", CapReg->Bits.ND)); DEBUG((DEBUG_INFO, " AFL - 0x%x\n", CapReg->Bits.AFL)); DEBUG((DEBUG_INFO, " RWBF - 0x%x\n", CapReg->Bits.RWBF)); @@ -688,7 +688,7 @@ DumpVtdECapRegs ( IN VTD_ECAP_REG *ECapReg ) { - DEBUG((DEBUG_INFO, " ECapReg:\n", ECapReg->Uint64)); + DEBUG((DEBUG_INFO, " ECapReg - 0x%x\n", ECapReg->Uint64)); DEBUG((DEBUG_INFO, " C - 0x%x\n", ECapReg->Bits.C)); DEBUG((DEBUG_INFO, " QI - 0x%x\n", ECapReg->Bits.QI)); DEBUG((DEBUG_INFO, " DT - 0x%x\n", ECapReg->Bits.DT)); --=20 2.30.2.windows.1