From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.2654.1659732013558717697 for ; Fri, 05 Aug 2022 13:40:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=cGkJKGPH; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659732013; x=1691268013; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QXgGy4iFhbCatHON8xXjy1eKr/flIFbuksnctwnNJjg=; b=cGkJKGPHHY4sfzxB76yEEv3cIgfJOvf3VOLdXyo86gUfYpQaDI9VFRfp FAo3cxg3k8IOW8i7sDkTU0pRfew+/Zd2hMicp6ujpC8VwnKuhKBZZtdXj yno0dRVcr8Ucs5rkuEBZUyDYpSEf71Bz4avn3QgEfsgRpajpOajYiAP00 L0DnTvLIPIx2fa7WUSUvJ+JzYi0lbvhpoeCm78+8+Wn42taxTUHRYOn3o stNRr31tGZVcEADSgqRdNwwtqnM0eDO2sxkCx5z4erjwMNWwJpjDTURPy P5Mx5l7/UicVR+HXpThY8+AdfAnS4cnRozGYcOvodEPRA20ox/86s1gwA w==; X-IronPort-AV: E=McAfee;i="6400,9594,10430"; a="376579278" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="376579278" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 13:40:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="579627976" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 05 Aug 2022 13:40:12 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 5 Aug 2022 13:40:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 5 Aug 2022 13:40:12 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 5 Aug 2022 13:40:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NBuqu43TQode530y6mQVCq4dII/SAwy8Asb2egnIsUJ2uyCnEC4CsGINZxmyB0pdEs64tkXcxCdUdHYwCbBR8Nnq3unEtFnCnQEC5+tZgvciz+ny0H1GcIL+xwDQi05h+UidHxaGhvLUn7Ss2nXo1esb3EWyM2yXTJWTLUqKNVMslAkQfkQUaOm1wIGs6Xa/hWzNAgnFgw7Xcih5p9qtNADfav0Nq45rAdwf9Q3z4KdVGFik4AlBXQ7vMMW9WymYYC770MYRPI8ipM5JCp+fGTfukiqoyjKNP6qmlrm+rgfPRrvRJRb/fIW/R9GBQ4R+S5+EyDlLe5OJmHq/NqEIuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98kQZ4nqa1m5JCKoaeoGy3awLZY0kHW4WQorYK2UMwI=; b=KxNt393gYfnOst2xJ03lHr6DySHlKvwxtnJo19tRYY1djDPZb06ERQPIUFCvw5yr8VQLxmM0lbF8b49PVPkak9Jft7hNE3khyn/rHl1rVDxqLFjD83/bA8WRJvfM52YAxkYO1gvmrdxPEhPPWA0BvrF3/oGD0a7O8oFvj1tfA7oM0CM1uTFVamGJTko1EPaz8vsoHPEOUIOGzR3qtwobckzOvZKLis9qUA6jXl3Lo4qeRXrC5pbB4jIRX2rLvHVKyBiouj0KjaqrLCgu7DV+DS0eXX7eP0wSIDQPnRtbN5v0vsQp0OWDi3m5bqlmQQ3HJPBoVWXT0/0k2tei2GOudw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM6PR11MB4170.namprd11.prod.outlook.com (2603:10b6:5:19a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Fri, 5 Aug 2022 20:40:10 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe%9]) with mapi id 15.20.5504.016; Fri, 5 Aug 2022 20:40:10 +0000 From: "Oram, Isaac W" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Thread-Topic: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Thread-Index: AQHYqPWVetpvGGDXDUu9xY/8CdvRba2gxSLA Date: Fri, 5 Aug 2022 20:40:10 +0000 Message-ID: References: <20220805180213.944-1-mikuback@linux.microsoft.com> In-Reply-To: <20220805180213.944-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14e4d37c-a072-43c3-86f5-08da7722b09a x-ms-traffictypediagnostic: DM6PR11MB4170:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x30+8rD+Y0ZC+dDh7EaxP7HC1LZE2WHhfVkCSN9urpC1aQ0977ToxZvjHYbel7TCcnxCiZINiqAfadBvQ87l67yiHcDPxb2BdBKjiQQja+H2l9JQCNk/icOMmIxdNL6QRUP3a5cikFL7wYffV6Eua09USm+Jc2kgX0ypf7ZnkZtbKdLERGDfVwlljI32THkHhi2J1VhjUg/2OLunn2feW31Ct7HwnfRFjbMpUJ+F5/RQJCpELI09QWABPSwu+zL4y2kwDwC5tEfhtybIM6+GIyXq4rs8hUs8lgOtRzBvqRu5HrZ9R+qnpKCe29v2ppa9QO/F6idznhjzJpXdUA0w0HTMVAgN4VSrI6qRhharrJgWETpKW/S0DM9OK4EtlXDFEBr1Qj6x+sRIBY7vnhRUA+srXzCEVOATeJ1jB6LP7Ysx4K1/3VWnbKhpMo86nMZJ78aC9arbHYp5xarSlpG2cQ+m4ZdvaQM5CZIjYaihPAfZsAWZ5rqc/SCmzPvQac3olu2W0NTZm3JewhLBlFqCKCqbrZngyi/SyytqXoERCBly5BZEpDPh2wBc7/kledQ2JOOWKNWluKpQHcn/ORsXHtHGQ3kRGhn1SJE35ViM38CRs14jpBs8bGZ1Uvof3v5HtK0fFvkCIGiyRyyRdyydWFoeeqH7W74LOtDYz/jse/dI75bGSwEzuI0iSrY8n/kboWtUtTJ7JwDY/I3/arWVcZVafJXyY0pvnwVlpXoYCapwaOZLHGUHVSydwbmfLeMka6mk6OwcfCIOi4+xYXqFirDkLmPwz2ia8A91rolrrtdvxiAzBi86s2/o9CO9Wt3y x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(366004)(136003)(39860400002)(186003)(7696005)(6506007)(107886003)(71200400001)(2906002)(53546011)(66946007)(64756008)(4326008)(66446008)(66476007)(66556008)(8676002)(8936002)(26005)(9686003)(76116006)(52536014)(41300700001)(86362001)(55016003)(33656002)(478600001)(122000001)(38100700002)(82960400001)(38070700005)(83380400001)(110136005)(54906003)(5660300002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+XXFhb4VhDb3XJ3zRh4hFA2FwaKbpz0+69XF1v8tUX2S8YiBMqLpFlTJsHSD?= =?us-ascii?Q?mhn39CtX502VhCJeyp3qWjA5LSB3FNi4zrWZC6T7k3fSVZBBpWN5x010LaEE?= =?us-ascii?Q?nw/5EFY9sOucMqP08fVcyvfgwPr4L5/7T5NDJaS7DAPkg0P3kH3QvdWgOvPk?= =?us-ascii?Q?MxcvdsUoxvlc/AkqeiYl3tlD7LvQNW+OmrKW62KwMv/e6URkByK7ktiGqA4c?= =?us-ascii?Q?kndCL/4ZHqWk2mh6V4nOZ7vsFrBzOsVow5LMm1Vykop21HvDzihgCrez3Rfo?= =?us-ascii?Q?cc9+pttHhzNREHsBn7dg6iPGupuz4p1DX2XhC5GoN/JhwLwzvlsFkopbH9ee?= =?us-ascii?Q?EuVY2LYCaIXJ9Bf1DoQSdTVOnKyY536sSSi7EdNN5d0eUlYQNhnC96/r9Wob?= =?us-ascii?Q?z71FKMfP4jl3LkbET0bMxyE5VbzSFFC6MSujT0TAH2cw9A5u1bmevMdAlS3e?= =?us-ascii?Q?WLGkd0QjRwLYbTwBnd7ktl0W1kQdYwZcURFvuIe4TotniX+jhK6tzD7EqemE?= =?us-ascii?Q?ds5AvDr2KOB7X2Dd/Kwv6e/xJghd/0sSI75l2tuZZO9kS7HQqQBJmBMvFyey?= =?us-ascii?Q?siD6LH+7qBLOla6pLGPTOwUkLfEaVndm1eAM8vgGGSJrARDCyEqVMqwdZUgI?= =?us-ascii?Q?YSZ4H076kSwQKGV0F55UeUgCULc0G8r2bFvdy2AKBVa8Tr7zuP1BAsOKvIkf?= =?us-ascii?Q?XmAQI7TK+FkiWEYM9p9VjAEjBlmNb4mtM6J5DNipfPUlIKI+9rt2Cdk/vVuj?= =?us-ascii?Q?Fdw+s5G28MkY/0gxWbVbYwikZE4fTkd5AJ1SxoCS7J2YhdIdCbKVWRO+AYOp?= =?us-ascii?Q?xTQQ0oeGpQZTV7puPiqoWgAr/bwBcEe8cB/H7Dk44NTTVdmF7ocvs88o2FjZ?= =?us-ascii?Q?+Tox57TdQlJNW1C6Bt54H0LJrEA4PvA7eTHn99Oxsa1bEoZEFWseEMssJDTQ?= =?us-ascii?Q?tbsqToKXgqduhBtCPcPJ+uqvSQ1udhH6oumnCfXbcjC8pfanEDda/hxjnK+m?= =?us-ascii?Q?nlpgNV02A3WkLHI7B8KJPhJvfm784WDM7fe2POMo4mShk8D5Kz78LEWjA5/r?= =?us-ascii?Q?+xsSFN4T3YJjdZHOXFd+YC90vXJcHPja3vTfFwFgJdadkBmQjPL4rZ7UQnKF?= =?us-ascii?Q?XxZnPp00LPkmsEqxR96nJQWaFZpq1G9Kq7YUXMWiZpTX4xRiK8oqSFwnQlcp?= =?us-ascii?Q?Zaah6aNiOOE0OVojIHdGkGdYUgDCdX7VwLvm/mLgwxb6sMBLe3N7ZCnE+ezR?= =?us-ascii?Q?0teHjO/+gornfA++0Esg6Zjgv1QNtVcUXWztqbrEGSL1ySdV//Lja7NHR0ct?= =?us-ascii?Q?hpLoKRIsT2pWFMcVxpkl5pg8qNcNQTiRgZPd1EcUxyZbDUbtRdtP8dLaRJo9?= =?us-ascii?Q?EJGj4KGP9eWweV1524V97Y9I/8OwMhjhjCPLdyNI2CWHNyxWp/lHl4zwGX28?= =?us-ascii?Q?QJUOwxIcmapWM+nxgXJxPw6nkFIwCBKpPWp14oQefbUZ/bqULjuUh6WF/125?= =?us-ascii?Q?v71rR0CqWmuUj1K2K0TcGf/ivm3HRLgzzlr/R+mpaZQjD8HdSR+2qLUJqJDp?= =?us-ascii?Q?ol57pFkWYKpTQKYNNNgBMvdUUkcLG45wYyYH3Txd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14e4d37c-a072-43c3-86f5-08da7722b09a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2022 20:40:10.1700 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VlmRYdgCPK/LpxBu+yMpGEFYaxt5eJA2GsVdTktc0av4HuztZn45Zt5nhob2aVD+45h8hA+vzRnlzz53YRW0tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4170 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, August 5, 2022 11:02 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: R= emove unnecessary GetVariable2() call From: Michael Kubacki The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemor= yTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library= /TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; =20 DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation - = Enter\n")); CurrentMemoryTypeInformation =3D NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } =20 - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation !=3D NULL) && (PreviousMemoryTypeInfor= mation !=3D NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemory= TypeInformation); } --=20 2.28.0.windows.1