* [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call
@ 2022-08-05 18:02 Michael Kubacki
2022-08-05 20:40 ` Oram, Isaac W
[not found] ` <17088D791A06027C.21918@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Michael Kubacki @ 2022-08-05 18:02 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong
From: Michael Kubacki <michael.kubacki@microsoft.com>
The data buffer returned from the GetVariable2() call in
TestPointCheckMemoryTypeInformation() is not actually used or freed.
This change removes the unnecessary function call.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
index 9ee9dd252c7e..0ff6789ac621 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
@@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation (
EFI_HOB_GUID_TYPE *GuidHob;
VOID *CurrentMemoryTypeInformation;
VOID *PreviousMemoryTypeInformation;
- VOID *VariableMemoryTypeInformation;
DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n"));
CurrentMemoryTypeInformation = NULL;
@@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation (
goto Done;
}
- GetVariable2 (
- EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME,
- &gEfiMemoryTypeInformationGuid,
- &VariableMemoryTypeInformation,
- NULL
- );
-
if ((CurrentMemoryTypeInformation != NULL) && (PreviousMemoryTypeInformation != NULL)) {
DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemoryTypeInformation);
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call 2022-08-05 18:02 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Michael Kubacki @ 2022-08-05 20:40 ` Oram, Isaac W [not found] ` <17088D791A06027C.21918@groups.io> 1 sibling, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-08-05 20:40 UTC (permalink / raw) To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming, Dong, Eric Reviewed-by: Isaac Oram <isaac.w.oram@intel.com> -----Original Message----- From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> Sent: Friday, August 5, 2022 11:02 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call From: Michael Kubacki <michael.kubacki@microsoft.com> The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n")); CurrentMemoryTypeInformation = NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation != NULL) && (PreviousMemoryTypeInformation != NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemoryTypeInformation); } -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <17088D791A06027C.21918@groups.io>]
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call [not found] ` <17088D791A06027C.21918@groups.io> @ 2022-08-08 19:08 ` Oram, Isaac W 0 siblings, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-08-08 19:08 UTC (permalink / raw) To: devel@edk2.groups.io, Oram, Isaac W, mikuback@linux.microsoft.com Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming, Dong, Eric Pushed as ea2a520c83..60053f3077 -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, Isaac W Sent: Friday, August 5, 2022 1:40 PM To: mikuback@linux.microsoft.com; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Reviewed-by: Isaac Oram <isaac.w.oram@intel.com> -----Original Message----- From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> Sent: Friday, August 5, 2022 11:02 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call From: Michael Kubacki <michael.kubacki@microsoft.com> The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n")); CurrentMemoryTypeInformation = NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation != NULL) && (PreviousMemoryTypeInformation != NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemoryTypeInformation); } -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-08 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-05 18:02 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Michael Kubacki
2022-08-05 20:40 ` Oram, Isaac W
[not found] ` <17088D791A06027C.21918@groups.io>
2022-08-08 19:08 ` [edk2-devel] " Oram, Isaac W
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox