From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.1738.1657237877933754807 for ; Thu, 07 Jul 2022 16:51:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CaFZAXYB; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657237877; x=1688773877; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=g6xSOpChoHJIEugmpnG3K9ldpaw7ri78J2t8VrzuGPk=; b=CaFZAXYBz30GVvCRsiBPmnhGVk/Qth8hzCZHIjB/DJbz1RaNRrVt9cj/ re1LFpILMpvnNteGENsoKndGCKyRtnAfMNmg1gNO0sKwh/sVAtI/V1Bgw +/V5YxoN3P4ZurcxGDxIVQ44hvj3rOLNRJMoszhAMYo6FWnr5MFyUrX6w UdKOIyHN2GtHkVNZveelaz2j/XycVob3KUWtpKJi8KP0sHcDAybv8y/74 FRhC/w8XCQw/BS5kFctXafaACezZb2mQLoiKM/XXhJShIiyuZzpARl0oh r4zaSu29pCPKWe/zYzHXRorjLTnfmx50KUEt1V/92v0rfV/rLfawlSp47 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="281695814" X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="281695814" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 16:51:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="620994375" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 07 Jul 2022 16:51:16 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 16:51:16 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 16:51:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Jul 2022 16:51:16 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Jul 2022 16:51:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8uJHJYLFZe1g19bBd1q6YvBG94t0euTcNBX7rT0qJ9Q/oyHw95YEjPPXHv0JEbof6bZ3aPaU6lOrnMstbqy9vdDSTBPXJmXAVOF82aBPDmWg/lBAFae0CVjsg6ZBA9TS/IeDPPqDJZJ2pAz8HuU34XVp/eiOJGyDI6cRNSkNgQUnY+lbTWFGVeaQdMFemFJXToukCjp9XAN5t35GY576IdwB4eV4NMPlQmAperbex1nFbpByjdP93dxNiWGXMsY4YFe6DwwyTGCd0Mv2+U+aHtSUrurLR6JUIMHBpXH3F0ZjldQHQ8vZ/naPmJfMKSlAdK/1iSXAoUvia/HPJohxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GrxBmR+QZDCnlysgczLuJIBz5W7TwlF+EN4HPmEuIQM=; b=BX0uwxWUEqxJ+a9roHP1Amkown2G5GsroW79rOpQnXqZmJ6bpmmwuJf+Gpoj/MAoK4nqYF6nNsrl7UyrBf9mJhStD2UmMCDT85C700nONmltH5UPHrqxe4gM5TfjwDshfK+qqGIwrEtaZnu71fw3qRYfv137WZRbQawcgr/MEppYSiHulkankIVpy9xZyKKYpKnhM7Yyx3eQErL8OjCXGFu+lK09qJSOL8WLMz8X5QrTuHvHc1bRvxHwwxcLDHIHN12WNQaU19bm5DXBqMkzDNwClOGgia4buIFXuOt9GMQCYFhzyyKZ2jm5+BeF2Iw9VHTcRPfugP2l8Y4eSLo3DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 23:51:14 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::c815:3a9e:d7a7:49a6]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::c815:3a9e:d7a7:49a6%6]) with mapi id 15.20.5417.015; Thu, 7 Jul 2022 23:51:14 +0000 From: "Oram, Isaac W" To: "Sinha, Ankit" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Dong, Eric" Subject: Re: [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class for some ACPI related PCDs Thread-Topic: [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class for some ACPI related PCDs Thread-Index: AQHYkifByyaylIObdUWhWx4yIzOILa1zkyDQ Date: Thu, 7 Jul 2022 23:51:14 +0000 Message-ID: References: <20220707173330.2066-1-ankit.sinha@intel.com> <20220707173330.2066-2-ankit.sinha@intel.com> In-Reply-To: <20220707173330.2066-2-ankit.sinha@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f3f42b9-ad0a-4b6b-e4be-08da607393cb x-ms-traffictypediagnostic: DM4PR11MB5280:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 40tq73clO1sLCvVhdoeX5+EnwbRS/bfvcAlobLOjpKApdpxtEli2rFcc3d9bxzD5TYIUHbTKlkycVwFQkcXmub+GQ8LYFtUFHH2sipGCY2+AW7lZYIo1TnElXa5D7Dl9zZX0bD3UxaUpEL+ALpj8vr9Av19M5UMxO47jyuKTKc0yA4zBKTvOiFGHIrLnp3uS42TEPHHcrPSvdTlTq4VXOkcyvaB8Cg19I09eWZmAfjM+25DgwFQmTbsw7K/Yqi9Cp7czpzpN2GDWiNgUwQgC99qH3P8EwjJfgXSWMoKu15/Zue6u9JeFXpK526I6gHs8G10+wVsP6HuOs0kSM6MyhkLHpIAAKDwGPaTs6/syAE3BzKcMj/G+4decDujSYeMFojHXpviB1tyQSbOFLXnE54AkA6hHkttDRH7sxEfniD3LwcrpqRwVsTx9pUFkZ/St7Q6iYyRBGpHdr7HzfNthomizs8x34arZzqM533eLcN48di7uZ2rJpZFUtm6A41chQ6TuXNA9m7In13BMi0msg3CF9NC1J92MPYnA90n66nadDj93VRKYKV3ryVz4epfzqXRQUBvMA6adI2EwtQaFEzxMCJm7SaQNefLETTk37jCMGuHPL0l7w+KiUCdCbKfheK4GCMXaUhk21biadu8RgzukCiOjXvRoLvmniQTCNeco5Ylmz1ceUcckEOPzwHQ8YjzRKLMnzz6YXHVCoAtZMcg11Y0puGZ6E6+ZqHCDC6sEOZkJyxNi9UzQN3KA7AzugUFY1QxoNHTzphZUPOmzqnvJ/11hVchP76Pjycnm0Zec5XP//3Saccd5Z0hecFbe x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(136003)(366004)(376002)(107886003)(66946007)(86362001)(66446008)(66476007)(66556008)(76116006)(64756008)(4326008)(71200400001)(8676002)(33656002)(30864003)(52536014)(83380400001)(5660300002)(478600001)(8936002)(186003)(2906002)(41300700001)(38070700005)(38100700002)(54906003)(26005)(110136005)(316002)(55016003)(19627235002)(9686003)(7696005)(6506007)(53546011)(82960400001)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xIUrQWrm7i8sg+VzHTvvSZ7rvO6ZT1SI+5MyLcgSEJybTvQU5HhiHNVHako5?= =?us-ascii?Q?43Kg35RyLnFJqA6UtYREvSqp4VG25SqSTjHL7GQFP8/Boem6k7Nq3eXjXQx3?= =?us-ascii?Q?/iL3lLQRBhhCKsBhDZNdZA09ZQal/aGirku7PjF/SlwbN/ws84MxSvvEcjP9?= =?us-ascii?Q?VvIztPBS0I1sKg611PG3SGG0ZTnSD9+k8oQOj863ReonzD91o1Wk47kpk9qu?= =?us-ascii?Q?6RTX1vExyfc3nP7S20z9b1P/PM9H6mqRQxbAfmpQ0jm3CzPwAgDjG+JUs0eS?= =?us-ascii?Q?Hb8hG8yVKtBmC0YxOfhhq1OlmgCKDfEZGR4stNCEBukWe+URa2iOhKOxZHdl?= =?us-ascii?Q?8w0YlBznuFYC1Xjan33KuK2qXV27xl0Ji2E8QN+ZM/MUx6GLIyPH+aWx5J4d?= =?us-ascii?Q?mK52OGbNmao7bbCiENjB2+TFTxkfZA6ZHfod0NoyoFVjxmPn8iQGFKvpOzHe?= =?us-ascii?Q?RGcLDvDbICx74SNY9+fx0aGeLaRhFGkpASmzo0jRDerQ20/vNFWyerg7dVvN?= =?us-ascii?Q?lkq/kmfaqYf/VBzGVJ9GTV6cTm1/UMnKuCH0lW8PO9CU968lbBnYUO4BDPDh?= =?us-ascii?Q?k/+7VlSTszITBGYCQFidggJ9riT9k7DpgfzIx6zPvPGtkFgsFkOobGK+kPDB?= =?us-ascii?Q?x6Qoqc+MrfXhE81gvqs7dRalGVkM5wm8wpvAcytj/IR9w6LWt538oyvnOUQs?= =?us-ascii?Q?paJbeQ60MT/v5evybVxkQp198VK7XXlfmPxuIpGUvdBay6xGw9XtJmBPfIeB?= =?us-ascii?Q?PwCJPvxjY3uq3T3VgDUxxLGnFX5UzkCvgsbdhYBWY8Q9/z6nJxXJMtecHBdV?= =?us-ascii?Q?DIxP4tidvHPiPVIzAW+tL+x12swW1ponPoPl3V/q7j10C4efu3/LTCfTLL6n?= =?us-ascii?Q?Cr5vtyTeVIR50AFgabvWq5QpULvVXbSaPzCml50KwT5/kYEUZ4MaGUsQt1LJ?= =?us-ascii?Q?zewcVJIfXb1ZTJmxlq/EYpassdiIM8Ivu4d3tSR+/+jr2iiX6/p9we/rutWR?= =?us-ascii?Q?tCNUdMXqv3XMnu0ojF0asEsBesYz/gqE7PH8a6vwJ5nDoVTsrbymupCEgtuS?= =?us-ascii?Q?Qnzlq6qPA+TtJEYtu3fGecidAtUjc012+GACaguqRXtLdqDhKhDcuM9WwKLW?= =?us-ascii?Q?pVdRFMNoqrfL6RspoGwzuNW0Z+v1TQbD9nXJ2jER605w1n1b8aMJArlCChMm?= =?us-ascii?Q?jq5pvz46ehFtZVlCsTLzbSvisNaL11UKIQFIz5JqJITLrRw1QrO9aCSZP8Rq?= =?us-ascii?Q?ed8CD1oeLDveNJkxP+S8AZ6wROYeIXIJWGkRAtvP5DPC1oFIZMIlg0w/qnKN?= =?us-ascii?Q?BASjPBu5SUXo93Y5Iua1XSodGNCONQo16sljcMIAM1huR+OxQUxrDNu+5Guh?= =?us-ascii?Q?s9t0hm+WFBDrTAuVE1zoBZfpO62ctdpWSfesdxT7liK1R4b+xR2e34VCG+ut?= =?us-ascii?Q?AXBicgKICBU610A+W446ZZeTlhynBFqFNXNJ6h0qQvm4TGp5cb2Qzy+gm192?= =?us-ascii?Q?Nu1FQlE8RbK/57WU45AvFhsOK0RUgNYg0OS2O3ISSRxizN72HD4fjvAjV0vs?= =?us-ascii?Q?G2KlxiwoE21RmydRZ0M0a6O8SGlm+4gnOgLI5PQ5?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f3f42b9-ad0a-4b6b-e4be-08da607393cb X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 23:51:14.2825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jMECpn9/JJ7bPR13t6NwzlSXsWS9dMt+iCOK8Bh4598HN9TsMClKut0Ivx3SL8tCAsUT1QYEwBWpGQ2BfnvbYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5280 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: Sinha, Ankit =20 Sent: Thursday, July 7, 2022 10:33 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Dong, Eric <= eric.dong@intel.com> Subject: [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class = for some ACPI related PCDs From: ankit13s Some PCDs related to FADT entries need to be defined as dynamic for boottim= e customization and update. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Eric Dong Signed-off-by: Ankit Sinha --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 29 ++++++= ++++--------- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 24 ++++++= +++------- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 30 ++++++= ++++---------- 3 files changed, 44 insertions(+), 39 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 3c9f79de5c6c..c7e87cbd7d9d 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -1068,7 +1068,7 @@ InstallMcfgFromScratch ( &McfgTable->Header, EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BA= SE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE, EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_REVIS= ION, - 0 + FixedPcdGet32 (PcdAcpiDefaultOemRevision) ); if (EFI_ERROR (Status)) { return Status; @@ -1195,6 +1195,7 @@ PlatformUpdateTables ( FadtHeader->PreferredPmProfile =3D PcdGet8 (PcdFadtPref= erredPmProfile); FadtHeader->IaPcBootArch =3D PcdGet16 (PcdFadtIaP= cBootArch); FadtHeader->Flags =3D PcdGet32 (PcdFadtFla= gs); + FadtHeader->SmiCmd =3D PcdGet32 (PcdFadtSmi= Cmd); FadtHeader->AcpiEnable =3D PcdGet8 (PcdAcpiEnab= leSwSmi); FadtHeader->AcpiDisable =3D PcdGet8 (PcdAcpiDisa= bleSwSmi); FadtHeader->Pm1aEvtBlk =3D PcdGet16 (PcdAcpiPm1= AEventBlockAddress); @@ -1209,6 +1210,7 @@ PlatformUpdateTables ( FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpiGpe1= Base); =20 FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 (PcdAcpiPm1= AEventBlockAddress); + FadtHeader->XPm1bEvtBlk.Address =3D PcdGet16 (PcdAcpiPm1= BEventBlockAddress); FadtHeader->XPm1aCntBlk.Address =3D PcdGet16 (PcdAcpiPm1= AControlBlockAddress); FadtHeader->XPm1bCntBlk.Address =3D PcdGet16 (PcdAcpiPm1= BControlBlockAddress); FadtHeader->XPm2CntBlk.Address =3D PcdGet16 (PcdAcpiPm2= ControlBlockAddress); @@ -1216,7 +1218,7 @@ PlatformUpdateTables ( FadtHeader->XGpe0Blk.Address =3D PcdGet16 (PcdAcpiGpe= 0BlockAddress); FadtHeader->XGpe1Blk.Address =3D PcdGet16 (PcdAcpiGpe= 1BlockAddress); =20 - FadtHeader->ResetReg.AccessSize =3D PcdGet8 (PcdAcpiRese= tRegAccessSize); + FadtHeader->ResetReg.AccessSize =3D PcdGet8 (PcdAcpiRese= tRegisterAccessSize); FadtHeader->XPm1aEvtBlk.AccessSize =3D PcdGet8 (PcdAcpiXPm1= aEvtBlkAccessSize); FadtHeader->XPm1bEvtBlk.AccessSize =3D PcdGet8 (PcdAcpiXPm1= bEvtBlkAccessSize); FadtHeader->XPm1aCntBlk.AccessSize =3D PcdGet8 (PcdAcpiXPm1= aCntBlkAccessSize); @@ -1226,22 +1228,23 @@ PlatformUpdateTables ( FadtHeader->XGpe0Blk.AccessSize =3D PcdGet8 (PcdAcpiXGpe= 0BlkAccessSize); FadtHeader->XGpe1Blk.AccessSize =3D PcdGet8 (PcdAcpiXGpe= 1BlkAccessSize); =20 - FadtHeader->SleepControlReg.AddressSpaceId =3D PcdGet8 (PcdAcpiSlee= pControlRegAddressSpaceId); - FadtHeader->SleepControlReg.RegisterBitOffset =3D PcdGet8 (PcdAcpiSlee= pControlRegRegisterBitOffset); - FadtHeader->SleepControlReg.AccessSize =3D PcdGet8 (PcdAcpiSlee= pControlRegAccessSize); - FadtHeader->SleepControlReg.Address =3D PcdGet64 (PcdAcpiSle= epControlRegAddress); - FadtHeader->SleepStatusReg.AddressSpaceId =3D PcdGet8 (PcdAcpiSlee= pStatusRegAddressSpaceId); - FadtHeader->SleepStatusReg.RegisterBitWidth =3D PcdGet8 (PcdAcpiSlee= pStatusRegRegisterBitWidth); - FadtHeader->SleepStatusReg.RegisterBitOffset =3D PcdGet8 (PcdAcpiSlee= pStatusRegRegisterBitOffset); - FadtHeader->SleepStatusReg.AccessSize =3D PcdGet8 (PcdAcpiSlee= pStatusRegAccessSize); - FadtHeader->SleepStatusReg.Address =3D PcdGet64 (PcdAcpiSle= epStatusRegAddress); + FadtHeader->SleepControlReg.AddressSpaceId =3D PcdGet8 (PcdAcpiSlee= pControlRegisterAddressSpaceId); + FadtHeader->SleepControlReg.RegisterBitWidth =3D PcdGet8 (PcdAcpiSlee= pControlRegisterBitWidth); + FadtHeader->SleepControlReg.RegisterBitOffset =3D PcdGet8 (PcdAcpiSlee= pControlRegisterBitOffset); + FadtHeader->SleepControlReg.AccessSize =3D PcdGet8 (PcdAcpiSlee= pControlRegisterAccessSize); + FadtHeader->SleepControlReg.Address =3D PcdGet64 (PcdAcpiSle= epControlRegisterAddress); + FadtHeader->SleepStatusReg.AddressSpaceId =3D PcdGet8 (PcdAcpiSlee= pStatusRegisterAddressSpaceId); + FadtHeader->SleepStatusReg.RegisterBitWidth =3D PcdGet8 (PcdAcpiSlee= pStatusRegisterBitWidth); + FadtHeader->SleepStatusReg.RegisterBitOffset =3D PcdGet8 (PcdAcpiSlee= pStatusRegisterBitOffset); + FadtHeader->SleepStatusReg.AccessSize =3D PcdGet8 (PcdAcpiSlee= pStatusRegisterAccessSize); + FadtHeader->SleepStatusReg.Address =3D PcdGet64 (PcdAcpiSle= epStatusRegisterAddress); =20 FadtHeader->S4BiosReq =3D PcdGet8 (PcdAcpiS4Bi= osReq); FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 (PcdAcpiPm1= AEventBlockAddress); FadtHeader->XPm1bEvtBlk.Address =3D PcdGet16 (PcdAcpiPm1= BEventBlockAddress); =20 - FadtHeader->DutyOffset =3D PcdGet8 (PcdFadtDutyOffset); - FadtHeader->DutyWidth =3D PcdGet8 (PcdFadtDutyWidth); + FadtHeader->DutyOffset =3D PcdGet8 (PcdFadtDuty= Offset); + FadtHeader->DutyWidth =3D PcdGet8 (PcdFadtDuty= Width); =20 DEBUG ((DEBUG_INFO, "ACPI FADT table @ address 0x%x\n", Table)); DEBUG ((DEBUG_INFO, " IaPcBootArch 0x%x\n", FadtHeader->IaPcBootArch)= ); diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.= inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf index 119212d2216b..31b6c3be3cc1 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf @@ -71,6 +71,8 @@ gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength + gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch + gMinPlatformPkgTokenSpaceGuid.PcdFadtSmiCmd gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress @@ -82,7 +84,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress - gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize + gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize @@ -91,16 +93,16 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitWidth - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitOffset - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAccessSize - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddress - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddressSpaceId - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitWidth - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitOffset - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAccessSize - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddress + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceI + d gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAccessSize + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddress + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterAddressSpaceId + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterBitWidth + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterBitOffset + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterAccessSize + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterAddress gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq =20 =20 diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/In= tel/MinPlatformPkg/MinPlatformPkg.dec index 68ab1d702d6a..58fc5ba15908 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -112,9 +112,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuCoreCount|8|UINT32|0x90000022 gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount|4|UINT32|0x90000023 =20 - gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x900= 00025 - gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900000= 26 - gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdFadtSmiCmd|0x000000B2|UINT32|0x900000 + 2A =20 gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800|UINT16= |0x00010035 gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x0000|UINT16= |0x00010036 @@ -126,7 +124,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x000100= 3C gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0x00= 01003D gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x00010040 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8|0x000= 10042 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize|0x00|UINT + 8|0x00010042 =20 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UINT8|0x= 00010043 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UINT8|0x= 00010044 @@ -136,17 +134,6 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT8|0x00= 010048 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8|0x000= 10049 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8|0x000= 1004A - - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId|0x00|= UINT8|0x0001004B - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitWidth|0x0= 0|UINT8|0x0001004C - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitOffset|0x= 00|UINT8|0x0001004D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAccessSize|0x00|UINT= 8|0x0001004E - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddress|0x0000000000= 000000|UINT64|0x0001004F - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddressSpaceId|0x00|U= INT8|0x00010050 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitWidth|0x00= |UINT8|0x00010051 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitOffset|0x0= 0|UINT8|0x00010052 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAccessSize|0x00|UINT8= |0x00010053 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddress|0x00000000000= 00000|UINT64|0x00010054 gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 =20 # @@ -271,6 +258,19 @@ =20 [PcdsDynamic, PcdsDynamicEx] gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0|UINT32|0x90000019 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 + 0000025 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9000 + 0026 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x9000002 + 7 =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceI + d|0x00|UINT8|0x0001004B =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth|0x00 + |UINT8|0x0001004C =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset|0x0 + 0|UINT8|0x0001004D =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAccessSize|0x + 00|UINT8|0x0001004E =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddress|0x000 + 0000000000000|UINT64|0x0001004F + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterAddressSpaceId + |0x00|UINT8|0x00010050 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterBitWidth|0x00| + UINT8|0x00010051 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterBitOffset|0x00 + |UINT8|0x00010052 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterAccessSize|0x0 + 0|UINT8|0x00010053 + =20 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegisterAddress|0x0000 + 000000000000|UINT64|0x00010054 =20 [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] =20 -- 2.27.0.windows.1