* [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
@ 2023-01-18 13:04 Abdul Lateef Attar
2023-01-19 0:30 ` [edk2-devel] " Isaac Oram
[not found] ` <173B8E643ABE185D.14781@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Abdul Lateef Attar @ 2023-01-18 13:04 UTC (permalink / raw)
To: devel; +Cc: Abdul Lateef Attar, Oram Isaac W, Eric Dong, Liming Gao
From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
PR : https://github.com/tianocore/edk2-platforms/pull/55/
V3 delta changes:
Addressed below review comments from Isaac
Patch 1:
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
Line 168: Don't we need to free buffer on this path?
Lines 655, 1083: Please put a newline between while and the block to free resources.
DONE
Patch 2:
edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c 338:
Can you change to mUefiShellFileGuid and initialize it to zero?
It seems misleading to me to have the default value here when it is not used.
I think we should also move the declarations to the beginning of the file.
DONE
Cc: Oram Isaac W <isaac.w.oram@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Abdul Lateef Attar (2):
BoardModulePkg: Copy device path before processing
BoardModulePkg: Adds PCD to load UEFI Shell image
.../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++----
.../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++
.../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++----------
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++
4 files changed, 41 insertions(+), 20 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
2023-01-18 13:04 [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Abdul Lateef Attar
@ 2023-01-19 0:30 ` Isaac Oram
[not found] ` <173B8E643ABE185D.14781@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2023-01-19 0:30 UTC (permalink / raw)
To: devel@edk2.groups.io, abdattar@amd.com
Cc: Abdul Lateef Attar, Dong, Eric, Gao, Liming
Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io
Sent: Wednesday, January 18, 2023 5:04 AM
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
PR : https://github.com/tianocore/edk2-platforms/pull/55/
V3 delta changes:
Addressed below review comments from Isaac Patch 1:
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
Line 168: Don't we need to free buffer on this path?
Lines 655, 1083: Please put a newline between while and the block to free resources.
DONE
Patch 2:
edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c 338:
Can you change to mUefiShellFileGuid and initialize it to zero?
It seems misleading to me to have the default value here when it is not used.
I think we should also move the declarations to the beginning of the file.
DONE
Cc: Oram Isaac W <isaac.w.oram@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Abdul Lateef Attar (2):
BoardModulePkg: Copy device path before processing
BoardModulePkg: Adds PCD to load UEFI Shell image
.../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++----
.../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++
.../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++----------
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++
4 files changed, 41 insertions(+), 20 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
[not found] ` <173B8E643ABE185D.14781@groups.io>
@ 2023-01-19 0:36 ` Isaac Oram
0 siblings, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2023-01-19 0:36 UTC (permalink / raw)
To: devel@edk2.groups.io, Oram, Isaac W, abdattar@amd.com
Cc: Abdul Lateef Attar, Dong, Eric, Gao, Liming
Series Pushed as 3b368b33e9..201514e6f5
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Wednesday, January 18, 2023 4:30 PM
To: devel@edk2.groups.io; abdattar@amd.com
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io
Sent: Wednesday, January 18, 2023 5:04 AM
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
PR : https://github.com/tianocore/edk2-platforms/pull/55/
V3 delta changes:
Addressed below review comments from Isaac Patch 1:
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
Line 168: Don't we need to free buffer on this path?
Lines 655, 1083: Please put a newline between while and the block to free resources.
DONE
Patch 2:
edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c 338:
Can you change to mUefiShellFileGuid and initialize it to zero?
It seems misleading to me to have the default value here when it is not used.
I think we should also move the declarations to the beginning of the file.
DONE
Cc: Oram Isaac W <isaac.w.oram@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Abdul Lateef Attar (2):
BoardModulePkg: Copy device path before processing
BoardModulePkg: Adds PCD to load UEFI Shell image
.../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++----
.../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++
.../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++----------
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++
4 files changed, 41 insertions(+), 20 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-19 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-18 13:04 [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Abdul Lateef Attar
2023-01-19 0:30 ` [edk2-devel] " Isaac Oram
[not found] ` <173B8E643ABE185D.14781@groups.io>
2023-01-19 0:36 ` Isaac Oram
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox