From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.34015.1674088247409463150 for ; Wed, 18 Jan 2023 16:30:47 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=UEodHl6j; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674088247; x=1705624247; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xfzfdyv3eg0q10lX1YFOT2Y/T2ul3D1Tx8uIwnGlsGo=; b=UEodHl6jaq4l5Mr2O8RV9m6MHVNRLstxMzk4iX+phkj/P6+fUSs0bH2V 0GQseLnpo1hzbraRlMc+uQ2aw5O4xkafN60Lxi7gpW1KjZ2aKmKN6SYIm 6/MdKQNaI3Q9mZeuxA7iphOIEcQMCMGAfgbnZnE1eaz0KDzp7mPY5BdvY fBw5bYIRJFNVVRJ1RYk9CqPBI95t4XYIIithiztVI9fk8ua3V1w8jmxwG 82zjpT6u19PrGSmJdCXVhOVIGAhY+PoLcZBva/U4eJkxwyJ+lc62n8H1g sOtSWIAinXSaOfq7Trw5Ne5jRaOp4TwwQzdACrilx5s4h3p6Fo+/e01fu g==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="305523093" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="305523093" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 16:30:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="783872065" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="783872065" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 18 Jan 2023 16:30:25 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 16:30:21 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 16:30:21 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 16:30:21 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 16:30:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H5Y7mgJT3M3aD29kseRUxa46lisQB4c3Lpr9GqUKVhsEBSNCGl1ofXzBqwiVwySiWi3E9Fr5W/7VtgdBYiu2YGvzrQe0lG+ncssyd8wT2zbUHB618Awzs/XEb15gU8VYszTDiURJdJlyU0tC9BZizT5aLEM6gOf3dC8OqheHMDt4i2P2Q6v7+k44Wq7/wywBroPz9d8vC3UsMvFExC+g629fOd4iGwTjnfLELWBMp7YpToWXexzc0Tu/Wh7wFSku2caViPDDPhm1VeRNN2nTPr3r+nhVHAewt/x2mOVsuUDfGSTB6cBRwrSyiTCm+Mg0Vdn8ipLrw2+MQZBlYysIXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSTNmBpWByzCl5p6wkB4UfZ18uuTsYe24HUHwvGKTic=; b=Ps8XemFTuMODNlyuMB39sHmM85Yu40hY15r+4sYz+wS4GHkYmRQaz0SfB/82CAM9wNWWX20/ndjG7QxLXt+jZha/tfmnOICyZ1IHuwOZJtOT2HZCHuviRMZaKDMGLSaSidSQBhSAwTV+wC0DWuQnotIYWTkW8UXebyk5FhAUtY/qMCtWc+BZaqfXB/JKvJKD4pta8UAx8i2/cRbL5O4016UiQUNC5kxtJRIl6u9Ke0mlw8RknLeqiCI5pjqX4H67b003Cpvd7YJBLtPxbUA3JLERVi9qGu4hjeharO0rgpPwrUglz2MyR9Kw6NikkQUEBHDyLF0mezxxNDFWQm2w6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by IA0PR11MB7353.namprd11.prod.outlook.com (2603:10b6:208:435::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 19 Jan 2023 00:30:18 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5%5]) with mapi id 15.20.5986.019; Thu, 19 Jan 2023 00:30:18 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "abdattar@amd.com" CC: Abdul Lateef Attar , "Dong, Eric" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Thread-Topic: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Thread-Index: AQHZKz1ohFccbhcBbECblTaOyHx0BK6k3eWg Date: Thu, 19 Jan 2023 00:30:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|IA0PR11MB7353:EE_ x-ms-office365-filtering-correlation-id: 6b413997-edc4-4025-fdcc-08daf9b457b5 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gc/N/shvPifJCenEy8s7UT7BitBtrIBEWBFFoVjvdwStBG3Kn/gJoOgvIgWtHD0zhX1yDaluEu9RoMGgHIw7MWK/mJD2NUQN2toxjgueG0/yNjcJlcJO/adf/4s/yqiHVxl8ZQbSptJGAJmAzXSyUneOJMSqDJnCMJTT9I6YuB0QIz1Hhjexx/xJ/VJpxQ18V5/zkNsZfaqsigIK3qBIwUEzOYwQwxRVQk859RXG9kKVgKJWTNwc2oETgnmNfXKk2ywaXl9Gr1oR9WuScU4UkLBvOSKg8esNajOS9RUBaI5kJamlW9n/IMIAmqvWW0bJynEKsLuHiOblqMfCcDUpP5hD+3H3yaweGCpmM+4mJC908OxRhzsFPr++q/hHA/3VQmP8FIGCdBvMRIccspSIQzxdNdkBpPErK3p5mfoep3J40yd3HFF54+mQlDwxd8keq1QcCQrjSfglKzC0S+yhB+66xtuEkwCcBD2wNQp5KieEaUcZGDFgBgf6jv4Kyh9WpioMixa4/kDbLKIsjw+0vJOqbXb9jDObMS3pVXh0gwaP9hdGB0nxGQJUWP0ILd0kbjYw0EbWZNlNi/JfteGicJ0azB9lJiJnztJ2fEVDgeffP/Ad3mOWcmEB4ap/+omE5RWElLr3ROPC3wYWCpEZid1W67URA26hj3zJQO7RXeeIUixYOXa/Mr5pexXvtuvjqdE9z82HrI5aS6i41ZJcbhGMeh8PknTt53oz6w11xf8UGvxPk4Oh71/zGXhpL4yzw1OA3tTXYmq4rnW0Xdvc/w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(82960400001)(2906002)(110136005)(38070700005)(66899015)(5660300002)(8936002)(52536014)(86362001)(7696005)(83380400001)(26005)(76116006)(966005)(478600001)(66946007)(64756008)(186003)(66446008)(4326008)(66476007)(66556008)(8676002)(316002)(55016003)(41300700001)(38100700002)(71200400001)(54906003)(53546011)(33656002)(9686003)(6506007)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C3FmvtXgN+zQJpjqN9FQrA34YBq7/2tIlVBdl6caggDJI/3x7oeegoHoAmyD?= =?us-ascii?Q?qs+fhYFKEiiLGr/CRrwSVKBox29i38BMPu0svGqobS8Uw1eir+K3BENTy+gh?= =?us-ascii?Q?o+s2MjxgLzXlncJ7XXyum1YDe///hH9FoIRb9FzBcENwaPnxmvyiP25/smzl?= =?us-ascii?Q?MPT24qbbaJOwkBIkhN11dAIoKQP74itEbdptAZR/Jm48+0LAIPan6EfVGfdG?= =?us-ascii?Q?BRwJK1EaLuvSOaIcVuc6uyoy0uXObAn9y/WM3fdj0JxI4PWxFfdbXnTYklY9?= =?us-ascii?Q?ioqhhBWrhmwXRtUqPX4CoDitpn0A+V8wIlXv/nfAm+ZyBrsP2Of4dSUL2qBZ?= =?us-ascii?Q?hYxcNsNFFJTfdgxtNswq/1alt2HKopM42+MzZsI6DwqwqOizOwlf3O/eGPmE?= =?us-ascii?Q?zMwOXt9ZPGMwZKhTDOpMICNA8ru4xj4IpYL9GFAF9IoVknc+a1eobydpPhn4?= =?us-ascii?Q?GjWK4D5/tj5EMrIn1cMdYUjmyYe7hz0pJki8z7MBT+GK9YC1BclzmEJnjGH7?= =?us-ascii?Q?LSH1KBBvAPUR26j3r+xIhCMTigH7c96K1J1jkFxYqTENfsEENUUw0zVQQnPA?= =?us-ascii?Q?1BsxDhqsRXpGObi1ZW3nbH7/jdGw44mmRSWQJvvk5N5L3Xag63t6UVoNwyJu?= =?us-ascii?Q?mKrrppU6nAfm/YhoQ5h4x5zwRdS+79/RRkV0Dyr2Gv8puNoPBVt2u73zxKy8?= =?us-ascii?Q?2lqeV8IX3Z/8UggBFZLtmwerPJBNEw716Lgx5o5BTnmiqPCzzICeMIi85Er/?= =?us-ascii?Q?2Q9NiDDLoE+Jf1aeJzk1sow/9pgO2om0jCykQ/uGi9F82C4sBLjcTxRlZ9rz?= =?us-ascii?Q?/imrklUeyPpzxFjBS/xl+CgfFoIaS4aWfVf89q1KJhBwvCFmyuhDDtz4nJbi?= =?us-ascii?Q?AdyDgUYNzKsdAA02QYkdpnn+gO73UZU352CAarR8RUrRz28q/RZHo2cg5m3P?= =?us-ascii?Q?+NeAehPBNwwqeVclQptFd2vJAjWOb3FnzQYaxacnRANgqRkm9A3tcpBZp4Yb?= =?us-ascii?Q?1ZLvCUqRoJF/qwoUbZgvaNqQWuQLSudAhqI88qldSymI5+z4O9izh4dVcfv9?= =?us-ascii?Q?EtjWLRto3WvrwKaEWx4ipTlWhWOC14st2rzIZ1+xXhjrvCFPmDBnjofmsGzr?= =?us-ascii?Q?f0SYbBhFCmb81M3wJTnpxVew33OVfpi/8Uq1PKFlEsurEcCqVnvvCnKEmXM2?= =?us-ascii?Q?qogTUmhzrXz2ET0NalabDTRWwUxPSJeBLvK1ARgvLmwmotS+4ygnPkHE8Ofb?= =?us-ascii?Q?zdxj1Y4x/BWhdi79SePN2pAPEAz0TRXcGrp1+qlb4knvh7m6qMjNVNScXPCu?= =?us-ascii?Q?6aLv0bPwyS0s78L0TSD0I5GXqLMGvtfKDc3Yz5fFryjCgIcTQhjkSTfyZ7xk?= =?us-ascii?Q?UKvLfoicVIoPznGF2V6kTQp1blHQHaOUib/WEUsVGBRWNksoSj6t/KEPybYb?= =?us-ascii?Q?c48nnc+zpRBxCGMyTw/NXMcFC4IJOcLWzD4dMlb4fYB1eV+iPsr0kd5+401t?= =?us-ascii?Q?q2qswvzuHqW/up2ns3idoGfooZNS9507fBsRGYaEjGiIIRxXXqiy6UD4lr+A?= =?us-ascii?Q?0kk5ZqjU3EXNXd6WLswdPEDqQU4zvrNeGPvQRHhd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b413997-edc4-4025-fdcc-08daf9b457b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 00:30:18.6852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SlSGwyV4Uwr61Jl5efnkx5vCO+8KyT7JlWYezMdaMAvoD5Vca8MDPT5KOo6W5eb3lKxBcZ2GrOhQO9xGsRJc9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7353 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abdul Lateef= Attar via groups.io Sent: Wednesday, January 18, 2023 5:04 AM To: devel@edk2.groups.io Cc: Abdul Lateef Attar ; Oram, Isaac W ; Dong, Eric ; Gao, Liming Subject: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fi= x From: Abdul Lateef Attar PR : https://github.com/tianocore/edk2-platforms/pull/55/ V3 delta changes: Addressed below review comments from Isaac Patch 1: Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c Line 168: Don't we need to free buffer on this path? Lines 655, 1083: Please put a newline between while and the block to fre= e resources. DONE Patch 2: edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/Boar= dBootOption.c 338: Can you change to mUefiShellFileGuid and initialize it to zero? It seems misleading to me to have the default value here when it is not u= sed. I think we should also move the declarations to the beginning of the file= . DONE Cc: Oram Isaac W Cc: Eric Dong Cc: Liming Gao Abdul Lateef Attar (2): BoardModulePkg: Copy device path before processing BoardModulePkg: Adds PCD to load UEFI Shell image .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++---- .../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++ .../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++---------- .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++ 4 files changed, 41 insertions(+), 20 deletions(-) -- 2.25.1