public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Isaac Oram" <isaac.w.oram@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"quic_rcran@quicinc.com" <quic_rcran@quicinc.com>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions
Date: Thu, 9 Feb 2023 01:44:39 +0000	[thread overview]
Message-ID: <SA1PR11MB58010CC80A784A7947DF672FD0D99@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4cfc2fc1-c4d2-e66e-78f3-cedaec02fee6@quicinc.com>

Pushed as 615afc82db..ab4ddecb12

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Thursday, January 19, 2023 7:56 AM
To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Rebecca Cran <quic_rcran@quicinc.com>
Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions

Reviewed-by: Rebecca Cran <rebecca@quicinc.com>

On 1/18/23 18:20, Isaac Oram wrote:
> V1: Make the Windows build example current working directory based 
> instead of arbitrary.
> V2: Fix case mismatch in edk2 repo local name.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Rebecca Cran <quic_rcran@quicinc.com>
> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
> ---
>   Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md 
> b/Features/Intel/AdvancedFeaturePkg/Readme.md
> index ba50560328..20f456bebe 100644
> --- a/Features/Intel/AdvancedFeaturePkg/Readme.md
> +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md
> @@ -19,19 +19,21 @@ Supported build targets
>   * GCC5
>   
>   ## Windows Example:
> -With current working directory at O:\
> -
>   git clone https://github.com/tianocore/edk2.git
>   
> +git clone https://github.com/tianocore/edk2-non-osi.git
> +
>   git clone https://github.com/tianocore/edk2-platforms.git
>   
> -set workspace=O:\
> +set workspace=%cd%
>   
> -set EDK_TOOLS_PATH=O:\Edk2\BaseTools
> +set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools
>   
> -set 
> packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel
> ;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\ed
> k2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-pla
> tforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Netwo
> rk;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platfo
> rms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\Sy
> stemInformation;O:\edk2-platforms\Features\Intel\UserInterface
> +set 
> +packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\e
> +dk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel
> +;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\
> +Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\ed
> +k2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Feat
> +ures\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBan
> +dManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement
> +;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspa
> +ce%\edk2-platforms\Features\Intel\UserInterface
>   
> -cd \edk2
> +cd %workspace%\edk2
> +
> +git submodule update --init
>   
>   edksetup.bat Rebuild
>   






      reply	other threads:[~2023-02-09  1:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1674091122.git.isaac.w.oram@intel.com>
2023-01-19  1:20 ` [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions Isaac Oram
2023-01-19 15:55   ` Rebecca Cran
2023-02-09  1:44     ` Isaac Oram [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA1PR11MB58010CC80A784A7947DF672FD0D99@SA1PR11MB5801.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox