* [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions [not found] <cover.1674091122.git.isaac.w.oram@intel.com> @ 2023-01-19 1:20 ` Isaac Oram 2023-01-19 15:55 ` Rebecca Cran 0 siblings, 1 reply; 3+ messages in thread From: Isaac Oram @ 2023-01-19 1:20 UTC (permalink / raw) To: devel; +Cc: Isaac Oram, Sai Chaganty, Nate DeSimone, Liming Gao, Rebecca Cran V1: Make the Windows build example current working directory based instead of arbitrary. V2: Fix case mismatch in edk2 repo local name. Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Rebecca Cran <quic_rcran@quicinc.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md b/Features/Intel/AdvancedFeaturePkg/Readme.md index ba50560328..20f456bebe 100644 --- a/Features/Intel/AdvancedFeaturePkg/Readme.md +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md @@ -19,19 +19,21 @@ Supported build targets * GCC5 ## Windows Example: -With current working directory at O:\ - git clone https://github.com/tianocore/edk2.git +git clone https://github.com/tianocore/edk2-non-osi.git + git clone https://github.com/tianocore/edk2-platforms.git -set workspace=O:\ +set workspace=%cd% -set EDK_TOOLS_PATH=O:\Edk2\BaseTools +set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools -set packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface +set packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\edk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\edk2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Features\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBandManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspace%\edk2-platforms\Features\Intel\UserInterface -cd \edk2 +cd %workspace%\edk2 + +git submodule update --init edksetup.bat Rebuild -- 2.39.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions 2023-01-19 1:20 ` [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions Isaac Oram @ 2023-01-19 15:55 ` Rebecca Cran 2023-02-09 1:44 ` Isaac Oram 0 siblings, 1 reply; 3+ messages in thread From: Rebecca Cran @ 2023-01-19 15:55 UTC (permalink / raw) To: Isaac Oram, devel; +Cc: Sai Chaganty, Nate DeSimone, Liming Gao, Rebecca Cran Reviewed-by: Rebecca Cran <rebecca@quicinc.com> On 1/18/23 18:20, Isaac Oram wrote: > V1: Make the Windows build example current working directory based instead of > arbitrary. > V2: Fix case mismatch in edk2 repo local name. > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Rebecca Cran <quic_rcran@quicinc.com> > Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> > --- > Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md b/Features/Intel/AdvancedFeaturePkg/Readme.md > index ba50560328..20f456bebe 100644 > --- a/Features/Intel/AdvancedFeaturePkg/Readme.md > +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md > @@ -19,19 +19,21 @@ Supported build targets > * GCC5 > > ## Windows Example: > -With current working directory at O:\ > - > git clone https://github.com/tianocore/edk2.git > > +git clone https://github.com/tianocore/edk2-non-osi.git > + > git clone https://github.com/tianocore/edk2-platforms.git > > -set workspace=O:\ > +set workspace=%cd% > > -set EDK_TOOLS_PATH=O:\Edk2\BaseTools > +set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools > > -set packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface > +set packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\edk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\edk2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Features\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBandManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspace%\edk2-platforms\Features\Intel\UserInterface > > -cd \edk2 > +cd %workspace%\edk2 > + > +git submodule update --init > > edksetup.bat Rebuild > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions 2023-01-19 15:55 ` Rebecca Cran @ 2023-02-09 1:44 ` Isaac Oram 0 siblings, 0 replies; 3+ messages in thread From: Isaac Oram @ 2023-02-09 1:44 UTC (permalink / raw) To: devel@edk2.groups.io, quic_rcran@quicinc.com Cc: Chaganty, Rangasai V, Desimone, Nathaniel L, Gao, Liming Pushed as 615afc82db..ab4ddecb12 -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran Sent: Thursday, January 19, 2023 7:56 AM To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Rebecca Cran <quic_rcran@quicinc.com> Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions Reviewed-by: Rebecca Cran <rebecca@quicinc.com> On 1/18/23 18:20, Isaac Oram wrote: > V1: Make the Windows build example current working directory based > instead of arbitrary. > V2: Fix case mismatch in edk2 repo local name. > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Rebecca Cran <quic_rcran@quicinc.com> > Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> > --- > Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md > b/Features/Intel/AdvancedFeaturePkg/Readme.md > index ba50560328..20f456bebe 100644 > --- a/Features/Intel/AdvancedFeaturePkg/Readme.md > +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md > @@ -19,19 +19,21 @@ Supported build targets > * GCC5 > > ## Windows Example: > -With current working directory at O:\ > - > git clone https://github.com/tianocore/edk2.git > > +git clone https://github.com/tianocore/edk2-non-osi.git > + > git clone https://github.com/tianocore/edk2-platforms.git > > -set workspace=O:\ > +set workspace=%cd% > > -set EDK_TOOLS_PATH=O:\Edk2\BaseTools > +set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools > > -set > packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel > ;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\ed > k2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-pla > tforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Netwo > rk;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platfo > rms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\Sy > stemInformation;O:\edk2-platforms\Features\Intel\UserInterface > +set > +packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\e > +dk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel > +;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\ > +Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\ed > +k2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Feat > +ures\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBan > +dManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement > +;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspa > +ce%\edk2-platforms\Features\Intel\UserInterface > > -cd \edk2 > +cd %workspace%\edk2 > + > +git submodule update --init > > edksetup.bat Rebuild > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 1:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1674091122.git.isaac.w.oram@intel.com>
2023-01-19 1:20 ` [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions Isaac Oram
2023-01-19 15:55 ` Rebecca Cran
2023-02-09 1:44 ` Isaac Oram
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox