From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.80296.1679594539267582046 for ; Thu, 23 Mar 2023 11:02:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gODpBLZz; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679594539; x=1711130539; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=O1Umx9+hPjPaNBvBfFRNfhWY6za7EITRgwB3LXu/+DY=; b=gODpBLZzF5zldHAJhwzqc2zQXsXLYg9SuLa5z1l3IPG8hEmr6lpZCxku GjGYy73LZCzLjSDHx5fhS71RH1gSWcl+RP2ZFuJHFFuufF1961a2jV96B W2xoEAbhuUmC6eZawLF+xtdcc00gUvQv1oa4QkCTmI3e2EBsdxz9AbZ4R ZmwpDwDy+KaK8oPpC2nOZp0kkFASm4dXvnGmF3/nY/IjoitAvbplj27w7 80N4Y0xzrSRiwNGDgUKHeUF/byqGJ/uFb+r4n179AfnxbDrgAcGVUw8Wr rifUCbYinVzO3sqv9ryrm/NUjqbqMFyYN/v5IKGN8MZEx0pOJIDHaO4v/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="341133365" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="341133365" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 11:02:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="825925357" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="825925357" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 23 Mar 2023 11:02:17 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 23 Mar 2023 11:02:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 23 Mar 2023 11:02:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 23 Mar 2023 11:02:16 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 23 Mar 2023 11:02:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5bW2C7Qh+wzq5C/5AlrXmN51tS9+qi22Y35iNllMTAD/rALE6sEfXSGZkdSjfHdrOFWAI1+W+Z1IZhfNY7C5++yktU9e+rRyBociWHIfd/vTzvbtJJd2df8nrYd+5N+CYmc6fyMGp1J9RrM/JM2KxH2f7bakv2TynmzUBMashdGTdyzOltQL4JiCZ+3DIxVgyLEZmLpY/TAy3lKlQM47QXvdzKrtVna+yLy9TfG5AszWyxjKlDBDeG63tXOFFAuOSId7sUGiaNlZFR3Y6DAEgnLqfXKRVpb5ROeDenz6Z/0zh2/ql9pwKUuoyoZCegzKxJ1JdcnxtdMI1Jj+5uo5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Om2ZvPcBd4Wh3QL/6aCv60pDNtVurU+2Vm1Dp04N9A=; b=A7rllb2bprMBvbjV266sW3uPqBG5ihMBTDx5zwDyPEIeKvFOS3mySCzL4IfZY73rykKqsYHG7WZSoKUvjGz/I1jUMpW6/5peEoe+4E2PqjohGamMkG7a3asaplWhgo0VZkZ99KbT7NirZD5rPajRi33qGVTIYjOCoSV4Kj0ECQaF6x0+aMY/sKsy/TdmpUEVRQWxHPa2QAkczOt10rnEdOtJbSeJghCTckETAkcnsiBRXuQ0dDBC9FJqsQ+jACbGwSiTYsfB4NsvI0H2T88l/ayVXvVuuhlkhhVJT/4QFYIuyc9TKtfjDt7HnvAqSF6AZ6g4MoU8RdU+yT80d8oisw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by MN2PR11MB4581.namprd11.prod.outlook.com (2603:10b6:208:26c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Thu, 23 Mar 2023 18:02:14 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::5fe4:fb10:27ba:d2ad]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::5fe4:fb10:27ba:d2ad%9]) with mapi id 15.20.6178.037; Thu, 23 Mar 2023 18:02:14 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: "Gao, Liming" , "Desimone, Nathaniel L" , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy , "Abdul Lateef Attar" Subject: Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package Thread-Topic: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package Thread-Index: AQHZXGjpKj2UPwdP0UmFbbxQij8V668IqJAw Date: Thu, 23 Mar 2023 18:02:14 +0000 Message-ID: References: <20230322024840.1629-1-abner.chang@amd.com> <20230322024840.1629-2-abner.chang@amd.com> In-Reply-To: <20230322024840.1629-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|MN2PR11MB4581:EE_ x-ms-office365-filtering-correlation-id: afbc689f-21e4-4f95-93de-08db2bc8bb88 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 81jfyEK7ytQ6DvRSIIqi3A4myhFb49wCG1bYf/yvHwKD4f/b1UWts+Bh3/JrqwLruHpa4HhOHb7tpBwNtTUlKvSw92v8vmo/HUTeZVkr8OQ/rs/n9QzG8lCUUrJVKU8r9rfvjxDCLKj712mslyONYHXZoXDPAQpEbgObMS/A8a4t/onH6hpfgnd+h1vpk/HNaYKcJ3gMAAW0X1UaOX3l+zNwt3PdPTuIbB8V1cBfgOacKV7WrG8cg09C1fayPK6tXrN30oaBGpTy3AMkr4YZiCH+Ks4x71bxO71FNiGwkJs1ht2QPD7sp4vofNtefF5Sd823Gktd7zz6sNZZlafyDwHKzfUyNNYQYqR+c6ADLaNRPzMpWEYjx24h6HAy7qLPi+34vXrBDDvDsD+ipKS3UqQtB6LlnvSKxe+zNgwaK4LDfZhvHMkgSU/grPzulz7Dbf5XATmg2+IrNFWAOEqOknrz9QJl0PeuuZ28tt2aGHJNcjARHiCYS0jZJUYCL6I3EHOKB6n/xi5R5C/pel1J9grK0uu5oNeb64ssB8TQNHD5yjdVy8JjT2CAi5tO4ZHHaQT+to3xKy2dFcPBL4yr9JvO+Ce7m8uAUQgsmhd20IHR65AXMCot7BE9m+5o4B9ETQrUy4+r4QsB2S13Bwr4P3KbzpZSfuocqiEU8m7VGoTOAD19Vy/4uf6ufIGAbpYYA2fjruYlOa21tfZobGSLuV1B0oqHYyD+7D10PLaJKUA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(396003)(376002)(39860400002)(346002)(451199018)(6506007)(38100700002)(122000001)(82960400001)(53546011)(26005)(55016003)(83380400001)(186003)(9686003)(5660300002)(8936002)(52536014)(38070700005)(71200400001)(33656002)(54906003)(86362001)(478600001)(41300700001)(110136005)(316002)(66899018)(2906002)(966005)(64756008)(7696005)(66556008)(66446008)(66476007)(8676002)(4326008)(66946007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QHP/GvD5t2xeLmAR8jDo1x+KdE0kzOKJ+FfR3kWYN5m0ENzNa+XzKUMg9OuE?= =?us-ascii?Q?f9jqjr/HlFFTTEaYNGrLMohVMGFFGwOYmQfesLYQ+xLwT5qbsPNhwKtT7x0W?= =?us-ascii?Q?GIXbtJV1m3maTv7UhxkVq95hqnouXNiMAsqW+abHS4Vs/18yF7J53cmgSI0O?= =?us-ascii?Q?9Qw6JpX9yY6rheOw6uejj29xn5sPr6kDEMXY2hFuqvtgPO/vYIWeekQIyAPZ?= =?us-ascii?Q?J3T8EFjQi6tPfmb5rNS0gs9c9PKkMqI8+rFJ+U28I3BNVInbLv6cKK+XrfHd?= =?us-ascii?Q?AhymnoZhZrNuB+0TVg/+hYA3O1+vxL83D/JYgkFrnzFAzNN+Zhus/3OIAtbm?= =?us-ascii?Q?nNesJxUHw6Z/ZcfAnsEdL1TyJ8q5t2M33EvUhIubModq4KbrEGWIloyU/ea6?= =?us-ascii?Q?Raoj9hTyrNDRCczb6ZWDDdN5kOfTLiEfRMUsv3UN/pulRR+Bpaj1hYX+w4Ok?= =?us-ascii?Q?Cilg1cvTYxtJmug4+5N35cfy6PFDycv8h7fI1sVcA6wxuebYOBEvXVMwXzPL?= =?us-ascii?Q?BA3XSg3U+QvB//piIdRnPxedtZsJQ69w268U+yZz19LHvw7zo54A5aOJr7+o?= =?us-ascii?Q?jiMDkHGcCqFNXiQXpY7b4ZEcHhbRkqQs8Zeyx8acTrwuZ974CziFcaclNBOF?= =?us-ascii?Q?eNt/XPI8p5NxQYvdkSXHZjcVqaczGbWvhYhtbZfsWm1NnuUzgFQUGRqgVIno?= =?us-ascii?Q?zXOxUs/pAgHLviniPWDVVw6dqV24xBP5aE9YldRxcBUcLM3uuJPQbEyi/rPH?= =?us-ascii?Q?lUk7ZePrgHJCDnR4+QutJxfHvVamFOzoLmo8VoIRIhwo2GvF/f38nLymq7r8?= =?us-ascii?Q?qrPh+Vjvpaqs8RvO3RDDuv2N8DMsKbcYABihuMFY7MnZLI9Gvmv76JnBWPQc?= =?us-ascii?Q?48dDNvh7HO4rOxUVtp1k3HGAl4TBGEZv8t0ccV6pkxrHQ8jnXmaocSGACeOD?= =?us-ascii?Q?6EmM19r7WBOG1yvoOhGqfboeUL6/kPOtQgU5Dfirp/h2Z1sXYebppLNHpV32?= =?us-ascii?Q?C0qxlraJJxe7sdRqngc9XjV3hnMIwhvO3vOnHF5kEvtIa2WsFWrDgpN6Q1vm?= =?us-ascii?Q?eknEYCkvJT/S5qiuSJ79GQPvUce6gHnQ1L/aTnQGbIWTFb8Fk/ge8JPwO+YV?= =?us-ascii?Q?MDRul0yNt6JWqu+FklP8aDQx8siFbzKP81ffdqDXjsZaHeGK6xM2/dJQ9url?= =?us-ascii?Q?Nk31QtV1wRLX0sEuELsKWxNLWUsEFshKqMQ4DQDE3iPmMY5FF1m1tbImNGMq?= =?us-ascii?Q?h6NfokgaOR8jvZw0ymGwgyRUOkLcQN5GNiiW4BP2rk/nAIxJz8xIxDEAuLee?= =?us-ascii?Q?8Y8J2M8nsCcRm7+Nim8bwKoY0WK/UjtcbpAT7KQ4tlPYWqIDrUd7CD2W9Vvb?= =?us-ascii?Q?zGHAkIHlQcaN4lr/edcFF7M0IhPlNaCYHOkzbuWKoYzWVE4ASAdYrpdWt2OD?= =?us-ascii?Q?5q/GE2iJNoMMdCiRicXb+LfA7Gnaoo0xySEAom+Na8XuaUdJd2wIAq26pnVn?= =?us-ascii?Q?/aQV7usJt7AheREe2WQ5/rqNxiqy1zgQ8g6fXNIQeUCtnTbAi+v5fT5ZvrR6?= =?us-ascii?Q?DozjpkHzjws6lc3+NufgEGdnWFO5jcTWzaeODfU1?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afbc689f-21e4-4f95-93de-08db2bc8bb88 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2023 18:02:14.2175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2RSZ77Obel8BcUCUZR74Lf1NLNtsRZO0c4pADyY2jjmcOewOZsVeIM8o8Jdcq6itwadpomxxpgP8owfsNurB2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4581 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram edk2 convention has changed to naming DSC include files *.dsc.inc. I plan = to update all the features sometime in the future. Manageability.dsc: I think that the "[LibraryClasses.ARM, LibraryClasses.AARCH64]" section con= tents should be moved to the ManageabilityPkg.dsc for package specific buil= d settings. These seem like ARM libraries not directly related to manageab= ility features and we don't really want Manageability.dsc to override any b= oard porting choices already made by the board. And I think that we want t= hese includable feature DSC to be scoped to the feature only as much as we = can. Regards, Isaac -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chang, Abner= via groups.io Sent: Tuesday, March 21, 2023 7:49 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Oram, Isaac W ; Desimone, Nathaniel L ; Abdul Late= ef Attar ; Nickle Wang ; Igor Kulchyt= skyy ; Abdul Lateef Attar Subject: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package From: Abner Chang Initial commit of ManageabilityPkg Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Abdul Lateef Attar Reviewed-by: Nickle Wang --- .../ManageabilityPkg/ManageabilityPkg.dec | 21 ++++++++++ .../Include/Dsc/Manageability.dsc | 16 ++++++++ .../ManageabilityPkg/ManageabilityPkg.dsc | 39 +++++++++++++++++++ 3 files changed, 76 insertions(+) create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec create mode 100644 Features/ManageabilityPkg/Include/Dsc/Manageability.dsc create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec new file mode 100644 index 0000000000..71bd8a0c80 --- /dev/null +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -0,0 +1,21 @@ +## @file +# Manageabilty Package +# This is the package provides the edk2 drivers and libraries # those=20 +are related to the platform management. +# +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights=20 +reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + DEC_SPECIFICATION =3D 0x0001001d + PACKAGE_NAME =3D ManageabilityPkg + PACKAGE_GUID =3D 36310119-4FB2-4BA3-959D-74C16B849F9E + PACKAGE_VERSION =3D 1.0 + +[Includes] + Include + +[Guids] + gManageabilityPkgTokenSpaceGuid =3D { 0xBDEFFF48, 0x1C31, 0x49CD, {=20 +0xA7, 0x6D, 0x92, 0x9E, 0x60, 0xDB, 0xB9, 0xF8 } } diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc b/Feat= ures/ManageabilityPkg/Include/Dsc/Manageability.dsc new file mode 100644 index 0000000000..2cb63c1ca6 --- /dev/null +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc @@ -0,0 +1,16 @@ +## @file +# Common libraries for Manageabilty Package # # Copyright (C) 2023=20 +Advanced Micro Devices, Inc. All rights reserved.
#=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[LibraryClasses.ARM, LibraryClasses.AARCH64] + # + # This library provides the instrinsic functions generated by a given co= mpiler. + # + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf + diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/Mana= geabilityPkg/ManageabilityPkg.dsc new file mode 100644 index 0000000000..b3586afa07 --- /dev/null +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc @@ -0,0 +1,39 @@ +## @file +# Manageabilty Package +# This is the package provides edk2 drivers and libraries # those are=20 +related to the platform management. +# +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights=20 +reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + PLATFORM_NAME =3D ManageabilityPkg + PLATFORM_GUID =3D 7A98123A-B194-40B6-A863-A52192F6D65D + PLATFORM_VERSION =3D 1.0 + DSC_SPECIFICATION =3D 0x0001001e + OUTPUT_DIRECTORY =3D Build/ManageabilityPkg + SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64|RISCV64 + BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT + SKUID_IDENTIFIER =3D DEFAULT + +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + +[PcdsFeatureFlag] + # + # MinPlatform common include currently required PCD + # + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE + +# +# Include common libraries +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc + +!include Include/Dsc/Manageability.dsc + -- 2.37.1.windows.1