From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.2522.1659731412580793999 for ; Fri, 05 Aug 2022 13:30:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=l2hWy85+; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659731412; x=1691267412; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DfMXsdMXE0zZJH6PnrdseKme1acoW49k472VckkfkKY=; b=l2hWy85+9OyuUDhxPvCXHiL1dBi5jn8gCb8+CJ0QCWbKZwQXgqJcqZwu 9BZOqGOS6nck//ODVP8pg3AQIpxIQ4SJnP9Gm8DNQm3Sr6kdzZvc4FkMr qeAhOz5CJKDkNR23YUk92esbEskiqsRmGN6rP6IpcApwwIq/Zi+WBR9y1 lX8MK6UTt4yrjdes5Pr4yVH4taXrorxzL+kawQb/whYP1W3aWrrUklFaU AU6cF3NygU1ZdIQ6msoAi92KPmeQhloZ9gCd23NE4yUq8Z2SIN8LSh0Zm FFCqbCBKl4c+YgR8BQ4/PmQ5wnCQGJjEQGm9IucGtI5K/TZ3pMncaAQZ/ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10430"; a="277208005" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="277208005" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 13:30:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="671812710" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 05 Aug 2022 13:30:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 5 Aug 2022 13:30:02 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 5 Aug 2022 13:30:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 5 Aug 2022 13:30:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 5 Aug 2022 13:30:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=feYNrstSmJddeZ3qqA1BeT7SaUyj5y8hQdBj8Et4tVBrttuED0+DJLwSLeCu7y6yyUKkFfyClJfxnKq0Nmnn8HU5cfBdeiJQhsSicStoULxvYBR9XXHpe2T/bj0l1xtbPdYuXR4EnVYYyLR+mMKUzpkwOzLAE4t564lpjtqyXmCPh2j3Dm7d/9gd8F8ByEZi9siyFSh2gdg5dYC8A3Dy/FJTz9VGJbHj/e5WAoN52xSCbG7qUnJux4JSqtMr4VB+KfM0d/dUN/YKeKBgWIvzizpN2Xai36MyVlxbmjJGLlu88fSp1RZs45VlcGa5lDn4pnjJXYHbppde9L9YJLYQ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hm/J/A1j52Pivf0m7OMw5kKQIXnvenNuEW4s7y0IWvQ=; b=LBcUpCOHLrSl93HLRKp7tjLH6rO8QQ4fcWVDzkGFy7ZFxooMRhWWiX4g0gzggRaYRmF3obyj+hc/oibm8VfjDAuJkSwuhDGuJE3HB8wFZRECAs0rR2AdZo1uV24BRzYT4IUQn81u8gy6HMkjY1STAjk0bywfXqEhfd+XfTVP9Nm+QxQQH52Gqj9UuISJkG42xPyvGvEjNrSdAdzRoaNRbQdInwnqKCIodHnkgkcnAjRu9oX53VxiU1SqJKZu19FDgYoVv1nNRklT7u+P/qCH6RX6X+724eOZYhzRsIsMpT5hDIx8XrqA7dsAmRdoKUrNyCIpWqHqQG49io6R763yqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by CH0PR11MB5756.namprd11.prod.outlook.com (2603:10b6:610:104::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Fri, 5 Aug 2022 20:29:58 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe%9]) with mapi id 15.20.5504.016; Fri, 5 Aug 2022 20:29:58 +0000 From: "Oram, Isaac W" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data Thread-Topic: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data Thread-Index: AQHYqO8JjIW9Tck1902b5IeJ6Z5fja2gwjPQ Date: Fri, 5 Aug 2022 20:29:57 +0000 Message-ID: References: <20220805171532.868-1-mikuback@linux.microsoft.com> In-Reply-To: <20220805171532.868-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 549f0dcb-f597-4068-d50d-08da772143bd x-ms-traffictypediagnostic: CH0PR11MB5756:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aKfoeDOfCKNwus5MYIyy6fcFpQWZVISPaO6q9952MyNbc5B9y7540JA3EI47kL5Fe5u/LZfnT+POBvj344bPpfQOnSh9Ao6Xj2I0GJ4SvSWuYsTfXB5h110uhD1DOaSMGeoSd+9e8195sDRogWCGiTGugH9TEXfsbKrY2Ow9pvYtDazarh3t+RSIlH3s62NALew8GBMgUpSiY3xzF0EihqjvwJkuwSWc+RhFJzZlh62/VhZIq8bLcBjQ1RfqTm9bJvKTyiOYbESck9ORA/bugJfDkcBjTkG7WqZfmHN8iAu8HeheoZWYeOoTQqTaXIMdJOoZnGxRxl/kWyIjqUkA7SI1339GvJUqG5XStTVVclhGVHU7mfnJ2vfhfBpqw2zQvkvB1+FrAy64hk3ocCmhzwqhM+lZtyTc3aW3nvxAoj8S7oIDDryBV8+DvJc6Cf2+6hS/ldj3pSdsF2AQ/I4xLyAG2atnG1p5GoH7+hSDDf+rdMKVzck97ulaOeaY28o8jYG6VUfSo33USaUu4ga0HaCqMR15iC+IVbobO2ExGXXcjIZ+USCZ01MF5lRClkyUcoPdqbrFxcUvRV+V3NyJiWZtH7YwLcsmZ/OUtGcrdMdhl92Iraz0oWYOKrXw/6wEnoZcqNzBSPGEZC4l4oFbcg0irCbDplqyHv3y+RBlBy+H6kq0hwSxHjbjf1HWWSJRp4B7ylxltYPpXgipKifAxD8stxVmpXI0B/iGEc60Xeu+UNUFDQNa3fB1FRkEOwNOGoEXnrbBaV26iBC8ZiI4IfZ8UFL+Y/YCcuJmsv/UmgR0GlTQPEfB8XIUh8kIXXX3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(376002)(39860400002)(136003)(366004)(38070700005)(2906002)(110136005)(107886003)(66476007)(83380400001)(66556008)(66446008)(76116006)(66946007)(55016003)(71200400001)(316002)(41300700001)(5660300002)(33656002)(478600001)(54906003)(186003)(64756008)(52536014)(6506007)(26005)(82960400001)(53546011)(7696005)(8936002)(86362001)(4326008)(122000001)(38100700002)(8676002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yk/oNrMEtUKDzF119ynsZBh0FhgAFMAavmdoiMccYDbi7+lZFRhfT/BM4W+Y?= =?us-ascii?Q?/KWhz/2w/Wc4cPF+zhZH/TfLF9KchgB7JarTrj7ReauTNQT3tDW6/gmAufpT?= =?us-ascii?Q?3+eOwBpIEVcc+AgR07DypyXvRjqa98U41ZbCC7/+79XxItm3faXa13jZLtwf?= =?us-ascii?Q?3LVtSGuXoPNKwn4JzAyqCMsmgp9An3AnW1NfN5tX7BuIIrC1CVy0i5srLvPT?= =?us-ascii?Q?2L0LlySoAjpL7aeT6kEzoRC+m+GZKNIgrGi/I+uyhHKkLFOZMh5uU4O09Vtt?= =?us-ascii?Q?Z7U0+HnHb+G37KDu5n1dYUY67GDqkct0S6KdJYfiVLNeE7HJzeHd+X1tvUDH?= =?us-ascii?Q?vYSffm0wDqe5d1XxZHsyOxfv+RrCdlyiEkPeOFPB1fZ11iGC7s0sZcn5QKz3?= =?us-ascii?Q?go4BCIwU0pDGLJlSOUJgG6A8fjFZJomDvfqIuRKIdPJVmeCwffaHyHw1Ag5Z?= =?us-ascii?Q?A1KIMvW39wdTiWwMaDlul8BXPzOdKNWvX0uw/KikCwXrbuawpNH99GrpXVvv?= =?us-ascii?Q?iJHvWDQRJ87rKmrwM5LezsNnuCxb6kUzPQDhARbcK45cjgl96SX3p9eEG1JP?= =?us-ascii?Q?XATUQ2uO1M6bsvYzayG4RcD+7UdD2gjAvs2hrdgixLRv78izUnofM9XrSP/P?= =?us-ascii?Q?pItNv8KQHQGhlu5nXZkAAWkCrarWXzxdO25YWa6uayx9A4s8wKLu1x55YNK+?= =?us-ascii?Q?lhkRodA0TW+g2fFeff4nL+v1ecq4ns+k3ZmR9aRQnZW25VPAc8Wg+S0vVIkl?= =?us-ascii?Q?WMWCZtQO2O6uoIIWV5nfag0fB9xcuWe+QKQd8dQlX5RC52jQXTilhNfzU5Lr?= =?us-ascii?Q?vxxAdqoAKDXaEzf0ZQ74p19y8h3ukJNexuYtoX54rwTM0M2oaFCJ3EUeCZrz?= =?us-ascii?Q?JsMLPqXMQEOYbcwQjqWGCywN/tsp8AhWR1zxulXDr6qyse4EE366xZBXA+n0?= =?us-ascii?Q?EBgoMNNOw0FWEa7K7irCY9Hq7UskExBbiLECw+xFJk8cfMWFp34l22UGjsmS?= =?us-ascii?Q?kg4d+QiBu2+cXxcx3TqzSmMY2kmrEni9z/gwz4hJAQzl1qVLyj3ULEnun+Id?= =?us-ascii?Q?KB8RC1bZEKAu1S8FWfS16/GlggWyCsgpqr6NLQVToZKoXp5I5p84KpKgIN+Q?= =?us-ascii?Q?8wXDmL7jYdOnQ1ISlKDEiBJzQg2oY5Ep4W3kODOLY3XcFecjYfa3OdycQ8wz?= =?us-ascii?Q?GsmfhJplYbZ8xYoceZpGi2aKLTsukzBTcxSG6+qKAS1aC0sVnk0/k0p2Jofa?= =?us-ascii?Q?I/Kat4YIllLvb4a05NijJ1xLu2Vt5AH2y+PzHdCptwhEoIHM+EPk9Jf0zprN?= =?us-ascii?Q?nMvJlYKDIeqajylvGV2FX0BBgzgyb1EP7QTWnDH5PenYlwk4cV5L/uGbxBdQ?= =?us-ascii?Q?m6SCYDIS70wTtT4xo/JOhzyGvqfI8KEsfWPLkoXL6CxxjUR4Y9+r3JURDQIh?= =?us-ascii?Q?wYh3iSapEEA52K0lWCrKjwSwa9/40jyDGoce29humumOa2awVqhxhfXl964i?= =?us-ascii?Q?CQD4XQv5WpaWZAPvHCSJ3OkTjoOHMzAhJLFhpgNPbIgL6wP0o04QQGN00MLS?= =?us-ascii?Q?1hRMsiOqXhpjNR60zKIU078827nm1bm2dcLwDGZs?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 549f0dcb-f597-4068-d50d-08da772143bd X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2022 20:29:58.0018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m43XuMTyqRjIFVDiua4soUyW3Vp9t4+F8cmIFUiP1h/2ZBdtBwXZbZgkbhNQMGuhwCme109u5zgcw7laeEe0/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5756 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, August 5, 2022 10:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: P= revent modification of HOB data From: Michael Kubacki DumpMemoryTypeInfoSummary() is used to dump information about the MemoryTyp= eInformation HOB. The dump function currently modifies the data which can c= orrupt the data for later HOB consumers in the DXE phase. This change makes DumpMemoryTypeInfoSummary() treat the data as read-only. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemor= yTypeInformation.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library= /TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..a30b69dd787c 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh +++ eckMemoryTypeInformation.c @@ -22,8 +22,8 @@ ShortNameOfMemoryType( =20 VOID DumpMemoryTypeInfoSummary ( - IN EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, - IN EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation + IN CONST EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, =20 + IN CONST EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation ) { UINTN Index; @@ -83,7 +83,6 @@ DumpMemoryTypeInfoSummary ( } =20 if (Next !=3D Previous) { - PreviousMemoryTypeInformation[Index].NumberOfPages =3D Next; MemoryTypeInformationModified =3D TRUE; } =20 @@ -110,7 +109,7 @@ TestPointCheckMemoryTypeInformation ( VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; VOID *VariableMemoryTypeInformation; - =20 + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation - = Enter\n")); CurrentMemoryTypeInformation =3D NULL; PreviousMemoryTypeInformation =3D NULL; -- 2.28.0.windows.1