From: "Isaac Oram" <isaac.w.oram@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Oram, Isaac W" <isaac.w.oram@intel.com>,
"tommy_huang@aspeedtech.com" <tommy_huang@aspeedtech.com>
Cc: "ardb@kernel.org" <ardb@kernel.org>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Chen, Ryan" <ryan_chen@aspeedtech.com>,
"BMC-SW@aspeedtech.com" <BMC-SW@aspeedtech.com>
Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
Date: Thu, 9 Feb 2023 03:12:38 +0000 [thread overview]
Message-ID: <SA1PR11MB580119B0DE5A21CE2B08EC1ED0D99@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1742056401050A3B.15261@groups.io>
Pushed as bc0b6bf..bd07ad3
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Wednesday, February 8, 2023 5:59 PM
To: devel@edk2.groups.io; tommy_huang@aspeedtech.com
Cc: ardb@kernel.org; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tommy Huang
Sent: Wednesday, February 1, 2023 3:14 AM
To: devel@edk2.groups.io
Cc: ardb@kernel.org; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
Subject: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
1. Correct all INF_VERSION value.
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: BMC-SW <BMC-SW@aspeedtech.com>
Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++-- Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
index d6a674c..6bda488 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
@@ -10,11 +10,11 @@
##
[Defines]
- INF_VERSION = 0x00011302
+ INF_VERSION = 1.29
BASE_NAME = ASpeedAst2500GopDxe
FILE_GUID = 7F81D838-F91D-4C44-8552-8FB912122FDD
MODULE_TYPE = UEFI_DRIVER
- VERSION_STRING = 1.29
+ VERSION_STRING = 1.13.02
[Binaries.AArch64]
PE32|AArch64/ASpeedAst2500Gop.efi|*
diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
index a652ced..3375407 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
@@ -9,11 +9,11 @@
##
[Defines]
- INF_VERSION = 0x00011302
+ INF_VERSION = 1.29
BASE_NAME = ASpeedAst2600GopDxe
FILE_GUID = 36f08597-2a8d-4824-9416-59c810b0d9f3
MODULE_TYPE = UEFI_DRIVER
- VERSION_STRING = 1.29
+ VERSION_STRING = 1.13.02
[Binaries.AArch64]
PE32|AArch64/ASpeedAst2600Gop.efi|*
--
2.25.1
next prev parent reply other threads:[~2023-02-09 3:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 11:13 [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value Tommy Huang
2023-02-09 1:58 ` [edk2-devel] " Isaac Oram
[not found] ` <1742056401050A3B.15261@groups.io>
2023-02-09 3:12 ` Isaac Oram [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-30 2:09 Tommy Huang
2023-01-31 11:38 ` [edk2-devel] " Ard Biesheuvel
2023-01-31 11:52 ` Tommy Huang
2023-01-31 12:45 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB580119B0DE5A21CE2B08EC1ED0D99@SA1PR11MB5801.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox