From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.5842.1661987917538312107 for ; Wed, 31 Aug 2022 16:18:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hXgznIYy; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.20, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661987917; x=1693523917; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lXIV935MKcq1qbwQbULweaLSwVCqPcOPPL9hekHBdcs=; b=hXgznIYyY4u/7P2ZiCqXkHQ9UznmaVKtxNfya5folN9vTxfcZNm14KEH 1T4/EcFxOg7dv5UuxJrCXmEOAjpdAFfmh2Op80H+/ZYUTtFglYNmRSPb8 sDNbx2sBLS6anmVR1pKa3O1KlH+ChQLYAAyMrukIUhnAU3h49gA4bR9nO BaSGyxHE9/X8S02ZEYY2Qv1XdEL7QDAn0d905RWqKqY/DIFX/HRyU9PbR an3Xgi9hh7+IP8ZGHwSYyreT0JIS0v7XOA+rUkcOdA2vMJE4kdtwobqBJ FcqqpuybocCkMDkySy9NYWDHjXFSGDX1y9NTMlpFg+dxNe6gkjVAOgpJP w==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="282546972" X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="282546972" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 16:09:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="642069441" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 31 Aug 2022 16:09:49 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 16:09:49 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 16:09:48 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 16:09:48 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 16:09:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRAOrcZV8nw2mpppr2kZoqDS4qGmPVDmxmsK6+DRrS3hzf4ab1oxwFnQCFSQdhc5/SnCQbqAH0gPkfV+GDYyMyNMb83O3ljDteai/6H1wO4TOt01ehqX/ezXyEmrElLSMl1JBD/nsW+JK7KNayj5NtemQKyAdYOv7rGzdmfjTF+r3K11yOn3J7oXsrcC7r5wBfuaUbVma3e+h5T/hsMuG0paIWMl1OLoMNn70VqOWFOdQONHne7lenPwqS2CX94GKfuIBZF+ihtLxFE/vwjo5wPie59zZtqABSXuEz24Tnt87KAzP7qEwKnIQSf8bXGW97v2HAJbp7ieo/TQRrN8cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofT8QKS124Jd4NE08BGiKFiNifUnD8apvirXfOm252k=; b=DqWJwIEA+Qeoz3vVWrrfoV6SEOobxCsvImH9yIY+y8tD54EBxS94uIWdLgymNl89fqOwusvHyWuNScYVpfkP41tBHll6rKCEmEl2ptpPysyr5zxZQZfzdPsVTIFESCIDRLX9Ri3v5kIep0J6U5ZMSe+TeghXrmfkDodjfeQMAjzejgdqoyff1RXG6PceOyM6DkGNApYUoE34sm00ObiRFwu2TUCEYvhjRGIvTEK9xDiLJ3zuN/P1wg060l71zRK3FQf16KMH8hnxPzzzNVtKSaw6op+bY6ZldZJjPVVxITn+VRQ75LV7Jc72SX4vcLgO1tdbkMiSCdcOKi9/5imaIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by CY4PR11MB0040.namprd11.prod.outlook.com (2603:10b6:910:7a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.19; Wed, 31 Aug 2022 23:09:46 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3%5]) with mapi id 15.20.5588.010; Wed, 31 Aug 2022 23:09:46 +0000 From: "Oram, Isaac W" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. Thread-Topic: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. Thread-Index: AQHYvWYv/tWmmBgMNUS5HCDJZ3d4vK3JoPIw Date: Wed, 31 Aug 2022 23:09:46 +0000 Message-ID: References: <20220831181842.3141-1-chasel.chiu@intel.com> In-Reply-To: <20220831181842.3141-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69f892bf-b1fc-4826-bec2-08da8ba5e59c x-ms-traffictypediagnostic: CY4PR11MB0040:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FEgPCsWBKODZGf64yFMqc/B2CACblKscUK6QVLDcNGmCIoUWy0lnD5DBjhSIpR+ZgWLbKCI5PYcFy6OJ224yoN/ufvdeoPkIL1/j8yg4nu4TDrgIm1zOOjwuTSz8HuH4h/HW+wJnMMOzQh7eNlk2Fa2H5i7B7tWJBF73WAMEMvyXVgOvAD+Km1oiaa6reaVg0vxxi/JHDtgVL50o8oBZj5f8osdzmAp4ocSB5O8bDAs7HB/EWOsvVNlCFAF/emJ3m5AehsjyEddON8zTB9APVZV4G6TTQIGp2hKIWVpBF6DaEQvWMxXAU/DGpjv9ZO6/wr+MowpEY+YeCQPChINysfQLRYudOrlZObJssSnXlSpeHAokffw6dKctgZ4LMG1hyMX+0YtiJssjGZdI/zPBPWILKbqpS4pK5Dh0l4OXoZK/h5PLEB6s5+ucs7CmfxNys6AeKtUJsrLIk3sUOfWr+oJtmF92Xbsca45e26/4mfiOgLPtu00dbFS7Wfwz/I0eBi9UgaV8FuAjihZfEuuTSkwMRxfkgxe4e61shGo5Hv718wUgZqC8mIbC4LqgU2qREtKi43r/dgK7b2M/4gj5VCjX8M4pzJ4wPvjscETjp1K4pB7hIky9nKxc7e7e6HO3FGu5YZKgJ4WDafDIFMV3rDQcBJ2GxkEljEDn35S0DSe3or+zsz5HTge/+jWzMUOSwwKfjEWFSYZX+Cij3tgY4dVnY9ttheRBl6I2Qm49zuR1amoveUIli+9m3Rfc00EAg8/iY0yXN0ea1xwK5eii4A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(136003)(39860400002)(366004)(71200400001)(26005)(478600001)(110136005)(54906003)(38070700005)(82960400001)(38100700002)(186003)(41300700001)(107886003)(6506007)(9686003)(7696005)(53546011)(33656002)(66946007)(55016003)(2906002)(76116006)(86362001)(4326008)(52536014)(66556008)(316002)(66476007)(66446008)(64756008)(8676002)(83380400001)(122000001)(8936002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eALi3sKq2yt6Os7jRunM3KXlM4P4+bg5Np8sO5VS5mpuHCDWqs+GaEtUx4bD?= =?us-ascii?Q?LZwRSEvoG5CjnSTP8gY3EtI88YE9n+z223+FUSrUpk5qLQFYhZJbkWNgqUkF?= =?us-ascii?Q?vp6iHJbJ8AyaiwnrqXNpIVZCS7lsZspaopyl/uHh5bUvUm/wmawV+h1mFtU+?= =?us-ascii?Q?60U1fjxMArh2CpSkrUlqVqQINQWCmZXrGvAMzQdA57YIXpUILNhwx2c8wWxm?= =?us-ascii?Q?bis1Xl/Ubm0RmNszoWn5C62EQ0PQXMEbf9yJ49xhHNTXN4m1fk4kdecoUeb+?= =?us-ascii?Q?Zvj9MeEW4FusK7Rx7JJAAn/XpId4G+3CaDVKy4v/lMIl/WcG7NHhnSHjMcUI?= =?us-ascii?Q?G7FFpKfaE7HNVeheCGllr4NtZzoJKEHCXnIi6AkJeD6Vl7YqBNO8CBiR0Qu+?= =?us-ascii?Q?AGftZRTz6R1GBjIc/8QUuczztFlUm8Jk3OvDezMwky+1n7+yy9t/wkh7XppB?= =?us-ascii?Q?TgZItLMstGh1/3VeG/X5jk4y+5nN+EF0epLFR4VDkOymB9QW+SzMAUBpKOZd?= =?us-ascii?Q?rQmmOJhHc/9nanXNT7VyLgc+KZkBSl/1a8L8G8oXnox30N4ianvKk8qNE/Vt?= =?us-ascii?Q?MYBfRI6fLxQlZhuSY01T7ue/LWjJuIq5aaQLhgtDaGuIQh8b4I8RZU4PUcQf?= =?us-ascii?Q?qndi4mvg8cVEOX7LSIP864UjyI0ETqINBNTsP8Z3Y1DHSaHJaMzTpF6Q9DIc?= =?us-ascii?Q?zdGm3rNk7VLBX8LB73DhJqMcJJGReuOrBIYPNeqc2NtfyikiyHFF7Zpj2Eaj?= =?us-ascii?Q?vwGBvW7LOBGxiPjvytdgI3VMz6eRvxuwm8Esgg1cEl5U0DnqnwY5sOk4mFRX?= =?us-ascii?Q?bJnZ9dHKTCJ8lQb8q0EGDxFbV4HjsugafuK/4IL8lloKyQJA8f0ovjc8bM3n?= =?us-ascii?Q?z+CstduqELJckKKLMmvhfItwjlbzX7U4eigMT2CO7H1N7AaAJ53xSpApiB6g?= =?us-ascii?Q?xyd1XlNz9PaVqcNnKeamx60+QOLeYsAvXt7iZhburEagmW9Ztk0aCv3euwlI?= =?us-ascii?Q?5grNQFacso/MmW0nwGe5JsNMCtnp06nlS+4bDCFkA4BiPPONR1oJrDpRFskx?= =?us-ascii?Q?iK+yjHbarO/R8v/JyXaMdg+v7nRzlp8hwIwKioE4UsVMIBDOEj7JMdHI8R3V?= =?us-ascii?Q?E+jXGQiySOjDIbTk+e7NkqakNCUAP44YfLk728fIgVKceSwnItwDGxdrp5a3?= =?us-ascii?Q?0kT8SvBVXebLz5Nsapfhpn55UIzHuNkIQTMVORHy9EZuOY52l9ZOPNs8sME3?= =?us-ascii?Q?UAG3yx9X1AVJLJiR2n8I8YMVVj9rmrr6zfEz6UtM1lDSDMrCVAstrrx+H9i/?= =?us-ascii?Q?FfL+orweM8zYyfqBXGwVQSbCdMWgbIp91iy8eohKUeS3JuowvlG7WLozQ3Xm?= =?us-ascii?Q?TguNwF86NlT5H4rBgo+bPQUhuhaypaDyzCa+MpTW/MQSmkXVu381aZPl2OKg?= =?us-ascii?Q?3vqoQd+b/8D1I63UUGU5XA+oG5bhcYAUb/3fpKFLDRx+6oAL31jw35AA8+YF?= =?us-ascii?Q?awigqjEqYzpPnj9zScyMRbsIKB3VKpAh7oEhQvOEEl8v0AuixqSqYbQ9dUOM?= =?us-ascii?Q?RB+qltOoyIH8Ca4gzV1mAtlpqBWmWhWubQ8MfSqW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69f892bf-b1fc-4826-bec2-08da8ba5e59c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 23:09:46.4309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5q9DWUTbDOwVG08onPgmvSLei71PySyySXmpyvIgwL6YhyNXwjsZyWcAQQ5jlbIFalPITMHYkr/hyAKT+4g+nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0040 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This sample library does not do anything. If the design is such that a NUL= L library is functional, then a NULL library should be implemented. Having= a sample library that has the same function as a NULL library doesn't make= sense to me. It looks like a NULL library would work fine in this design. If you update= to IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/Bas= eFspWrapperPlatformMultiPhaseLibNull.inf, that would be acceptable to me. Regards, Isaac -----Original Message----- From: Chiu, Chasel =20 Sent: Wednesday, August 31, 2022 11:19 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase lib= rary. FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platfor= m to include new library instance. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Pla= tform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc index 8e91dba6ac..d4191c4b01 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc @@ -54,6 +54,8 @@ TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHier= archyLib/PeiDxeTpmPlatformHierarchyLib.inf FspMeasurementLib|IntelFsp2Wr= apperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf+ FspWrapp= erPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformM= ultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf+ FspWrapp= erMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProc= essLib/FspWrapperMultiPhaseProcessLib.inf TcgEventLogRecordLib|SecurityPk= g/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf TpmMeasurementLib= |SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf --=20 2.35.0.windows.1