* [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. @ 2022-08-31 18:18 Chiu, Chasel 2022-08-31 23:09 ` Oram, Isaac W 2022-09-01 20:55 ` [edk2-devel] " Tim Lewis 0 siblings, 2 replies; 5+ messages in thread From: Chiu, Chasel @ 2022-08-31 18:18 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc index 8e91dba6ac..d4191c4b01 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc @@ -54,6 +54,8 @@ TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf + FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf + FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf -- 2.35.0.windows.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. 2022-08-31 18:18 [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library Chiu, Chasel @ 2022-08-31 23:09 ` Oram, Isaac W 2022-09-01 6:01 ` Chiu, Chasel 2022-09-01 20:55 ` [edk2-devel] " Tim Lewis 1 sibling, 1 reply; 5+ messages in thread From: Oram, Isaac W @ 2022-08-31 23:09 UTC (permalink / raw) To: Chiu, Chasel, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Gao, Liming, Dong, Eric This sample library does not do anything. If the design is such that a NULL library is functional, then a NULL library should be implemented. Having a sample library that has the same function as a NULL library doesn't make sense to me. It looks like a NULL library would work fine in this design. If you update to IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf, that would be acceptable to me. Regards, Isaac -----Original Message----- From: Chiu, Chasel <chasel.chiu@intel.com> Sent: Wednesday, August 31, 2022 11:19 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc index 8e91dba6ac..d4191c4b01 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc @@ -54,6 +54,8 @@ TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf+ FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf+ FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf -- 2.35.0.windows.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. 2022-08-31 23:09 ` Oram, Isaac W @ 2022-09-01 6:01 ` Chiu, Chasel 0 siblings, 0 replies; 5+ messages in thread From: Chiu, Chasel @ 2022-09-01 6:01 UTC (permalink / raw) To: Oram, Isaac W, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Gao, Liming, Dong, Eric Agree. I'm sending patch to rename this lib from edk2 and will send patch to rename this lib from MinPlatformPkg dsc too. Thanks, Chasel > -----Original Message----- > From: Oram, Isaac W <isaac.w.oram@intel.com> > Sent: Wednesday, August 31, 2022 4:10 PM > To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> > Subject: RE: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 > MultiPhase library. > > This sample library does not do anything. If the design is such that a NULL > library is functional, then a NULL library should be implemented. Having a > sample library that has the same function as a NULL library doesn't make > sense to me. > It looks like a NULL library would work fine in this design. If you update to > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/B > aseFspWrapperPlatformMultiPhaseLibNull.inf, that would be acceptable to > me. > > Regards, > Isaac > > -----Original Message----- > From: Chiu, Chasel <chasel.chiu@intel.com> > Sent: Wednesday, August 31, 2022 11:19 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Oram, Isaac W > <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, > Eric <eric.dong@intel.com> > Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase > library. > > FSP Wrapper has implemented FSP 2.4 MultiPhase support and required > platform to include new library instance. > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Eric Dong <eric.dong@intel.com> > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > index 8e91dba6ac..d4191c4b01 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > @@ -54,6 +54,8 @@ > > TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatform > HierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf > FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLi > b/BaseFspMeasurementLib.inf+ > FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspW > rapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLi > bSample.inf+ > FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrappe > rMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf > TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventL > ogRecordLib.inf > TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpm > MeasurementLib.inf -- > 2.35.0.windows.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. 2022-08-31 18:18 [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library Chiu, Chasel 2022-08-31 23:09 ` Oram, Isaac W @ 2022-09-01 20:55 ` Tim Lewis 2023-08-08 21:25 ` Nate DeSimone 1 sibling, 1 reply; 5+ messages in thread From: Tim Lewis @ 2022-09-01 20:55 UTC (permalink / raw) To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong Is the FSP 2.4 specification available publicly? It is hard to understand the impact of this without referencing the specification. From the FSP page on https://www.intel.com/content/www/us/en/intelligent-systems/intel-firmware-support-package/intel-fsp-overview.html, only 2.3 is available. Thanks, Tim -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel via groups.io Sent: Wednesday, August 31, 2022 11:19 AM To: devel@edk2.groups.io Cc: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone <nathaniel.l.desimone@intel.com>; Isaac Oram <isaac.w.oram@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Eric Dong <eric.dong@intel.com> Subject: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc index 8e91dba6ac..d4191c4b01 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc @@ -54,6 +54,8 @@ TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf+ FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf+ FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf -- 2.35.0.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93013): https://edk2.groups.io/g/devel/message/93013 Mute This Topic: https://groups.io/mt/93377589/1760553 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [tim.lewis@insyde.com] -=-=-=-=-=-= ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. 2022-09-01 20:55 ` [edk2-devel] " Tim Lewis @ 2023-08-08 21:25 ` Nate DeSimone 0 siblings, 0 replies; 5+ messages in thread From: Nate DeSimone @ 2023-08-08 21:25 UTC (permalink / raw) To: LEWIS, TIM, devel@edk2.groups.io, Chiu, Chasel Cc: Oram, Isaac W, Gao, Liming, Dong, Eric Yes: https://www.intel.com/content/www/us/en/content-details/736809/content-details.html > -----Original Message----- > From: Tim Lewis <tim.lewis@insyde.com> > Sent: Thursday, September 1, 2022 1:55 PM > To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com> > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W > <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, > Eric <eric.dong@intel.com> > Subject: RE: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP > 2.4 MultiPhase library. > > Is the FSP 2.4 specification available publicly? It is hard to understand the > impact of this without referencing the specification. From the FSP page on > https://www.intel.com/content/www/us/en/intelligent-systems/intel- > firmware-support-package/intel-fsp-overview.html, only 2.3 is available. > > Thanks, > Tim > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, > Chasel via groups.io > Sent: Wednesday, August 31, 2022 11:19 AM > To: devel@edk2.groups.io > Cc: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone > <nathaniel.l.desimone@intel.com>; Isaac Oram <isaac.w.oram@intel.com>; > Liming Gao <gaoliming@byosoft.com.cn>; Eric Dong <eric.dong@intel.com> > Subject: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 > MultiPhase library. > > FSP Wrapper has implemented FSP 2.4 MultiPhase support and required > platform to include new library instance. > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Eric Dong <eric.dong@intel.com> > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > index 8e91dba6ac..d4191c4b01 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > @@ -54,6 +54,8 @@ > > TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHi > erarchyLib/PeiDxeTpmPlatformHierarchyLib.inf > FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib > /BaseFspMeasurementLib.inf+ > FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWr > apperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibS > ample.inf+ > FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrappe > rMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf > TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLo > gRecordLib.inf > TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmM > easurementLib.inf -- > 2.35.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#93013): > https://edk2.groups.io/g/devel/message/93013 > Mute This Topic: https://groups.io/mt/93377589/1760553 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [tim.lewis@insyde.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107647): https://edk2.groups.io/g/devel/message/107647 Mute This Topic: https://groups.io/mt/93377589/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-08 21:25 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-08-31 18:18 [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library Chiu, Chasel 2022-08-31 23:09 ` Oram, Isaac W 2022-09-01 6:01 ` Chiu, Chasel 2022-09-01 20:55 ` [edk2-devel] " Tim Lewis 2023-08-08 21:25 ` Nate DeSimone
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox