From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.32511.1684266861919761878 for ; Tue, 16 May 2023 12:54:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NHNjQNaa; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684266861; x=1715802861; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=O4s4YvZzHffASWEZ8qM8NUSdBhIrRDFYwGUHED/Jdhc=; b=NHNjQNaa/k2ns/9WMaWRMAlUKdcsFMHmWTB0OM5GvQSr5IDQaN+OSg8I urzqAGIf6JzuD2E95yarQhNarRE8VeIUrHLZQEZG/qCAHdJ4PWWB/7eMB jt6BsiP1L+8KU+eZ6i5MN1HWp/Uf6+GObymUUVgD2IToB/xiBQE3Exool YpLF8q/VcmQDwlj5nR+ofNi406GCbkSqSp8GFwztLM+huHXu58+NDgbIz r+y9OsPzBNwl3h0R6ZaRjxTI18otfKVyiRGBiRxbaLBxMWIUjCg6T2bEs egW/xnZHR4V7bSh2i6JTTOiOi5VtG8Yxgr5VHFp0HAxoRSy2Kfoj+pQI1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="331194074" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="331194074" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 12:54:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="947975969" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="947975969" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 16 May 2023 12:54:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 12:54:20 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 12:54:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 12:54:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 12:54:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuhFLo68tZfmZRvBzeX4m+AhpQddQ8F/BguA+KptVQpWK18BKBTM7Y5dmvWkni/bpV8jFwLtSw4u1BzN0zcfnqEWerm1VZRL7xNu/rfZrstVZvP7ROx+lSuTDp0Fcur0h6bMwk+Re//aZ6ayyT/QzQ4++qDGVoKLfcoOxQTaMUnBaTIh/mgKz+g/uTYjVKO5Iql3KAKV3BIQHZmIsabeeKn/zID4tTmuzCpjcJuuy2SyOJ1jZ+DI+9VVMOZr3kfxlDNoBBMtYRjMX8vrxVt9AW/ZijK7UQwqanRsmtZMDcP0SIC+mtmUzgM4zGhpeAf7TZDTaggtTnqpQS/VuH5uCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2EOSAgtwELSNLs857xQq3MVg2jzszUVEVSp6Tb9akkI=; b=e1gKA+f7+zya0w2xZ59qb5JXt8rDAxAgIKvQEO0JPdf6qaAEd62Agt/uiL1QjCGpIuF29oW65fxKynRphvBE675Lw3tZBkxCJ9nI7RCvbGgQ5cL4hkssg0dOh5F3tCUtPBjaysqZVKXKBl6e+aitJYb8kLvwDQDNXTZz6UC7L4c9U84eD8ViBXiHJ9aLEaCppP1kFSIH01PYchsTzdBCOP9m1McQIY214wpjWP40MixlxsEjd6FLDEafBAWHoEqIPaY9/K+TjuOMzyl7wPY2VookqFV9z9o//NWe+ac00KYgvr6XJMfgsrw2JAha4Ak8Kyvw5n1mHBDVx7kui67wYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SN7PR11MB6603.namprd11.prod.outlook.com (2603:10b6:806:271::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 19:54:17 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6387.030; Tue, 16 May 2023 19:54:17 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "rebecca@bsdio.com" , "Dong, Eric" , "Gao, Liming" , "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Thread-Topic: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Thread-Index: AQHZhvHATL2oyLC++E2kYEpoj97Uha9b2JmQgAF5zoA= Date: Tue, 16 May 2023 19:54:17 +0000 Message-ID: References: <20230515055421.3241932-1-rebecca@bsdio.com> <175F6E02C829A330.20583@groups.io> In-Reply-To: <175F6E02C829A330.20583@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SN7PR11MB6603:EE_ x-ms-office365-filtering-correlation-id: 0dfca2da-0876-4e09-6296-08db56475528 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O/SHjGK55G1XYb9v2lXyjuJ41MZyZCqTmNbMb44gTIs/rl9FA6gZVipEsO8s9zcUIWrYyDpe5oX+O+yy+w79cD8IG8O9bsmD0N99+uHupQ00N8yk6Z6oogZJnEKN2KxsH5WGqfA9weA2srL+HFfnsPo119eDahoLbkCewXq6qrvVWf2+Z25NSFtMzU59WhZk8PH3jmmx/dtk0uEwqv5eTzC1FQePMtrwl78AF5nlV97H7DJzc+IwUlloqOzWYHswj9VVsnzG209hDbAUHxBQ8wrr7pP79LcN7PHh8NRdxn7ECSPQseerYCmTXAQ82jOA9uX/UL4tr7po8J4NXgNG9FVMf0BrgbRm6zOubc2nDkAa71RrSqb+I24AAM8mCBiGkD8L6Is56sBanQpEX2TYoWbXxsf4yThNu0d0l9PuzNF1iwnwtaDRrjD5/mE1OufvZgIHzUnZZGbsfFtrPS8XCN8cMmW3uVQwGXsAFBpL18MTMdXhAA479KGv3kVEj79b2E+i4wGWFGOSNAv3Em2ipZfgQ6/7JFdbtmmZR91wAlx00BlhFuTlZXshKp/tsCco/mdtMlmxZ56yoNG54S+ttP6bUbGkzVy2WqiaLMgoTcOrqNMh/TL3Q/SSdSjRbUALjXF5ZOk5IenUZrRaajkeZUStfBjAxBavqXvn8PsKBso= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(396003)(366004)(376002)(136003)(346002)(451199021)(66899021)(71200400001)(2906002)(966005)(478600001)(38070700005)(76116006)(7696005)(66946007)(6636002)(64756008)(66556008)(316002)(66446008)(66476007)(53546011)(110136005)(122000001)(921005)(55016003)(82960400001)(38100700002)(5660300002)(41300700001)(8676002)(8936002)(33656002)(86362001)(52536014)(186003)(26005)(6506007)(9686003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pcXmIw18LGDXFTD+2y2yX3pj/zTxwS51kmpi8J1amiNT1+aLKPB4Muvc5S4C?= =?us-ascii?Q?upYRl0widBNVz/0QeAts6rNjXUpBAYaa3kZOHjg3H3gcL39rB5JtuCkRX7qy?= =?us-ascii?Q?+qnCGB2OMixDkZvHqbir31tMl8GQhFpFWEnVZT7PxxACQO7qbinIOt6kLioB?= =?us-ascii?Q?22abIFs68xQoZOHdqIzOb17OSMtZQzsK7Nx8NxGPBcHS9BSpKIS866YfgeNx?= =?us-ascii?Q?VQHa185Y/FzmKvNo2RUBW4m6AhtFjXEfzk9gug2FbxdRTKEqfB1fYd1Ms8on?= =?us-ascii?Q?tyrI6AFN0TvWeV/j86yEepd2gKOl/bdr3YaHSbbqCVJB/+N5mW02Ty8zt2tX?= =?us-ascii?Q?Z5CcrUBED/+94vqXY6qdPPLiDjipaOuDmXaK9up7bgVNGcQZDHuvKaGYLVQ3?= =?us-ascii?Q?80/3xlfgX5wT75JE5qYy1AwSQ6dta56/CsBW5r2EI/VvQBOkYoC219eRbHFx?= =?us-ascii?Q?hTFwPZbOg1KMQ0ZLi2mqXE1UnGtkpCeAzif67uAGb8fbZuEN84PPOOLFrCdS?= =?us-ascii?Q?KCdMOpUM9iBW8llqH+sLpixcEqi3+MB1xPH/EkJzvPX+VGmgU0NL6Sl9lAqc?= =?us-ascii?Q?/d8sp0awbOVNxIH69er1TLM/wX45oJhMhZplCGY40jK16dKcFV5yf6j4XUUs?= =?us-ascii?Q?BJY+BQIhxRACJesoNG3rdZaaaKPgNjIcgUyI8PFGCQNOZx5vrKzJzU2yLPu5?= =?us-ascii?Q?oAiOSBVzv7tQ9F2+E30tMtCTRClMl3Xs+cq8xR5zf01YN4MeSp+CSZwQuUHN?= =?us-ascii?Q?A58jjwoxDAL14HIMcPWCQuN7RIDD+U+bgbgbX2eKPCcF4yFxhhBoQjMxA2Kl?= =?us-ascii?Q?cJCuXkD0AlsRPjrzn2CYwp1EvBUHTic9tIbZFuq2Bas/fNgwiNgD4o4yhjH7?= =?us-ascii?Q?AFLNaxf4jvqIyigwyaXgRyx0Aklzu9EEXf4HHERwcHINVl22Rz6PDm6UaFvu?= =?us-ascii?Q?Vh39drURqcg26/cXzDLECv7Gyi9+eE2kJlcAUo31OvJOGITODfrZehl50UzH?= =?us-ascii?Q?YgYGTET4WMEGymv6ARr+xOwq/7odPYod0Fd0TCpaYizS9R0Kn/EEhA+A4Fqz?= =?us-ascii?Q?ZE+yWxA1eeBOE7HVjQnaU6MFA8VTicOb3gEM5uqcULK/CSyBx8V5ozlFWP0C?= =?us-ascii?Q?l5wbCsXdsdScmHfj37HCM5oeiMvilibVs3zzH9fKWhiH60QMf4Hze9p2MB5O?= =?us-ascii?Q?1BjRtMNFqTBI/ttuH+NAj6z+Gj8fgeF3SdRpXxfaOgIea9WA5cGsO0VVKFot?= =?us-ascii?Q?NVqXLN+vrmY4dz17zwQZQCVQCTB8V9dLroAXensao3bBdaYyJ/pVCVkGCiIq?= =?us-ascii?Q?ANlwHyv0tgXp9voH11yxTPRTtn0cmjL0CEuXruSnksEzZUvhOkETWnxLY+64?= =?us-ascii?Q?edFcxPAtxmhyuUoJclNjtvlUJm1kODaZfhEwLjnh1T/y6gSaOWYP43nrm4Vt?= =?us-ascii?Q?ZJhogvbKh/TFqGTXxzI6BCIk6qahnuoB6DStVyyMWbU207nqSq0J9z3zUEOC?= =?us-ascii?Q?ejOjxEFru6E+N34TTom+3FGQZsPKcz6OqRsHMvBDdKKu/BgvF0ssZabKgpdw?= =?us-ascii?Q?Fjozj5eS1+Pp91NXC8Clf1RS1M9NznpB4CQVTEv3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dfca2da-0876-4e09-6296-08db56475528 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 19:54:17.4325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ScXqHguboRLelEX3DlGt1H5F4Po6EUAYpK0eOKCIlGDzlZthnCwkC852XLxBY8ttaNYfYsGxw6craMS6v9lJyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6603 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as acf260597a..15f27d5c30 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Monday, May 15, 2023 2:22 PM To: devel@edk2.groups.io; rebecca@bsdio.com; Dong, Eric ; Gao, Liming ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix ty= pe mismatches from prototypes in BoardBdsHookLib.c Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Sunday, May 14, 2023 10:54 PM To: devel@edk2.groups.io; Dong, Eric ; Oram, Isaac W <= isaac.w.oram@intel.com>; Gao, Liming ; Chaganty, = Rangasai V ; Desimone, Nathaniel L Cc: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type m= ismatches from prototypes in BoardBdsHookLib.c Add EFIAPI to the implementations of: BdsBeforeConsoleAfterTrustedConsoleCallback BdsBeforeConsoleBeforeEndOfDxeGuidCallback BdsAfterConsoleReadyBeforeBootOptionCallback This makes them match the prototypes, and avoids an -Wlto-type-mismatch war= ning. Signed-off-by: Rebecca Cran --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | = 3 +++ 1 file changed, 3 insertions(+) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBds= HookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsH= ookLib.c index e866f70bc336..bc80badb3e01 100644 --- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib= .c +++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook +++ Lib.c @@ -1273,6 +1273,7 @@ BdsReadyToBootCallback ( @param[in] Context Pointer to the context data registered to the Even= t. **/ VOID +EFIAPI BdsBeforeConsoleAfterTrustedConsoleCallback ( IN EFI_EVENT Event, IN VOID *Context @@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback ( @param[in] Context Pointer to the context data registered to the Even= t. **/ VOID +EFIAPI BdsBeforeConsoleBeforeEndOfDxeGuidCallback ( IN EFI_EVENT Event, IN VOID *Context @@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback ( @param[in] Context Pointer to the context data registered to the Even= t. **/ VOID +EFIAPI BdsAfterConsoleReadyBeforeBootOptionCallback ( IN EFI_EVENT Event, IN VOID *Context -- 2.39.2