From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.2950.1688692459636213115 for ; Thu, 06 Jul 2023 18:14:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NLCZk3gr; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688692459; x=1720228459; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4QTwBpyCj8pOM2huGOnv6Lap5ypW0y4uC8aG5iS24Bw=; b=NLCZk3grrhR3OfzVYIwRbsUQvPwiD6RPGPygOotAIBdhJS7v4q6Xm6iz rGfcjgM5E2rb75va8MoVnJCdqMtkjBhJj0Nf8eGsT4FnSmSHCo/hAHTcv 5xfpAEx1zqZOa4I0chH0b3rvExHZ5guiHrAmdCvLy9MEL/kJ+zrySOemk g5HyHqBrzLiJWrXbMlLHwBFiVhvkzxOhr43l3fPe8/VjAgCL2gccHn/gZ 2t5oesYVTzcoFtxEhAYEoj03Zh1RXa5Lvi6BGG+nx847dHIY0Dml5ugWY jQCMZpq9LtvkgRF2b/70876M4I4Xc5j8jO7QGXePfdPMddox11eV1rgig g==; X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="353610148" X-IronPort-AV: E=Sophos;i="6.01,187,1684825200"; d="scan'208";a="353610148" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2023 18:14:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="754959012" X-IronPort-AV: E=Sophos;i="6.01,187,1684825200"; d="scan'208";a="754959012" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 06 Jul 2023 18:14:10 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 6 Jul 2023 18:14:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 6 Jul 2023 18:14:09 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 6 Jul 2023 18:14:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6ZXeGHO4O1XRA0jOpbSBRJULmY3gOUWzy8oZ294UPtmIXqZcPyOBDlPnZ2jo0CmE5T5ZxIrSrPr+1DmYjHZS1aIOCYsS675wgnasm4kxyxcnUlc8UYTB91PFtbl392z8/zU23WRgabaCGnaltyKx6wXTLs1r6jcrCFnI5zt/lbKBzCnDGcXyoAo7K7KB4uHIe2qjS9LFxZsjtABLy9TppJMDlOYDkmtMouGj1sq9FEbPQPW3L/5Lc40fOM159sIAElMpvNo1zlmEzAnELTH2Bj5TpjBNezF0zhxi2tHZ7ewUJnbKrsBTGaf1F1O3LqMc8dz26kDiSd29mA5mYazJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A6C4wNyzNgAZ625+Ae42+Tvo0ZvmQznXVCsxMdMZgks=; b=FENJS5u74Z4boQgtCyIXfkuOEfEluO8PpmapAKEKU0JYLILiftHQf/gF4JmekOKQDTGbXViAKwJRSZYw7qEGOEComlGs7RGZNLWcAvbRTsz6EL7aQ7+GfPKlWIGgGjG5I5rvTNkkEkF03E1gDjHohkgsULaxIl3qGVv9scG4v0EZQHU6cnUyFFlNmWZeGWszE3BgEn6TvAHtuLuFNNMFQly2fA4UgJ7PmikKwKKTDt6DvLcLxvenCb20RLK4+vyzuaymKFJMGsMBWtq+XXT8brGcQx0wumG+D3vJa1/oTxqCelmUOZ1reZOgSgyUxSmLV2nioqFxf5SX+oMFZx4nVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by MN0PR11MB6012.namprd11.prod.outlook.com (2603:10b6:208:373::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Fri, 7 Jul 2023 01:14:00 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::ba9b:b98b:c9f2:b32]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::ba9b:b98b:c9f2:b32%7]) with mapi id 15.20.6565.016; Fri, 7 Jul 2023 01:14:00 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib Thread-Index: AQHZr6rsMuuRRkpq1kGYu3P8iRW536+sCu4wgAF2QQA= Date: Fri, 7 Jul 2023 01:14:00 +0000 Message-ID: References: <20230706014028.194-1-mikuback@linux.microsoft.com> <176F27C19A6762FE.24383@groups.io> In-Reply-To: <176F27C19A6762FE.24383@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|MN0PR11MB6012:EE_ x-ms-office365-filtering-correlation-id: 48de269d-910e-431b-4deb-08db7e877255 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BmEEQUomXbM4uRsu4O2RyxMQ2O7XgVbHVx7zuJbabNRau+EQ064VWvoV8+yAwbFaStrfnc+f41HOvtrd4RRd97jpGVKkbX2XOs4iwnGOijvwSOWnrWbXjhWkrCfi/WfZrb7OK0TTSFFVHY9lvPuidIoht4gAiYh/Eo9OdUZiChCWEMFrSSLrYCwXexcsTBhz87adoDZZD7aImJpVupHeah3+Etbc0PGaTYTZERKJrmlBGSxJOtn8FFP+foQrGWpGzk3tUOgtBB+vbvEalG1zzx6IXbsbuxyOBeBtLdcURb6LvedtdubHGRDDycBKPRPU8URjM433cAO+2NVum6gHuIZYaOc4+llwIeaXtb+iwm3AdhX2I+BUuO/xQ6Jk3MqIwCkh2tRFzjYTKB5gKqPWF+vUalpkKto3WGOjWiRaINY74oa25TJakYDNHLvCVguowG+AjIwkVVen59pwvUSxVBHwY2DYkAUaQHtAS9qgTZrHm1x5bxz2OggUy3A2yYlttmAVs7FilqyE0cGBKLudnIqUt8uJpVXmVZ5qeu1HMpm45Ekgv4sYymKCqmnruCgOjgmZSM4KmmljSC3S3KJL4/ji7c71sjgPwPsq3bLqngvyqeIqNe1qODJA7gNb5aPG7qSStcNrcIysw2irUsklww== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(376002)(366004)(396003)(451199021)(38070700005)(86362001)(33656002)(2906002)(5660300002)(52536014)(66899021)(55016003)(38100700002)(966005)(9686003)(83380400001)(186003)(53546011)(107886003)(6506007)(7696005)(54906003)(122000001)(66476007)(478600001)(66946007)(110136005)(82960400001)(76116006)(316002)(4326008)(26005)(64756008)(66446008)(71200400001)(66556008)(8936002)(8676002)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rnN4EnHuZLyJH0MFYkWhNoUqsvf3DcIu2N/2gPydnZvsWTRZmG+3yQr3XP/Y?= =?us-ascii?Q?bRHe8fcCM72hCq5achkSUHh5WsRRsGcAWOxYyUJGSGiTUMmI/OrPF4OzEFFO?= =?us-ascii?Q?PwVmj6SkZZ6w/QWvcMlBqb8GxXlcF4osxD02emVT0Q7lW9mPhn3f81zCy4m4?= =?us-ascii?Q?GMNm8HexuE8jajLjs1VGY6pEKDWQ187nKWZA8v+AAOF1cvAROj3NuzQvP+0B?= =?us-ascii?Q?5o9TQrgDJW+i9uQArqt/iGBfF20/vCpdSnmSfoHPzA7x9pEWk9acF0wFZPD1?= =?us-ascii?Q?7I18Tu5LTkG6gs9xh8cdB14ra+zGl3gesxSb4rnkeaXM4oE23XQ6+32QpjNM?= =?us-ascii?Q?qOvaTCr8zcMUPfGwP9GbY8FpqobMGglOkaph1Da7Pu8NO1q49TfJcS++V3jV?= =?us-ascii?Q?Rb9ZJuctuGP5TLVBXpk4KD/B3TZeFmD3aUlCHiGV+nP3mSVJ9nMoouH2xWNm?= =?us-ascii?Q?etCFRv4yuRzjqfMQJATBDpsXcUHdYlhike1ht/xdnwsVcrigBMUdsolStiYP?= =?us-ascii?Q?99U6psvrI5paD7UMzHWUU0wv9K/V3goxC/96FadZK1mndtIR+bQ6Ak2tKJmi?= =?us-ascii?Q?XeAkeHKPfkQdCpkeQFr4nnyd5m6O0YaKfHIGjRSdqVYyq3gXsILPFnO6BqSL?= =?us-ascii?Q?Q45c9fWZMTQ5fIfGl37hjW4Qfi/hhF270O8QnRrbY1sq1YVgDOj/Qqf67GNU?= =?us-ascii?Q?/zTIgjQ+lssvk04KSmaDvSREJpqTwTQ17ouSjbiPlppLciHUPRhY16YjM1m9?= =?us-ascii?Q?jTpJZ1+SRPIBzYPqjwUnX72C6SSJrCISWKFiaiCsc+aTLEs1uSvobezvMIjZ?= =?us-ascii?Q?YZoGSE39V5DahRPotbmFi74kXrPK8TtDY+PFLhcHDp/31MqaQA5nj/Sz++6M?= =?us-ascii?Q?U+sIcjDL6ViQC4eUKZe9FUlU0gCsmSC+AMSInjRtXHmLSRrC7F+QE+0bDV6l?= =?us-ascii?Q?yG0k+dpg6ip1fhkz1BHBODaTn3ZRjl8pxbH0r3rEkYnLRvEVg+Vc+OZt7FYr?= =?us-ascii?Q?n+oe2gHlbpHd2+e5X4BJQW34R8tFVBEF1QhZV7Lysh4WnZ06yAAIsOPtLcrr?= =?us-ascii?Q?TQwZfur/8ApuezxZ5Kny+rSP47WknqdyVMcG/r68RLM5ZjTUwgMXZEdFy5JT?= =?us-ascii?Q?rL85mOd6U1yFyG8tAjjoBodUlEcFyJkwSTGVhYisUvRovSi7fwCiwWEQClUf?= =?us-ascii?Q?xCmtpcj/iIl84afV8tS7F/B3WLKa9xV2qfmjMYbtOrvKrbB55wIJQI0/vRye?= =?us-ascii?Q?beDe1fWxpg7NNKb/vxOSyqrsi6etFmGg8+MCDEoBxB4vxTkYvw59lOptp1ki?= =?us-ascii?Q?d8KfccUtcSgqyX0tXH/stg7L7J6j5ecBllnJXY+89YsYFtMfPBbgb7cyUAld?= =?us-ascii?Q?eWpGY+efsOvmx7xzaItuyUdP/dZRgnq6dQrGkAkEI9ikdf9H16rzC60cvp57?= =?us-ascii?Q?bjWWRLJ5VztGZQUBNqzJHnmzV1BY3YQpQmMefkAEF++caxQ4xgMXx9dQyBgJ?= =?us-ascii?Q?knNJ9nL49EOpXdCIL5dz6a5GLbz4kVAjAHLwfT52ZWYqMoMO7WZbf35YRBJo?= =?us-ascii?Q?QNgHQg6VOyiVD8XABp5ceog6k3B4znEZVJ/p301S?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48de269d-910e-431b-4deb-08db7e877255 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2023 01:14:00.6926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vKE31uKzDgXaWp5W2QpCxD/dDVj4Sgfq99aHq0kae23SYhvF1sh6UCB+GMUtzDoOtz+C+WOa6fJVae01DivYUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6012 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as f4fbaf6022603957fefa77c9ceb77f4b2851b0dc -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Wednesday, July 5, 2023 7:55 PM To: devel@edk2.groups.io; mikuback@linux.microsoft.com Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fi= x build errors in SmmVariableWriteLib Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Wednesday, July 5, 2023 6:40 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix bu= ild errors in SmmVariableWriteLib From: Michael Kubacki Commit `b71f2bd` introduced a couple build errors in VariableWritelib. This= change adds the SMM Services Table (`gSmst`) and MM Services Table (`gMmst= `) calls needed to register the protocol notify in the Traditional and Stan= dalone MM services constructors. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVari= ableWriteLibConstructor.c | 6 +++++- Platform/Intel/MinPlatformPkg/Librar= y/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Stan= daloneMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Libra= ry/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c index 8c2b7d18f5f8..447d358a3104 100644 --- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneM= mVariableWriteLibConstructor.c +++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Standalo +++ neMmVariableWriteLibConstructor.c @@ -74,7 +74,11 @@ StandaloneMmVariableWriteLibConstructor ( // // Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServices= ProtocolGuid. // - Status =3D SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocol= Guid, VarLibExitBootServicesCallback, &Registration); + Status =3D gMmst->MmRegisterProtocolNotify ( + &gEdkiiSmmExitBootServicesProtocolGuid, + VarLibExitBootServicesCallback, + &Registration + ); ASSERT_EFI_ERROR (Status); =20 return Status; diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Trad= itionalMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Libr= ary/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c index abc1e25cde6c..413930d465eb 100644 --- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Traditional= MmVariableWriteLibConstructor.c +++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Traditio +++ nalMmVariableWriteLibConstructor.c @@ -74,7 +74,11 @@ TraditionalMmVariableWriteLibConstructor ( // // Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServices= ProtocolGuid. // - Status =3D SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocol= Guid, VarLibExitBootServicesCallback, &Registration); + Status =3D gSmst->SmmRegisterProtocolNotify ( + &gEdkiiSmmExitBootServicesProtocolGuid, + VarLibExitBootServicesCallback, + &Registration + ); ASSERT_EFI_ERROR (Status); =20 return Status; -- 2.41.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106669): https://edk2.groups.io/g/devel/message/106669 Mute This Topic: https://groups.io/mt/99977994/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] = -=3D-=3D-=3D-=3D-=3D-=3D