From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.15315.1665538433008926173 for ; Tue, 11 Oct 2022 18:33:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FhUeFVnZ; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665538433; x=1697074433; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mtm4Bv3jt7RfcwUUo9DLudGRmeC6SE1XDlwMjuk43FY=; b=FhUeFVnZLXpgitOLj2Usxbp4Wwy+cTd0QN0e7csN1TRS9mcnFky0Yfly oRgkzhFDFbNbE+BkBVWaTnOZXY+PE6etRqMkTOr9d5NwSfV0n79kCR49L WSL1twzTnlHSI5K62DRcTBy5qMFMOCWKFXTO+teSZxDRz25A6gWuv32wX e2mFOXyhaUjX2s82uekVwyl3fx9EXq3ybANj9V+6NkD/rx3T8gtMQUoQn fC9QTpIoI2loD4PJePYt9miudIc6lnNp1EQCeKWREvZUzN4SAmPdMZVFh MzpqQE9DOJnjsxgcnJk/TxpUgZ5PrAH8CWBJWe1MZ24i23Vj7vGqUZDGm w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="306295867" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="306295867" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 18:33:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="626583898" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="626583898" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 11 Oct 2022 18:33:52 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 18:33:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 18:33:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 18:33:51 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 18:33:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ScnJGqPQVEDph3YtC6gBtWd5QuQkXd4cVR/NM8ULCKzQVwElNuJnMWTocN+8uK8TQSIF9gh0R9kY/qmgI7qABd1oOnvjjZY+tCG4IPvln5Dr18WkvBXceExeVXDGw23pBTkRHATpiwy9AwI/p+ml6l4uLuqmuTV4wQIgpe0q96DLnQz3QhYgMrapu2JxAwjy3N4jhMujO/+w9vlIRNro30D4gFU0yyCMALwpkxLzIQ0RjBHvojBQ6fovnl4DFA0nkf1yHx7QLber6c9v1wWf5Oi8GllCuebwtLaeaL9iY1rd7K1j2cQ012WRpLieVv3YxmpJZJRvmrafBar0uf9IbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ve/LYSiEb22b26DVKAWcPCX4hXEixY26mEAHC6SrXYA=; b=ZwR+hsJuzJQkJoI6RjXKvejgNNU8Pch4sOICbQ8F45/9+jkGNEOoKeqdQ9UKH0aZOn6fNxmPG5iih3SVSdXPKCNjJMlOUO0znIoJasyK55hGgJ+um8BZbBkYD/9uSpvYP02zqFpcNHQiuT/xwAk2CHhbLMYAmZ9zZxE1Ze92Q1bn6srPAvDJgkBz/SMMXHHNSRamCWBBgIAn4BfvygKKdt9KyEUe2ZD16BVOQ7DHV7+55/OwN5KSI1zR98kkoNWVlfe8tUKmofldZgRon4q2WEMD2kSjBA3SdDPz8SCwFG7+ZsK15wW1cceRhbP/Rrv3jIG/XmMzRGaSMsJ8ZKzz0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by MN2PR11MB4552.namprd11.prod.outlook.com (2603:10b6:208:263::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 01:33:49 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940%3]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 01:33:49 +0000 From: "Isaac Oram" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Chiu, Chasel" , "Dong, Eric" , Benjamin Doron Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Thread-Index: AQHYyGl/OBJZnOd+ZkamT5cbpnE0164KBMkAgAAfe0A= Date: Wed, 12 Oct 2022 01:33:48 +0000 Message-ID: References: <20220914184027.1510-1-isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|MN2PR11MB4552:EE_ x-ms-office365-filtering-correlation-id: c7e327a0-d9f5-48a1-02bc-08daabf1cfe7 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g3qd8M61cnrRmBFaqyN5Q95aamT/1yW+WrI9QCq6m4jiDh3GPVK/OyqDh5qhrTOPkg/pI6mYYm8KtYPAVBx3JAlbrXtkGv9eU4HSF4ZCk0JEKS5Bm97oKzCBVR14Ss+gH6zPDjOwiDILS9MFAIoP333qlya1YIFrgRnYtTCUWicTuYKiko2IGZJf2m+H2sv7MJJ+U1JaJLu1hfexGWB3/XY9bxf4UerKGM+mSEWnZgfCcGHRDUQyvloUG1pdW74cAUT9X6KLGUJzJsim4sWk/kLp9wBP7ZLgsYlYafq7KWfx07rzREUmK5sJvAs0Qg+4xFHEVHmKo220K1RDmAJUUCjVjb91eprz2tyoqnEU7XXsuK+tWCIrIwoRDWaNN8D8NtI/bU/aJFAD4AVcUXpORkFaqfvvv0QhwGGulqGD0k38F1v1Ype2+UAKIPYJJdFZFqyWRHpXcdxVTwOjKA/o6rPkXv6qrhNjH28a5t1Uurh2f0gB2ORiHjUljoQ6wZ5EoIwmFQiHY7YpRO0nWmWuYJiPEkJBy1488q5ziWqozWE1j1AIJb7BujjfJAtUx3JJ/dkA1dMo9/Yo9fGUDoBtuvWscYhO1ffeOr+V2sUyD3PewiKTFN31ajj7snTNlMGAEBpK3WJiBYgCsFNuuSDS+4UD/Nc9yUHCEXoW2uEUOBTG8wxf2JR5wCJQh+lzzLGLKpvTN8ABqSr5m4shGBkheZFwulUGnrNgsbqF5wduurmGkBy8TuQQ7VF5Qp7egZrwvTeK1CHoYY+RwJPoz/nilQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(376002)(136003)(39860400002)(396003)(451199015)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(41300700001)(2906002)(5660300002)(8936002)(52536014)(6506007)(7696005)(38070700005)(53546011)(26005)(9686003)(86362001)(186003)(122000001)(71200400001)(19627235002)(82960400001)(83380400001)(316002)(55016003)(478600001)(33656002)(110136005)(54906003)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HbbDUulidjms4YrpDGQjmGFVNqRZ6fiAErzJDmieovTmAXxA75FlOpVRn1Df?= =?us-ascii?Q?GR+RN+JhGhP1zVs6+ApleoOMIS1Oa2fRle4rcyKt0YthtaT45M0FTQvzYI+v?= =?us-ascii?Q?5vc1e7j9bYdwhKSwI/3gEhdDWcf2RHaU5YTDeUe0IBWWhuNBmZbTE/kbWzRv?= =?us-ascii?Q?84oic0BcWT/TuHj81u3cJ0JZ5eW6TC2B4V1/4u93+TV0/jNZcepP6QVhjVbM?= =?us-ascii?Q?oVmgcsXsZui0TXY8hMTxiCpV2oaSihibBr8+BGC17w9iHd3eWaw8uPenV+1D?= =?us-ascii?Q?mHjcgbl1i321GenB0rPzi111L0o9xR8oEf2zwn6paBMDF2wV35JvozxL4vnB?= =?us-ascii?Q?ZtGgESxa/PKYAXGBwR/onLPC0oAMuDYuwwI8OyxuU11Uz5bFTq2ZWJqnQZ2c?= =?us-ascii?Q?yOrWdh5FWRxfXMg8VV2ys1UMm2k4mDZTZApN/Heis5mKr1g+Ltkdao7pPmNy?= =?us-ascii?Q?BuZbQw3+BoqlS9WusyjGGgBAapNdRbYKhpF53kF60zjhtqizKOrspT77h0gt?= =?us-ascii?Q?4P1DFdUyTJq3VfYu4CxSKtKJ8XpXwW//j8DPiVCM9P/9bG5g3q/UY5ik2EGY?= =?us-ascii?Q?XcA2nvq8Kxwrw9IDpl2/h6d5RvY8Os7L9xdxLZJ8dUJVVzdLQ14rZfC3pEdx?= =?us-ascii?Q?qWYt/4SE646RKQpK0rxfjbw7f1rcbl6HmSWVOxAUMJQofbFCSbL1GrP2nQbb?= =?us-ascii?Q?V+Lxk0rekUy+NntVYh/QjgHKuq6hKx+GtuQW+UxxT2xWJAbu4+VOwq6w8O8g?= =?us-ascii?Q?OgSwa19Rc1HvE3ZDz5AIgIcmxiYNBSgNjQ5OYL2vLhcWV2UpPHW14XquI6VX?= =?us-ascii?Q?aI0NqRuAppTAX8DFJ2ki8wX9GfniMzN4O8KVvs8Dy/+8LMQp0w2siEkUpnVj?= =?us-ascii?Q?BqP/fDIrKEHSw3g2kAIrgG9kCIi6tUzVECii1hVeJg9GMDkaN19QBfvkek1h?= =?us-ascii?Q?pPFuaaPAbp0kmEZNAgt21R3gHpFzGC4O24bZ8459ETRI/n7l/oyqdxTHiLkj?= =?us-ascii?Q?54EoSPpMfhlLp5KEQs8q91oM+jfS+qrhBpz4GqK/Kvs9Rac2kfY8nGxUlylm?= =?us-ascii?Q?eYb0yCLTn1QAc6NeVn7VPtH3+rbyUjJkrHkd5vhbaEu1VZE3CBbd23UiWDwg?= =?us-ascii?Q?Nqn8AxI8o8eumxaiF7Gux0+kXsmDaJ/N79ZsXS5SSTxwCWQxxnTRZ0259eyO?= =?us-ascii?Q?Dh2L4dxCktHLmUbdY5RTg0As4j/wv+4JYJA7VqHRPnnP1ypGjU+uZkdlssWE?= =?us-ascii?Q?qdeDbaMFDRSLBO4ADa1/VcUHrNQr/yTkRYDQ88Sogb5yU2dWhzswyhy0CTs8?= =?us-ascii?Q?C4Oi8M+9X/Cb9XFaiKkU/9GHW1uyxuYez9QfjAuCYMr5a9f296aYnoOOquMi?= =?us-ascii?Q?+SetBZ2viMscx0MfcFXNsb1OkdPcfIOGQuyyfOiAwah9b2ax24h1DiGZJXGX?= =?us-ascii?Q?+xI9V1RE+MEw5GYlxu+rCUHNq7j/2X1ht26XKs5erZ0MLrsuxS/XVU3rz4vg?= =?us-ascii?Q?4GrZfdv7x7BLSC27T2j7blh66wCNIasUE6loXnbkLjKnkzMJP1MAP4z+SSfe?= =?us-ascii?Q?V/tC2DesyqpOIGhuEtvXN7jPNlKHM4jortjibmn+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7e327a0-d9f5-48a1-02bc-08daabf1cfe7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 01:33:48.9525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0vbZF6VIds7+mUpsas9Eq1AdELR9NsEwd5FOM3aHCGxn77KdSDj/YuFHIhi1gKDsaeuPSwYiWYImHQCVHAEIvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4552 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 07d0c989089f94133e7b71e38c18d206134863e7 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Tuesday, October 11, 2022 4:40 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming ; Chiu, Chasel ; Dong, Eric ; Benjamin Doron Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Bu= ild fixes For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Wednesday, September 14, 2022 11:40 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Chiu, Chasel ; Dong, Eric ; Benjamin Doron Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build = fixes The S3FeaturePkg changes in [edk2-platforms][PATCH v3 2/4] S3FeaturePkg: Implement working S3 resume Introduces some build issues with standalone package build for S3FeaturePkg= and AdvancedFeaturePkg. There are also some type cast related compiler wa= rnings. We do not currently have continuous integration testing. We do not currently have documented build testing configuration requirement= s. Therefore I am just fixing the minor issues and intend to merge both patch = series together to maintain git bisect to the best of my ability. I do plan to document required and recommended board port and feature pkg b= uilds. Note that the use of UINTN for intermediate data instead of EFI_PHYSICAL_AD= DRESS is only to be consistent with other ACPI implementations of similar f= unctionality. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Chasel Chiu Cc: Eric Dong Cc: Benjamin Doron Signed-off-by: Isaac Oram Isaac Oram (2): S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c | 10 +++++----- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c | 2 +- .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h | 4 ++-- 5 files changed, 14 insertions(+), 8 deletions(-) -- 2.36.1.windows.1