From: "Isaac Oram" <isaac.w.oram@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chiu, Chasel" <chasel.chiu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro and unused include files
Date: Tue, 16 May 2023 19:42:37 +0000 [thread overview]
Message-ID: <SA1PR11MB58012B1B8F0BBB01368F448CD0799@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230515135921.3299706-1-rebecca@bsdio.com>
Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: Monday, May 15, 2023 6:59 AM
To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro and unused include files
Delete the ALIGN16 macro definitions in
Platform/Intel/{WhiskeylakeOpenBoardPkg,CometlakeOpenBoardPkg} since they were causing a build breakage since March, and aren't used anymore.
Delete include files in WhiskeylakeOpenBoardPkg which appear to be unused.
Changes from v1 to v2
=====================
Instead of fixing the ALIGN16 macro, just delete it.
In addition to the one in WhiskeylakeOpenBoardPkg, also delete the definition in CometlakeOpenBoardPkg.
Rebecca Cran (2):
Platform/Intel: Delete ALIGN16 macro
Platform/Intel/WhiskeylakeOpenBoardPkg: Delete unused include files
Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/PlatformBoardConfig.h | 3 -
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h | 131 --------------------
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h | 38 ------
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h | 103 ---------------
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h | 42 -------
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/PlatformBoardConfig.h | 3 -
6 files changed, 320 deletions(-)
delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h
delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h
delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h
delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h
--
2.39.2
next prev parent reply other threads:[~2023-05-16 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 13:59 [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro and unused include files Rebecca Cran
2023-05-15 13:59 ` [PATCH edk2-platforms v2 1/2] Platform/Intel: Delete ALIGN16 macro Rebecca Cran
2023-05-15 13:59 ` [PATCH edk2-platforms v2 2/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Delete unused include files Rebecca Cran
2023-05-16 19:42 ` Isaac Oram [this message]
[not found] ` <175FB728D423FEDD.26562@groups.io>
2023-05-16 19:45 ` [edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro and " Isaac Oram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB58012B1B8F0BBB01368F448CD0799@SA1PR11MB5801.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox