Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

["Isaac Oram" <isaac.w.oram@intel.com>]

Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. f5da8af6befbfc655fd3e4cb899eda158dd9ede5

My apologies, I was sloppy and didn't ensure the edk2 changes were pushed first, so IpmiFeaturePkg build is currently broken pending https://edk2.groups.io/g/devel/message/97789being being pushed.

Regards,
Isaac


-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Thursday, January 5, 2023 9:05 AM
To: abner.chang@amd.com; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: abner.chang@amd.com <abner.chang@amd.com> 
Sent: Thursday, January 5, 2023 8:01 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish

From: Abner Chang <abner.chang@amd.com>

In V2: Addressed the comments from Isaac.

BZ# 4214
This patch adds IPMI functions for building up SMBIOS 42 record for the USB NIC host interface exposed by BMC.
The corresponding updates on edk2 is in the separate pacth.

This is the part I of upstream, the follow up patche sets are:
- RedfishPlatformCredentialLib contributed by NVidia.
- Relocate IpmiCommandLib.h from edk2-platforms
  to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
  and located under MdePkg. With above, RedfishPkg doesn't have the
  dependence with edk2-platforms. The implementation of IpmiCommandLib
  stays in edk2-platforms without relocation, which can be pulled in
  to platform DSC as needed.
- PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
  temporarily because some requirements are necessray to be spec out
  in the Redfish section in UEFI spec.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>

Abner Chang (3):
  Features/IpmiFeaturePkg: Add IPMI functions
  IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
  IpmiFeaturePkg: Add reference of IpmiBaseLib

 .../IpmiFeaturePkg/IpmiFeaturePkg.dec         |  5 ++
 .../Include/Library/IpmiCommandLib.h          | 62 +++++++++++++
 .../IpmiCommandLib/IpmiCommandLibNetFnApp.c   | 88 +++++++++++++++++++
 .../IpmiCommandLibNetFnTransport.c            | 43 +++++++++
 4 files changed, 198 insertions(+)

--
2.37.1.windows.1