From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.531.1672940500791800151 for ; Thu, 05 Jan 2023 09:41:40 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZIFQnCzr; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672940500; x=1704476500; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UYjo2Q6++Y2lmvNB+egRlofmJbfuka0YknspyD486n8=; b=ZIFQnCzrO4wMpF66DEF8LiLwKRGIxCv/lvvA92v6HFWfLSb9bxciEXuU ojiUoG2wZWGRttRYjoeX750teLWQ4E+DcvI7HyrLlYM3J0VzcV8Hd77PL gQtWePMz1/89+TprDX1usq7I2XW3j9DU6X7rE24Os7h1jCivbkj6WVZMN qsneIOjbGkNW862xRS/hCIFoPNyVHSTdio5jdB/S2QoC9xiIe+S4ewvk6 AJXOs+jje1Ozpi/FG9Y1EroiHZMJHaMQbtouRvL5qNr70ilUzc7yi9Sf/ ugte5xUNOzkJaUQVTGisEXsONyo63juMku+mlJIFxLclhlvPgYJSb7Dk5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="322336461" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="322336461" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 09:41:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="657596969" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="657596969" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 05 Jan 2023 09:41:40 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 09:41:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 09:41:39 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 5 Jan 2023 09:41:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4p40PdGIws0IdSijMQrUG7kCoP7Xb6+muC+DSJPYvG1zl2xGGAVoY8uYSPdtrYbnjpCGudlx1lZkM9XyokIMQP5OSX+yzEzCzImxxP7J+ytfV6H7XzikJqm2kcPHiR5bAX8cZm6FJZEVM1FO9si1Hx3HHCUKMRLpWFBvToMlxX8P7d5MfQCM7JL2Haz5zMr7/vrtLyH+2lIDJ49a1jsjYNYLelpm+up5KkezoC7B01K6F7iQ3EZ441mpbitK4cCSnpHMfbo0TLa+fbayC1i4EfLfDFtvbt2/ywINMc4/YQuUdoFxSNGGKJ7ges9ELgupqJp14x7DNfUGtR1+REkFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DiQ5bWc1AqEfso5eK/51DGyfBcSbSr3kF8nKy4+83x8=; b=XFtmHgb1RGmmX0Yq7ZlPgrdI4FmmY0lGvvTxoah6aQemShorCq58ugk2CBU1LafVqv+lzEpdb8TeLp2pEC+E1BOYMUGqEOAiN/UljSGK/Pewu/mh69mAKlxhuittBUZPkpbdf1BI0F6CW6JVO8rT5JmQzGsLIBok1QpcgGWu0JcgQ4MWbNY3eEFVBlLvjmgI+o4CDD3jkbKYOsIZEEFCO+5q3OTW89rqj1Yizd3dHveKSPR6V5OsLAOeFWl22hYY3Fjz13r0PDE0wNLMRuMoSMSuv2d3SE0okCGefZvnxN3RBUZtfTRrTW5rtjEf37MDOuHD/EfsAy5C6nJiGI7Tqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by MW4PR11MB6864.namprd11.prod.outlook.com (2603:10b6:303:21b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 17:41:36 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 17:41:36 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "abner.chang@amd.com" CC: "Desimone, Nathaniel L" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Index: AQHZIR8LWofAPDAH8EaQaIRDPPizoK6QC/DAgAAJh+A= Date: Thu, 5 Jan 2023 17:41:36 +0000 Message-ID: References: <20230105160100.772-1-abner.chang@amd.com> <17377895696F6651.2132@groups.io> In-Reply-To: <17377895696F6651.2132@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|MW4PR11MB6864:EE_ x-ms-office365-filtering-correlation-id: 4aacdfd2-83de-4232-1db8-08daef4417ef x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VAMYM7KYrIGRMlcsD2xIQzHfWK99eyJgQ/ihGagyGVUMmLzSjMLDyYbPEjOccKCPKodhIUeQpkhgCIv5m4zy9e4b+Wuh6QkyWzjiO59Dc2Kz8klZM/x5UyjdXjUGlu15RueSjuBipJDHfmEiDAn64ESz4RhyV/TWD/XRJouuqPmecFRGhg1yaS2v8iRyQTnWpzPRy3FJh5PDRqRsdelZPagrqrCNf3BTERLoooRy8aziI6FHIDr5EuHVk1N+jj72FlWAkAACue2HQ1Wpf8ftrC1cU5pUHJLKI/sS3sCvwbtXXLi3FBEe78240TCq/1unkyyHC9WOjngN7CFMZ5a87y+cKdRApTTxGEvFEt5RJIyKb8v3vp9iwBSpXMvdEc1NBk+spTUsDx18FCCWcAW6iig4RoLwCRWar859PZ1nkFBMWLaY3kIIxZolkuzorVetE1bD5QqVjjgL0TMJsLkK+APeuiRuZr8QithI03ZOtopmU10KKhyP4Kx2V8Tuxm3sSxhHewQpdjyF1WwE+8F8L0Sjyl3C8DxbE+u3GxXz0RVLcLtBFHBSzhS8gIakggR4Kg9UWQKZiXtXaWI7ucLcI2hg5H0Ob9mAGDsOAZcvc+5lUCRb7bZdG0z8CvvYidPJv+41O2yRrishnJwotCSvVE3hY99G0eZ3oQUiHU+x3EV30AhfGPFeP4FOy+lXBAGQr+yUakgTu9HIDPK8zK7R5ldkMWJUvGbpi6AHEHgn+T3xsqybAcpAW6GSDnPfV4O1dluNl8JqCX2QlZG2DqswNQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199015)(38100700002)(7696005)(33656002)(122000001)(55016003)(86362001)(478600001)(38070700005)(64756008)(66446008)(316002)(6506007)(52536014)(5660300002)(966005)(54906003)(53546011)(2906002)(110136005)(71200400001)(8936002)(66476007)(41300700001)(76116006)(4326008)(82960400001)(66946007)(8676002)(26005)(186003)(83380400001)(9686003)(66556008)(66899015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0xIOArgr9GI5tqqJPNu9uNeg/Pwflfp93gsD64BrbFhHy9UFijMpV0INwiSQ?= =?us-ascii?Q?zdkd6SY0F0pBkG2q8Jj8jpjsjNt6zLLYZm4k/R32Yor5TH3jo1IQbWO3N6/E?= =?us-ascii?Q?Pp7/BdbHIUeDV8FPwNYRs8mVcZpee7zDox2JFY68NWuKvR3kQ9dhPYmnJh6c?= =?us-ascii?Q?BsD9hIlehj2VLPRIV23TNgBWEAvQQhDP6hxUZeeDWVjrrPc4wLspAg9Wk2XP?= =?us-ascii?Q?6BdAx7uGygMOUGUn4/Laa4ROdxVxOD5qcCKjEILgLQZUZW1ZIp9kbk1KohcK?= =?us-ascii?Q?ZbWVqzUambjawqT8COTHoxahyPbwxVIV5DiDZz20IpH6Zw60LKF2eAiA+U5C?= =?us-ascii?Q?VJi0V89BsgseXiFcbV8Rm5Wtm49kBM7GOE561BW0QBfMFSlbTfeM40eWLlvv?= =?us-ascii?Q?VYJ3bwMHcEAAkAdDeYa6sFRrC3RcKxRvQ6Bokj8+vxg9m5ZaOtuYl7Dt69lu?= =?us-ascii?Q?kXqhqKumN8nMmB5ACoMWWaR2KZUpjFyXL2X3nGMxv6pr9oMWlmBJCPLT0bqz?= =?us-ascii?Q?lHi2w+MZYmkFaXOJuoVKIPL4NnsxFDyt+OtpxErVFQr/VErpI0jLJnfaljnf?= =?us-ascii?Q?bOPiiM19yg9FW80r4pPsMcQcy5CdFB3rJL7cj46M2eXCUYtDdeqsvmQR0+is?= =?us-ascii?Q?WLeyJFwe+oKCwUglbrKT6pWdz8p7VVVMu3YyJQDfeRmi9hPLWTa4unicv5SE?= =?us-ascii?Q?OeGspo9QiUI5ekzd0XTzwBkE2RDn19qa6RHTCqosbKfQq5ZNx/j84ASg6dMq?= =?us-ascii?Q?vmQhefjb4PzH5wOQDcytvXo/nVI08Dd2F9irRNib11+RoQ0qflxSAlHh7VOO?= =?us-ascii?Q?kE8Wi/d2y4TA+H6W5SY+UMtDogBRkzK/LtzUcEBRx6iaBosIT6Be7AQP2rjE?= =?us-ascii?Q?TvmULXX5+f2M5hN6rLGUB0v58SupH75OCbXObZE+Sh38O1/10r3nLQgSuZdp?= =?us-ascii?Q?Y309pSMF3AbBCq3LUEmZp9KHLqMUC35efl8+p76DFRPdNPrRrUBcL2tvMNly?= =?us-ascii?Q?KKTGUb9FB8aBWR6jDR74bO+XC9s80Z8MLHN19mwjwEBxfzftU0ssEggmva5b?= =?us-ascii?Q?2sCvuanFYjaiRpXzkmWxewqfI4Ukb8DYMT3vzMM2xXAYWxetu56UWs3g+Xhp?= =?us-ascii?Q?f9nJEDCK5vMGNeniMsPSpKSrBU2LG5XItLiSYgBO1WIA/5fy0qdZr2LCyNaW?= =?us-ascii?Q?lUP+dbMKZPCn3HC3CgKUg+92qJvuH8l338RikkL7p8pM1e03TUMfVKCCyaap?= =?us-ascii?Q?O49chbJK0+REM2/9pEKSG/MZHr8Ff03G8eyHV7T8E2YUx6UFHw2A40RJozqv?= =?us-ascii?Q?re7hOI8isWP6PzVRsQzSdArmtTV9D4SfsBBUcJLSt1Nn9/wPjMEHHL4v49ga?= =?us-ascii?Q?pcsVjxXfrUaumAoUG6wfYbEz2hZEy+W69rk9YtmoI/Lf/cJc7bTMi1fE0Wnw?= =?us-ascii?Q?GIKsyLwVcE4xeXyFrciefsKDq6bay+sNtR/wgDbPadzHnswbCLQP0U/63JNj?= =?us-ascii?Q?ie3wq1M5Oeav0ukj3KIgoO2UvK4pju6XV4NH02eB1zQmox+zP3xME66BXaGw?= =?us-ascii?Q?VUgYLWNnKRNNyhzsFqGNckETIbTqr3llXEtWd3Nh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aacdfd2-83de-4232-1db8-08daef4417ef X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 17:41:36.4239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DL61GHUKlOizv1oWMl+wq7NSuNIPZCsAPfCKJO/Iym2Jh7ERh+PA0Lb+cm43iJSFf53frxe6BqHAANr45WCpzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6864 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. f5da8af6befbfc= 655fd3e4cb899eda158dd9ede5 My apologies, I was sloppy and didn't ensure the edk2 changes were pushed f= irst, so IpmiFeaturePkg build is currently broken pending https://edk2.grou= ps.io/g/devel/message/97789being being pushed. Regards, Isaac -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Thursday, January 5, 2023 9:05 AM To: abner.chang@amd.com; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Kinney, Michael= D ; Gao, Liming ; Li= u, Zhiguang ; Nickle Wang ; Igo= r Kulchytskyy Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfi= sh Series Reviewed-by: Isaac Oram -----Original Message----- From: abner.chang@amd.com =20 Sent: Thursday, January 5, 2023 8:01 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Kinney, Michael D ; Ga= o, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish From: Abner Chang In V2: Addressed the comments from Isaac. BZ# 4214 This patch adds IPMI functions for building up SMBIOS 42 record for the USB= NIC host interface exposed by BMC. The corresponding updates on edk2 is in the separate pacth. This is the part I of upstream, the follow up patche sets are: - RedfishPlatformCredentialLib contributed by NVidia. - Relocate IpmiCommandLib.h from edk2-platforms to edk2/MdePkg. A NULL instance of IpmiCommandLib is created and located under MdePkg. With above, RedfishPkg doesn't have the dependence with edk2-platforms. The implementation of IpmiCommandLib stays in edk2-platforms without relocation, which can be pulled in to platform DSC as needed. - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging temporarily because some requirements are necessray to be spec out in the Redfish section in UEFI spec. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Nate DeSimone Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchytskyy Abner Chang (3): Features/IpmiFeaturePkg: Add IPMI functions IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions IpmiFeaturePkg: Add reference of IpmiBaseLib .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++ .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++ .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +++++++++++++++++++ .../IpmiCommandLibNetFnTransport.c | 43 +++++++++ 4 files changed, 198 insertions(+) -- 2.37.1.windows.1