From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.12670.1684466873789367322 for ; Thu, 18 May 2023 20:27:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KpX/V2lz; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684466872; x=1716002872; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dvTtZvtUdN5T4zRZTU2h3KBsW3lbg/GvxOfBHU36Pew=; b=KpX/V2lzqyxmk/uw+w+0V+3IRKm/A3ove7OekMKDL+NNCdnl7KUvTNXs y9amoFht2We0aKCupL2M1bBbJYj1IavvJCxJMAtJ4ldiSmfqdkARwVxYk ivAwGUsuT7kgxsnL1c5+78UK+uEsFpCYmSBIDn7wfse+Nw7XrTsf9OEZA ppWzbMwrhFU2DRnGs8HRDK1Xd2zhKlNGK4tIpv98yglxEyZ+YJkq1Rjq7 7L/CRUPFpNCrR3gN/T1ePg0Rzn5LDyvY8vbgHRs2MX21zW84y5FoRp0/8 4+OfX/vyLB/nT48jNuOyIv8l20CdVuZcN9hHuhA0mytl7DiPpFjltgMVY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="417958904" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="417958904" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 20:27:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="705432844" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="705432844" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 18 May 2023 20:27:53 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 20:27:52 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 20:27:52 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 18 May 2023 20:27:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xjn9XSEzKiQMZ3Thvyl2QOJsDmQvXULwob4QhP2R+LWlR8vIuQYdTYuV/kgIUsoBKpDhPOOoW9lqJcdmoRZ3HqYxmkieEn0VT4RIKqLd/BilSI5tcwr0lmmtwmWz+J9c8xnvLan5GhJpohfnPGoH3ShgjX4TMWafO0HtOpfHdMff7AdDp0ubX/IipF8RSJDbbXzzBrAziqvPb6X5SPFl7zEDMS/ddtYbTUzRC0zkrlz/xJ3ceIXqq1husoSO1ybQ73yXW1tkL640bOay2lgi1DgAwsRUm0xnrM3sZIkKbL+ZCWQCTcoQKdNMtm/NN2QbKwGyiU3QFHrW/s9r17rytw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BJ8oMvRfCZFhn/jl7E8vwH8L4wPWt3hNQd2RzlfblQk=; b=U3f6xhsfrvazc4ql88rOT/faSq3iTDC4iRsKgQyxJ+l6ymnMCAl5xC37XnfXHi06k7zBilWltQyB6sZCg5IgMfh6reWvxRyBVUsXjHxtpszS0DTrw/remGJPo38OgY/1KVobZmMkB4ymLHVg3DMIqdo8oYW4ety61V2hk83elyDZDHZZWeKOTMoITWBd7p9QS85JXDgD3AmBI/aLk9u+yycjyvLBGLm/Ht8UEWzMCRyaA4J3UlzSLXtgAGxJ3qXfqCnmiKXNo5mW2nyEx0r5S0O9cg8qTvEuXDS82GQh4VWta1ZnoG9ylJsLb/IJwgrz8UGi1ZbMHbgs6kf/l1nMog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by CYYPR11MB8306.namprd11.prod.outlook.com (2603:10b6:930:c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Fri, 19 May 2023 03:27:51 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6387.030; Fri, 19 May 2023 03:27:51 +0000 From: "Isaac Oram" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Abdul Lateef Attar , Nickle Wang Subject: Re: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiBmcAcpi: Add to ManageabilityPkg Thread-Topic: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiBmcAcpi: Add to ManageabilityPkg Thread-Index: AQHZhbKPmiuOwvfTP0OJgE0HIcLvVq9g+F9w Date: Fri, 19 May 2023 03:27:51 +0000 Message-ID: References: <20230513154919.1873-1-abner.chang@amd.com> <20230513154919.1873-2-abner.chang@amd.com> In-Reply-To: <20230513154919.1873-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|CYYPR11MB8306:EE_ x-ms-office365-filtering-correlation-id: 4dc80190-1111-409c-dc8a-08db58190699 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M/oN3G/u8mQirMtyUIszKwjc+p3TPkvAXAutpF3Zc00aWSCOwdB8nCScac8epGhOxRjWVn7LBbN1b8ekIikT4v4KOzAcAasr8sE7q3RtbFlm8et0nGonevAPH4qO9UQ4QRSfyVH6TaybXu0KhGhfm0lRmlDDQVNikVtRuH6o/EloUyFxwXllnz8LhoGo5uLNEvwMPMDweZFsFZJPnf14h6x80w7917rvKD3dNEM2+8NLRgEfgi+crQKzJpikzmtHgGXHcdqE7GrzfwhtdN3ayEHyhYE930fvpydRWTmHrPyQeJ/XjD6bI6Ra3LKUaScuRd+kw7g3JCpgQFvzia0CZiSz1TcxWfbzK2vOPn6IgkJD4r8msJxmZrylbvbr4rnjBReuqKwaLjj65VImUtLl6T0JqAhQBB/NXgwo4G6SiE61SqdRuRwrJNU7xd/RlcxJXgglmBvanr/ZDJoJXXQK1q/KFD9IbjsdGZO+2Mr2RtAMV8dRdEmqXPVroZw6rsAlmJAa+nd3o9ibJ5M6kfbCErk9v7fLIpCFjGjcis9M6DfCCie6pxzhtum34+NYkILwYL+W2Pfuuh/Rk91q5yRLZs7on+Q9I5eYcWeD2Uj1oXtQRX7NQhl0+Bps07yazi1S x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199021)(8936002)(2906002)(316002)(478600001)(52536014)(41300700001)(8676002)(4326008)(54906003)(110136005)(71200400001)(66476007)(64756008)(76116006)(66946007)(66556008)(66446008)(5660300002)(7696005)(53546011)(6506007)(9686003)(26005)(122000001)(186003)(82960400001)(38100700002)(55016003)(83380400001)(38070700005)(86362001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6DeVhymELUAwpm3fXC2GZy6qX8z+b+e94WGvNCktN9TMsxqiay88q9V/8rBf?= =?us-ascii?Q?Iyhx1mNynTV8C4zqUfeTl/O2DhCEUhM2qecU9jhYm0mGoH1KfSWKfEGsuwak?= =?us-ascii?Q?BxN7iGFV72g8ajN/TCeXoptc0ukgRn+qFsIabMNcwMnkMhbzF/2B5LR+t9ep?= =?us-ascii?Q?P721fZpydigyW2lBCkmhpG/MvbHnLTQwxkrLicupgp1RK7apq0pVQCKCmotk?= =?us-ascii?Q?+ZGROiKX9aERULjgIkXxPvtjPfHw9KKgUqY8j9wgnURYR1mtMTwKtFaqHDX8?= =?us-ascii?Q?q5f5flFPd3RFQgyOhVN5z/jw5J3KEot0IkbiBpXxY17i3sdEooqMOv32z6KV?= =?us-ascii?Q?T3RUKxZZtVpR7UseDMBSwJgXOLMR5ePW3dwXKxB0qLtzJ26tIghbWHyy/Ith?= =?us-ascii?Q?9cta4lNpcWIu6FhmgEc1g2qqm8vlsxUJRzhKix6iqjKz/uBqwvasQpc6a18i?= =?us-ascii?Q?tyMw0IqXF6E3uCjKHeOIZlyj0ELU+5Nwi3yj5a/9oydadFKLf//y0UjG4FKF?= =?us-ascii?Q?cEHyoq+ETR6llT7P7YAqdnNfao/lQfIMTL67xba4uEcIrj5FlP9MKJtVF3Er?= =?us-ascii?Q?cpn4KKHnuiHdPoO/Tfkm+H8nsCuX9QgxQAs9jIQR5bWolw2okpppUIOPCY1u?= =?us-ascii?Q?AL5il+Fc6Jnnhabme8gomIBgbS/Cd5ZaPvc/exdBOnGlyPxjpRAa5st5Bvfm?= =?us-ascii?Q?EqZrFx5ReMG9MEx/y57d+0CAuM2l1Tl9AxJikoIM/mJqOpnaAwy6r/regx5L?= =?us-ascii?Q?L6cTbqiAn1MJyrvLS9Z2HWglpfxm8eJul/2Wqor7PBmdVbkOuwBGrjSWhzfV?= =?us-ascii?Q?0CefCc3Ei2Ov7UI4EpufOx7MwZaAmMQn7sOXdCDyik42sgjuDlGaKU8gzvuK?= =?us-ascii?Q?srStqr1ZBmyDKnpFZ9T1TU3VKVrghylyaeXPw0g7+zU4sIRdpQTRQ00dTW94?= =?us-ascii?Q?WBOdTQPaUat/bgWEiAkFD7t1wK/FzJSSmIp+mCxQKHxyzlFXOS9+59vanrV8?= =?us-ascii?Q?7S/XbTHMlAyl8x3JU7GiS786OVYAjE5DYuDlDyhMHzPN6RMTz/O5hsyR7dKE?= =?us-ascii?Q?3IfV9OkhcFzz56/F6oJB9p0ZfXQL8TRSycGdZmCGsblIgK1E745oMnMLMDJt?= =?us-ascii?Q?u9GWXj+5QcVWkWcKwdqUsaV6VpF2PPMSDdUkSqZxFEW/1yFQZh0tkcOZsdlP?= =?us-ascii?Q?/Em/5gZLIP5jyEJ6e2RvIvsbjEjpob77QOhQIz57s2zbyF7FyTvmNoA0HQGl?= =?us-ascii?Q?0k1lw89Wy7+/bxTC09T+dtPFp1qy5xqAt8EHYvEnBZHiudfuSO1jTcqxM5t3?= =?us-ascii?Q?Y6yXSVOl9R/4y8avZU+mvyyqK7/KsWavgI87OKH1cWbv2ARernpzEgJU36UY?= =?us-ascii?Q?HN0jW7XccisSritlv1rwKqFJah3oihx3vvyGsQiyeEEVwgH6o9vG8vUzgr3N?= =?us-ascii?Q?/YJBli8+/eluJvGm+QjeaALDtjd7ssXhMPnK5FLCLpPj2IT5Mu0H565MELG7?= =?us-ascii?Q?8x9vhB7Zl0him3FE61p2sLJi+9k9gpzhjluB0+boewMK4jat4I4Rv32bnYgK?= =?us-ascii?Q?MQbGSF1w23YCOUIzH9HYJBznbm5rSY6at06JiZDp?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dc80190-1111-409c-dc8a-08db58190699 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 03:27:51.0839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oy1eoEhQb78Na8xtQNlKWuAcCkm+Y9KIw0W8KAHB98ooAteuN6Bk2Vu8i7my4dHk+liMAQ+HC5+dJGKWFmsaCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8306 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: abner.chang@amd.com =20 Sent: Saturday, May 13, 2023 8:49 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Abdul Lateef Attar ; Nickle Wang Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiBmcAcpi: Add to M= anageabilityPkg From: Abner Chang Add IpmiBmcAcpi to ManageabilityPkg. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang --- Features/ManageabilityPkg/ManageabilityPkg.dec | 1 + Features/ManageabilityPkg/Include/Manageability.dsc | 4 ++++ Features/ManageabilityPkg/ManageabilityPkg.dsc | 3 ++- Features/ManageabilityPkg/Include/PostMemory.fdf | 4 ++++ 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec index 38813c5f48..ac3504cb41 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dec +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -79,4 +79,5 @@ gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BOOL= EAN|0x10000004 gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BOOL= EAN|0x10000005 gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna= ble|FALSE|BOOLEAN|0x10000006 + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcAcpi|FALSE|BOO= LEAN|0x1000000D =20 diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc b/Features= /ManageabilityPkg/Include/Manageability.dsc index a432b0ff26..1a4f719dd3 100644 --- a/Features/ManageabilityPkg/Include/Manageability.dsc +++ b/Features/ManageabilityPkg/Include/Manageability.dsc @@ -51,3 +51,7 @@ !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D T= RUE ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf !endif + +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcAcpi =3D=3D = TRUE + ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.inf +!endif diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/Mana= geabilityPkg/ManageabilityPkg.dsc index e3baf27f2a..712483faeb 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc @@ -37,7 +37,7 @@ gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable = |TRUE gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable = |TRUE gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna= ble|TRUE - + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcAcpi = |TRUE # # Include common libraries # @@ -53,5 +53,6 @@ =20 [LibraryClasses] ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTran= sportNullLib/BaseManageabilityTransportNull.inf + IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf =20 !include Include/Manageability.dsc diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf b/Features/Ma= nageabilityPkg/Include/PostMemory.fdf index 9100cb2646..a23144d5aa 100644 --- a/Features/ManageabilityPkg/Include/PostMemory.fdf +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf @@ -26,3 +26,7 @@ !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D T= RUE INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf !endif + +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcAcpi =3D=3D = TRUE + INF ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.inf +!endif --=20 2.37.1.windows.1