From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.111815.1682986358640463100 for ; Mon, 01 May 2023 17:12:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Jrko/M1t; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682986358; x=1714522358; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ErKSnKxVj++QdPJCLyorVFhSKoMPgclVljSIFwHEg+o=; b=Jrko/M1t03sqKLqCw67XMTjwdwv6oWi4vYZfaH37utAllQPT+YqDdf/o xtQor6OYwXbS8XO1GCjrFBXbIyR3fVM3OByJFyhDHtADF9fAhLYxAdijw XJ9y0Y0B9xBMYKDlRkN/lC5FSgvz/hcpaXF1i/8GmM5X57gSatWyp54zu /OU+Q8I5fWIW3MZahn6Q4v3PHqRuWx8TdRG20r5+UJ4avAMak+42zzW0U +hP44v4xhXbcvuuQawG4U7SrhKI0sLHW8R4eHGFoNnyYcEkviPg6db3Mq vLtD0zc8Oc+eOmzsR3S/1sfUi5acbHYMtwhGr65dHImZKYd1DqCN9S2nM w==; X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="328635998" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="328635998" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2023 17:12:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="726532977" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="726532977" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 01 May 2023 17:12:34 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 1 May 2023 17:12:34 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 1 May 2023 17:12:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 1 May 2023 17:12:33 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 1 May 2023 17:12:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c/RP4uGvfhEL29bbqxcPOOYugdN6wus+v/+dLYWJ3JQPTQvUMhR2eUOKTmCYeE6Anz8iO7faD3AZ4tnAX645FSDL3c+jeipsnwNrFOSED0TOpdu8wWRob9NqPdsGuMVOg6D7sHeY2qSn6JKv6o4AJdkLtHZDJtOQMbBj6710jt0JtPfbvOd2mEbwbNgGj2wjpXOvL1wiI5w9AsO7B4AA8u/6wZg4PvlI0u863bdntgW2M66yZOKzh24YiVQ0o4BfW8n6puZ7c734YapBt+Mu+QB5RwX8Q/BDJtea4G9gUiCzIdOzMhsFrOznxcBzIkmz4hBvld/cz7SMtm66sf1Z2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZTn7u56kw/lmA86/YReVmuFzGLghG7c3boEzjzMmPFM=; b=kGqAA+YZqznPpT21TJrblmFbm/QFcT8qGbXItDxzTSLFT05UuywSF1PVP4NbHJE4/ntU1qOhoEwbk4OJIYzkqWpBMSAImu77hK4FeMTa0emcgSBaZzeuwB8AMYw2od7VwUk8JQIRWAN8xVL7BbBo+2/zp+QEk260v3mnqBTKM5rh76tHerPg9QI/yC6ChjdZ8Uw3C7tkK9lUzoyFeaUnrRPDs4Hny0DHiBEFkzm367B9TcUo2+/oAx/pkgVF8hw+E1VWp4OA/WoXrygirGQt+kPBRgEywThd/BsVbaThvXqWgHMOfQfY35qp+mcFgSLxUTxSkWXxV8GQW6R4p/aX7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SJ0PR11MB6671.namprd11.prod.outlook.com (2603:10b6:a03:44b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.28; Tue, 2 May 2023 00:12:28 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6340.029; Tue, 2 May 2023 00:12:28 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "Attar, AbdulLateef (Abdul Lateef)" CC: "Chang, Abner" , "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD values Thread-Topic: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD values Thread-Index: AQHZa5bkZyavaPV+gEijMpk5GVhjLa9AlUUAgAWn7OCAAAApAA== Date: Tue, 2 May 2023 00:12:27 +0000 Message-ID: References: <7e573a1e75f5f61a453f099edbf846e59b0b162e.1681122267.git.abdattar@amd.com> <175B2AF24675592E.29517@groups.io> In-Reply-To: <175B2AF24675592E.29517@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=8a4af0e0-4edb-4e45-8967-76fe5f1e7e4b;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-04-27T02:56:15Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SJ0PR11MB6671:EE_ x-ms-office365-filtering-correlation-id: 2d4fb047-1334-402c-8b52-08db4aa1ea06 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4QQU9+vxQwEbgWBLsXdDKPu0bbhyf29pyFuoKvxxvpO4MO5Mj/8EHbxaswkX5JZaBuA89vxjroJEFDWHE9PAdLeh3vVMWetUEQShzfUIdQ5J4o4W1LQsMHFnBWWsxOCazBq/D5E5jp5XpHR70B8KgRzw4oYmpMnzrBhZQaOowuSZYX9FS+MTkUEgubQIlWSz1bysywmDf7N8HTtpg6zqv0/aYWkK1+X5iqz6a76u8sObM5t+cickxDlqPDwoE7wAG5y+jLjmpGfWKTo0IimO5ltVonP2EjkyQVCFZRZ5bvpUZeJjy+AmhtFvdWheF54mJHDpeI+k7KTgqwxNDdzpu31tPAS9h+vLNAI0cjXK9WmeoS1ii1Wp/V7tb+FXbiliCbIRv0Czx+8OXyqBixem59GdgI/GlrfKWemIz6XwHByO/zPeBHBybSH/Ab6GEVv3S00Qqkz9fLnmiTsin3Wt+NrawhiQGCpgJs8H4Hezq7sJ3AdLW3EHNOTUnkBagQFFovSI2D8T7L4LysCpu3Nfx+ixmshJPuz6kMMppTbElwextSXWWMUcthuww/NxzzhHZjAf1ngDnKwdCx92uYP08txnRnUY7QrnuER/UglwRydL8hcfJOXpFSFKnQjBKj2/v2yi77lfPevk6lJ5t9J6dg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(39860400002)(346002)(396003)(366004)(451199021)(8936002)(8676002)(38070700005)(26005)(66899021)(9686003)(38100700002)(6506007)(53546011)(33656002)(15650500001)(478600001)(55016003)(5660300002)(186003)(52536014)(316002)(2906002)(71200400001)(54906003)(82960400001)(86362001)(7696005)(83380400001)(66476007)(66556008)(64756008)(66446008)(4326008)(66946007)(110136005)(76116006)(41300700001)(122000001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5UqUKHdJxEW3lQz6fGrAoMSaXY6om1Wesb1L2qH272fuT9b7/W+syewz07T0?= =?us-ascii?Q?RK7Mgzzr248e0vIiIT0ywNrewFPX65lnb48AEOvK/LzgxXwQ3qDAhUFJ6vnx?= =?us-ascii?Q?eY226jTTHCXoiakkvfKnuhcK1fYzE6fH1kwOxiasqUGw3GVrxMEfb1ZZNL4+?= =?us-ascii?Q?ZE4tF+N+5B4D0tPzNqCXte0a/Amc2aruOc1vEutPTodyEwin/Eey+ybiPZ81?= =?us-ascii?Q?NttNFfW6RcbO9wMlQcUdgnZPCg+GSE1vopB5TVRKI89EuvPwAIyu2Pg7W7Q0?= =?us-ascii?Q?ENkzKvlDMWxfeGlMDZFtbhUt7VzrXXVYPeRplPYKVk8FRLp2akfGf8w0odD8?= =?us-ascii?Q?6Lzp+TQkex+/kvP/9RRaD+rcl2wFklHORRW0JscUw0SL7fQtTt7iHiRSWtTp?= =?us-ascii?Q?pq1UDYNLlMQIXNBCLSgL5Yw/kGL598piwdoP6mlNg8hO7qJvcOibOFVmMK60?= =?us-ascii?Q?+pcDm1BIZWUKd8cVpBTLp99geTw36bGaByWwHl+X4o5y5ALOMFSClbyQ8wVi?= =?us-ascii?Q?JLgvgybqgqANdR8hlLZy2Az15PHrj3YM4ndw1CAsPiYsj8/J+WPDe0i9laD4?= =?us-ascii?Q?FVajXIsiifYTXSzd0veoCLQxCzcF2xCm3QJfi2ldOYUcwkArM8xgiR5ZtXmm?= =?us-ascii?Q?/lk/wvR6TLY078Nn5GLWL2PJRhu3THdYglEaijv+I5ehYJGtJO9Rk3QMntbt?= =?us-ascii?Q?TTtofdc1EdbiEZYE4PKMyMElPIqxKmXrnTCig+gKipLVfhZX9VVnpRVMN+Vq?= =?us-ascii?Q?0B4lbY4J146B2IaSiFddzFMVqxHsrCoLXnS3yTmRSZXZ0SGwbwQl+rLB/W/g?= =?us-ascii?Q?Bag/ZVwRA2BWQgr9IzK80SfdcCyGF6y2hNFn1owQJ/k9RzgTY7o1Wz/YFimq?= =?us-ascii?Q?suY3cJDw7tCs7po5RSTzwyRnY4J7sUvDC3FCUwG5Vs2j5+I9BLmjAKn1nQ8c?= =?us-ascii?Q?SqTUaROdpRhpY3BudwLejgK4wMSu3L0rTLfa6jbTHL2SRVaie0scNE/Kfexl?= =?us-ascii?Q?wPR1euWSgIwrvHT7t111CM8fO0XT/4rshrdgwfqLlGCHPnSrNei+16O8KB/K?= =?us-ascii?Q?D87Mgqn9rM/s59QbFKIglloXQy2WNA+VKjA2EeIUYq0QhiYgzIiysDG8/aBe?= =?us-ascii?Q?Xrf5LXw/DQ+/nhv8W5rmVfAmCeuvGQGrzd/XQSsRDbIVI+QwPRyMTHl9xzMJ?= =?us-ascii?Q?KWbPyOI5A5cIwitYTRRn+zfzS3d9TWk9HotZk+tuEyF3krLEd/a3KacHsXAY?= =?us-ascii?Q?wdvvCIGmrt2syExPUATf4vYE1ZJTJ2ycDKEaKKYsq6LiJGfE+qgqZZ++qQ82?= =?us-ascii?Q?v+wdrIqmCLk5UWNMY9e7WeE1SX9JTpwoQrJ698nSKu0ph0eG5cefG3C4cCEA?= =?us-ascii?Q?lQJUzcJAi3AwkyrFSBGZo/Q2IeJeNUziOwQn4Nu2GYHQ3k3OtFdqXn5uF7ct?= =?us-ascii?Q?uT3T1deOMJX0tAyHFw5iYJqKgOCUsdKfn7ns7Tz2fcBxZYwPzpKCHRUmJXYn?= =?us-ascii?Q?1gt3AF0SP6DuCgpXwqTNbk4ij6+Xp3n8+YhPUBHxaB2ylUxQ4NmNVtFyBMzx?= =?us-ascii?Q?s0kPHgUcw85eUBb74vzWdgZQ4reY3p+qwz3YDC5Y?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4fb047-1334-402c-8b52-08db4aa1ea06 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2023 00:12:27.9350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pala5xcGYL+GKWCAMofrsyjbVHxHvqDyXGX/AD3I0KTerVrG+AHs33Rwee9TTMRrw0g6OzS/nlb/NwvgiwQijg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6671 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 64b06a4d19..d39c665fe3 Note I had trouble extracting the patch. I had to ignore whitespace and th= en fixup line endings to pass python \edk2\BaseTools\Scripts\PatchCheck.py -1 Regards, Isaac -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Monday, May 1, 2023 5:08 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Chang, Abner ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; = Gao, Liming Subject: Re: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table= based on PCD values Reviewed-by: Isaac Oram -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: Friday, April 28, 2023 2:46 AM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Chang, Abner ; Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathan= iel L ; Gao, Liming Subject: RE: [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD= values [Public] Hi Maintainers, Please review the patch. Thanks AbduL -----Original Message----- From: Abdul Lateef Attar Sent: 10 April 2023 15:56 To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, A= bner ; Sai Chaganty ; I= saac Oram ; Nate DeSimone ; Liming Gao Subject: [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD val= ues From: Abdul Lateef Attar Update the SPCR table based on PCD values, such as base address, register b= it width, access size and address space id etc, along with OEM data. Cc: Abner Chang Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Abdul Lateef Attar --- .../SpcrAcpiDxe/SpcrAcpiDxe.inf | 13 ++++++++++ .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 26 +++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpiDxe.inf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcp= iDxe/SpcrAcpiDxe.inf index 3fc84959a015..9a4f95e86bbf 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= iDxe.inf +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ AcpiDxe.inf @@ -2,6 +2,7 @@ # SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). # # Copyright (c) 2008 - 2020, Intel Corporation. All rights reserved.
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights=20 +reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -26,6 +27,7 @@ [L= ibraryClasses] [Packages] MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec SpcrFeaturePkg/SpcrFeaturePkg.dec [Sources] @@ -38,5 +40,16 @@ [Protocols] gEfiSerialIoProtocolGuid ## SOMETIMES_CONSUMES gEfiPciIoProtocolGuid ## SOMETIMES_CONSUMES +[Pcd] + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterAccessWidth + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio + [Depex] TRUE diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 7ad0c058c844..51449d0fad9e 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -3,6 +3,7 @@ SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). Copyright (c) 2004 - 2020, Intel Corporation. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights=20 + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -368,6 +369,7 @@ OutOfBandACPITableConstruction ( UINT32 FlowControl; VENDOR_DEVICE_PATH *Vendor; UINT8 Index; + UINT64 AcpiTableOemId; Handle =3D NULL; @@ -456,6 +458,30 @@ OutOfBandACPITableConstruction ( goto out; } + // Base register details + gSpcrInfo.BaseAddress.Address =3D PcdGet64 (PcdSerialRegisterBase);=20 + gSpcrInfo.BaseAddress.RegisterBitWidth =3D PcdGet8=20 + (PcdSerialRegisterAccessWidth); gSpcrInfo.BaseAddress.AccessSize =3D + (UINT8)PcdGet32 (PcdSerialRegisterStride); if (PcdGetBool (PcdSerialUseM= mio)) { + gSpcrInfo.BaseAddress.AddressSpaceId =3D EFI_ACPI_3_0_SYSTEM_MEMORY;= =20 + } + + // OEM info + CopyMem ( + (VOID *) &gSpcrInfo.Header.OemId, + PcdGetPtr (PcdAcpiDefaultOemId), + sizeof (gSpcrInfo.Header.OemId) + ); + AcpiTableOemId =3D PcdGet64 (PcdAcpiDefaultOemTableId); CopyMem ( + (VOID *) &gSpcrInfo.Header.OemTableId, + (VOID *) &AcpiTableOemId, + sizeof (gSpcrInfo.Header.OemTableId) + ); + gSpcrInfo.Header.OemRevision =3D PcdGet32 (PcdAcpiDefaultOemRevision= ); + gSpcrInfo.Header.CreatorId =3D PcdGet32 (PcdAcpiDefaultCreatorId); + gSpcrInfo.Header.CreatorRevision =3D PcdGet32=20 + (PcdAcpiDefaultCreatorRevision); + // // Add table // -- 2.25.1