From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.18525.1672938369295229265 for ; Thu, 05 Jan 2023 09:06:09 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=aZlNvCsl; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672938368; x=1704474368; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=szi3x/W5L6jspipAFyOLLZqOvAfA4JTFEkFZxggbXvM=; b=aZlNvCslMmUMhUemFyZ/knL8HrLo16cgOzywoYylO8m6luhX7SRd32Tm 3cSeCDEALDLVukr+IoXPBKyf9wo5cMK63jw+Ext4iqeUfeVNCX+4b3s57 Z74B9TPx7R76mI2xe8XiosI7+LFbQTLgGYn7H3+PeetwvmzxJp9wKam15 50qrgTwchx0JiirsCHB3XovL3in+FBSClfWYEwT9uf+Nb5oCLWc1LUVhP e7Ldvc6cof+C5uAZSSGC3ChjurzYqOffZOS7qrqcUjVoDkPbXbZkAchiT JC++pLg2RVu+ll/kyOz68E9LSYpIPsFYTfjo4Klb3AznyxWkBfMiO7+M+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="384571007" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="384571007" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 09:05:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="984372499" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="984372499" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 05 Jan 2023 09:05:09 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 09:05:09 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 09:05:09 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 5 Jan 2023 09:05:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgcBwsSUKnqeT2McsjyCgP3woB755kcXx5/y4hg3kwfm76IWk+i/85kON4B9YqEbBxvA80xCCjXNFIDUI1BLFnGx0q95/KTgwCJpTwFNlCsmVDBbDFBoqqTF54yumI3+57uRUzvr35CVnjL0jN4kaAXs6+38JfwZPGr8zYGYtScg/+mVNFRwAtX8zpsOCON1NFEx7p6MaLZdBQrGTF0LRIat4xn0XtBBCEnmqge6oUlzL3X4Dv3BmqJxQvc8ooKPBy0cF0yroX5nJCVs8re6Pv6tFX4hppUjX+vaQDn445clf5b74SY2wYWu+t/oUGTLBcnd2eFviKUTyxHs7r/Ddw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fkpg52fW/zz12eXHNeRlKV+KVRSbfYpm7I2P6r3/vmA=; b=NRJRF6sbO8slLy/nUP3si8EkHH7xbuiEvPOcPh/UVp7MLFwca+T5JamMCgyhNfQBRVS5Qo8Dx96ngyFZspzGtxyjLe1CogqC8Npe6TFLbPv8KR31BT5afFtLBDbVKcsqPkvmZtRU6SP6/FEGq4KKPBgYMaNfvVQQ0NJVUzE4FnebigEbsCreW0kmA5EsV1g+4ngzny5enxMRrzX0w0sCEdMQCdw6TsBs+fIUPPqdKH4fhMHJAot8xyUAI5nf2hH67xj42v7iFBROVaj6qOaVvqZ4+a/vmgbfTUNIKmzCliHTFNQpTlF9L7z9uz/4gF9INo4OH7sA0OE5EIUy108DFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by IA0PR11MB7840.namprd11.prod.outlook.com (2603:10b6:208:403::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 17:05:03 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 17:05:03 +0000 From: "Isaac Oram" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Topic: [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Index: AQHZIR8LWofAPDAH8EaQaIRDPPizoK6QC/DA Date: Thu, 5 Jan 2023 17:05:03 +0000 Message-ID: References: <20230105160100.772-1-abner.chang@amd.com> In-Reply-To: <20230105160100.772-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|IA0PR11MB7840:EE_ x-ms-office365-filtering-correlation-id: f6370f1a-c6d9-461c-6777-08daef3efd0e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lKNJqXXFHbrz0q+Xm2cOwoz0A5uls7wvts9zMRAWiaGF85HtDX8jzvHVHxdr8FH7CRRDc7i0aUkZJ8Q91HG63j3vHRqZY4p+Vykvij6dU8VOfvtcbL8wFWne4x36vLfL8b/dAe4h7hTzLWhXXmzCDmAyAKUeu5keNcqApINBjAgbh51i+HtNrF/bBpqfOAYzGs/qDwYQDwFCtTu/L9BiLUWBXjXps8BS6eP5M8CiDj0f3Di+EWhxLunE+4SUHDTsjswgimNi7reEPN3BSjMR83HmgSzib0oXRJF78jrxGrf75ZCNRM0rQ0+4jbklJkN7tYqILBi8JJ5G7Gl8KkY8EsSsujFFE/bZp2I7oLKA3SPs8Zi348XzL0gDao2j9P8ToAe33X3MTdH2CkEVJfbgYVea+LM1IcuN26fiCdpbZiGMm7XBZQe3b5pM+qV/3knrUDPxAhD+JLoxijEbWndDA6WoiPgyCqv/3wlWuB6zs/Mb+ztNDUJddjme8SHYhTEkWxtR25sxGWm6k2Yt6ZuHrpiLPCWyJ420ZqK4ML/0sIoINjIEfEwjS+beMQeoL6dfxtlDdLyzKN0n/1hJncRZgC45p0Ld87lY1Ex6nxRz8pwJpP1hOkHZZI8E2+a8le2CkzqZO8wxCqNJG0Db9ATHwUsfNouGwhmJCWWZdURyjqc5GpF7tM4QhqAHvSzw51Hw4DCsN9A9uCVvBbO/YZHz7g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(39860400002)(346002)(366004)(451199015)(38070700005)(82960400001)(122000001)(55016003)(38100700002)(33656002)(86362001)(316002)(54906003)(53546011)(110136005)(7696005)(6506007)(478600001)(26005)(186003)(71200400001)(9686003)(5660300002)(83380400001)(2906002)(66556008)(8676002)(4326008)(66446008)(66946007)(52536014)(66476007)(8936002)(64756008)(41300700001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g7Tl3qlhoAfSOS3/4frVU+mVZQ/8QhY+xxuNB8b+PwCn/1YUwurF2Oa1KZ51?= =?us-ascii?Q?CIGClYhawJnnVW4xIJElsINv/ScACTyoM5TKbrw5DF85l5YvR9dFc6LLzMgz?= =?us-ascii?Q?Mp4aSDfi4YGKnI/gbY4ybkJoY5fzzMFImdlf1+EM3YiVOnWEZcoDMsLAS0q1?= =?us-ascii?Q?kZOyloEzSBczZpHjpefkKGuaqMQ7o5OfLAjPBs6jZxXBhjHpR/lrZANoYPCH?= =?us-ascii?Q?TsV7Y/yZItrNvVp+6tZuPIkC86MsfIt2fYOkOBgeONZaHUI2RizvFf7TQN/0?= =?us-ascii?Q?rzszo66g2e41zcXTv6F8HsUxND63IMvIsaGynQiBTVA0pd/aDqA7GG+Lt0Ih?= =?us-ascii?Q?vmUND02/FwPX0ECEV9d5kqfuaDw1/pwFukZCOLtLeuEooVDuN0oAfmswv26R?= =?us-ascii?Q?/UwMgETW80Rp19Q3Ot30PVF/7bQFlvnWR+Y8Rc3J6tYNPiIHgzm9i4UeQnsV?= =?us-ascii?Q?6v++QyeGgPM4hw5p/WWo6izYh71oK449d2pj+xO+KE0AKV0OWP5Z3GF/NZim?= =?us-ascii?Q?T0QLDgqpgn098NI3eoe1qrPOpIV8uAdTJ3tWzUh8IV5WCY+c0BfhrImMstbX?= =?us-ascii?Q?AM4HrIhi8rmsACENNmMhTTKTnWMttum5LW6j1sBbUuCBLEd4UmKq6mGQ/OVk?= =?us-ascii?Q?8M8tunwkNLWjp0CGX6/Cd+nYrgaY3cVWyXP2ZAXTkSJ65yrL6l5Bey6eWwWF?= =?us-ascii?Q?jJ1ML1v3NVQ4pIEv2ZiO+ndGR2NSt9z5bxmezyAKSc76SBderZuHRVuk/TJu?= =?us-ascii?Q?iu2F6Y7vLTow32hz2b/mG84U1iewBekZs8h12BRyz3OFFSHWWPIx1BXfGIIG?= =?us-ascii?Q?01AR3liDzF3D4LmHbnY1/uaHfU2Xwry0IYUQhaHLORFo9D9Qqf5Z1Vj9p3J9?= =?us-ascii?Q?b4oYPS6rdEwKUnCwQEY09KNADLBQfwN+ImlL0jWMPzxy4GH8pGbkv955y692?= =?us-ascii?Q?QR4XSeWhpQtB2lO5cWJkXgB3+UkfM1Z2ZqN8JYiCcobfBp/mKm8KMJKigKKS?= =?us-ascii?Q?f5cYvCU3zxIi5s+KXXk7onph89B2JuGAxs4YIxVutAzOy/TXpKvxjd1s4MBB?= =?us-ascii?Q?u+YLH7WM5hbBivMeBo7S9QKOlgUdVjIeG/Fl5T+p6LX4BpsnkZRbOhrC4cBd?= =?us-ascii?Q?vvyJg1HwW3PdLVkuxDQtjUY8HcCd15V+oc65A9vvjrDyBAz+HU/KwrwjnU4/?= =?us-ascii?Q?J2Ap4TEannr2FH8StjtSZUj+5Au0bTAUsyDDsPIus5NoNhzIPcB/vp+/JIjw?= =?us-ascii?Q?kvmNXHcKO1aua93Xzlm9XQ6U3uDPdPBqLlXuvc2nS1UovLYFaNtoxzmvpTgN?= =?us-ascii?Q?HQzAkZonSUXpo8IRbZfxV+BRMaIE29PDkIvG46HjttAPuzu3iaNFAsa6Xbh1?= =?us-ascii?Q?PWTKdUtiIZLRraqOVkQQ+rCuB8GH8Ht6OwS7W2MkNde52eOoHuP9geNvMTCi?= =?us-ascii?Q?yE1RZXaO1y+eWOwSLhdcniShcnbax8kQHo70lMI3nM7BJJXgVWqZ+e9McywZ?= =?us-ascii?Q?0UGQlctIWFAPQYb8wJPaQIwqv2LelZlhF9LKlyA0GQevZ3TiVOMw0y3Bo0/s?= =?us-ascii?Q?5qtxr98vMdCakRaZDnzqJgeLOJaiM4Z+HnjcSeuj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6370f1a-c6d9-461c-6777-08daef3efd0e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 17:05:03.8936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H0Ntysa1JruA2HEFzK8BDedCT0f3Ln4NKwcm0x+m3PaXq666c9AuLdZ3WiFBwFBsoTKhE7Z6kZStLVWoBBCS3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7840 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Isaac Oram -----Original Message----- From: abner.chang@amd.com =20 Sent: Thursday, January 5, 2023 8:01 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Kinney, Michael D ; Ga= o, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish From: Abner Chang In V2: Addressed the comments from Isaac. BZ# 4214 This patch adds IPMI functions for building up SMBIOS 42 record for the USB= NIC host interface exposed by BMC. The corresponding updates on edk2 is in the separate pacth. This is the part I of upstream, the follow up patche sets are: - RedfishPlatformCredentialLib contributed by NVidia. - Relocate IpmiCommandLib.h from edk2-platforms to edk2/MdePkg. A NULL instance of IpmiCommandLib is created and located under MdePkg. With above, RedfishPkg doesn't have the dependence with edk2-platforms. The implementation of IpmiCommandLib stays in edk2-platforms without relocation, which can be pulled in to platform DSC as needed. - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging temporarily because some requirements are necessray to be spec out in the Redfish section in UEFI spec. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Nate DeSimone Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchytskyy Abner Chang (3): Features/IpmiFeaturePkg: Add IPMI functions IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions IpmiFeaturePkg: Add reference of IpmiBaseLib .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++ .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++ .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +++++++++++++++++++ .../IpmiCommandLibNetFnTransport.c | 43 +++++++++ 4 files changed, 198 insertions(+) -- 2.37.1.windows.1