From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.84.1662734720826183859 for ; Fri, 09 Sep 2022 07:45:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Xa5uYnZv; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662734720; x=1694270720; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tIuIJWB60yFswkzWnmok3ctTU+t3SjT5Ldsu5BZY6eg=; b=Xa5uYnZv8L7mVJ2UrAEbOopuK/UsC9vaVxG4qBC6hLrZu/01apz5W/h3 jqWlrzau6lgd5u7sZP6VjpSa61mfYxeokGlbHQICaCG/hYAWhPIIrW0uX bCatm8JKVIqTHfzDPj25jP7G7LePTO3F7Zz/sjITfRxSXqGpdIj83d721 uumXcRmhmvT/O8h50kj6SS+ci6ifEx1wQ4viTGopIm0gCyphxuFKnB11Z kgom/DOepPa4Lm+Qb0cyo1JT0nQH2X9IJ94kmLNqDZoQ9mES07Y4RFqQX MYSkUx918qjdYAHG0gUoJRFv8dqHGZOZnoaqABMd5xwp5jXyKabQiPCG0 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="296225996" X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="296225996" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 07:45:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="617853147" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 09 Sep 2022 07:45:20 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 07:45:19 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 07:45:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 07:45:19 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 07:45:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ES/yTkUW5jB9eWKlNkebPbeyItZ5j9VgdE4nD/0xmr/ixv1qCFFpuOKEqlopny9Ld/P+7Z0e0/aqStrDcxEEWeaePtgDkWuXiBEiv0+QCQgcH9lIC7K+K6wklWdK4dOpNpSzEGcQpX6ajlWvlDIt46/KOxNhCsB4iU4LoMAgAUs9ZDOr12TYpmHNXhcxFCLKpXSRSeK2aIs32l1RFbMfQJppjpSpMVcUY/prdsMFG6LhJnzCZ5fF5iKQJcHoBlz5xdQrZQ9UvoHlzIw1VhMBJj+SP9iU9TyKWQ27QGl6wQH5L/9RM7hQX1arp5KZfWJQPAG2tLizNJc7sk77ZMmw+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsOFQ2IjhRXiOJInq90xG/gnpu2B/G8HsEiXwxiK4NE=; b=kl8dwm/bXlw20OyyIc48dlLyRIZ1ltxADgXeOX1p0N6SRMUi7AmuaCKYgL3ahcDpE2I6ilx+/mWkNEew36gV3SXxHey5B19jO26DMw/sLX4BWJRsIRIFGgK4zQCWhDm6YP3DrIsZxtw75jYI+EWtRj6Wu3LimqUjO8CyDIx7ptJseFglKQEzUQ6e3pEuAh+6gj9aTamOF/I8KXAtNNsj5WXfEHGEkk7h9Gf1Kr2pVsDzDGoGZpnN68dkb5RWjmMnChRUuXMBPdr0Ehq3CMFSm780c1ElAY3ZTZ7itma8fxy2LprO+Sr2BAhegJ+frPWfbcMe1HFmcrmAgXKrYSld+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by PH0PR11MB4902.namprd11.prod.outlook.com (2603:10b6:510:37::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 14:45:03 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3%5]) with mapi id 15.20.5588.010; Fri, 9 Sep 2022 14:45:03 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Fix out of bounds array index access Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Fix out of bounds array index access Thread-Index: AQHYxFRevRuFrd6f4ke1eUw/DM4GUq3XJxFQgAAFtvA= Date: Fri, 9 Sep 2022 14:45:02 +0000 Message-ID: References: <20220909135843.659-1-mikuback@linux.microsoft.com> <1713375209CF3DF9.32320@groups.io> In-Reply-To: <1713375209CF3DF9.32320@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1179fef1-774e-4e71-6841-08da9271e0fe x-ms-traffictypediagnostic: PH0PR11MB4902:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CSwsL4wt6Enfm2+vCODQf9Buwjniyw5fsmFU0NZAMlV9zp9TePC3MzslOK1fo9JVVJ6v6M66UtixklHxsamEC/tQVYW7w+4FKei8CGOsBsUD8xe94PQDp4RFY/M/cPQ76bU2I7aMtjpkq8GtXifpBHVQ725Y1Bpbri+gi/XCPVJIE1cOFbWal1mD/Db+P+R05EleoPlUMt6EW6pEViUFgXaRtqDkZll+gdVYZyDkH5TvgHJ6+Q7maoSh76FPVsaKPs2/oTJ3jYJALqytTXC+fb75YGUWgE6v6KZ+9zBm8I6gvA9CEDHp0bUWqJr9PqFDl6abnHigU5feJ/wesoW2bzpO6rjdyKSab+p37/dV4ZM0/FkopZyM4bKzgX59hkq27WkLrud2nKXB6SmFfmdix6li7b1ROS2rTdvmf21CPcKRmYbnSgjZ36Mm/M84ZC5eJegQqUZ3rOwHsmM3QyFabq9ThxrkHKBvjHc1FFMXfaE/Q9lfPmKL1HHDMurrn9uxc7HhQ+0Ye5eg38ppoULF7vzGiQRx3pxqKgbyo/n+sfBSFqtwQdAK4F2wdYtYRDLaQKQvR5w8fEHzWRwlfFdi9C9IvbFy7xUKfRcMtfjtl7WQp5D2iND28GUTHccobZ9pUt8SzwLdBLREF7i+Gq37bSSKP3rQloOKjpXlRkQNk2oZ8kgqOPfpfw3w90ghsAsWJs6y2KvkBA8w7csuv432anAq9yo5VClGDUcDndqRrfixTOGRPon5OeMV2gZ4lyUSCh/wK2qT0Yu2aNhjMcffdcu7PVCmDSMQgm8BVEYUZla18DCJLfNT34OrnY8+r7DXkeZlZg8JfAx77FVH4uJPgA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(346002)(39860400002)(136003)(376002)(8936002)(122000001)(2906002)(38100700002)(5660300002)(52536014)(55016003)(33656002)(86362001)(38070700005)(64756008)(7696005)(6506007)(107886003)(9686003)(26005)(53546011)(478600001)(41300700001)(966005)(83380400001)(66446008)(186003)(316002)(66556008)(66476007)(4326008)(76116006)(8676002)(71200400001)(82960400001)(110136005)(54906003)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LmfL72jCps2ZkXXUzlm+uj4HDNAlUV5rLDFBg+SIMcghNe65lBwoT5SFmqIq?= =?us-ascii?Q?ju0QG8m5+z14UD4PE+Jr3xsU4e/eEUin48TYLmLBatkRd7YnF4aVZCKWmO6y?= =?us-ascii?Q?lVyHsIhZXVzJBSfTXvkipoXxeTPl0HF48A/YELR2dBEkg7sdzDzPKrbAEOwm?= =?us-ascii?Q?bLCvT2Z/SfCNSHeVmf5iayYUvuuDXWQTzoQiMi6Bs1hizcA4CQ3N525BVPWJ?= =?us-ascii?Q?yk6UYTAyFLPoACLLHSsAaiAFXyxFzKVnYy9r5+QusSyKtIMLCDyGvrMEyuOB?= =?us-ascii?Q?r4sHIJPuitXyyTJfzgreMCZqA9mWqcK00IQJyoFaDQbRx4syXRR2R7uULMDX?= =?us-ascii?Q?3EUuaNq6+xKqHruKxn4KgObJ74poaUto8CJekjfahKm1Qh0h/Mi9nSk2GL+U?= =?us-ascii?Q?Jy57ZfuUJRh+ZXguRFJ9iJLceWPSbc0Rt4jX5iZ9XHjbdEtkJtJABTdA1y/X?= =?us-ascii?Q?QHOviG6AZQSmIxb7u9Y9twsonlIDWK6EIBcBz8ynWU3DT9Bw8V1XVzYXGCk6?= =?us-ascii?Q?clmb77I1F0IpQdFbY2TV6wIhKNRT0SV5ZgQ8xzy1LzaU6uIV2gyz+K1cY5Tm?= =?us-ascii?Q?wVYVxChaUqfpsnbKg5auPcX7StVteX89RNae8knJhikdOGo3bnt3HqZLxLLf?= =?us-ascii?Q?fWz7QsXepdHwBoNPtVULtubNjUfmVu3DXhKgXhiMKU9AqAJPvWpDAs35GDeU?= =?us-ascii?Q?HMMcxNNAnRszimhEGf04eoGnVAz0HRNAemfDyOJt6fc2uMdTO8++YeGeJUvc?= =?us-ascii?Q?/k5jH6BJTr9Mr3HeSnKvY6R6m71+33HaLN/Ao5Z3OJf4hDf2jHrJSO8GsX00?= =?us-ascii?Q?Q+mQyzqgSJGK2E78167tLdKlsIE28e0suiowIjrFERKboMM5Dbrsovo5U8sc?= =?us-ascii?Q?M1oa7WYV5rFrZLKk4vTmq32O29GxC2C8lTfBBdGQVOJKPYtYov5xycB4J9br?= =?us-ascii?Q?S97zuR6AEF/s+REIr3/IKf8EZ1ofmIoovT3DkDy+VQR8GuHyWqGtDAWGzoUN?= =?us-ascii?Q?Dga3kavf67KRGk6zo4Hsnk3pAkXYIeeAPVIdQazheoKfF51RyRp3EJAn6yrj?= =?us-ascii?Q?LUHmheU29hxRHk7oaHky9pIAeh562rgmIjrcDTO8PEXnSwOcHcsB2PZRt8kK?= =?us-ascii?Q?PONfGFGCOwGdz5onxj1LjPAubuiL6iUatV5K9SIow8B+DwyYzYXPhvKL+Lb3?= =?us-ascii?Q?41ebYypegDPjZ9zF8Jvrw9XFfjBteChonBV7oXEPZbRLDCM6HStZsN2SZr/T?= =?us-ascii?Q?iKgCPOXVsYZaE20gDWRxQt1+NnBqBZGlyazbf/vNFEKJzY84SNG/M1JptsvY?= =?us-ascii?Q?WL6vhbxjuVCWTb7OgFqZOKPpiT5E3PnxNjY3uVm5loDD0Qpgaqi7PcUAQijM?= =?us-ascii?Q?bvAn1DveCGCq+M3xY7lCSQjvdQdyhRsrSksq/3vRHNmD5GhzQ2NuFF6bq2gr?= =?us-ascii?Q?CR6h8R8qbrvR18hKdlEPQjN2YneFnHHVid0l2LUKzPIoJZRF1+9VpVcvbzPA?= =?us-ascii?Q?C3S+Mgy/JoVMNYpRq26mxh2tOLi6Ea8Dm+X0bSuXKZIvDoRx8EWIaQbHRjit?= =?us-ascii?Q?hxWpnTrpVNjMOEcaA3459zExEiCLAmo1YOPkSSp0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1179fef1-774e-4e71-6841-08da9271e0fe X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 14:45:02.9919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7BVLK+LbVNRR0h60J3Pq9zyiR+2JjmnwDWUd5lMNrg7ZEFJn12BRUCZdwxXgBdgNfbqMSyTDQwK5ik6CLVVADA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 4b2a5f42a9..7f63ab7da9 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Friday, September 9, 2022 7:25 AM To: mikuback@linux.microsoft.com; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/Tes= tPointCheckLib: Fix out of bounds array index access Reviewed-by: Isaac Oram -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, September 9, 2022 6:59 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: F= ix out of bounds array index access From: Michael Kubacki The following code accesses array index "6" which is invalid as the array i= s of length 6. DEBUG ((DEBUG_INFO, " %08x %08x %08x %08x %08x %08x", PciData->Device.Bar[0], PciData->Device.Bar[1], PciData->Device.Bar[2], PciData->Device.Bar[3], PciData->Device.Bar[4], PciData->Device.Bar[6] <-- BAD ARRAY INDEX )); PciData is of type "PCI_TYPE00": typedef struct { PCI_DEVICE_INDEPENDENT_REGION Hdr; PCI_DEVICE_HEADER_TYPE_REGION Device; } PCI_TYPE00; "PCI_DEVICE_HEADER_TYPE_REGION": typedef struct { UINT32 Bar[6]; <- NOTE: ARRAY LENGTH IS 6 UINT32 CISPtr; UINT16 SubsystemVendorID; UINT16 SubsystemID; UINT32 ExpansionRomBar; UINT8 CapabilityPtr; UINT8 Reserved1[3]; UINT32 Reserved2; UINT8 InterruptLine; UINT8 InterruptPin; UINT8 MinGnt; UINT8 MaxLat; } PCI_DEVICE_HEADER_TYPE_REGION; This change fixes the array index value. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckPci.c= | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckPci.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /DxeCheckPci.c index 514003944758..575284ccc727 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= Pci.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh +++ eckPci.c @@ -75,7 +75,7 @@ DumpPciDevice ( PciData->Device.Bar[2], PciData->Device.Bar[3], PciData->Device.Bar[4], - PciData->Device.Bar[6] + PciData->Device.Bar[5] )); DEBUG ((DEBUG_INFO, " %04x\n", PciData->Hdr.Command @@ -256,7 +256,7 @@ TestPointCheckPciResource ( UINT16 MinBus; UINT16 MaxBus; BOOLEAN IsEnd; - =20 + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckPciResource - Enter\n"))= ; HandleBuf =3D NULL; Status =3D gBS->LocateHandleBuffer ( @@ -338,7 +338,7 @@ TestPointCheckPciResource ( // Device DumpPciDevice ((UINT8)Bus, (UINT8)Device, (UINT8)Func, &Pc= iData); } - =20 + // // If this is not a multi-function device, we can leave the = loop // to deal with the next device. @@ -360,7 +360,7 @@ TestPointCheckPciResource ( } } } - =20 + Done: if (HandleBuf !=3D NULL) { FreePool (HandleBuf); -- 2.28.0.windows.1