From: "Isaac Oram" <isaac.w.oram@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Tommy Huang <tommy_huang@aspeedtech.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Chen, Ryan" <ryan_chen@aspeedtech.com>,
"BMC-SW@aspeedtech.com" <BMC-SW@aspeedtech.com>
Subject: Re: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver
Date: Wed, 18 Jan 2023 00:16:04 +0000 [thread overview]
Message-ID: <SA1PR11MB58013F9FF1938259C804CAFDD0C79@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXFbFo_8+tJeXW-4Oq1v+yd-wvZEvs8C5TM1_FFzOqv2yQ@mail.gmail.com>
Thanks Ard.
Tommy, I will wait for Patch V2 with the correct INF_VERSION.
Thanks,
Isaac
-----Original Message-----
From: Ard Biesheuvel <ardb@kernel.org>
Sent: Tuesday, January 17, 2023 3:16 PM
To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@intel.com>
Cc: Tommy Huang <tommy_huang@aspeedtech.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
Subject: Re: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver
Note that the value in the INF_VERSION field cannot be chosen arbitrarily - it should be the latest version of the INF spec, so 1.29 (you don't need to put a hex value here, just "1.29" is fine)
On Tue, 17 Jan 2023 at 23:40, Isaac Oram <isaac.w.oram@intel.com> wrote:
>
> Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
>
> Note that you do not need a cover letter for single commit reviews. It is needed for multi-commit reviews so that you can describe the whole patch series.
>
> -----Original Message-----
> From: Tommy Huang <tommy_huang@aspeedtech.com>
> Sent: Tuesday, January 10, 2023 10:08 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram,
> Isaac W <isaac.w.oram@intel.com>; quic_llindhol@quicinc.com; Kinney,
> Michael D <michael.d.kinney@intel.com>; Chen, Ryan
> <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
> Subject: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg:
> Update X64/AArch Gop UEFI Driver
>
> 1. Add ASpeedAst2600GopDxe.inf.
> 2. Add ASpeedAst2600Gop file for AArch64.
> 3. Update the others Gop UEFI binaries into the recently version. The version will be v1.13.02.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
>
> Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
> ---
> .../AArch64/ASpeedAst2500Gop.efi | Bin 42880 -> 45056 bytes
> .../AArch64/ASpeedAst2600Gop.efi | Bin 0 -> 45056 bytes
> .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
> .../ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 22 ++++++++++++++++++
> .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi | Bin 36928 -> 33600
> bytes .../ASpeedGopBinPkg/X64/ASpeedAst2600Gop.efi | Bin 32544 ->
> 29952 bytes
> 6 files changed, 24 insertions(+), 2 deletions(-) create mode 100644
> Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2600Gop.efi
> create mode 100644
> Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
>
next prev parent reply other threads:[~2023-01-18 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230111060749.3684623-1-tommy_huang@aspeedtech.com>
[not found] ` <20230111060749.3684623-2-tommy_huang@aspeedtech.com>
2023-01-17 22:39 ` [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver Isaac Oram
2023-01-17 23:16 ` Ard Biesheuvel
2023-01-18 0:16 ` Isaac Oram [this message]
2023-01-18 0:38 ` Tommy Huang
2023-01-18 0:19 ` Tommy Huang
2023-01-11 6:19 [edk2-devel][edk2-non-osi][PATCH 0/1] Update ASpeed UEFI Gop binaries tommy_huang
2023-01-11 6:19 ` [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver Tommy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB58013F9FF1938259C804CAFDD0C79@SA1PR11MB5801.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox