[PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

[PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

[Mike Maslenkin]

During review of a previous patchset with IpmiFeaturePkg changes,
Arunk asked to add additional update of BmcStatus [*].
Also I found another issue at GetDeviceId() function that could
be solved by trivial fix.

[*] https://edk2.groups.io/g/devel/message/100945

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Arunk <arunk@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

[PATCH edk2-platforms 1/2] IpmiFeaturePkg: add missing update of BMC status after GetSelfTest

[Mike Maslenkin]

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Arunk <arunk@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c                    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
index 79eb5f2b86e9..5bdbe47b6acb 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
@@ -198,6 +198,7 @@ Returns:
         break;
 
       default:
+        IpmiInstance->BmcStatus = BMC_HARDFAIL;
         //
         // Call routine to check device specific failures.
         //
-- 
2.32.0 (Apple Git-132)

[PATCH edk2-platforms 2/2] IpmiFeaturePkg: fix IpmiSendCommand response size in GetDeviceId function

[Mike Maslenkin]

It is required to reinitialize DataSize variable before subsequent
IpmiSendCommand calls. It is especially required after processing
IpmiSendCommand with IPMI_GET_BMC_EXECUTION_CONTEXT because it returns
only 2 bytes as a response. So to the next call of IpmiSendCommand with
IPMI_APP_GET_DEVICE_ID DataSize=2 will be passed. Probably this call will
fail because the expected size of returned data either 12 or 16 bytes
depending on IPMI version supported.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c                   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
index 5bdbe47b6acb..c333ca2e067a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
@@ -305,6 +305,7 @@ Returns:
     mIpmiInstance->BmcStatus = BMC_OK;
     return EFI_SUCCESS;
   } else {
+    DataSize = sizeof (TempData);
     Status = IpmiSendCommand (
                &IpmiInstance->IpmiTransport,
                IPMI_NETFN_FIRMWARE, 0,
@@ -326,6 +327,7 @@ Returns:
       while (Retries-- != 0) {
         MicroSecondDelay(1*1000*1000); //delay 1 seconds
         DEBUG ((EFI_D_ERROR, "[IPMI] UpdateMode Retries: %d \n",Retries));
+        DataSize = sizeof (TempData);
         Status = IpmiSendCommand (
                    &IpmiInstance->IpmiTransport,
                    IPMI_NETFN_APP, 0,
-- 
2.32.0 (Apple Git-132)

Re: [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

[Isaac Oram]

Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: Mike Maslenkin <mike.maslenkin@gmail.com> 
Sent: Saturday, March 11, 2023 3:30 AM
Cc: devel@edk2.groups.io; Mike Maslenkin <mike.maslenkin@gmail.com>; Arunk <arunk@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

During review of a previous patchset with IpmiFeaturePkg changes, Arunk asked to add additional update of BmcStatus [*].
Also I found another issue at GetDeviceId() function that could be solved by trivial fix.

[*] https://edk2.groups.io/g/devel/message/100945

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Arunk <arunk@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Re: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

[Isaac Oram]

Series pushed as d7466862b7..4811c37ae3

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Tuesday, March 21, 2023 1:44 PM
To: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: devel@edk2.groups.io; Arunk <arunk@ami.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: Mike Maslenkin <mike.maslenkin@gmail.com> 
Sent: Saturday, March 11, 2023 3:30 AM
Cc: devel@edk2.groups.io; Mike Maslenkin <mike.maslenkin@gmail.com>; Arunk <arunk@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

During review of a previous patchset with IpmiFeaturePkg changes, Arunk asked to add additional update of BmcStatus [*].
Also I found another issue at GetDeviceId() function that could be solved by trivial fix.

[*] https://edk2.groups.io/g/devel/message/100945

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Arunk <arunk@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>