From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.27409.1679434294233513985 for ; Tue, 21 Mar 2023 14:31:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YaFsT+Yf; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679434294; x=1710970294; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QG0mgnwk/Xef1LDnOAd7uAI9cOZM044/n5BByKYs0gk=; b=YaFsT+YfQjcssz9bLNq5jhZ60t6zp7l7XZTr0Aqdu1rQFwclQJBAuPd+ WSwv7M0z3yr2lrRIYHEa0U5Pgys5SedtjBgMRuNJ8vBJ5nv16JdoOFnUK 8gGH63pH/r97lUojlpscaoQWuFE3HPFK+g/ECPuWzhkeu//W9Jmi+YK2b niAS9VgvjF6GCNwbBdsLjquVW3Ic6vTqGHX6CYfc4sp7dIAkqD/FiioWo z9kegs84gDVdd5oZVnKcN+ZBCJJc/0/GWrxbUKJPJ8ofAsTCSI0Vq73e8 KVKKTThPE41aMeLPwu/QOPYVBNi6AnhK99jA9oB9WyiQU3i9pwMZqzXcG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="401635862" X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; d="scan'208";a="401635862" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 14:31:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="792261713" X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; d="scan'208";a="792261713" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 21 Mar 2023 14:31:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 14:31:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 21 Mar 2023 14:31:32 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 21 Mar 2023 14:31:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bk9qkW4Xr49H2B43DUI8pv5QnoGvBaC3IJO7T3zVYRgktJf6PMjGHBwbehoDxpSsELTbJZPowq2VsZqCUuKyv3aH2ZxgMTMDC4JXrlvG6xZqvn7DdiZhKTD5sRZ1I/Xb3ZVOwWc8OfLeRzJef/QRg+a+p6oHxmTFfEGbLina+zBQIKZ8PLmrunycyfB2Rn+S5wBnXJKuEPMl225mlVew87OXCmRVg8FT5FzkFMiOKTrjQj6YHkLBiOtI3gSOp7Z/YCk/x6Xcrm/M9/0tG1pAzz7jqrkoemVWCg5eZtM3XtenxlL1PCe6ghA463lhrzUgsATpuN/PWcGcLCXwvFM54g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QG0mgnwk/Xef1LDnOAd7uAI9cOZM044/n5BByKYs0gk=; b=PAek5QLjqXhqkrpGnHjfz2g/Z2WtWYpbdVEqy+XoUcluItLXVeTAaweU2Gj65GIRV1eu9A+138e3Po6OcZadR/MFg17coz25Q3yjGEkPvnbLdfqOeIHuqhgv5xlrucQzJr7F86cvCHCitqnOuhYCfBoXwf8cjHLdMJkLAjI4BqONeZlJj8cEFWrXPuCT3z+GcVMDzhlJUr41jVtlExkBS+akA0jHneLHfn8AYHMnokaArF8lRh9B3TqyrAXkTkdgzy0yFsgxZ/mlDHZyFpvrwjmMbCn3I2X3R7wtCpORbnLW89Jy1dTJG5WeYLv3xmgWUe4QXDZ6uj0HoAS20iqd2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by BL1PR11MB5352.namprd11.prod.outlook.com (2603:10b6:208:311::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 21:31:24 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::5fe4:fb10:27ba:d2ad]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::5fe4:fb10:27ba:d2ad%9]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 21:31:23 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , Mike Maslenkin CC: Arunk , "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes Thread-Topic: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes Thread-Index: AQHZVAzq1JWtL9jt/UuXU3zRwCVFJa8Fw0xwgAANc0A= Date: Tue, 21 Mar 2023 21:31:22 +0000 Message-ID: References: <20230311113006.18957-1-mike.maslenkin@gmail.com> <174E8A0CD4032B9F.19937@groups.io> In-Reply-To: <174E8A0CD4032B9F.19937@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|BL1PR11MB5352:EE_ x-ms-office365-filtering-correlation-id: 1a46f681-8420-49ff-4340-08db2a539e58 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ENg5KUgRtD9g/wF/k0okMuHZ3dsmJjpMcEzrvNocQjmOLnojNcwTSka0oPwTGQIe8ZpcELhOZSWdI5r9DoxuDMSSh8g2Xg7Zzehuxi89ZYwXedM0mVt4/HU+1VgUwMuuAHX2tVP0K908a3oeIfMLGxujPkGswblxNdtYWGK45suSJvhlL8A26Nwc5Hn5YHvImFo33lbQ33aA6x/JkYwdcxLzt9Zu4Est9XwLIHcHliHC/GJDbpoUFSNjcynvUTp0CaosDcM/VssT1gXyOmFo4lu8OULB3paRV7JOX0F60oIfkap9+LbcvQHHEcIGAhWatSnHIISxXlThrttluWLb1Kl9GErla2dYxKrw+p0DZo5WlrliNwIcqt0AQCO9Av8Dmghw4q4U/itFH7UyV5g9DuR3uyzIkM5VR27PGEMZ/ScSznVPltAaN1I5w/k6XY+3MnuJyHho4Tk3RtWa3KimfSnbA6Lmv21SI3SMSPzYqrOGlQnpPGHY7n9YJFvwrdP58W36m630kHei7qmRe9GUAz8YOcMQzxlGDZGhoAqABX7s8AkdHJz76h86Wr67XJ9catpa7lovyTYep87KuSTUWLqoAnjN4wNNTMpo6T4Xv/Xs3ED8jNrxsuPxeWeQrYkK7eWtjfnadVkvjRvs/qkAS9rAwV4n9gUt1yqi4brOj9htrBtl61pX16c3bb/B87b6EML2WDf9NW8rOLPUNi63N2gI1k1FxoLNe95Clee3uBI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199018)(66899018)(83380400001)(966005)(110136005)(54906003)(316002)(6506007)(53546011)(26005)(186003)(33656002)(71200400001)(9686003)(478600001)(66556008)(38070700005)(7696005)(86362001)(38100700002)(122000001)(66946007)(55016003)(2906002)(5660300002)(4326008)(8936002)(66446008)(41300700001)(76116006)(8676002)(82960400001)(64756008)(52536014)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kO8f8a8u0N1uXxkOJ+TsGry7KLSpuTBUqi5TUrT2R87wgteC3qWY9ygS1S2s?= =?us-ascii?Q?3gGQHuRn1MtdyHbyLxKyBHIqZ3Lz+I+V/15Md3Jb+bR1D5TxKhgTzzj1h8Z+?= =?us-ascii?Q?GfCiL9dqQ2POr2ee2cLR0l8XNacsFRl4KHrh4Xjlis6+JkZlWMwnrmP0ZKLQ?= =?us-ascii?Q?PcQzcbS/eWsmHfxkwJYmp1VTxeDJeJ4oxPNJMX5fL0Df58EH2ZansuBaQ0lH?= =?us-ascii?Q?sixan+gTUW3rceowTYO/gDN5SXY6ERqRqs3gIgKXLZZDVZT69FFqVE9KP043?= =?us-ascii?Q?iLVaqbLEAE0U4UtMgzj6Cb6O6TYuD9LMVBSi4u2gMieqWe+/Vn2ytrLiIALP?= =?us-ascii?Q?urU3FOmgx5iGPYobgRRPuj5GWFbOuBvEI1BsuQ6ScO+M3N2Jn2dor5iU6Bia?= =?us-ascii?Q?qqP28/sBs7gtSMJygk9ZFy1Ayl9tpw7sp7ssJiI7/mYMpre6R4WBxoagxbXq?= =?us-ascii?Q?r2QYEwzKlQdonzM7lw6td4rvYILJ8VT62gZ0a3yGReItIlAbtCPPZyrEIR/a?= =?us-ascii?Q?fskpL8HKUMmEODFKy9GEXTXFycDS5UGGZGtV/xCZLtYXBvsM9zr2GvIJY7m4?= =?us-ascii?Q?mmoigmpvMklb25Iumt5sj6xATxD81IlCaFGZGSVnTmJsSknGULI7gihDv4SR?= =?us-ascii?Q?gg0144ImEenawkyXjHxexfzWr2cJbs/BFA/Eq31NURSG2NSZKfuhzHsY5S3W?= =?us-ascii?Q?6xlSe5aUqaFmCoRNFhXLUZspqENoczMx3sLgUBhcsWwEphVi1PRVj5Iiv+Dv?= =?us-ascii?Q?4d4BRs8D9uMG2kXAT3ZgRDdl6v4kUY/r5secJC9jlghEZ3KyktRxNNBFCjzg?= =?us-ascii?Q?NI6f7EBP+d35KN/XK6YNhgr2Lt/itfh7x4l05zyoa1WZjfRB6IolMnKoExqj?= =?us-ascii?Q?y06GjPJyCs2wDRSC3kggnIYzGrtFwShMkkRCOm3BJn1cq4lZVDDkgox4IUq9?= =?us-ascii?Q?YgXDIZJDVjonCickRim+u5cP5n9SiAd7Oi+A7kb2IqeIGqiiap1YD9eatlmv?= =?us-ascii?Q?rkgvt/16Q1pRPFAu2CST3MCYUI3hO4IGeEVy7TuRLJd8vhGnVYpCEDDLyZfn?= =?us-ascii?Q?7z9hIIaKZajzHmE/svgnzGK3FtRSYh/mylOcu3Osm9YbnLmJl/AfYo0sNO+3?= =?us-ascii?Q?Yj0ubqmYWFJmmUZ/sp+Bn84HaRfE8mDnNSmaPJnbRgYoldzWUtaBFjQqomHv?= =?us-ascii?Q?h0Qt1slabIyJFhNPT5Hhy0lYFOINwGZ7OTRm3yV90U/0I18LaYwMm6Xvb3eU?= =?us-ascii?Q?f2v3KkdYGiHXsngrjXsDLD9MqyVKIB99ET5ag7QBRLr69P9qVKoqzC/JwlNa?= =?us-ascii?Q?kw/b30gLXyLGGIcDrn1DQQ6LGN4qCh2b5dkDTj6TojPQjbefpjdspGTRs1oC?= =?us-ascii?Q?8Mq2lMLONGN2wEmppZF5+sLi7jVuJ2zFliIyhrMXavhqDSQHRDuAc7Wa/kRi?= =?us-ascii?Q?UD0+MWtmRVWn43qnpcqj3+cTsUc7vumP3FvodZ7pHZmZET3xdDNjDZQM6bGA?= =?us-ascii?Q?LTDuh/11xDhL7+zj6p5mKEr0sd0sj6peNtmH0WVYr43iF+mvbI2+FKUw4Dvb?= =?us-ascii?Q?yw5743HnAQaNGDogUUhoZq0a6fdBzAtitvfg0lAz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a46f681-8420-49ff-4340-08db2a539e58 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 21:31:22.9981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DztPeJnaB+eklE0rqOEdk1eO38bh+XlCeZfe+CIWonmU0vSVaBkjT1JblufmupC475J/Lm/J5vhE6XrgJpHymA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5352 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series pushed as d7466862b7..4811c37ae3 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Tuesday, March 21, 2023 1:44 PM To: Mike Maslenkin Cc: devel@edk2.groups.io; Arunk ; Desimone, Nathaniel L ; Gao, Liming Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small = fixes Series Reviewed-by: Isaac Oram -----Original Message----- From: Mike Maslenkin =20 Sent: Saturday, March 11, 2023 3:30 AM Cc: devel@edk2.groups.io; Mike Maslenkin ; Arunk = ; Oram, Isaac W ; Desimone, Nathanie= l L ; Gao, Liming Subject: [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes During review of a previous patchset with IpmiFeaturePkg changes, Arunk ask= ed to add additional update of BmcStatus [*]. Also I found another issue at GetDeviceId() function that could be solved b= y trivial fix. [*] https://edk2.groups.io/g/devel/message/100945 Signed-off-by: Mike Maslenkin Cc: Arunk Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao