From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.34490.1674088598505781755 for ; Wed, 18 Jan 2023 16:36:38 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NtFXfA3s; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674088598; x=1705624598; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XbTfwu9pe1+AhBTrmTSRdPyAIlPLugupm7sf0hVo0T0=; b=NtFXfA3sUHS/1xuET8haLOvUgnP/J0RoijTYRnIwr0U9n0vozMQlitlH VDMD2SKJoAJ2M7vNgh3cAz9LEOoGeoJxfiKf/wY395JvK8MBNm5iMMemS DZvBKCDC7IqQNanhE0KfLRuNTKq1Pg15GypN+thU9COAekmT2iAgeSp4p 2QFAZ9WJ6zjvXAymPDKpH9GbiYEtm+WfHTtAF6cJz3wjjTdd3jkLYwJw+ jIvTa4dxiuhAzTDmB1Iw6P68JCXSiYdjkvGgjvH4p35MNJZWxPWs0zcF+ mUQZ/zNpqvubQoQV2meLfNDOR2d7qE+3crYvzTvaIni4hjPyCPFI9XddM A==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="389646926" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="389646926" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 16:36:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="661937334" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="661937334" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 18 Jan 2023 16:36:32 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 16:36:28 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 16:36:28 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 16:36:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CF7EoQFXLux1yAkk9u2f4WUEWzNNFOLfsSRSFIKbqKSDcmP34nl+uu2SR36F0/k8r6Ns+2UqsQUhu3AhSbc8NT77XRS0AYWJcYAWo93W/eGXX7y1qPX3ZjA1ca2UbXpZw8p3fpfXPkvHdYIGV7LQG4eUvgXMyTKeOrv2eIQI9xpAkYVmEamRFsQ3OViERl7J/jZNd/PJSIlMTSX0Lu+28PMD1UFMSIBWvRjEj/F6jG8JdS7lhEhCVdLpgOo7NGkjzbVjtyr9IV5kLXvAyTGZyeB/Cc8l+0iYpsBcybivd0hWJMJEA0avQa/HoTILySiavq8p9/dxVaHZ6WcZJuU4FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ltzf4/a+uuKt0LVnMWfkf0LLUM1WnEiAYeT0UaEiYBQ=; b=jGcM10CyPiN6Dq8vfG92qreZ7AGfJw/weXu/3vlWyM/wX5FeJ0V0GVMjQxEfIlweKsoDvzFFA9XUihSNnwg7RaddeiS3SYjrO7KHSPlDRc0hjws0ris/51htPSzK/XYQo4dBcKsV2+9Hn6EeBijuUuPV7B1F0mkkkIn/QtpbxtN8pAW7gaiBHE7/lpqOH10jL+fwUMVfJZ5TztaUAqce2Ozdr+budqbFOVhmyFC3PSW90JIOZUlW06duTjFe/yG2s0zyXFYMTZ261OvcfUjiTKX9u4kL+pec18An73FVdw39HBVJlh7O4x0DAQsTdFEZgtJv4TO/zKQAK9Lpx/ttIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SA1PR11MB6782.namprd11.prod.outlook.com (2603:10b6:806:25e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Thu, 19 Jan 2023 00:36:20 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5%5]) with mapi id 15.20.5986.019; Thu, 19 Jan 2023 00:36:20 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "abdattar@amd.com" CC: Abdul Lateef Attar , "Dong, Eric" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Thread-Topic: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Thread-Index: AQHZKz1ohFccbhcBbECblTaOyHx0BK6k3eWggAAHkgA= Date: Thu, 19 Jan 2023 00:36:20 +0000 Message-ID: References: <173B8E643ABE185D.14781@groups.io> In-Reply-To: <173B8E643ABE185D.14781@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SA1PR11MB6782:EE_ x-ms-office365-filtering-correlation-id: 96d66743-9405-4014-4d01-08daf9b52f48 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PBfp7xj4VE9DYGFGFJiJDsfZC3DG4p9QvISz+OyhViT5No0alzh4lpEcCXP6Tbl63zoZrebJV5kVB5+Rzief8+NpPji93XNJqvw/Cv+EaY4ArrHAG3xhD2lc8SrvEWl/t9rjGTS0Uybig2ee8HpbqT0ITXGXuuM8G6xeX+k64I7SiOLtvNuz2AdXT6d7kI5bLPmouDFgaRxTtmdyq9wKpkmPuROXlbnaNzq+11+L+xbbzqujk/OfYQ2dDAZw8DGyu0dBApaSUJiNzTCbFEJ/tnp1EkSHv9ovw6hiBU0aNbz5o1l8zh2GVFuk4XBLN/glE6CnSs1nKiV7mzHUnMbVQ7xXxnD6EVjY7rwfzs7mRDZJ25142oCqY44LZC7YKzyTJGfchEp0218lajKH1YX/zXoz4I2yiQRHolmkX8jfPOxKCYOiQtpF/ICFwbRP6iPVy3+D6Q/9b5D9125BzfM3OYe4Bun7Z//sAWwC1qT0ASSYSm/ShYZczas8vfsBEqpZbcI24gm0oJ2x9MY3vWSFDq3MaeDPZtYXIAPD9MuPRdzU3Tlkie++4ugjJ9lgZus4ohZALJREVw9njUZOqD+M8Wv7L2nLWEntt9byrXwyBlr5O4g/VWzWEIpA3d6alVFR+fK1azpXHJBtQsgE+PF9AeeHQmfEc7k3yweISzIZIvxVNpVlCyhIzd6MZ1kax48DSGsqu43///23PQSC0TYVHmMg1t2GRzmnqCAemyTlZdCkMCttmuMhPhVIuDqRpdJ8B08oGphf3lzDr1IaliuClA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(396003)(366004)(376002)(451199015)(83380400001)(122000001)(38100700002)(82960400001)(5660300002)(33656002)(52536014)(7696005)(2906002)(66946007)(38070700005)(66556008)(76116006)(4326008)(8676002)(66476007)(55016003)(64756008)(8936002)(66446008)(41300700001)(53546011)(186003)(6506007)(9686003)(26005)(110136005)(316002)(966005)(54906003)(71200400001)(86362001)(478600001)(66899015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ufz9Xh+YX7JaSQXws9VhH1ssj5xwNtaW0P/3Y4jiA1arpLXoyynCsGDSbpsF?= =?us-ascii?Q?KhlCJcd81+uQqU+MAgz00G7j1vwsiK+R6jRXqyMOW8YwiMUf7UuVIUapC5Lq?= =?us-ascii?Q?/xqDkF+2Gc/cHVPLkFALjOn8eUByU2IhY1uwTWiBCZkaPZV/LzMwsEfCNaMS?= =?us-ascii?Q?vUTLuEozshdquhYrxVayeaLq4Wyyd/AT9Ci4jpjlitalQwZ/kx7ft/y7Gyrl?= =?us-ascii?Q?b5zhQ6xjqEbL3cjipLSxUJJ++5wp0VpHJyzMU0Rl2qK9EF44qxT/6sdvz2Df?= =?us-ascii?Q?1T1O/sJFIjQuqYUHttEXuQfm9taySnL+4S7xmSMnNfOUBRZ/9rFooZIFq5QE?= =?us-ascii?Q?nrTFnSNhRezqLmf0ndZkxRWpjB3C5VFZQJ3nUyHWhR1U82tgJ768Szk8s8sS?= =?us-ascii?Q?VLT2K6BGDWhvlhxVNAPBp9YoQ9uOztjAryhMuqizNWjiFULVnlboXnjldMTu?= =?us-ascii?Q?YJQhD3N9PmUsQccerTM4uRTGkexm2TEdtJZftp45v/90BYvtc61GWN9ML6Dm?= =?us-ascii?Q?MJpn5rrRG/DqJIeDu2PDA5gCRUA9idddO3ZjoEjnYKoDXRA7pahLdjYMyyjS?= =?us-ascii?Q?UqT9fbNuo19paM74ErFy9yJXvSHMpMyxCa3/1fzSo0wx1W4uwqHIoAUDc9kg?= =?us-ascii?Q?6Hf90mZ60hcjgq/C+9B2XQqhrx6HeLgyqcwIZB5ZxzqWZ98ENP+t8GoPT6vp?= =?us-ascii?Q?RnEUBrMeS4J5V7jFtgZvMq1HUu2yuDE53ol/5hRU/wQiBO6ey9josBdET1mu?= =?us-ascii?Q?rHM19ry7s/q9Z45GNc5W+jB6eXanKc9DGQCQdwo0DV4Jy07aLQ5qNfCRobum?= =?us-ascii?Q?BdPQD+89/CmujgAkLes3j4Gy3ZGwlm5R++vP9+2TtHfZEq8euHGWrkfW8Se9?= =?us-ascii?Q?nnkmI7D3tUSaudUEziQ34z1iGexr5MAxixBP8Pr1lolmPKLlXRTUi04RgbCY?= =?us-ascii?Q?0chcRJ4wKO/tzmIDp4hWqv1VYCHAO3kWP8xs+7PVRZZYcXlrewvqLi9URBaL?= =?us-ascii?Q?8+xgGpqbS8QuORG917HnRp/CZL79u7QF7XHgL1BhX7mdEqNJxXlNju3RY2wT?= =?us-ascii?Q?t4G1/ncwhiYL/1RurFpaS7KPNtOB8jP3ICb3tXzxw1T9yjb9+XWXNDTrp4KL?= =?us-ascii?Q?nk8+HD+JV/1i4vsBOfNf3IutNMHgL3hMU7W4OqeILP0QwWnXGDIQK5SQuZxA?= =?us-ascii?Q?5W8S9ojlhds6iAyLAxGrfJ3v6ojElfxRvNAn0HuC9uWR+02FOqy/oHkjqzF7?= =?us-ascii?Q?o7y5vHtonj2eUfISZmKm+gNXWHSbQLC/fvkVcD0ggETSLaIExZOGjbjMKLt/?= =?us-ascii?Q?FJT3VQY63dfwgV1BOrBqOS1cd5B59DEQ2oypJfDFdKsv1KUoLG7n2C0lf4Lx?= =?us-ascii?Q?2rNGpddJYqgXDhv3v5KumBRAg6sykdFb4AMpDrHVoIjTsVdywpeqo/YRYnIm?= =?us-ascii?Q?9WBuAfTFCjdZWL+yIBR5YXikaoekAYUpyrR1yjpyVsaELF2zg6ROWuf8nyJS?= =?us-ascii?Q?Ot06514gI6i6i60FplQ1b34MQMejjUnHNDSFgVBxTQXE3hN/x8FIEbQTeXSX?= =?us-ascii?Q?EdEVWA7j310PsYfXFxGYeR+qAwEoTtf+QstQqds8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96d66743-9405-4014-4d01-08daf9b52f48 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 00:36:20.3386 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hpmLAGKOMJWzcoPBoDVGlCmc0iZPSFCfLeprcXqcVZS4yhUTE0PMmovQR//F5VC16xZtwGklKTTkPGo7mamHOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6782 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Pushed as 3b368b33e9..201514e6f5 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Wednesday, January 18, 2023 4:30 PM To: devel@edk2.groups.io; abdattar@amd.com Cc: Abdul Lateef Attar ; Dong, Eric ; Gao, Liming Subject: Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GC= C fix Series Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abdul Lateef= Attar via groups.io Sent: Wednesday, January 18, 2023 5:04 AM To: devel@edk2.groups.io Cc: Abdul Lateef Attar ; Oram, Isaac W ; Dong, Eric ; Gao, Liming Subject: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fi= x From: Abdul Lateef Attar PR : https://github.com/tianocore/edk2-platforms/pull/55/ V3 delta changes: Addressed below review comments from Isaac Patch 1: Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c Line 168: Don't we need to free buffer on this path? Lines 655, 1083: Please put a newline between while and the block to fre= e resources. DONE Patch 2: edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/Boar= dBootOption.c 338: Can you change to mUefiShellFileGuid and initialize it to zero? It seems misleading to me to have the default value here when it is not u= sed. I think we should also move the declarations to the beginning of the file= . DONE Cc: Oram Isaac W Cc: Eric Dong Cc: Liming Gao Abdul Lateef Attar (2): BoardModulePkg: Copy device path before processing BoardModulePkg: Adds PCD to load UEFI Shell image .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++---- .../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++ .../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++---------- .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++ 4 files changed, 41 insertions(+), 20 deletions(-) -- 2.25.1