From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.75016.1680537383573459691 for ; Mon, 03 Apr 2023 08:56:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZU69zi8u; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680537383; x=1712073383; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GTjA1ZxkSVtvyv/w7dFd01M10BlFhvErRUdNYKWchlw=; b=ZU69zi8uRcT4A/4KIyTw7PAl2ETyUl+o4WiahdhNOku9jXj39UcCPVca CAwIJoEZl8RomIWgfgzTrkPu8cAFm/aZgr0msH6AvCVXmWStnr75s/o+2 WTmnrhJhQSatjwRRKrzEEESR9dSeEq8FBiTrdVp2Qb6Jvs2AwsBokvExz W2WRXgk2C2l3SjB9BsNzSrh7Y7Miqih+qHsRs7cYZt8txJGERglHyErNQ 7FzJghoLBYytI7UejotM/fuzhAqsCQ8c4mELhUWUktzTRJ9HhKMj6m2HC VDW1jDj3UuRkw6R+HXiWVnUeTXc6BO6vMfwf0Ul5+VNPA37pK6qDprc5k Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="406989105" X-IronPort-AV: E=Sophos;i="5.98,315,1673942400"; d="scan'208";a="406989105" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 08:56:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="775255431" X-IronPort-AV: E=Sophos;i="5.98,315,1673942400"; d="scan'208";a="775255431" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2023 08:56:22 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 3 Apr 2023 08:56:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 3 Apr 2023 08:56:21 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 3 Apr 2023 08:56:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JB0HW7N0UKGAkPb/fSFG03yClXQbeRj6uQ1vhrQ7nOGgMH4Cd966R1Rw4BmRo/WCIbQiEkEKnCf72C+jQOCLQ8ta2F26fLJUU3AVcE0fIJluUvDvjE4w03G+KYZJ+qLC06sZ8vO5cp9Wr0QAswLYPx2RoIgpw5C+cwRpdKjRp/TBEWHA45bSov+Zte1YgkcExQw+Vtb5Jy6ZvjZ2JKD9OUAlbuCIALsL1LeALGiqXSnhre1LJTVO6syrzuOG3Gh1dmve/r4aQf+hWgS3r5If1Xz7SIEQF/IUsjs3Sy366EhbeeEolIvYAdj8W/zTVl4nYlPSIxjn7HA6FeVv2MWcAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dwYWKAoh1bRWWf2t6r3lS9X7itl9NRM0WJFJZQWdPmQ=; b=L365yyvak0ey96Cpv0FTAC+/OJTbwqHheaJ3SdmJXUfWAL6JdHtjL7g/jacy8oyw7gHfYJ/dFdlspQBoOfzXR1jnTfzfLRUnSz/UNwnj/Dzuj7ZjzfiW0EsGxPRw24FsaMn8L3qrOXrhAK8Xrt5TCJIJioZXh2MU7VVJFtTU6EufaAfORT5MCYDKivUbwQ5bJKFZGDLm/KccMGe4Nt/EJ4DDbihCXEIhgdMxKCOtV5J9ERLjYZeFIIknWR6OX1Yf8dXYOB/xAVjj50MXzVww7CkZ5ot32efsZ2VCVA8SJ8ZC0sPxgveN5zJjy7uFm0DJaxs8kEDz97kklNrqtSBilQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by BL1PR11MB5493.namprd11.prod.outlook.com (2603:10b6:208:31f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:56:17 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::5fe4:fb10:27ba:d2ad]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::5fe4:fb10:27ba:d2ad%9]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 15:56:17 +0000 From: "Isaac Oram" To: Ramkumar Krishnamoorthi , "devel@edk2.groups.io" CC: "Venkatesan, Selvaraj" , "DOPPALAPUDI, HARIKRISHNA" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "Ponnusamy, Suresh" , "Desimone, Nathaniel L" Subject: Re: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82 Thread-Topic: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82 Thread-Index: AQHZYJvfwix5djkE90ukpHw1Rb2I7q8Zxdnw Date: Mon, 3 Apr 2023 15:56:17 +0000 Message-ID: References: <20230327110351.1371-1-ramkumark@ami.com> In-Reply-To: <20230327110351.1371-1-ramkumark@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|BL1PR11MB5493:EE_ x-ms-office365-filtering-correlation-id: 93b688d9-9e64-4c3a-97c6-08db345bf5c7 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qs7TbXK5KmOIe6S9wJOROg+oBJrvQeKJ6KHV/noA2IMSSvkkPF3jrA2pbwLFxcyiByBEkJ2mSZBUmY2VNWlOwj4iJYJgwWcGs8HYU7CYOesDemvO6UgYX/0C7SuNF2tQhxgKbZ07UMBpcwHXXOgdNHWm6dvhsgv6kQxwAj1hAFapY52gMj9/z6Z/zCbVmS2Dyof33I0ROsYUZjC6NDqkredJuLVCFh6+iNRl4hgoFE6wV4W4C6nNTmOVrUW1XyDdn4aDjtgOPHoiJsvAlcOfYrFBJgITqrc0bhDe9dMGI0VxjhQq4913FXk1X0MrpHRBuHL7kI1rUNGf3wrxQzA5PCwhAOugkLbrLNrC8gOKaj1G/mOad0mw0zoYEgg52XbmhDuGIRr057EhA8zo4IlD6nW541YgDBmIyjRZnaSQgymlC5g4tK7dGQKNXgcNQxKPc76GrWxFCTITgb74yuJi2YetRUzFSVY9N30gdpWlw8Q5fy+iNl/b4ml2m8bXxr3DPGySKm+EKz6utF8hzc5IZrXcOwjxolOZhxp6nOtLUfvq6Wri2eUc1//NWSyfmXlTwwer1LKiN2HoEA0E5zEJEuc8f1TwJ4uc9hQeAN/lvx69ZLbRFOCiS8W+H0Cjr1gT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199021)(107886003)(186003)(26005)(53546011)(9686003)(6506007)(478600001)(7696005)(15650500001)(110136005)(2906002)(71200400001)(41300700001)(4326008)(316002)(54906003)(82960400001)(55016003)(83380400001)(66946007)(66556008)(66446008)(64756008)(66476007)(122000001)(86362001)(38100700002)(76116006)(33656002)(5660300002)(8676002)(40140700001)(38070700005)(8936002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DJ566GWXVDxGJ3fUqJTG+Om1M3TAfjRnOEbmQNuBzrPcGmU52EiYt7aKEqIq?= =?us-ascii?Q?v7XW4u/NS2sFcvjVtNAqDELqycOFDTcWYVJOiZMDebdSm2sO4Zwcl3jVfCcZ?= =?us-ascii?Q?v5g4wmBnYI0UlbT4jPegY7R3dYPsl4JEFSR2Kb74OYar2+HO4keQLVVkWEAL?= =?us-ascii?Q?4dvjNIkEJq9rsT+79Cv4CYF64Xfxy9UqJ5o6utMgVFOfZc/88OBkNy/A/HG8?= =?us-ascii?Q?m4kvrBfeKwPOtZ0KpzwndnX9RQYcDXfahJeL3TocBjbv3D9GZT6fSrQJmxPC?= =?us-ascii?Q?qjqdbbNhsA82B7iOx9YibrBogf3vPQ9SIJFb9pZfzeB1/YqeC8oN2Y+JCbCy?= =?us-ascii?Q?fFyQyBjB1+mD4YJ1iWgtXpqVn4zCr3Q/TL1O/whQlwqASwf+aH3+qQqHaAB2?= =?us-ascii?Q?2ZWp72tb2HI6wr9iI5y5ReEEmNK62u27VUnfToWhwQQxJVmOGk7z1f79/IFV?= =?us-ascii?Q?slr8PMr1d57gLhpABsJW26J1tEy1qmT/MKNZERCGHNhkJZYJGNM4tthpmKIl?= =?us-ascii?Q?zb4VOTHCuWWXluYBYoEV4/XjF8gPNGHNcc51uCUpBo0Hkkh9yVr/DwcuENpx?= =?us-ascii?Q?gR17MZbO9+gLenFB8DyVYL0Y4Tz7vorjle1lkEsjg50Mt9v+QR2Nf90i6vbZ?= =?us-ascii?Q?IJ8an2fkLWsGMsf+EXgdgATfROd6KKGvsmiAjLU9cViEjSeAlplQqg2GZ3Pq?= =?us-ascii?Q?gIv4MV47afKqE4IFMY1nHnkge2L87DohZtwbRZPQ2Fwi6ip1UnYLVGcZ2tih?= =?us-ascii?Q?YqV0/jxG9BrHoLVXLLglycsgPkUtGoCOaICfJgcy2pC2bQRnulalDMZuo8h0?= =?us-ascii?Q?rGZ7QjjvCHCUSCCmwsjd20vNPZhsIhO8ZK6EHpGBvc58leiPE0sFiuTV8blV?= =?us-ascii?Q?6T8nXPGrhRq5INmruGkhCzlN/MzZ4Z7TFgsSXrSM/+bMUx3WEU4oyHGmdVGr?= =?us-ascii?Q?x041fTEHCo0prxicTMhLvMMNfW4/n/KkMPRBrLV1FJZTA+wnS39G2uLoiku1?= =?us-ascii?Q?jYjq3TRjPOWlJ17q3R03ZnoldYC4nBZoQLJNdPXOvyJPTfEBieQedzylxwaA?= =?us-ascii?Q?HwvDAMk3s1SeDsusTn2lmpmdRQSC2QqXKu+ccZRwhw9QAQTcfIaXwrdzVU87?= =?us-ascii?Q?tDYQqCUeLRJ0UZMTAErp3An8pBkqudCEkpZ3GNB1avxuN8zT2xHxyF6GkgkU?= =?us-ascii?Q?nsHfD1b4dFRp87NlZ1EScHpfEzRE0u0d8EVVdvIL7AkE7ZAUyeWi4OZnrh0V?= =?us-ascii?Q?FPccDSGw/25Iv+ZB9WLfpcHNidotO9a3lfYwYi/Q0bg6HSEnGvv6lW8/htGl?= =?us-ascii?Q?lezpkUHd8U/vWKZouHqQnDLCJauIFnR8UqTEV/fSu4aKo9/RADX4PlqQCGYv?= =?us-ascii?Q?T06gXwVdoKyPLwo6jEVZO2+Q/UTXwGncupwJsElzIjI0gqo7kTh3pFnIffnc?= =?us-ascii?Q?kK6iOwPA4jLyJlXyZ2wdX0RhXLszsytKGdPzHwvC5vSzTJyAB2jISOgGBeSn?= =?us-ascii?Q?AQdTS4kJuyQiSW612mQBFSj9418ExMl93kip0Ofiw/l/uKTMUdi6YeM6ATYW?= =?us-ascii?Q?EmsmJxZNdNE+qSy02e9fyj2/uGGHOgK0mxaZGtiR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93b688d9-9e64-4c3a-97c6-08db345bf5c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2023 15:56:17.3057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8ZL9CRW1O6W2sXTKOCycn3XHBQTvAe/J3WSdBBQknSWqrw8k1QQHmwAeOHOk2CoWTZNdgs/CxhXWTa/NC6LJGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5493 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram I amended the author to match "Ramkumar K ". Please cor= rect. I am not sure if it is git config or groups.io that is mismatching. = You can do git log and see the delta between author and your signoff. Thanks for fixing the enum. Regards, Isaac -----Original Message----- From: Ramkumar Krishnamoorthi =20 Sent: Monday, March 27, 2023 4:04 AM To: devel@edk2.groups.io Cc: Venkatesan, Selvaraj ; DOPPALAPUDI, HARIKRISHNA ; KARPAGAVINAYAGAM, MANICKAVASAKAM ; Ponnusamy, Suresh ; Ramkumar Krishnamoorthi ; Oram, Isaac W ; Desimone, Nathanie= l L Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Ao= wanda platform to 0x81 and 0x82 Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and A= owanda platform to 0x81 and 0x82 Fix to resolve the boot error - Change the enum constants values TypeBoardP= ortTemplate, TypeJunctionCity and TypeAowanda in PlatformInfoTypes.h. Changed PcdBoardId as 0x81 and 0x82 for Junction and Aowanda on respective = PlatformPkg.dsc. Cc: Harikrishna Doppalapudi Cc: Sureshkumar Ponnusamy Cc: Manickavasakam Karpagavinayagam Cc: Selvaraj V Cc: Ramkumar K Cc: Isaac Oram Cc: Nate DeSimone Signed-off-by: Ramkumar K --- Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc | 2 +- Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc | 2 +- Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc b/P= latform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc index 8761f8b56a..fa4cfc09db 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc @@ -49,7 +49,7 @@ gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047 # = Built in messages: Error, MTRR, info, load, warn, init gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 # = This is set to INT3 (0x2) for Simics source level debugging !endif - gPlatformTokenSpaceGuid.PcdBoardId|0x26 + gPlatformTokenSpaceGuid.PcdBoardId|0x82 [PcdsFixedAtBuild.X64] gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear|1900 diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.ds= c b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc index 8e226c1552..f934a456dd 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc @@ -49,7 +49,7 @@ gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047 # = Built in messages: Error, MTRR, info, load, warn, init gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 # = This is set to INT3 (0x2) for Simics source level debugging !endif - gPlatformTokenSpaceGuid.PcdBoardId|0x25 + gPlatformTokenSpaceGuid.PcdBoardId|0x81 [PcdsFixedAtBuild.X64] gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear|1900 diff --git a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h b/= Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h index 0c14a2409f..ca96ab3304 100644 --- a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h +++ b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h @@ -69,7 +69,7 @@ typedef enum { // // Vendor board range currently starts at 0x80 // - TypeBoardPortTemplate, // 0x80 + TypeBoardPortTemplate =3D 0x80, // 0x80 TypeJunctionCity, TypeAowanda, EndOfVendorPlatformTypeEnum -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .