* [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
@ 2023-05-15 5:54 Rebecca Cran
2023-05-15 21:22 ` [edk2-devel] " Isaac Oram
[not found] ` <175F6E02C829A330.20583@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Rebecca Cran @ 2023-05-15 5:54 UTC (permalink / raw)
To: devel, Eric Dong, Isaac Oram, Liming Gao, Sai Chaganty,
Nate DeSimone
Cc: Rebecca Cran
Add EFIAPI to the implementations of:
BdsBeforeConsoleAfterTrustedConsoleCallback
BdsBeforeConsoleBeforeEndOfDxeGuidCallback
BdsAfterConsoleReadyBeforeBootOptionCallback
This makes them match the prototypes, and avoids an -Wlto-type-mismatch
warning.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
index e866f70bc336..bc80badb3e01 100644
--- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
+++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
@@ -1273,6 +1273,7 @@ BdsReadyToBootCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsBeforeConsoleAfterTrustedConsoleCallback (
IN EFI_EVENT Event,
IN VOID *Context
@@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
IN EFI_EVENT Event,
IN VOID *Context
@@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsAfterConsoleReadyBeforeBootOptionCallback (
IN EFI_EVENT Event,
IN VOID *Context
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
2023-05-15 5:54 [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Rebecca Cran
@ 2023-05-15 21:22 ` Isaac Oram
[not found] ` <175F6E02C829A330.20583@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2023-05-15 21:22 UTC (permalink / raw)
To: devel@edk2.groups.io, rebecca@bsdio.com, Dong, Eric, Gao, Liming,
Chaganty, Rangasai V, Desimone, Nathaniel L
Reviewed-by: Isaac Oram <Isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Sunday, May 14, 2023 10:54 PM
To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
Add EFIAPI to the implementations of:
BdsBeforeConsoleAfterTrustedConsoleCallback
BdsBeforeConsoleBeforeEndOfDxeGuidCallback
BdsAfterConsoleReadyBeforeBootOptionCallback
This makes them match the prototypes, and avoids an -Wlto-type-mismatch warning.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
index e866f70bc336..bc80badb3e01 100644
--- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
+++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook
+++ Lib.c
@@ -1273,6 +1273,7 @@ BdsReadyToBootCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsBeforeConsoleAfterTrustedConsoleCallback (
IN EFI_EVENT Event,
IN VOID *Context
@@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
IN EFI_EVENT Event,
IN VOID *Context
@@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsAfterConsoleReadyBeforeBootOptionCallback (
IN EFI_EVENT Event,
IN VOID *Context
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
[not found] ` <175F6E02C829A330.20583@groups.io>
@ 2023-05-16 19:54 ` Isaac Oram
0 siblings, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2023-05-16 19:54 UTC (permalink / raw)
To: devel@edk2.groups.io, Oram, Isaac W, rebecca@bsdio.com,
Dong, Eric, Gao, Liming, Chaganty, Rangasai V,
Desimone, Nathaniel L
Pushed as acf260597a..15f27d5c30
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Monday, May 15, 2023 2:22 PM
To: devel@edk2.groups.io; rebecca@bsdio.com; Dong, Eric <eric.dong@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
Reviewed-by: Isaac Oram <Isaac.w.oram@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Sunday, May 14, 2023 10:54 PM
To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
Add EFIAPI to the implementations of:
BdsBeforeConsoleAfterTrustedConsoleCallback
BdsBeforeConsoleBeforeEndOfDxeGuidCallback
BdsAfterConsoleReadyBeforeBootOptionCallback
This makes them match the prototypes, and avoids an -Wlto-type-mismatch warning.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
index e866f70bc336..bc80badb3e01 100644
--- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
+++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook
+++ Lib.c
@@ -1273,6 +1273,7 @@ BdsReadyToBootCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsBeforeConsoleAfterTrustedConsoleCallback (
IN EFI_EVENT Event,
IN VOID *Context
@@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
IN EFI_EVENT Event,
IN VOID *Context
@@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
@param[in] Context Pointer to the context data registered to the Event.
**/
VOID
+EFIAPI
BdsAfterConsoleReadyBeforeBootOptionCallback (
IN EFI_EVENT Event,
IN VOID *Context
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-16 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-15 5:54 [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Rebecca Cran
2023-05-15 21:22 ` [edk2-devel] " Isaac Oram
[not found] ` <175F6E02C829A330.20583@groups.io>
2023-05-16 19:54 ` Isaac Oram
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox