From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.3072.1684185743765472501 for ; Mon, 15 May 2023 14:22:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=b9MKhSCR; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684185743; x=1715721743; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=agR1xtvJjYcZwDwuBSmzmltKfD6jBZskOeDHRau2tAA=; b=b9MKhSCRhp11+cAvNVw7y6wUek+nUy8kmE/F2UR2FXdrf3lO3Zobf8gr cYpXVUp1LcYWVONx8Z/dYwD/zZEcGCoeue0WzjP2mMoIkte9gPVw8Orru 5q09n/9CT+IKdrat7qRzo5jMz8fA95zHip4AH4RBY093jNsxdDcHPlnMf WqEQPizOw3q2LHu4yeXBZLyFIE7YCzGcU+LcJyrgcF1VVFc+dFiwUCuxt 1V4E0kOYTSaAn4kCqiUV2OevaLTSy18h+aXqui5aOLuuAj0uJa5a3OhvP uQvCpn3BIXYe7wEnqUdoh3eR0fsfUtqoaMlRUi8hJQ8UTBDMaaBCZm8S7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="350152464" X-IronPort-AV: E=Sophos;i="5.99,277,1677571200"; d="scan'208";a="350152464" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2023 14:22:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="704123404" X-IronPort-AV: E=Sophos;i="5.99,277,1677571200"; d="scan'208";a="704123404" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 15 May 2023 14:22:23 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 15 May 2023 14:22:23 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 15 May 2023 14:22:22 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 15 May 2023 14:22:22 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 15 May 2023 14:22:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFsCM3oTZZ9BDBBUdbyxxINHYi1ETGk23EMO+IAlsFwYIBwO6kUo35OxC+ccLaSJTvK4tWMzfRoBjyaCeABONjaSPNGc/vgGTvy3h61h1HbB45Qv21d+4CG7goIM8FobisdoUI5zivdxBkD5vm/naS34mCV5rqNXf5TJgI5YSbqyUR+HSQnBouyljWr5rL4sVDMp0RAL5J0OCA0bmTVuMtEptyLiaYTzOVygsnQ19nORSLba8a7hc0bwJwk3F4TjsLzb0A1/u3ZW8HzNrcIV7wsmM0UlHriSusyDjeZ5wfyrQh2tdNp6U1KQu3rC9+xC6SZ6EZ5112S4whDj6bP9vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgPUPmNLs/23PZ+JxGUTqFAq1hSZSUy1XzkUGwZ6+8E=; b=fTR2I1snpNFQvhU/SU4PQ0V61COrWJQqJ/j4WOfhDnMYUJzj/+Kk2Rnr1YjrTF82J+lRz3wJLSEh5qG1l1mGm6wBKi8Cf3pN8/D+TUjJWpT/MqJzRXUe5LNoJ1x536RV94NslbOsWLD9T/4Pdmdn/seq40Tn02GVAs17/HzvuuRytw4l7L1p6DWTHzoVtRnklDEVNOLXwYOmfq9VJcEiNgjA/LHc6zBCmsol5pIwXEmM/RlGCiPu9G8NXjPYOexMqwkOcqXgYRDYHepFjtOE8uVViuU8AZbULr71ADDDI7AK84IbVECo5E12FEfulPD5+5kz5Nf1khiuQ4CUy5oDCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by PH7PR11MB6330.namprd11.prod.outlook.com (2603:10b6:510:1fe::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 15 May 2023 21:22:15 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6387.030; Mon, 15 May 2023 21:22:14 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "rebecca@bsdio.com" , "Dong, Eric" , "Gao, Liming" , "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Thread-Topic: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Thread-Index: AQHZhvHATL2oyLC++E2kYEpoj97Uha9b2JmQ Date: Mon, 15 May 2023 21:22:13 +0000 Message-ID: References: <20230515055421.3241932-1-rebecca@bsdio.com> In-Reply-To: <20230515055421.3241932-1-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|PH7PR11MB6330:EE_ x-ms-office365-filtering-correlation-id: 931a4779-d1a5-4b1b-22c6-08db558a73db x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NUevuGhfo2pAOwMNrHUVviL2P13O7BiIK60O4xAmasDEXAGy0kmgAh0FYN9zRIAardRfbkCgayj0UvAq/36rOnnqsptdm8OW7YMvOxeeYZFRVL65UHQxIL4v36uTvM9MM01M3CZdI47tgmjndsrK7ZFpumYTdPz3w54QA1yPooGYp7FCGHcWCNO51XcCusX3jTyqgeIVs2qOt9NSxfjprKpbg5jQU07jyxytGR9d/ZWeKrs8n/ScKLBBr9STqcphkVyF9Y1SC4zHkR5ET/1u3Cs1wJ0F6k09JTuvOxNLLe0DNKzP2XER4+pFpWt3CGSL7so6OvqCKWENKiLuQin17MXkGdXA3IoNrGHjxG1xRMC2J7zeuDQzMhVj6qzjRndNs5lKuIiJKunn7FjGqG7fvECJ9ZQY/IeWD9MQXA8M5en8dxLyL8osgcmWVJ+v5QEeLlK9cCD1bQZUyK/oiSHk6iuPW4Jy0SaQakeZFVUEAmc1ZPPG/ZI14eDsPq4elu9FYJfQY/uT94hAdjvSzWs0+ExcKJwcEMx/2HbHiF2G5EtdiTODL3BGKe3asB100T4OwPUJLGf2NXRc7cjN+SRE0lZfmHv6IUbhou/nTOjKUqU3Iq/HR5hGLDxHZU5xvkJ2qXWdfOK928otu8F/rPdAlWo5etCLJjHsi6Rs4dfAhUE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(376002)(136003)(346002)(39860400002)(451199021)(2906002)(478600001)(41300700001)(316002)(7696005)(110136005)(66899021)(71200400001)(8676002)(8936002)(66476007)(66556008)(64756008)(66446008)(6636002)(76116006)(66946007)(5660300002)(52536014)(966005)(6506007)(9686003)(26005)(53546011)(186003)(82960400001)(55016003)(83380400001)(921005)(38070700005)(86362001)(33656002)(38100700002)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y23YlHWyVaPYQoSRbNMvBVNJYmmyqvNqj+VC3U1ryAl/S75eH+L/7JFzL066?= =?us-ascii?Q?OGxbBlO3yKIyg2pGKPNwGBSvF2f+ucR1s2T2T8ccPrb64criM31+a+CypBHK?= =?us-ascii?Q?/8BsuippqwJSd+6xTl9JlEyCTZPdKabPiIwchip2Tzhj7ZMYN14+H1PNnNGi?= =?us-ascii?Q?Bix+5KrJ4vIXCpYjHYzrkJ9Lfpb+Yt4MRyttKz63Tkeq19xdLXY90CgbcTvN?= =?us-ascii?Q?B/6NToNPUJL8ctRfkySZHpVp0Za+8svEm3RFyz1eX8su8+WIKb6aqVAZeO6/?= =?us-ascii?Q?33EBitsa/eyAOEbzgjfqhcxiHF0Ol+qnhtDANsTZEUc0rFsSQO/mEyXilPsE?= =?us-ascii?Q?FK6tIA0U36MXR24BBanXk4pOfE/abvy8BE9y56s+XNAIrfGTyFE7nlF4ieaO?= =?us-ascii?Q?pC8oQnaRg6swqHu5uGCTI7uO1dfPutkP3evUMD/ROuA2O+XSiFgx3+jnNyHz?= =?us-ascii?Q?4WUK7HVO99OdtbUII75p7tm4k5ZUp2BUvQQZsBucWpabgjxHzLf/VICxL41Y?= =?us-ascii?Q?YYq+PW/LSZjSrPF4U30VNEfwuu+0DWLs7VGgY64KsYG+ASkY64rze7Z3+4TW?= =?us-ascii?Q?DvjJRNB0XbXT6+QCL2Db1j3GogYKYPdcmOGmbAvghMSI+rGzJrMbuwxK7moQ?= =?us-ascii?Q?McxlODRlPre84atgEHRdr4WdLJyGWJFqTGD6RIbtQowLYWfOBzthqsXDq5oc?= =?us-ascii?Q?kse3fyjLhDdEfi72c410Utp/QGEvdqLFh11z6W3Yr/VqBiWzuIfUpfWBIdp2?= =?us-ascii?Q?/2aWG5jV6PV13a5j8/qT27IjHDEG/f7cWDuLmS9b2ju8rcHIeshubH+HN44X?= =?us-ascii?Q?t+s3Gee/onHhtL8zQosS0/A93rvCFObLgv7eTdMBo7NJ2QrTSJuT0tfFlBUR?= =?us-ascii?Q?WnitR2T4Ppfp9s8Ta3VDrE+E3XNR7IfPpzvgoluXty1mGu+1r6wzuOHgx5o1?= =?us-ascii?Q?3PKj6xyXRNK0hXrk6WCBzviYPRUggxgeVR9BE0QC/SNci1dUs72C5p1fga9A?= =?us-ascii?Q?pTChvdy2z5633omP3Z9JOZJHyWvZar97liCrzbYCrk17a5+lmONE5NRiXAoT?= =?us-ascii?Q?Ook6cLUqcGxUOb4lf6Har4N0hyifZYnrg5TBLAPP1MhKBYI2EqtGuiQyW4LD?= =?us-ascii?Q?K9FHU3PWg1Hfn4TKOd0XbsrtayaQlJKNDLHM/jmKjDxy/3oqndFCfgXyXecD?= =?us-ascii?Q?znH0wf2QnoFfwF7ToNB1p6lI6BrSd7TF0z9yc3RYldt3a6Sot8Qv5HYmepQp?= =?us-ascii?Q?V/A/oPAHV+TMAa1cPpltLw4aCxXRS0hQsVg9A1L7ajywmGjNCKj0NbdyOcWe?= =?us-ascii?Q?wzn8GyMFnSxpNL0xS7322dZkhxNzdNXNqGLG3NKiWy2RLc+5w31Fupin2A5A?= =?us-ascii?Q?vp6RD5io1geAzmtLh8my7G24WnnL+yqwreubSNR2TfPcZWrz53JfewgAc8MD?= =?us-ascii?Q?saNLfkarAEdXcSfA397kMZYKWZ3yGBe4r3GQXlZcKQxGmsa3KA7SQjEZ480H?= =?us-ascii?Q?6I+O8fvnOb99qx/xLQIsNbn+jZdcjatZ9jbMiw1Uly3OZpohW/A5N7iCrVxq?= =?us-ascii?Q?K1so0x5SyFgzBpKJHsjFPe+Y+qn+ssrXTeOi6ab8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 931a4779-d1a5-4b1b-22c6-08db558a73db X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2023 21:22:14.0387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oAmD/QvxAiTbKkkWahrGgmfVn5m6D51ImTvg+ScGBpNmklDqMXHpXt53eeYAfdXPB2OmKGtMFuKFLMUGLDmhLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6330 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Sunday, May 14, 2023 10:54 PM To: devel@edk2.groups.io; Dong, Eric ; Oram, Isaac W <= isaac.w.oram@intel.com>; Gao, Liming ; Chaganty, = Rangasai V ; Desimone, Nathaniel L Cc: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type m= ismatches from prototypes in BoardBdsHookLib.c Add EFIAPI to the implementations of: BdsBeforeConsoleAfterTrustedConsoleCallback BdsBeforeConsoleBeforeEndOfDxeGuidCallback BdsAfterConsoleReadyBeforeBootOptionCallback This makes them match the prototypes, and avoids an -Wlto-type-mismatch war= ning. Signed-off-by: Rebecca Cran --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | = 3 +++ 1 file changed, 3 insertions(+) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBds= HookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsH= ookLib.c index e866f70bc336..bc80badb3e01 100644 --- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib= .c +++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook +++ Lib.c @@ -1273,6 +1273,7 @@ BdsReadyToBootCallback ( @param[in] Context Pointer to the context data registered to the Even= t. **/ VOID +EFIAPI BdsBeforeConsoleAfterTrustedConsoleCallback ( IN EFI_EVENT Event, IN VOID *Context @@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback ( @param[in] Context Pointer to the context data registered to the Even= t. **/ VOID +EFIAPI BdsBeforeConsoleBeforeEndOfDxeGuidCallback ( IN EFI_EVENT Event, IN VOID *Context @@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback ( @param[in] Context Pointer to the context data registered to the Even= t. **/ VOID +EFIAPI BdsAfterConsoleReadyBeforeBootOptionCallback ( IN EFI_EVENT Event, IN VOID *Context -- 2.39.2