From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.1776.1657237937234567973 for ; Thu, 07 Jul 2022 16:52:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=O18kbcqm; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657237937; x=1688773937; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=owCLuW6TjaiEgjxTBoxW3JFwt/aDMvZtHTUY87Lc3oo=; b=O18kbcqmqk4T5Ip1pDsJJhY+0TGcmm+QrTVDDI7dZAlEKExdwvxQX6lS KfPc45gVJ/Y9UAaFWNS5JjnmYVWvSQL12xm6SF+ZisiP8Zev4EBe0I05p qhCKyVa4lex7fThm2KL7X1fflYcmr/AxMx5JleFVmvNF2YQOVVf83CWMI Ho97fQNyMzcRcV4C29hfVkIldauBeZS8gt80lXOzrQx5J8m/XYz+WZufK Tk8x4A2rlZXSARsO4h6kY447kqWZtJzGYSTYbOf9Fw7glFN0y5LJ4P8tL eGhJMZwOkr5Q1GZcRc/rVRob9b5eLBQlwY57FRbmCe6I6p3Ku2X2jSkHL w==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="348130586" X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="348130586" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 16:52:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="598194326" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 07 Jul 2022 16:52:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 16:52:16 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 16:52:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Jul 2022 16:52:15 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Jul 2022 16:52:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q9bDc1tH7uGdFmiiR5FcCoS3l9X1Euw0oGaDahGRr73fwNj35QXzW+morDxB3znfCyrmkLZeTWWyBXqgj0qdLlVp+Bs07S1daWHASKYXg0xDBIiaSLgth50RzFreUyNGnRpp2Fkn2pBgmN3PEaIoGIS3dMdavXbZQmGl8Ym+nhVp36XxIM44MkOTy7MgRx8/TxW+CoA3RiR29wRbTpW7qBBH8zODuetWWF5sR5NAZGtGapKJZYYlTOuKi330gsUDVuZdDS4af+vLXtTeTh+lumNp8sY86UZZZJreO4s4dANAt0zb8AIZo46xpdZXn7dZDdvjuX29E6qK2d1h0e4jng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tAUxSacZq2Z+ygnt+E1QK1u1+Uezi5C/i227c0RFJMk=; b=HJ+kIVFO43iniAe7R16fDVFzNI9nb7nQM/CC2YfoHs7HvQVAO/LEOI57Y3VX2TRHVgN+IzqzyNgDUGDWBOf5H6tiQpR361DZ05CNWv7jyRC6cF9HSeaLzKnfGlShJJFxRErTTc9+etArYCGGkTHJ+xJUk0ZrJGWWh9JezeFf0fwKcyE4TGiydglR4kp5IofNHibUkiBhlvBVzZL8Id5EtlTzGW6Y4ZqEbUpqy8mJrK44hdjjJk8+tBg4vgSMgXmWvk6LD0cMI9TCAib8+eQV/VHx2HlOvihuKkHDwmA90ld0HwN3nQ1m+92H9LBsoFFmbSkHExKOSh570/JLUWc9HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by MW5PR11MB5859.namprd11.prod.outlook.com (2603:10b6:303:19e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 23:52:14 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::c815:3a9e:d7a7:49a6]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::c815:3a9e:d7a7:49a6%6]) with mapi id 15.20.5417.015; Thu, 7 Jul 2022 23:52:14 +0000 From: "Oram, Isaac W" To: "Sinha, Ankit" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Dong, Eric" Subject: Re: [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs Thread-Topic: [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs Thread-Index: AQHYkifQar8rauqcpU2I6ku6wO37Ja1zlNMA Date: Thu, 7 Jul 2022 23:52:14 +0000 Message-ID: References: <20220707173330.2066-1-ankit.sinha@intel.com> <20220707173330.2066-7-ankit.sinha@intel.com> In-Reply-To: <20220707173330.2066-7-ankit.sinha@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b93dce9d-2ea2-4f37-e6de-08da6073b79a x-ms-traffictypediagnostic: MW5PR11MB5859:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H9ig45ERQZ7wf0JRjTU4U/mdd+G/wW55UsDMIonEjL+cHfzx2GCMeVAFiQdo3dDtw+jf/5OgWuDO/o2zNPO8xq6L/AzVBN4P8HlW9T06GL+h+pl/BsryK9MI/ZrzNWXaaytJpfGW8/Q51OP5X0Me1pF3lhet8FJjvjpICAzgfN1YPTR6CD0iJhmEVjsraPIJCB/2XqsSTch6uMKP3UGLi4xmiOna48Ug9rbjyqxyo9+YdQTZ63Gbd/DbRIe55uD5x+vjHKwzzAFEgtfj9v7ccAx83dhtO0ljqq93nEQLedPzAUqqQX3TUUSKYVWmCiwgSgnQPxSNXSPTs6aBcFj8tpAouZg4XJ5vjCveIkwZAy3F3oavI2c6HX8eNjxlojKdH8m/Iwn8Qco9VM/gYrY5w5N3U2udj+vx21CA/OztbcUf74h3aIVfCEqXmcXD9jJYc/rASPKlehICMeQEPRHksjkE/ZizFgQqaJf4s8ng+Rx7PlaYpvejbPQPwypF82ewbDv16OfSzF269Ul0wVUojCiyczGPlU+WV+ind57UC0j1XR0OoEOsxAdseP+EbAzqTscOcFWn/z5z7/IX7uNAgBmIUB0SpTAQ1bkx3mYt8sld2vzeA9e1qzn9FAzH3R+I5pDBd72/9TWn3B2G4y3WS2BYKZ27fwLtoabSCHPYjOCnvKYD2Rk254aesuqd3Jan72BCt9mBpW5NHOO7YRbwXKKv9DhoG7rwFdksRHTDypm2fpRNdBS1vpYNotcJ5QQPuMUB25We8QS26jbSJmZQ0bvLr/BmpMi1csa2rAgixhiRn87OLCgf/B3k9L/eSosP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(39860400002)(366004)(4326008)(66446008)(8936002)(66556008)(71200400001)(66946007)(8676002)(26005)(478600001)(76116006)(7696005)(110136005)(86362001)(55016003)(6506007)(5660300002)(52536014)(33656002)(66476007)(9686003)(64756008)(2906002)(54906003)(186003)(41300700001)(316002)(53546011)(82960400001)(83380400001)(122000001)(38070700005)(38100700002)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c4OuuetW7TdOKXMFGigRLQXuC7LFQofF+s5iEgwX8lG8GaejixQl8p+7EoXK?= =?us-ascii?Q?j1d10EGM6ipJmKFx1LL+eAJ4LeVR2lmgxlux+3XsrzrCc26S7JQ3JtlpXvqD?= =?us-ascii?Q?sFT+v4RD2Qu64XYUWjHsQCDO+hgugM47jyy1+slfnZEKj6VB/Y5pCxCLtFP4?= =?us-ascii?Q?n54dlGz6pp/6hnbDjjOOY+wjygnM0DolwewUAYoSkvheSOs8U4fvPim3YPw0?= =?us-ascii?Q?8i9A9volLBS4bPSQBN51bevT86+lONd05K8fp5OInBicAleUhSTMufovrCzO?= =?us-ascii?Q?uoceIKQ+y8oLMwhvvd7hXQC+Py9819uAwalAkEPnGJGjw6b6+idq27iILL4i?= =?us-ascii?Q?y3DK3G39aINtJ9i+zEJr5pZrTaI/opALpAK5kx37AqffsuQ4uHxWCxG9ySiI?= =?us-ascii?Q?TKMNFfm0pjZajeF3brkUTLzX/Ad2q/PBRnsa4Ml3RBjSo5AtFyaknjw6NKUE?= =?us-ascii?Q?4AzcA3YzcEEGr3xNWmefQoF0OjyPwa7QdNJI2VLsLfx5WiGGY8yAApIBoh4D?= =?us-ascii?Q?ZhuS7AcI/4eDM+yXlYPlcX+JLqx+HugLDYj5r3YD/XCOe1AIvPSjbQXYB/bC?= =?us-ascii?Q?25CEhBKjGZAUQA/hR9LDm60zdymNELnTy6bRdof4XWPzelpM8xNyDl3tdiTl?= =?us-ascii?Q?nsDwudidVbjZy0+UkQKCo2nGcfnr50BSc4M4iLSOZkFEDCKbs0EZYFAjZfcU?= =?us-ascii?Q?vBrdf71iEYH8/vFTCxPBoH5s21wMfY/SzEv/5n0qmBLJLpR+HQuTvfn0gplU?= =?us-ascii?Q?wYddC9/YbCoSn5O3h37ZKXUcyP6L2XM1sot+Xs4LxD5uEkZ+iQdF0PrYRjP9?= =?us-ascii?Q?TnOWv9TC1OPGZnEhSqeYBQTYPJnIoQ30uXneS1FwGhPCCp5FYHRaabWxZa/r?= =?us-ascii?Q?Oj+3WNKOeAtu2LVn7zX0bzjzNLXAOAlBc10M7/PE3g6p16RTP8SkcMW1nCBA?= =?us-ascii?Q?7pCLddynpjCvNnnERs6MI+wPxVzx9G4ke/yXa/kV4EUxJxRXR+TXScMQLB6c?= =?us-ascii?Q?N8uzfMGSWv0bJM22regK7x52LlZMdFCHEeI7prZJOieu8Blg0ake3X96RI5P?= =?us-ascii?Q?KGSNw+lsMeZAlrEgtZjTQHRctw+/kDx78PWtxFsPol7RCwIitQ8CppqrIFkc?= =?us-ascii?Q?idhzu2wxnFjGX6j7a7OaJrEe0fz6fkLTsbMhEwdMdutVgciuDoBHEfOeK3JV?= =?us-ascii?Q?3zpVAyfe7qXYTOaXsmYHh8V/vmjN1J5EGUhdWHogq4ZgOgCAArfgd9QMQ157?= =?us-ascii?Q?8hcDiNfiW1WWEBBCjGCsxjSwUUB7dsUrC2Ym3h69HUxLywMiof0eK1lDPI/g?= =?us-ascii?Q?ZIzM9n8dPvzZUxWr2eYazUjM3es8zcf9KXXGcFIWm988BsYp6WGw3TJV/vOF?= =?us-ascii?Q?26Cuzuc03C59nnPDuVpOfnPl6kgxAG+l2pyJrwUgtLAONUBopxErz97lzEyp?= =?us-ascii?Q?5iOXpoK8hrTvXbnL7HwTz2PMXHGXYikEWF/Geb4k+8W6hCTC6jDny9PxbK2G?= =?us-ascii?Q?XzeKt6yt291PzLfpfOLYm8hI3sKlxMcEVuF0MMkvOiC7FXMqEEpxC8YhHzk/?= =?us-ascii?Q?CnDaduEbQrbPlbZQMpOefmd04E1NBLg9CJF87VPu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b93dce9d-2ea2-4f37-e6de-08da6073b79a X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 23:52:14.3608 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mXzzboQgi4ZT84zrbH7o6WYOASTvw5BASCgVKDkB9Of6C6uTgkERleNYYaFl45g6ynqzO9i+NVyz0G9m5CJWqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5859 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: Sinha, Ankit =20 Sent: Thursday, July 7, 2022 10:34 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Dong, Eric <= eric.dong@intel.com> Subject: [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-catego= rize ACPI FADT PCDs From: ankit13s 1. Removing ACPI PCDs that were re-defined in board package 2. Re-categoriz= e PCDs based on MinPlatformPkg definition Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Eric Dong Signed-off-by: Ankit Sinha --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 16 ---------------- = Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 7 ++++--- 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.dec index 7d8e0f34a104..fa2d61c9a71b 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec @@ -237,17 +237,11 @@ # is large enough to meet PEI requirement in the S3 phase. # @Prompt Reserved S3 Boot ACPI Memory Size gPlatformModuleTokenSpaceGuid.PcdS3AcpiReservedMemorySize|0x8000|UINT32|= 0x90010039 - gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x90000012 - gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x90000013 gPlatformModuleTokenSpaceGuid.PcdPcIoApicCount|0|UINT8|0x90000015 gPlatformModuleTokenSpaceGuid.PcdPcIoApicIdBase|0x09|UINT8|0x90000016 gPlatformModuleTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000|UINT32|0= x90000017 gPlatformModuleTokenSpaceGuid.PcdPcIoApicInterruptBase|24|UINT32|0x90000= 018 =20 - - gPlatformModuleTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x900= 00025 - gPlatformModuleTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900000= 26 - gPlatformModuleTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027 gPlatformModuleTokenSpaceGuid.PcdLocalApicAddress|0xFEE00000|UINT32|0x90= 00000B gPlatformModuleTokenSpaceGuid.PcdIoApicAddress|0xFEC00000|UINT32|0x90000= 00D gPlatformModuleTokenSpaceGuid.PcdIoApicId|0x02|UINT8|0x90000014 @@ -438,16 +432,6 @@ # 0x7F, 0xFF, 0x04, 0x00}
gPlatformModuleTokenSpaceGuid.PcdTrustedConsoleOutputDevicePath|{0x02, 0= x01, 0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01= , 0x06, 0x00, 0x00, 0x02, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x300000C =20 - - gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800|UINT16= |0x00010035 - gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x0000|UINT16= |0x00010036 - gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x1804|UINT= 16|0x0001037 - gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BControlBlockAddress|0x0000|UINT= 16|0x00010038 - gPlatformModuleTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT1= 6|0x00010039 - gPlatformModuleTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0= x0001003A - gPlatformModuleTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x00= 01003B - gPlatformModuleTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0x00= 01003C - # # UBA_START # diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc index 8c4b9cf6ce28..cefee8273b27 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc @@ -397,9 +397,6 @@ gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000 gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicInterruptBase|24 =20 - gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04 - gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0000 - gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000004A5 gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE00000 gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress|0xFEC00000 gMinPlatformPkgTokenSpaceGuid.PcdIoApicId|0x08 @@ -510,6 +507,10 @@ gPlatformTokenSpaceGuid.PcdBootMenuFile|{ 0xdc, 0x5b, 0xc2, 0xee, 0xf2, = 0x67, 0x95, 0x4d, 0xb1, 0xd5, 0xf8, 0x1b, 0x20, 0x39, 0xd1, 0x1d } gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0 =20 + gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04 + gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0000 + gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000004A5 + [PcdsDynamicExDefault.X64] gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200 gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8 -- 2.27.0.windows.1