From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.32134.1684266312698471339 for ; Tue, 16 May 2023 12:45:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=lGOF4kAG; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684266312; x=1715802312; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=XFazhIbDP9w0tjAW+srWLSht3BnNKQmiwQm7ESMJFGw=; b=lGOF4kAGqtgzC+Dz5dPDAGy5omOBlKn7l09e/daK4AKXprOoiXO3E85P fwtq9UJuAx697bQKEYtAPVSIob0vOvsncr+VupEqIO7wTj/8+lKD8IX4x ozfT+07k0IqHT2793aurGmcRTkfBiX1bq3Sk4aZb45fiGODWIWv5/aHMI 2cxdnzOGe08QtvisYLoxFobZ+kMSZes8F+6x5XoyLZcIfHXTMXNpIjBh0 f7SJfTXZDsI347bdaPggsV+ezILPk46JwBzFp/5eR2ynew+zWIV1C8DvS jAy7eAQvlb0/SKUkkXVFmJ4QcrkuA3LjNTYlA1wkeftsskJQPsAE5XFDm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="379759754" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="379759754" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 12:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="732103617" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="732103617" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 16 May 2023 12:45:03 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 12:45:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 12:45:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 12:45:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bK7gRjow2LDum/l9NUERTyX0dGKOPkLA/RqbTVtC5o1HtQQgD3OONd1xSaB5O732QLk7WOU5x0WxxIObtIoeHjO/ZHaL8pdnS0a9A3MgeulTL10OClgnb8zdvcy8Gr88JtwLh1MrydPpVPZkd6PfYJ2vXWvqi25rHMpUSTqWxKjbocv7SrKz8zNtC5gVV4rX7SIkQFnn3tsUFx5Az1K1/iJOgZPZBtDev7d4BVTFB/fgNPhHprkPaNVnCRwlpqDrQBL7YBb0OILw7/AoJGUwb+K5XG1RyWnLUMDqZPzt958Vds9fUdRKccrP5uUiQIwOG8gjWZCsmxj4Nd/kho6Ebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tftm1by1CJT0cDtI2Ui2w+m8AqIJmU+fD/1nDtXcAMU=; b=YVjJOibHoeEUNUJvsXTTNLas6OWf8snRFSLMagXGihQj1H65Ja+DHtwru9WiGME2uY+courg/EnlCN4up0mvHYIXuvIu8s8quNZ73jnq4+cM5hRQWjvz9Tn/cTZbeODsR3GbB4eypJYsJ9hG+15HXvozMxRIyr9VZcsJsYduCIIp9gphptYuVpj2npg80KyeDC1kobFFASTNoya+ZP1c79cgsqcJvqNXOUgd6WTGgseW0izt++4MamXlLgYaO0R/ZtmFJGNrsH8uSe/XMsPfYC7XHLShYQznsmIFzHbAD/embfLkQaP3u8pwlxAJEXaJmVcoTc8/DDLQICK7nndbzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SJ0PR11MB6744.namprd11.prod.outlook.com (2603:10b6:a03:47d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 19:45:00 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6387.030; Tue, 16 May 2023 19:45:00 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , Rebecca Cran , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro and unused include files Thread-Topic: [edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro and unused include files Thread-Index: AQHZhzWDkurpzQ5A4EOjDuFIcM8P1K9dTmxggAAA5TA= Date: Tue, 16 May 2023 19:45:00 +0000 Message-ID: References: <20230515135921.3299706-1-rebecca@bsdio.com> <175FB728D423FEDD.26562@groups.io> In-Reply-To: <175FB728D423FEDD.26562@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SJ0PR11MB6744:EE_ x-ms-office365-filtering-correlation-id: 07c53286-415d-4296-64a2-08db56460934 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7THle3AXwn4H2H9pt5geq3jAVhbZs/dg9hJroTCpPKpKElBWZj1MabrsmLFLLHrTCH7hjOEyrDojoQCWkVOhBpXozl9DEZLD9BBfa823X0IzxXmSeHeFd8BQVMRnMOwqEKU5KkpbyCru38Cx9Ui+5CuFgXhgMT+Ovy55iXam837NY+FgvBi/FfDwdgIZNN/HumQqMLhXwDrN3kAImrd73dnp7S/aN8n6OWKp4VGWgK6MNCrtAPRUddsppw/b5cHZMMuRzroeGLbN7XWEkAHflMAmwPP0LSsWcLNG3uyxBw27kFIRS3daqDnWek8WqsYKdowc0CJhyxH3t+2JsdvPfyP7I3bu8KfFY3r4X83gkmZjKfci4t163yVK3Q2Kh/xaherQAaUIV4S948CGAqtdfd5EST52j6bW3sMaOD0s7+IjUe0WJgodXSKPswhmGEFdHyiRQWiuMR8ZSTT1pytOTWRgdEPxE6fzgIQQuJDQjfn73v/6DksNgeRWN5XtRoRZVfNxMuhfjElDN2YA73utAwSIMOTTfCd6f+Ay9UoA74dsV4YZito2SNtzSbTXEUha9UHSFlhQXBdvFEvxDW8ymR1kLMBTADFOeCjjOehZyIMoBb4tVSCULcO82P+v0JKtFeUXuIkh+FGp6uHkL1Ngnm/Xjg3F20frKWHhjdcTbZI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(136003)(396003)(376002)(39860400002)(451199021)(316002)(33656002)(86362001)(122000001)(64756008)(55016003)(76116006)(2906002)(186003)(66446008)(6506007)(38070700005)(66946007)(66556008)(66476007)(9686003)(53546011)(26005)(6636002)(966005)(5660300002)(52536014)(921005)(8936002)(8676002)(66899021)(71200400001)(7696005)(82960400001)(478600001)(110136005)(38100700002)(83380400001)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WHxoXGvhlufhUmHNZGMigklIyJrziWHs3Xzj/aDouFi+MSKc8YaGPlXE/pzp?= =?us-ascii?Q?pyufRVE/05MxRUoCoxz00iFmCC8+akzANQp+r1P1oJo7NZX+HlZEtDC6GZ5z?= =?us-ascii?Q?tzwuMPTTGmdN9EXYuQb+B4uSrOc2N8ae8CbXWBxs9tJDPK9EVxjLqAMyfQkJ?= =?us-ascii?Q?OUSNLjt8zEys2fI3NhNJz4bmCVq8z9mPsrUrFtJYVkz0wfC6QEFYyMn3SYGv?= =?us-ascii?Q?uDSw9MnLcuhH/Cvu3KF0cMPVlEMUC7gfA1ZBUfrcoA9N14ORRCRLdHLXXcjf?= =?us-ascii?Q?WlhVXUnS12T19Lh88xPRnKypnZVdvoCL7pAjzMB7mls3G/r5QzbCBG2FEPAE?= =?us-ascii?Q?6kd1myYx6OIyfL8kvEYnaAkx05ssoRSzSU5+/+CWhQEWfyN+5X+cBWou0Jl2?= =?us-ascii?Q?YDlOAJXdcihQ+8V7tslXCOtiZ1iNRp7OE29jBtrqd8gcriufXRg5H5b7gSrf?= =?us-ascii?Q?CqCyO5eysReiQHDtkxePfe19NX7EdbLnq6J0mqJXq2ktzH4JSJRbDqkVRY1H?= =?us-ascii?Q?QVT5P15zEZTqE75OQHh7AL4xVyCsRGaNLhjqFqvJUSmXyvX8x684EyV2WEOa?= =?us-ascii?Q?C64OKIBT04jhlyMEm4IUF7IgH8SbT/i09ZHgCNtoCm2dx0uIO5V88jxYzCFM?= =?us-ascii?Q?U1WbJo+upw7csnfYRGKtuJn5Q2pN8YFHF6M8UykivwE7M4TspdgXTh86m+7g?= =?us-ascii?Q?KVP/GQQvzBS3BjVafKatM6ZfCCj1CxlA7A0TYajp31KQfFAGIPTjxbbPwTlS?= =?us-ascii?Q?+eYjT6gvVZlZpkg2IDhr1m4X0ye/T7dRjR3qJJIO3HoH6SOgyREWqflZQVpj?= =?us-ascii?Q?YvarmwEsscMXytR3EK6rT7nLV+u9OcMQierRYkawaTLzjLrfBW1iQeqgz+I5?= =?us-ascii?Q?JzompOjSePapUP4Ma5uMUaVwYde9DON+XERJmj6jVZrdbdQh9bOclx4bMuFk?= =?us-ascii?Q?Sq5yV4O0b+3Qo0H/Ptwfl1DyNQPrK/BdFDDFBqzR5z32Kln+JzTuwaqVG16g?= =?us-ascii?Q?Tywy5JHe54oWsuEZyfJqTJk5iIHxF0RpIHxzfPeRmvvnjx1kxl7iZVbjZ2ri?= =?us-ascii?Q?r2pIWRL/7uZZSxn0YSsujsJiYqvwMvsR/ebJOtOhSd1/W1+B5NM1MqqhzbVf?= =?us-ascii?Q?ADEtsB9lxsyLUCeoJzhyH+0UWq6X09+agd+5kLAPD/rUOyul3glUWy33MuM3?= =?us-ascii?Q?i1WjML4r5tYUxl61LioYL2PFoLmGdcsRi2/BocIpEnsF505KLIPVtZTkjSGp?= =?us-ascii?Q?sjx6yU7IYautjnkH//qktiOU6KR9jSxxUWjJOMIeC+s8LYBZIirNk9vPtQNj?= =?us-ascii?Q?CbmK7+ybI5XNh0lW9SrPaPy0+BPYT2oefDqf6a6igpQrKe8/ManPB/gNurH7?= =?us-ascii?Q?4agEB9XwYQ4MnW2Q7o5jWXPTRwvp0iw3luScju8KX7uOThoktSia3ij1kVpa?= =?us-ascii?Q?YHJaBp//IMbAvjOHNzCMF8OeUMMylurXTaLvMObVv2v4ItsvNFOcT/KOip6U?= =?us-ascii?Q?VUVO0JDMaDlQoUW0jyDNFwCxcs+j2bS0f85wbmSuGnuAhisX3Jw+gH+eqhOc?= =?us-ascii?Q?9ETiPOGhXdmatntjI8ZGbyo+7d2UMWmsqnyDNAFl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07c53286-415d-4296-64a2-08db56460934 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 19:45:00.4803 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 02pHzYrChJ1VhCEIzPa1yhex45ydTQxoaWK85xZBH7j3EdX7KHxYazzJKiAHPRTOjEwekQv5Q3R9KO2dQSZPpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6744 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 3c8ea51b12..acf260597a -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Tuesday, May 16, 2023 12:43 PM To: Rebecca Cran ; devel@edk2.groups.io; Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/Intel: Del= ete ALIGN16 macro and unused include files Series Reviewed-by: Isaac Oram -----Original Message----- From: Rebecca Cran =20 Sent: Monday, May 15, 2023 6:59 AM To: devel@edk2.groups.io; Chiu, Chasel ; Desimone, N= athaniel L ; Chaganty, Rangasai V ; Oram, Isaac W Cc: Rebecca Cran Subject: [PATCH edk2-platforms v2 0/2] Platform/Intel: Delete ALIGN16 macro= and unused include files Delete the ALIGN16 macro definitions in Platform/Intel/{WhiskeylakeOpenBoardPkg,CometlakeOpenBoardPkg} since they w= ere causing a build breakage since March, and aren't used anymore. Delete include files in WhiskeylakeOpenBoardPkg which appear to be unused. Changes from v1 to v2 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Instead of fixing the ALIGN16 macro, just delete it. In addition to the one in WhiskeylakeOpenBoardPkg, also delete the definiti= on in CometlakeOpenBoardPkg. Rebecca Cran (2): Platform/Intel: Delete ALIGN16 macro Platform/Intel/WhiskeylakeOpenBoardPkg: Delete unused include files Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/PlatformBoardCo= nfig.h | 3 - Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatfor= mHookLib.h | 131 -------------------- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatfor= mLib.h | 38 ------ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfi= g.h | 103 --------------- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h = | 42 ------- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/PlatformBoa= rdConfig.h | 3 - 6 files changed, 320 deletions(-) delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include= /Library/PeiPlatformHookLib.h delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include= /Library/PeiPlatformLib.h delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include= /PlatformBoardConfig.h delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include= /PlatformInfo.h -- 2.39.2