From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.2818.1659986511274019055 for ; Mon, 08 Aug 2022 12:21:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Bigbk0wM; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659986511; x=1691522511; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VLavS+7Moh+e2onjSjUkP4J6phFso02cL+RJtzAsBTk=; b=Bigbk0wMzMBj2UiB4ddzkoyAHl3eiy99oqiGaMn2wRiIuJ7s3eD07/8Q +OZIMlLzRPn17Pz8v8N88DBE4J2DkaLqLyx7gimG92dB9+UGJRK093oqg vNaXR3Fpa2uhvJzXjm5SBhpHGwOjnn88yGm0mEx3NL+Ec/QFFdOge9KVp MEwkEh2DndV6+TsG4pzLpUrKfHp6setH1c/lcznzVX1c9dqrGGMwV/frG IPUVzNKgqA5ZBQkVdT7XP0BOXfbgFbccSKpNjmOVLbbTyvvOIgfSTExKU 6x3B1NqCIeV6Ko4f05rwdXnJI5uhDLEUTr9NkPEKvovUemT2YiTqkzawO Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="354675810" X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="354675810" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 12:21:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="607953558" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 08 Aug 2022 12:21:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 12:21:50 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 12:21:50 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 8 Aug 2022 12:21:50 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 8 Aug 2022 12:21:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gHfgByrsOzmFaLa4vqfeejCdoGD2Slfc03SSPy12sN2ySEVH0jWY0hfqNitzp+onBXG0mbxLLD132NfGnu11Banb7oHgJsHpy9/+zs7MBPKEOqTdtQXbxK425Qf6Be3uwvgtFFD6QIe0VQwratDk2DJLDAj7s54mJ6t4o+DUupm4xePxJBE2rdz/iVWKtESmX22K9ilNOzxRgUjrjMBTyWiJhs/MFwBHY33HNuM5mzL1K2Xc6vkYH9sJahyR51KghsaiAt3lCA7RbDfxeddiHGawdeqBqunu9iw685pn6fiQ5wdPwhZmXpYj071lg0BE6irkzTTrS1ZEJyWBOprsbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G8lcywxVUlta9buTrszjWydqKX9pnhIPsdPUIy4CY84=; b=m8Y1NteZnKq88O1cNFsJ9nSiA782GOaUmR/QgWUDFR83m7qQcN+bunRR+b1xNM1ETHl7F5W9lWwK1sgU37RKGo5jBdctcpqlJgeqOMLYSRuBrvqTjNxeIpMXdumf2QAhsdzAiW0ZEz3rTZdzYG9Dl6z7/IRUwcAxl6bbgEP58+FLpfWChszVsx7Gs1yyCQjX7CUBm0kTiuwkKkRPdV+HI73U31p+5yfhSzkhpj3LuvElHRqzt4cBgvVm10CABKWJG3TJ7+MVSvepRcpvxD02yFNZeT4tS72XSwHUBp/8JWXuISLMW5GvC8zL575q9j8BypuHOWRmmJOri+UWKWBa/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DS0PR11MB6397.namprd11.prod.outlook.com (2603:10b6:8:ca::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20; Mon, 8 Aug 2022 19:21:41 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe%9]) with mapi id 15.20.5504.016; Mon, 8 Aug 2022 19:21:40 +0000 From: "Oram, Isaac W" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Sinha, Ankit" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules are mutually exclusive Thread-Topic: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules are mutually exclusive Thread-Index: AQHYoEnAkLky6TdA70Kt+XOgwFGKga2ld3zQ Date: Mon, 8 Aug 2022 19:21:40 +0000 Message-ID: References: <20220725171207.3154408-1-benjamin.doron00@gmail.com> In-Reply-To: <20220725171207.3154408-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fd83e6f-1299-45cd-44a2-08da797338ea x-ms-traffictypediagnostic: DS0PR11MB6397:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CbusHMiZdjSuH3Bw0pNurkyvg8Uxw8JlCYaagG+pAmrVLqF1b3s2l3Uc0h5Aw71chydZDKbivGq+zlYLggNRUvh/W+j3TLPvo5sAT4MJdazZL3kdZE5DlQNv35qm80sB5Ok1w7iZxlTTviAtMTEMC9urlPVA8GW4+yNliE9z3RblHgYYL46lj9v+6JH7B5r76VGu1VygZH/fxCAWcqhY7gJfg4X1sahWEfp/+9EmAaKqHnmjxI6Z6jb7eT8kaulRn8yk/WQhdx98jYR7UfHPYplfP0DU7unxQc4/vfZk3w50XmsAYU5CZBTOKZXQHsHb1z/TO6UscsMTmCKZiVUvMWVMNXNapaZvgn8m0d2qw/Y70Caok92m34Aln5JHOEVo2zmsQBLGJlGhgarJcJJw32iydewI2t28PMWJLEEtcAxxpZObt6whNtmx75E4jJPP6LkpulCMCpjFNmuTdFKytH2/DL6jTx9LWWl1duNsW3yi1Ndy+hou+Hq4DokunAvmvmcDOKLjrxPAROybAlQvK3TPS2+wROCRjnwgSi+ueBMnMTrNHrxlnwY8bU7RgwcpPGrFMpEXq5H3EZm0OG0CxQmT9tHyDr+xBkBInvnxGSRxXpSLc+bQSvKDqt9mbQrYuCze98CP8KMGR4UW3nE47wOviu0mZZ/KgxmMtbX5thaEdJpH/nfCdzGuAKgQM7/gtvzJqE2eKFOZEn5xZ/9OkQsIzsBrcHXgCb3PfcM9FmSmukQKeOrPbf+jsSPmEHyl6aQO+ZPRlds/NkbEl9qMZGpgcdGjYq3S/gs5Yev8gNq/Zp9VI2qNGO9XrXQ88S4SHuWmhDtxe1TAHYSnmagFzgoX1ym27AqI62L8woY3BYThgYISL1t5DW1AM3kBqxof x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(346002)(366004)(136003)(396003)(38100700002)(82960400001)(38070700005)(33656002)(966005)(186003)(107886003)(71200400001)(41300700001)(53546011)(6506007)(7696005)(9686003)(26005)(8676002)(478600001)(86362001)(110136005)(55016003)(66556008)(4326008)(66946007)(64756008)(66476007)(5660300002)(76116006)(66446008)(54906003)(316002)(2906002)(122000001)(83380400001)(52536014)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cJ2sef07l4OgPRcqUYLrDYsBKO7mmvpsPcYv4ROV0RQC69OOUpxXtBg4LBEO?= =?us-ascii?Q?L81BUxFHa+R93eJPG5usYDHS8TZ+U0XEQhGv4L62k3Qx/nNcniu4w0BDSzxU?= =?us-ascii?Q?YylJcJhbnDmVzypvRS9mxRlqC8rzpZ100LAEzhBflNFRYsNioHqWaHu1lOR5?= =?us-ascii?Q?NEwp3/rfwk1jAWEsARddATL5vwydndqx0YznFlXGZqaJ0iahi3POCLVCnLaq?= =?us-ascii?Q?LdhuemOX4wvQGXkvRkq7KviSiQLqOwXxw9OJvflw5M5i+RVDlipnCfdJDrQc?= =?us-ascii?Q?OkhGw5Kh0T7AXGyQH59kK/m9yElObN7AIUx/5U6KQ4GSveTqnEK1DSdcFczF?= =?us-ascii?Q?odRyT18kkU++UDZcxe/0mbCCgGQMT5NOtiMl5dVFP9+TaPSJr4y4U3dbSUTZ?= =?us-ascii?Q?QgFQrMhKGRFjqnWWB1FDu0BQc40XTNTRXrn6AcYSpZ0FE04MNPmI3V6Eki09?= =?us-ascii?Q?1zF6fR+6xxJ5gZTSMocNbFsiVto2XYc/exLEYrGqBXFaPULXHz7clh0yKaUx?= =?us-ascii?Q?0A7CYM9x98as9/wfzk/Dv7D1SkiAPxXS4wyIm4a37FNUgi4kc6dU/e+RwUsc?= =?us-ascii?Q?IMbgcuniMB6zhzZLVGRkt6vBNg5ddhvBwEcY6QUO1yfT18Jj4GTE96jYozJv?= =?us-ascii?Q?jScp33t2oqcfw7mGG9QiBMe9r371lM8kf0URE8rsNOxSo7XvSzd0Q+N3FZKo?= =?us-ascii?Q?my2l9ZXD2MaJdSoJ5VWp/71vIi4AcBZIynrvmDIjtDkyly+kDlYREghUscsN?= =?us-ascii?Q?+npUEp+thQqJP8mCM7M7Nj3gLxF6KtPX+fS8octyRNzLMJAv91pVu+sW2w3z?= =?us-ascii?Q?hbcwAInk4Gowqj4MsRJbpj4u9A5w3TaHeFN7UwXBnFhzVhCL44dEQX1vXZHz?= =?us-ascii?Q?c5N0DaNftfFhKFiC+yBmXa6rl7cWfUdqScmbM7+0gnZIKhMs2q+2o/2XkedE?= =?us-ascii?Q?lO8fe7sH3toPt0O6Kx++KmDJ08UbtRiuiT+Zm+GbPCt0XJEx7WBZCzqEhHAN?= =?us-ascii?Q?zIGFJLmCtOF8paqDDYXTgEMK19xpNY2FrzFxuWKff7ZW/ta27gD5hXHPH84S?= =?us-ascii?Q?iNRgcgup/8NqmhORETjc46KQfrF1hWav5iIKSUbl+5FN63LgI4C3UaWPWi3v?= =?us-ascii?Q?m8EiHFeDGJehFxzPtpPCoWLXa4yM8nGgZQmKHizAq+eDfg5fact4TDN08kc4?= =?us-ascii?Q?EdI36itb3CTe/Zx5Dc+KbkHJD6J1J3LQ0Trgb1j+4+oOwGNV2g5Lh4v21T84?= =?us-ascii?Q?x2SIFQWzlZ06oNYDbmRKhWJG1V+8FxIhsnPH7xgAhX+CldEI1sKxg3nnJcma?= =?us-ascii?Q?xo1M9CWzLjjWksOI7GynL/47aw1cBHeliE4KRyOkdNckEAtilcOyf5H1dcMK?= =?us-ascii?Q?C3LDoGYELjk220RlGKCwaEgwXqcpCGU5kKn6h6KBvakm1w5bBtAf0GGcC2Ks?= =?us-ascii?Q?+J+wDbZfk8FZsNF0RRIefBftcP3CoXgr7x3yfAZavW1qf9ATgiCxVvlX4MuP?= =?us-ascii?Q?WbrfIrnXoE28djt6uODX2dcreGGLowBy1T6jeUUhGHILPoewYhSfVp5Cpz+X?= =?us-ascii?Q?xmIIY2lwrDBP4HROW5q3fKMjQwwuudt8RRlL1us+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fd83e6f-1299-45cd-44a2-08da797338ea X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 19:21:40.8798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vlMb8u1yCmrqICc1KJHHiFfIM5GZCHs8mgYzzbX9Bm2w4TkzVkvz0SUh09reHcHMhh865YSWo6C5Xe6gbOqWmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6397 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Benjamin Dor= on Sent: Monday, July 25, 2022 10:12 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Sinha, Ankit ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules = are mutually exclusive The DXE and SMM versions of AcpiDebug perform the same task and are therefo= re mutually exclusive. Including both modules results in a duplicate ACPI t= able, resulting in the feature not working at all. Therefore, add a new PCD to determine which module will be included. Now, either version successfully write to the debug buffer. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Ankit Sinha Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 1 + Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc = | 1 + Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebug.c = | 4 ++++ Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = | 1 + Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = | 3 +++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = | 7 +++++-- 6 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index 28530b8c674b..908fe4d1f7a9 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -48,6 +48,7 @@ # Debugging features # gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDeb= ugFeatureEnable |TRUE+ gAcpiDebugFeaturePkgTokenSpaceGuid.Pcd= UseSmmVersion |FALSE gBeepDebugFeaturePkgTokenSpace= Guid.PcdBeepDebugFeatureEnable |TRUE gPostCodeDebugFeaturePk= gTokenSpaceGuid.PcdPostCodeDebugFeatureEnable |TRUE gUsb3DebugFeatur= ePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable |TRUEdiff --git a= /Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc b/Featur= es/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc index e214175edaf7..d59e3e61b9b9 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc @@ -59,6 +59,7 @@ # [PcdsFeatureFlag] gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatu= reEnable |FALSE+ gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUseSmm= Version |FALSE gBeepDebugFeaturePkgTokenSpaceGuid.P= cdBeepDebugFeatureEnable |FALSE gPostCodeDebugFeaturePkgToke= nSpaceGuid.PcdPostCodeDebugFeatureEnable |FALSE gUsb3DebugFeaturePkg= TokenSpaceGuid.PcdUsb3DebugFeatureEnable |FALSEdiff --git a/Fe= atures/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebug.c b/Fe= atures/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebug.c index 4caeffc7dec9..0b28e2f7a6d5 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebu= g.c +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD +++ ebug.c @@ -483,6 +483,10 @@ InitializeAcpiDebugSmm ( EFI_SMM_BASE2_PROTOCOL *SmmBase2; BOOLEAN InSmm; = + if (!PcdGetBool (PcdAcpiDebugFeatureActive)) {+ return EFI_SUCCESS;+ = }+ Status =3D gBS->LocateProtocol (&gEfiSmmBase2ProtocolGuid, NULL, (VOI= D **) &SmmBase2); ASSERT_EFI_ERROR (Status); if (EFI_ERROR (Status)) {d= iff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePk= g.dec b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.de= c index 915923100731..1a290bab29d9 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.d +++ ec @@ -28,6 +28,7 @@ [PcdsFeatureFlag] gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatur= eEnable|FALSE|BOOLEAN|0xA0000001+ gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUs= eSmmVersion|FALSE|BOOLEAN|0xA0000002 [PcdsFixedAtBuild, PcdsPatchableInMod= ule, PcdsDynamic, PcdsDynamicEx] ## This PCD specifies the ACPI debug mes= sage buffer size.diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/= Include/AcpiDebugFeature.dsc b/Features/Intel/Debugging/AcpiDebugFeaturePkg= /Include/AcpiDebugFeature.dsc index f5b8bacee039..684549bbdd78 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature= .dsc +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeat +++ ure.dsc @@ -54,5 +54,8 @@ # in the package build. # Add components here that should be included= in the package build.+!if gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUseSmmVers= ion =3D=3D FALSE AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf+!el= se AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+!endifdiff --git = a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf b/Fea= tures/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf index 855826292cb5..e904a2f8fbf2 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd +++ f @@ -7,5 +7,8 @@ # ## -INF RuleOverride =3D DRIVER_ACPITABLE AcpiDebugFeaturePkg/AcpiDebugD= xeSmm/AcpiDebugDxe.inf-INF RuleOverride =3D DRIVER_ACPITABLE AcpiDebugFeatu= rePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+!if gAcpiDebugFeaturePkgTokenSpaceGu= id.PcdUseSmmVersion =3D=3D FALSE+ INF RuleOverride =3D DRIVER_ACPITABLE Ac= piDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf+!else+ INF RuleOverride= =3D DRIVER_ACPITABLE AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+= !endif-- 2.36.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91815): https://edk2.groups.io/g/devel/message/91815 Mute This Topic: https://groups.io/mt/92609642/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D