From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.1621.1662759684441473828 for ; Fri, 09 Sep 2022 14:41:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Wh0HwM7E; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662759684; x=1694295684; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gRBt/uJoAbsfRz2tzXP4UgrNwUrapbov08KliezvEJo=; b=Wh0HwM7ELwXRpo2/tt2xDnMGBhljKNIUWesHsNsddUPofNqb3moA1FfI b8mwvoJBlgJZPmsGpcyUvPzNKIw/CBAHkrl5x5wLd6+E5y0T/DvVcxGv5 YbUp3UaDEJJZbdQwLoF3u25cYnGA5H8KvYBvMZZ4I8wYwxLiwK6ikAEOj LJ1OvLghvg7Xi3Wa5NcF/7gpYarjURVAUZ62mhD8HS7GJSnUy7zkRXZP/ 15AT+1Sd0pQGIRnhnCDeXw1fbfYNRryCsg1lZdR+YplU2s8r6cDSx97uI AQxoVQr+RB54ff16HdvRlsOUdlL2bCHUUNUG0a0IASNNov4fiKus0j7q6 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="298376120" X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="298376120" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 14:41:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="683785189" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 09 Sep 2022 14:41:23 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 14:41:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 14:41:22 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 14:41:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 14:41:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=At3IDrMTPchoYh5eV13Ua0UFt5yslPWLBWErUPSNpSBxvBvFlT3rmEc/Ir2XNkcnob8ymFoSxo0IcZZ3+flmJ6GvXGAqP3mau/eeSVz2eIoE7FriwSkWZdMdWTo2nS7tuDvZuVu/JOnHEDGVClHcXeMqYbb5WwB1A47R5MX+2SqtxvWZATI73R6+mbI0UFy/3fWlICDTKNnZ1VqADnIRzHQaNIJG7LljvdumC2zjbfQTtVEhY4BD+BvbYF5QjyhotYRAR44OrBxlRq+LUjIch/f6y0pX7RB0Y+aSU49qkg5kQGKrHXLPtjLj0B4W+s6zaMPf488YOASkPicW+jO2Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3apdUjxxE7/ka9+QHiQq4RXpZGod2N7SgyCUwPB2qkU=; b=MOlJja4mf7/VNkY6t0v2Y0y+mJvml42uvF//WboDUunu0nW5yMhEeKLtxvDCPz61m16wdhZVB3bp6uHcmC7g8PE2Jvs4LQwOtyfoe4d9JrLitPv+idzXbmKlyDKovBzj4PXIOyPqJNkMy2DEe9b9tf+o/MParqymyAvRTeUhDc3S/izmTP4NNYPR93DzMDvDkfs+1jl0qqcJy78XGmd47PLLZOWgyozcSyaeCed0iXwj74qcJBy+LM8WMAUZ2yEWvFuaZLmym06Nn5Y3TAQxviQQn55SFzw/cbCzXC38k4tGV1TBS9JQIA7I7a5H9zQN87NE3mMW/+cYR0OkMuf2LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by PH0PR11MB4902.namprd11.prod.outlook.com (2603:10b6:510:37::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 21:41:15 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3%5]) with mapi id 15.20.5588.010; Fri, 9 Sep 2022 21:41:15 +0000 From: "Isaac Oram" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel][edk2-platforms][PATCH v1 1/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Cleanup library includes Thread-Topic: [edk2-devel][edk2-platforms][PATCH v1 1/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Cleanup library includes Thread-Index: AQHYwhgu8vIPi7INY0uAYJYoR5UXNa3XpUng Date: Fri, 9 Sep 2022 21:41:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36347383-f473-4428-bbf3-08da92ac0588 x-ms-traffictypediagnostic: PH0PR11MB4902:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KtHz6u/TRXhGsYqUeVGEfxEXUUubjnRaxt8lKngucvtWtjMPbHRAOFyuDHhwfMMbBB5ukXyCQLrImtRq9Ob6ic8IOinC2vaYN5GTlc3jvldAFwyhuq1pMd2XWeYrrlQFjOJDCsaX7O6sOMBpEBCDA3232Uu8wkJWnJGbNhUA06F9XyXX3J02hlYDGugsXYzSY/gBc3IxbDkErbz1uGr7f/3x78vRBbfSuo2rlW1kwALpZe/2YYGfy0S27M3jOmlpCqtx0iOSrt/F2pXZCF8L45ZNgKylbRbFgx1dKPgGBqKu8/oA48xfgW8GBlu52/u6KkM7ghbAWsUCTP+KaUfjweStiCYdVM4hjwPgiUKFCyANkW7Jm66x3Aw83eR2kF9cMf3wdFFFqsK5pwtPnmOZ0+QTWRBXUvS/gLaMrREQnk/cT2LuPo04sVSNY1Nf+D7g7lbLD5vMPSctG582nRD/U1Rv4xJiO8DdMo1FiRSjPcKGQbuCNn4v1AmLppJ7kvgrwWcUqegR2+zdMK1nHbME5iLfZMxhPh3EtqDsfNlxx6EPZcHUUjdte76jsZJPTF/iBM2Pwnr4La3QczdUG/Vd1cWXv5hkHyJTnhiNTi7NNhRgMAk2AFrAXaEvIRyHzoMJvj4OHA6Py6VZjsFVChWZ9pVlO+p4r7iXTxAOIz1kJPThlhfcAUu41dwbQLJUHkvHo6jshtP4ixemwodV3DtxS+IbdshxegwzAK/3P9Ek7yYzj+TI2R0DMF30Aj6T5eTIv06A3NngLFPVMNSMcQM+og== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(346002)(396003)(376002)(366004)(186003)(66446008)(83380400001)(19627235002)(478600001)(41300700001)(66946007)(66556008)(4326008)(316002)(8676002)(54906003)(66476007)(71200400001)(82960400001)(110136005)(76116006)(38100700002)(55016003)(5660300002)(52536014)(30864003)(122000001)(2906002)(8936002)(7696005)(6506007)(64756008)(53546011)(107886003)(9686003)(26005)(86362001)(33656002)(38070700005)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KqRZueobY21/rW7WQgaNeJtS3cLXjQmePBzsO2VyB4NdPWxAu38+uv3p4+PZ?= =?us-ascii?Q?zokC/igJBeU78jpJIyoozuSu/Jupe8lbtp52lhGPJVYJa0pa/9jdCVI4oQ0n?= =?us-ascii?Q?EmTdiZAA3+Q/uV+oziXzLd4/AuGLhwBzcFAQ4erk8RtRSs4Kp4EA1ft8p0DN?= =?us-ascii?Q?5r/yTkNoZoBF/aFS/wwWZKy87j7fuuSZ0ibTl6ZOqecAi68CRIPkpciGbS3U?= =?us-ascii?Q?FVuWHDFG3AncfwvpG/weI24uz3OKE/nCJTiyAe5UZDS77a8aKqOky3/TF+EL?= =?us-ascii?Q?HypiRHMVwyTvZCa+CsnkaGBidCcMeHOP2BSJO4KxT8X4wOFQ/oVEreOtxrS/?= =?us-ascii?Q?6x5i2slEQOqLBWUYFVzZPO6QLG1QIELHPjE5eUgVJrI055mQ5TCU4h9KCT2d?= =?us-ascii?Q?p8O2+RRmy1eIfHxh27St6gjIQtnqIWGKlQRMEUrLbtrsdleQJDe0vlvyTo5Z?= =?us-ascii?Q?Nq3HkC4X6uCSvVdrzuwceGkuOC6R0xbq5HFXVsspH7jp7CFhKyW56ntq+6rN?= =?us-ascii?Q?AOq/2wo2cezpTF+e67lXvqqgxqTRj8q1CRWx/l7YfWz8A7QV0NlOvEJGtDJE?= =?us-ascii?Q?yQdoKGlAzqDR802vUkyco9FwWbFTRXu1e32Q6Ox2LPLHVMjYWNZIJ1rAyk0P?= =?us-ascii?Q?prBM/IggyJZIVGjc0q9o22zJ3GA8lgROxV6STpAEy4d5P0aeO0xcNgk+riOr?= =?us-ascii?Q?dc7D71K+YilvUkCeEGUmjRgPCo9u7/bhUSNsttFeeQ8RXjO9ggcea+EHaNh9?= =?us-ascii?Q?5Fpmk7TDTYZs2pEmBZgTLCJwnC2ca7FNjWyHEz6/zVb2W4fe7HeacK9+10N9?= =?us-ascii?Q?qxcwtbtqtuY8bWOsfluRLDxkwK4S0CM5ib7AeoP6qbfNjTVCCPKqi2+gfwXY?= =?us-ascii?Q?r+TaEmAivX+7CtujvLe6YeyqupaU+pKjJsFmGL9jAB/Trf6jeDL18+yKfVhX?= =?us-ascii?Q?GuOF1n1/uv9uhlsuWKFnWqvBoMxR7wQy5MBzxfCFiUT5P+Q7EfQ0uAYHIgie?= =?us-ascii?Q?dVj+WunLHTl7jl5WCpEM4I5P5l118ppUnDlJv5ufgp3f3OYO7AznyWW3bezF?= =?us-ascii?Q?wIHF3pTv1W88DDUukDix5W1TbGGsbLoDQ/kvDztiit7k63BGBUPhtrAuiH2P?= =?us-ascii?Q?OP8LUbPUV+SSNdGyEcccPq7UJBoN5NWOd/7FT5UIzjOjAh5VyMrDxLYRxZf/?= =?us-ascii?Q?WR6hnJO09qsaoWikX+/4XBMN1ftCcxU0Gz6cJESJFhAFz+jHiIPQ77Chw2mm?= =?us-ascii?Q?2X3SNhW3ng9ySR6lHvoM9NyvjcXFW3+biAnbAlFtEzrl7uZOVY7M1AngkCbG?= =?us-ascii?Q?x0W+MnMHZFY6sf/0EO7OdcZv28qhuaKfJEQIaI3N+QSDCQsWIFYcdAx+4n9z?= =?us-ascii?Q?+QpesaeKcWrNihAR6ZqWhHuoCECupjKps1T1+/M3eKOi9yTRTwTka40IAvFs?= =?us-ascii?Q?VSey8dw06o242l3DPjfTBy5iITr7xN4/5XEAoKbOWKWztuyLvjknd4jMIPh/?= =?us-ascii?Q?y49VGqAIo1oFI+7YBOKXtH/+4aOGQV1wyCvGg7+0xWTVtkhqRU9mYa7JB6Sl?= =?us-ascii?Q?i+Rl3oPTq+22DQZ3VLDlFIDFcySGQPKbEHvVVzmm?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36347383-f473-4428-bbf3-08da92ac0588 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 21:41:15.1067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sYY+ToounBnz41OvkibJb35RAhSF5CcL/VTd7VnuRsle6dLmtEK4nHsgOM4lBmipKkWlVMeaq33Z61JP2ChEBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: Benjamin Doron =20 Sent: Tuesday, September 6, 2022 10:43 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Chiu, Chasel ; Desimone, Nath= aniel L Subject: [edk2-devel][edk2-platforms][PATCH v1 1/7] KabylakeOpenBoardPkg/As= pireVn7Dash572G: Cleanup library includes Remove unused includes, LibraryClasses and update a comment or two. Cc: Sai Chaganty Cc: Isaac Oram Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- .../PcieDeviceTable.c | 1 - .../PeiBoardPolicyUpdate.c | 6 ++++-- .../PeiPchPolicyUpdate.h | 3 ++- .../PeiPchPolicyUpdatePreMem.c | 1 - .../PeiSiliconPolicyUpdateLibFsp.inf | 5 ++--- .../BoardAcpiLib/DxeBoardAcpiTableLib.inf | 5 +---- .../SmmAspireVn7Dash572GAcpiEnableLib.c | 9 +++++---- .../BoardAcpiLib/SmmBoardAcpiEnableLib.inf | 3 ++- .../Library/BoardEcLib/EcCommands.c | 14 ++++++++------ .../AspireVn7Dash572GHdaVerbTables.c | 3 ++- .../BoardInitLib/PeiAspireVn7Dash572GInitLib.h | 3 +-- .../PeiAspireVn7Dash572GInitPreMemLib.c | 18 +++++++++--------- .../BoardInitLib/PeiBoardInitPostMemLib.inf | 4 +--- .../BoardInitLib/PeiBoardInitPreMemLib.inf | 5 +---- .../AspireVn7Dash572G/OpenBoardPkg.fdf | 3 ++- .../OpenBoardPkgBuildOption.dsc | 4 ++-- .../DxeGopPolicyInit.h | 3 --- .../DxeSaPolicyInit.h | 3 --- .../DxeSiliconPolicyUpdateLib.c | 3 +-- .../DxeSiliconPolicyUpdateLib.inf | 2 ++ 20 files changed, 45 insertions(+), 53 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapp= er/Library/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c b/Platform/Intel/= KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyU= pdateLibFsp/PcieDeviceTable.c index 205ca581c6f3..537fb5c8e4f4 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/L +++ ibrary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c @@ -7,7 +7,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent **/ #include "PeiPchPolicyUpdate.h"-#include #d= efine PCI_CLASS_NETWORK 0x02 #define PCI_CLASS_NETWORK_ETHERNET= 0x00diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/= FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c b/Pl= atform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiS= iliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c index 81cd8b940f05..452c961b17ac 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/L +++ ibrary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c @@ -12,14 +12,16 @@ #include #include -/* TODO:+/*+ * T= ODO: * - Validate PCH Sample policies: only SA one used by default. * - R= emove likely fuse-disabled devices when reset handling is committed? * - R= emove duplicate policy * - Consider updating some policies, rather than = overriding. This could be factored into * BoardInitLib for deduplicati= on * - Copy initialised array, where sane- * - Set IgdDvmt50PreAlloc? */+ = * - Set IgdDvmt50PreAlloc?+ */ #define SA_VR 0 #define IA_VR = 1diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/= FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h b/Plat= form/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSil= iconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h index 5e720b0041e8..134188698077 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/L +++ ibrary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h @@ -17,10 +17,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include = #include #include -#include #include #include #inc= lude +#include + #endifdiff --git a/Platform= /Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSilicon= PolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c b/Platform/Intel/KabylakeOpen= BoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/= PeiPchPolicyUpdatePreMem.c index 2bc142c0e5ff..28e4e45375c2 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/L +++ ibrary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c @@ -9,7 +9,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include "Pei= PchPolicyUpdate.h" #include #include -#include #include #= include #include diff --git a= /Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/P= eiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf b/Platform/Int= el/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPoli= cyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf index eac9344b0aa2..0e1b42c20cd8 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/L +++ ibrary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf @@ -62,19 +62,18 @@ [LibraryClasses.IA32] FspWrapperApiLib- FspWrapperPlatformLib BaseMe= moryLib DebugLib- HobLib IoLib PcdLib MmPciLib- ConfigBlockLib+ = PciLib PeiSaPolicyLib PchInfoLib PchHsioLib PchPcieRpLib SiPolicy= Lib+ MemoryAllocationLib PeiLib [Pcd]diff --git a/Platform/Intel/Kabyla= keOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeBoardAcpiTableLib.= inf b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/DxeBoardAcpiTableLib.inf index 0d8264554734..660afe9292ec 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/DxeBoardAcpiTableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dAcpiLib/DxeBoardAcpiTableLib.inf @@ -22,10 +22,7 @@ # [LibraryClasses]- BaseLib- IoLib- PciLib- AslUpdateLib+ PcdLib E= cLib [Packages]diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7D= ash572G/Library/BoardAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c b/Platform= /Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmAspir= eVn7Dash572GAcpiEnableLib.c index 69e9c928ff69..fa2ed9745ea6 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmAspireVn7Dash572GAcpiEnableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c @@ -2,6 +2,7 @@ Acer Aspire VN7-572G SMM Board ACPI Enable library Copyright (c) 2017 -= 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2021, Baru= ch Binyamin Doron
SPDX-License-Identifier: BSD-2-Clause-Patent **/@@ -= 20,8 +21,8 @@ AspireVn7Dash572GBoardEnableAcpi ( EFI_STATUS Status; /* Tests at runtime show this re-enables charging= and battery reporting- * - Obtained somewhere from somewhere in vendor's= SmmKbcDriver (or RtKbcDriver).- * Further reversing will be performed = */+ * - Obtained from somewhere in vendor's SmmKbcDriver.+ * Further = information is needed */ Status =3D SendEcCommand (0xE9); /* Vendor impl= ements using ACPI "CMDB" register" */ if (EFI_ERROR (Status)) { DEBUG= ((DEBUG_ERROR, "%a(): SendEcCommand(0xE9) failed!\n", __FUNCTION__));@@ -4= 8,8 +49,8 @@ AspireVn7Dash572GBoardDisableAcpi ( EFI_STATUS Status; /* Tests at runtime show this disables charging a= nd battery reporting- * - Obtained somewhere from somewhere in vendor's S= mmKbcDriver (or RtKbcDriver).- * Further reversing will be performed */= + * - Obtained from somewhere in vendor's SmmKbcDriver.+ * Further in= formation is needed */ Status =3D SendEcCommand (0xE9); /* Vendor implem= ents using ACPI "CMDB" register" */ if (EFI_ERROR (Status)) { DEBUG (= (DEBUG_ERROR, "%a(): SendEcCommand(0xE9) failed!\n", __FUNCTION__));diff --= git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmBoardAcpiEnableLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/Aspir= eVn7Dash572G/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf index 63a54e1830a5..5db00224dfce 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmBoardAcpiEnableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dAcpiLib/SmmBoardAcpiEnableLib.inf @@ -23,9 +23,10 @@ [LibraryClasses] BaseLib+ DebugLib EcLib IoLib- PciLib+ PcdLib = MmPciLib PchCycleDecodingLib diff --git a/Platform/Intel/KabylakeOpenBoa= rdPkg/AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c b/Platform/Intel/Ka= bylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c index 6e752b4e227e..54cfaba47b1b 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEc= Lib/EcCommands.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dEcLib/EcCommands.c @@ -13,7 +13,8 @@ #include #include -/* Notes:+/*+ * Not= es: * - ACPI "CMDB": Writing to this offset is equivalent to sending comma= nds. * The CMDx bytes contain the command parameters. *@@ -21,9 +22,10 = @@ * - Commands: 0x58, 0xE1 and 0xE2 * - 0x51, 0x52: EC flash write? = * - ACPI CMDB: 0x63 and 0x64, 0xC7- * - 0x0B: Flash write (Boolean a= rgument? Set in offset 0x0B?)+ * - 0x0B: Flash lock/write (Set offset 0= x0B?)+ * - Key/recovery detection? *- * Reversing vendor's protocols:+ *= Vendor's protocols: * - Only read and write are used. * - Query, ACPI "C= MDB" processing and command 58 are unused. * - Equivalent KbcPeim is an un= used PPI.@@ -32,9 +34,9 @@ */ #define EC_INDEX_IO_PORT 0x1200-#define EC_INDEX_IO_HIGH_A= DDR_PORT EC_INDEX_IO_PORT+1-#define EC_INDEX_IO_LOW_ADDR_PORT EC_INDEX_I= O_PORT+2-#define EC_INDEX_IO_DATA_PORT EC_INDEX_IO_PORT+3+#define EC_= INDEX_IO_HIGH_ADDR_PORT (EC_INDEX_IO_PORT + 1)+#define EC_INDEX_IO_LOW_ADD= R_PORT (EC_INDEX_IO_PORT + 2)+#define EC_INDEX_IO_DATA_PORT (EC_IND= EX_IO_PORT + 3) /** Reads a byte of EC RAM.diff --git a/Platform/Intel/K= abylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572= GHdaVerbTables.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Li= brary/BoardInitLib/AspireVn7Dash572GHdaVerbTables.c index 0573736060fa..cc7369f3484c 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/AspireVn7Dash572GHdaVerbTables.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dInitLib/AspireVn7Dash572GHdaVerbTables.c @@ -2,6 +2,7 @@ HDA Verb table for Acer Aspire VN7-572G Copyright (c) 2017, Intel Corpo= ration. All rights reserved.
+Copyright (c) 2021, Baruch Binyamin Doron<= BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/@@ -9,7 +10,7 @@ SPDX-= License-Identifier: BSD-2-Clause-Patent #ifndef _ASPIRE_VN7_572G_HDA_VERB_TABLES_H_ #define _ASPIRE_VN7_572G_HDA_V= ERB_TABLES_H_ -#include +#include HDAU= DIO_VERB_TABLE HdaVerbTableAlc255AspireVn7Dash572G =3D HDAUDIO_VERB_TABLE_I= NIT ( //diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572= G/Library/BoardInitLib/PeiAspireVn7Dash572GInitLib.h b/Platform/Intel/Kabyl= akeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572G= InitLib.h index 83789c90becf..51a7b714c463 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiAspireVn7Dash572GInitLib.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dInitLib/PeiAspireVn7Dash572GInitLib.h @@ -8,10 +8,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef _PEI= _ASPIRE_VN7_572G_BOARD_INIT_LIB_H_ #define _PEI_ASPIRE_VN7_572G_BOARD_INIT_= LIB_H_ -#include +#include #include #= include -#include #includ= e #include #include diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Librar= y/BoardInitLib/PeiAspireVn7Dash572GInitPreMemLib.c b/Platform/Intel/Kabylak= eOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GIn= itPreMemLib.c index 1b4c6b484b43..d0125ebdbcb2 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiAspireVn7Dash572GInitPreMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dInitLib/PeiAspireVn7Dash572GInitPreMemLib.c @@ -1,6 +1,7 @@ /** @file Copyright (c) 2017 - 2022, Intel Corporation. All rights reserv= ed.
+Copyright (c) 2021, Baruch Binyamin Doron
SPDX-License-Identifi= er: BSD-2-Clause-Patent **/@@ -8,7 +9,6 @@ SPDX-License-Identifier: BSD-2-= Clause-Patent #include #include #include -#include #include #include #include @@ -16,7 +16,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #incl= ude #include #include -#include #include #in= clude @@ -47,12 +46,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED con= st UINT16 RcompTargetAspireVn7Dash572G[SA_MRC_M #define DGPU_HOLD_RST GPIO_SKL_LP_GPP_B4 /* Active low */ #define DGPU_PWR= _EN GPIO_SKL_LP_GPP_B21 /* Active low */ -EFI_STATUS-EFIAPI-AspireVn7Dash57= 2GBoardDetect (- VOID- );- /** Aspire VN7-572G board configuration init= function for PEI pre-memory phase. @@ -75,7 +68,7 @@ AspireVn7Dash572GInit= PreMem ( // PcdSet8S (PcdSaMiscUserBd, 5); // ULT/ULX/Mobile Halo PcdSet8= S (PcdMrcCaVrefConfig, 2); // DDR4: "VREF_CA to CH_A and VREF_DQ_B to CH_B= "- // TODO: Clear Dq/Dqs?+ // TODO: Search vendor FW for Dq/Dqs. Unnecess= ary if FSP detects LPDDR PcdSetBoolS (PcdMrcDqPinsInterleaved, TRUE); = PcdSet32S (PcdMrcRcompResistor, (UINTN) RcompResistorAspireVn7Dash572G);@@ = -241,9 +234,16 @@ AspireVn7Dash572GBoardInitAfterMemoryInit ( if (EFI_ERROR (Status)) { DEBUG ((DEBUG_WARN, "Failed to enable LGMR= . Were ACPI tables built for LGMR memory map?\n")); }+ return EFI_SUCCE= SS; } +EFI_STATUS+EFIAPI+AspireVn7Dash572GBoardDetect (+ VOID+ );+ EFI_ST= ATUS EFIAPI AspireVn7Dash572GBoardDebugInit (diff --git a/Platform/Intel/Ka= bylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPostM= emLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/B= oardInitLib/PeiBoardInitPostMemLib.inf index c8c49fa20dcc..7b68f66ac78b 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiBoardInitPostMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dInitLib/PeiBoardInitPostMemLib.inf @@ -10,7 +10,7 @@ [Defines] INF_VERSION =3D 0x00010005 BASE_NAME = =3D PeiBoardPostMemInitLib- FILE_GUID = =3D 7fcc3900-d38d-419f-826b-72481e8b5509+ FILE_GUID = =3D 7FCC3900-D38D-419F-826B-72481E8B5509 MODULE_TYPE = =3D BASE VERSION_STRING =3D 1.0 LIBRARY_CLASS = =3D BoardInitLib@@ -18,8 +18,6 @@ [LibraryClasses] BaseLib DebugLib- BaseMemoryLib- MemoryAllocationLi= b PcdLib SiliconInitLib PchCycleDecodingLibdiff --git a/Platform/Inte= l/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitP= reMemLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Librar= y/BoardInitLib/PeiBoardInitPreMemLib.inf index c53114e15450..a3164870ef9b 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiBoardInitPreMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar +++ dInitLib/PeiBoardInitPreMemLib.inf @@ -10,7 +10,7 @@ [Defines] INF_VERSION =3D 0x00010005 BASE_NAME = =3D PeiBoardInitPreMemLib- FILE_GUID = =3D ec3675bc-1470-417d-826e-37378140213d+ FILE_GUID = =3D EC3675BC-1470-417D-826E-37378140213D MODULE_TYPE = =3D BASE VERSION_STRING =3D 1.0 LIBRARY_CLASS = =3D BoardInitLib@@ -18,8 +18,6 @@ [LibraryClasses] BaseLib DebugLib- BaseMemoryLib- MemoryAllocationLi= b PcdLib SiliconInitLib TimerLib@@ -30,7 +28,6 @@ EcLib BoardEcLib GpioLib- PeiLib PeiServicesLib PchPmcLib diff = --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.= fdf b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.fd= f index 864d5561d7d8..b59d9a4f24e1 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.fd= f +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg +++ .fdf @@ -279,7 +279,7 @@ INF IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim= .inf INF $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPost= Mem.inf !if gSiPkgTokenSpaceGuid.PcdPeiDisplayEnable =3D=3D TRUE-FILE FREE= FORM =3D 4ad46122-ffeb-4a52-bfb0-518cfca02db0 {+FILE FREEFORM =3D 4AD46122-= FFEB-4A52-BFB0-518CFCA02DB0 { SECTION RAW =3D $(BOARD)/Vbt.bin SECTION = UI =3D "Vbt" }@@ -346,6 +346,7 @@ APRIORI DXE { INF UefiCpuPkg/CpuDxe/CpuDxe.inf INF MdeModulePkg/Bus/Pci/PciHostBridgeD= xe/PciHostBridgeDxe.inf +# TODO: Add NvmExpressDxe if supporting Newgate an= d RayleighSLS INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe= .inf INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf INF MdeModulePkg/Bu= s/Ata/AtaAtapiPassThru/AtaAtapiPassThru.infdiff --git a/Platform/Intel/Kaby= lakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgBuildOption.dsc b/Platform/I= ntel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgBuildOption.dsc index b1a04c474845..6e2053d67734 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgBui= ldOption.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg +++ BuildOption.dsc @@ -84,6 +84,7 @@ DEFINE DSC_PLTPKG_FEATURE_BUILD_OPTIONS =3D $(DSC_PLTPKG_= FEATURE_BUILD_OPTIONS) $( DEFINE DSC_PLTPKG_FEATURE_BUILD_OPTIONS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPT= IONS) $(DSC_ACPI_BUILD_OPTIONS) $(UP_SERVER_SUPPORT_BUILD_OPTIONS) $(USBTYP= EC_BUILD_OPTION) $(SINITBIN_BUILD_OPTION) $(MINTREE_FLAG_BUILD_OPTION) # F= IXME: $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) is passed multiple times+# BUGBUG= : `-Wl,--allow-multiple-definition` breaks CLANG build [BuildOptions.Common= .EDKII] #@@ -141,8 +142,7 @@ MSFT: *_*_X64_ASLCC_FLAGS =3D $(DSC_PLTPK= G_FEATURE_BUILD_OPTIONS) MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 GCC:*_*_*_DLINK_FLAGS =3D -z co= mmon-page-size=3D0x1000 -# FIXME: Protection broken, but works on UefiPaylo= ad, and not related to-# FspWrapperNotifyDxe. Cannot be related to SMM?+# F= IXME: Protection broken, yet works on UefiPayload. Consider diffing module/= library include lists (unrelated to FspWrapperNotifyDxe). # Force PE/COFF s= ections to be aligned at 4KB boundaries to support NX protection [BuildOpti= ons.common.EDKII.DXE_DRIVER, BuildOptions.common.EDKII.DXE_CORE, BuildOptio= ns.common.EDKII.UEFI_DRIVER, BuildOptions.common.EDKII.UEFI_APPLICATION] = #MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096diff --git a/Platform/Intel/Kabylake= OpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/Dxe= GopPolicyInit.h b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Pol= icy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h index 63cad5e3753f..56cab1df9b1d 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Libra +++ ry/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h @@ -9,11 +9,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define _GOP= _POLICY_INIT_DXE_H_ #include -#include #include -#include #include -#include #include #include #include diff --git a/Platform/Intel/Ka= bylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateL= ib/DxeSaPolicyInit.h b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572= G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h index 801387b9476f..88a507547f69 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Libra +++ ry/DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h @@ -8,12 +8,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef _SA_= POLICY_INIT_DXE_H_ #define _SA_POLICY_INIT_DXE_H_ -#include -#include #include #include #include -#include #include diff --= git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c b/Platform/Intel/Kaby= lakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib= /DxeSiliconPolicyUpdateLib.c index 6298bb53e65d..6840531da986 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Libra +++ ry/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c @@ -1,14 +1,13 @@ /** @file Copyright (c) 2017, Intel Corporation. All rights reserved.
= +Copyright (c) 2021, Baruch Binyamin Doron
SPDX-License-Identifier: BSD= -2-Clause-Patent **/ #include #include -#include -#include #include #include d= iff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Li= brary/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf b/Platform/In= tel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyU= pdateLib/DxeSiliconPolicyUpdateLib.inf index 63ac194cd0d5..989796cf8244 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Libra +++ ry/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf @@ -17,6 +17,8 @@ [LibraryClasses] BaseLib+ BaseMemoryLib+ UefiBootServicesTableLib P= cdLib DebugLib ConfigBlockLib--=20 2.37.2