From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.13352.1684467306678225495 for ; Thu, 18 May 2023 20:35:06 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CcsCe4gR; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684467306; x=1716003306; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=L4ftqvDSOT+l3jvrVTwymCpvAoO8TF/EOhlGGk7PUTE=; b=CcsCe4gRvvozAwgnYsxNRkCkiGk4PE01oQEY4lCIzBKY1okO9Y6erIS6 haRrVFkwAzL/pciul/EyVR7FOpBoPl5U5pwOfWIMOvxu5QawdgVZnJJ/m U89Tq4pl5ZrcYbHyoXSxnIR73lzijK0BRFk+BGHSMke8BR0QSI5gPwuOu 9tWK6ANIcC4z3Qtbj49TFhmcwzLiyXHkP3kN3MCoLCom3f84NW76D07Nu vrvtF2ojwcaqDtLRGv4wtdv8y41k/COfJ+e3cHwfUsju9RznlElhLYXDV JRtKH3asGrQpvvAA66g2jCdbsuwUvgV2+Q+B3q7qO91SWHcssfQpLqAZV A==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="349785239" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="349785239" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 20:34:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="652896340" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="652896340" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 18 May 2023 20:34:29 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 20:34:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 20:34:29 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 18 May 2023 20:34:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBFOA5seWe6A9ji4WB0jQOF5Q2VKARvkPpFW55d2SmOWFNGh7oXnKKSa8dg9ufFaQ5RclytFZLs0kUTeO1QSs0/Mo+DEkytLcnaeBLnUfksLJEc/ND56C9kODqeoLAI+NrAozHtswkcDW9YkhPmzaHMbdQVCgWTlZnOPTIBw4CJcL9vpK+Zx5l6zwqHcFDkVC7QXYZL2vwraHlIKY2dw1KEpPiLHAYlMWi2EDKTdzUnRTIEG3+0dCURXMF7X/ZfrjuU7OcF9rFuxwsvG4enZ5k/5WQS/lsoaYMZ+9H1axcwF0RSPhzWZ7Lf4Lx0D36yr5taEHrSX6v5wZJJ/zh87wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=45CCAEsRzew7NnaltrbGI/5UAN81wxpkDb1KB/LmRwY=; b=FqX4bUn+HGykvnkhCXvU1DC4TdC+MWiDLYn5SITScuYRvKCnP6fuQgdbci67c3zoPzEdixrkLUzYszhERgjcLPhsPZRqr205Qcd4ste/R/OGI7iXa4i1NaH/0YwjWkxTBBwJoS8HV6bFfZ8EXSlT0kan6szkSzx+ieH5aMlnR7PeSuUR0/HDy+cFbO3RzhNYEnaM9UVs90pJW6HK0+HMRvw8C5siKgk35s/OSW++WCFoK6ofPNR2PrRU2YFp6afAMOt7rGHFT14P6kyTUkJMaP4NGoG6IUxLpWJOYGPz9n9Wc8st9o9F2WluNWkmEe5y0HsCOrIxoWh9yX6fWmYfFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SA3PR11MB8048.namprd11.prod.outlook.com (2603:10b6:806:2fd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Fri, 19 May 2023 03:34:27 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6387.030; Fri, 19 May 2023 03:34:27 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: Abdul Lateef Attar , Nickle Wang Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFrb: Add to ManageabilityPkg Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFrb: Add to ManageabilityPkg Thread-Index: AQHZhZc0QlzJEpaGoUiMURF++WqTL69g+m1w Date: Fri, 19 May 2023 03:34:27 +0000 Message-ID: References: <20230513123327.1496-1-abner.chang@amd.com> <20230513123327.1496-2-abner.chang@amd.com> In-Reply-To: <20230513123327.1496-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SA3PR11MB8048:EE_ x-ms-office365-filtering-correlation-id: 62e0cb72-bc12-4ce5-8d5e-08db5819f2ac x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nxZjLMpYxKtpHkHYml053llhlHbtPT+nqND2EXsLbxhWYCqkP7OBkKc/37A3apZHaY9Wl8y/hY2bFEQyADzLSY9hyyzmEePKd1zs+vmdiR913/vWPD+BAKh+xS9St++SZiAg/gobYrxZuPChm/i+VHfDPvbnlgvHQ7GMskluatlIrP/xvRoclguWWwGiNJuJ7kqE8PD24rxlHrnAaMmMDRYed57TGu+nsK1uC+kT7amT9bBlIf7VgAG84aCRrngl0zzBnbyCSWWwrYtslq9PQI0dkZjIRpuPvUxX5CYd1/ET3y+naMMWsSNKzitnBZyIopI/wec2P+ob6HPi3A94WXZ2MMrp3QuxOdRwxoT1ObDAsf+C/yhfiTMpmG8slOaAF/9ntxBNeG+6MZN5CBnFY8t5Q01/rusPqWkv77KRtrrRrDWSRyG0Yu2Wb/cj57qs3ojxGOQqCSjKDrG/sc+j1MeHIWg6jfIqD/hkBv4njp8EzQ60K40+R/fJS9m1lZb3SqMh+0/BU24apbos9QqnLYvJDqOsqEt1Mu6JtVLbOYX5pLjuEII/eepfzcCUwtHTfRmX/7Mwqpc9Zncm3tnoageJSvb2H8pQXTaMSUQqU4/iOex9FSOr1BQ7W/EcUGEomAFUnAEznONt3ApGidY3fQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199021)(66899021)(66556008)(966005)(66946007)(66446008)(76116006)(66476007)(64756008)(478600001)(4326008)(110136005)(54906003)(316002)(7696005)(33656002)(86362001)(38070700005)(6506007)(9686003)(83380400001)(26005)(53546011)(5660300002)(71200400001)(52536014)(55016003)(2906002)(8676002)(8936002)(186003)(122000001)(82960400001)(41300700001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EZ2nB4DYVDT3e6xuK5IoPsLGpgco/26B12ZQMvgtxTjtRTuwqEPSjGZR1/Ls?= =?us-ascii?Q?r+CQLZn242U0VTs35WneElzA2UR7u6YcDWhcCssmm81hzbwimg5YE7Ika/6K?= =?us-ascii?Q?GRUlslvJ+U+3NygN1CAaJEwl5FMP5o/CgEBzV+SuYv6GxqFwyGjo826xlLoK?= =?us-ascii?Q?JonaanMgBk11KuCE0nOPEAwpsO5EAQlMD0qLeudq8swFdCrcSZorfrvgAF25?= =?us-ascii?Q?WH/DuIhV3Fveivx1ULQhxlRWXQYrdbDU20MSTIiUgRg+4BFJKeiMktwjjKzh?= =?us-ascii?Q?8ABXUkNS6TjHqwwWMbT4culYNn2QlAF+3kv9gA9iQPD0eEYYyBZJ4vPLvnQs?= =?us-ascii?Q?mPVb23by58tuYu7pcARw/es7+d31TnVjoS5VjP1rCduRGrwVuNZCo5ZQ2VbN?= =?us-ascii?Q?rL9KvDD8dlDc37YuX0Ek8FkzDTYzCQdGUxDhVHEAodf9k0Xn2zEt4Bnkx2qs?= =?us-ascii?Q?4IvzXNZDqOrLCHydtQsQ44bH73PrtDJaqWcQ6X5cFN13sPAV4J7JLP5e/0qJ?= =?us-ascii?Q?a2jTF1q8XdnxmwatVMhl24kH0T06R+eFKVj3mNvfuA4PocpMdRcpPgCkORZn?= =?us-ascii?Q?aFUtv5rwy+9jWTvOcz4eSQ6ODGiEbmBibRoBadzkRg1qDsHLXvJZwtC3ns8Z?= =?us-ascii?Q?SCcNIOYlN2OgGnaCIsh7MO8dAXMacXDaoZYfRt/8Z/aBkRvRdZXFrtn7GLn6?= =?us-ascii?Q?/tJfmX3etGA7hwLNiDh/OPgXK4Jpvp2+4VZtOWt5i0rpDKpL3aJhVHhvkVFo?= =?us-ascii?Q?GwP/tq1hc9liudXwDCGFiZ+fIHJImlLOqSVP6P+Mu6Lj2RE54kFxa6JCE+ej?= =?us-ascii?Q?XdZWPk84qeOUtYMkr2bfSNvfRDyDcZRndM+lyNXxJ4k63VwnF2jsyJOAib1K?= =?us-ascii?Q?KhYxBdzW2AOJ7h6TI9XFOWkFo0g2/PIAhtqU/juYPNEv+JcOzA1kgOthM+uX?= =?us-ascii?Q?GhrH8iupB/0XIaGsvdG6bxxqW0YAoxx466MaW7tSk0ZWF27e2obmWXKifzVG?= =?us-ascii?Q?X9TlQ1fWCzAfgaYc9OR6HM898LZgNOhw9X14qt2qHlNNz0sg4BZT9VHkSbVr?= =?us-ascii?Q?ORXNI70wAbBcPgi4GALyNjT+bU6qXW0hChk/CFISLg6mYJgaUv+qXQ814Jp8?= =?us-ascii?Q?5S4/UjHsVksMalLFbiEbmInTrfUKpGMxJ180mrn+jDE/KJed+p2zt7zb9B5P?= =?us-ascii?Q?BSowqUBi6G7zjmbBI2eE3rN3d1ZZRAJXzKc5QqPRnCkxCXIZ9IcD0mA8EB2P?= =?us-ascii?Q?wEEzbfUHEmvQ8pRACr9Vn1on5ChAA8Rn+A7Dedf41UJBkXXEL2OIAUtoBZub?= =?us-ascii?Q?OqAK2Bybz4QEAT0hx4Raax21p+Z4gU1pqf2RYqqMrRZ65BNKkmwib4kn0n0l?= =?us-ascii?Q?CMVd7KAzga5Mq+eSUfppk4UXo8/NfpvZcDNNc1TzCNuXq/msdGrrSLyRMpMq?= =?us-ascii?Q?439i/0f8xs6PYNEdadjOtogiPKg574PVdKbB8nVcN6u/Exm6WxTUEe8vcEW6?= =?us-ascii?Q?ynAgNgoc82DTSqt5Xn+YQccDLo102KMdmQAgqoQtct1SGe2snZTmvKlGo7bb?= =?us-ascii?Q?Vz8Y1f4Beww9bDlLvaFThQNwu9087PX+P1uSel3P?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62e0cb72-bc12-4ce5-8d5e-08db5819f2ac X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 03:34:27.1404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xzY9vebaHA5ncv+MU1hmditdxcIbdnACdlhmbiGNOehtg3IRZ1kD4GVB3ErrzZWVlVQUyobBlWeo4EqELLjFVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8048 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chang, Abner= via groups.io Sent: Saturday, May 13, 2023 5:33 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Abdul Lateef Attar ; Nickle Wang Subject: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFrb:= Add to ManageabilityPkg From: Abner Chang Add IpmiFrb to ManageabilityPkg. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang --- Features/ManageabilityPkg/ManageabilityPkg.dec | 2 ++ Features/ManageabilityPkg/Include/Manageability.dsc | 8 ++++++++ Features/ManageabilityPkg/ManageabilityPkg.dsc | 3 +++ Features/ManageabilityPkg/Include/PostMemory.fdf | 4 ++++ Features/ManageabilityPkg/Include/PreMemory.fdf | 4 ++++ 5 files changed, 21 insertions(+) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec index b0ca01094a..3980931424 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dec +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -79,6 +79,8 @@ gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BOOL= EAN|0x10000004 gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BOOL= EAN|0x10000005 gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna= ble|FALSE|BOOLEAN|0x10000006 + =20 + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb|FALSE|BOOLEA + N|0x1000000B =20 + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb|FALSE|BOOLEA + N|0x1000000C =20 [PcdsDynamic, PcdsDynamicEx] gManageabilityPkgTokenSpaceGuid.PcdFRB2EnabledFlag|TRUE|BOOLEAN|0x200000= 01 diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc b/Features= /ManageabilityPkg/Include/Manageability.dsc index a432b0ff26..06fed828b2 100644 --- a/Features/ManageabilityPkg/Include/Manageability.dsc +++ b/Features/ManageabilityPkg/Include/Manageability.dsc @@ -30,6 +30,10 @@ ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf !endif =20 +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb =3D=3D TRUE + ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf +!endif + [Components.X64, Components.AARCH64] !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable =3D=3D T= RUE ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf @@ -51,3 +55,7 @@ !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D T= RUE ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf !endif + +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb =3D=3D TRUE + ManageabilityPkg/Universal/IpmiFrb/FrbDxe.inf +!endif diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/Mana= geabilityPkg/ManageabilityPkg.dsc index e3baf27f2a..6fa3e3c6ae 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc @@ -37,6 +37,8 @@ gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable = |TRUE gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable = |TRUE gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna= ble|TRUE + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb = |TRUE + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb = |TRUE =20 # # Include common libraries @@ -53,5 +55,6 @@ =20 [LibraryClasses] ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTran= sportNullLib/BaseManageabilityTransportNull.inf + IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf =20 !include Include/Manageability.dsc diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf b/Features/Ma= nageabilityPkg/Include/PostMemory.fdf index 9100cb2646..84e7ea978b 100644 --- a/Features/ManageabilityPkg/Include/PostMemory.fdf +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf @@ -26,3 +26,7 @@ !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D T= RUE INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf !endif + +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb =3D=3D TRUE + INF ManageabilityPkg/Universal/IpmiFrb/FrbDxe.inf +!endif diff --git a/Features/ManageabilityPkg/Include/PreMemory.fdf b/Features/Man= ageabilityPkg/Include/PreMemory.fdf index 16e079f494..add36e2095 100644 --- a/Features/ManageabilityPkg/Include/PreMemory.fdf +++ b/Features/ManageabilityPkg/Include/PreMemory.fdf @@ -10,3 +10,7 @@ !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable =3D=3D T= RUE INF ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf !endif + +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb =3D=3D TRUE + INF ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf +!endif -- 2.37.1.windows.1