From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.19044.1654808089854381189 for ; Thu, 09 Jun 2022 13:54:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YRvrZysZ; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654808089; x=1686344089; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=03t/rlpdg1PkLBdZSUa70+9lZADUEy+hNYOAipShpDE=; b=YRvrZysZFFvxSbKxABnyTQMYD2Jt3zCL6OId3yDesMyMta41S2LlaVs3 FZ1vxJ3c0IwSQmETQDMU4FRkpJ1eoDOyr9pk7ktlDzs10QRk5HBGd+wqc 6nmYiiNiVHNg4wRkV47QKW8Aw05KIw+glvHUYuv9CIPuiy/4Dwy7NdQuA jnka0HphfFId2IGirt51aQDyfXp/rDnhZFvwKTS1rmCBapENiAQgkn0of IB52kj/RF5tyDos/0Da49+9JNMHSdLCGKKuNM2LY8TxIT6m5n8yhF3DA3 2PwtXyfDSxaffVYzfXhFXsR+SU5NSjrK9aAeaY/fv+ZAU7eM2ARsMhsfg A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="276187907" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="276187907" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 13:54:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="827811053" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 09 Jun 2022 13:54:47 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 13:54:47 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 13:54:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 9 Jun 2022 13:54:46 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 9 Jun 2022 13:54:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbCtLr/m2UfzlWxpPeVN1H4oeC9ucYEdgmZ0WHPtnNIp70aA1+Got1nJGxlw2DJiWg0XehhFF6qPlUYcQID8kkj2vHwhuAXFMak7wu4kX2euCUztUcr3688PQoRcM7UXvPH/Ajz24RI57VcozWANnbCiP/I3ew9ijc9ZUknJ377+ykVLM0lXlzd3jO/9mQfue1BN3PVGMrhEOcoJKlPwLH0MQ1EmnnNO9YTVy+Bc3syK2EH8uB+b7WNGr90yPwrfc5Cfpgpa16RFMW082Yz0iGIyM1iAJRSpMuVkshQCNh/NRfh/dtMJdXf40D3AUN/KgwyDkjP0+DFABYPnIMbwsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JIfPpm2MZvrawL0fjL+qLtRWD5sycFFIKQ4SiqIflgI=; b=AHx9LZX9BH321ObDrn2/cZWkZstXeTZ43voe5AcLdZ6aHq6AaLoI6VWmxi+hamvJOVmFbojpS+A4ezKOHkBj2HZU8L4bJ9+/aUvLebDfpNefqQ9RVXCRdnCbKnaB0I+Jt6Foz7kgWVEwnNkCbkqjW7XdWTmSplkXBs67qMsBuq41rIOPxtKq8n6oRDBpFEV7xlRX7OkMqbUPlIRU5n/tEk6pQ0ftVVOD4eqitaBVQ9O2IlqLTOMfyaKnVvnVunPRTdWh7xER7VetFIHub7+3A9IjI4zIm25dChCKovHgF7/186P9WNH6PEJEaPTZrulbabPTIlgJC4i33ERni4HLDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM6PR11MB3164.namprd11.prod.outlook.com (2603:10b6:5:58::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.18; Thu, 9 Jun 2022 20:54:45 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::e80d:5d0d:dfcf:1813]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::e80d:5d0d:dfcf:1813%2]) with mapi id 15.20.5314.019; Thu, 9 Jun 2022 20:54:44 +0000 From: "Oram, Isaac W" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Thread-Topic: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Thread-Index: AQHYesi2nYimHWmowUqtTpvkzc6OBa1GDsAAgAGB44A= Date: Thu, 9 Jun 2022 20:54:44 +0000 Message-ID: References: <75465408b8a1cf0d269a2b1d2ea7707b6731893e.1654645346.git.isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c422a527-a891-4bff-87a5-08da4a5a486c x-ms-traffictypediagnostic: DM6PR11MB3164:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XVZkm0T6HzoaC6z+ctYebhlPbFJDMkqdgPv0zZDJc0wAbay5iBDLN/i9LnVb0QPt0UzBrm//r2Wh2S4AWcQoNpFOKdPxwBRjiLvVE4xZJvUq+H2ULZGVaBE6hA7hUwGG+FAEmYfVv0+A/YMe0z8+PJhkyqRdDmbCwGsb84OlA2e6ZkvvPdunwvkREacPkIkfjetV3MO7b7QGissR5JrFkWy8tkjp7LwS8ibgGIS02AwC1yH1gyxUMj75PzPdW9vCxae04sc2Ud2d9QhGib/tyWbM3BaKcUggWdg1v5ewaYt7QlkS/vt77SbxpH/T9+ix6WHrBFzxdYF6AxKuPyBUjePv/7oWKhVSelFQmfNwYCP5wE0klM+8S8nCsKpCYrUHVPhPkaE1+J2aI2vSdA3xBB8uFgoYi2yjzyoN9cAHQT014Oo+UkyZ17CKUVIxofQHGVy/8csBIDHfD2cmN3zkqd+ojZ8eKjBJn5VGI+2PmIyPG3W9mR1rR5TllGun6hn9RknPDuI3/WZh1mmB+mZMKay8ZnJhrrs6VAN2yQLaLVTpwvi7aCxFRYdCHf3w1MWmazjWe7J72Fk9mVSl/tbK3k56lB6i/537fmAYklCi7O/6Z6FF+Dvm/wsl5224tRIzOSzJFl2MHZ8O4VEp+U8V6D9bV/0Mn/q37Dcygm6+4fHoe8+/npVMXnC26fc9+TCC8LmaOGWgpAGgM6r5p4itgQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(9686003)(186003)(66476007)(38070700005)(6506007)(26005)(107886003)(4326008)(76116006)(82960400001)(55016003)(8676002)(122000001)(38100700002)(86362001)(66946007)(52536014)(71200400001)(2906002)(8936002)(66556008)(508600001)(110136005)(66446008)(64756008)(53546011)(83380400001)(33656002)(5660300002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nPJX9RyT5g4u540DFOVPIU4yg6Ho1ftlJFfPA9Fz1DFRSM6QYh5xWnsAFT8k?= =?us-ascii?Q?QSqW94JXdzGfsjTB03ATVvowBCpVKm/jr8Cc4Jj3WDsVcxgG1pSOanH0ax89?= =?us-ascii?Q?O+J/OCOcD2ItwARepUwXODPABbkVnLA/z4LfhpjZjvZjc2ELVFtMDHkY5C7S?= =?us-ascii?Q?006ckj4MAn4BCApUMXW5Em5g8fiaB31Wg6rL6L2BMOddALOuUrW2yU8b67uj?= =?us-ascii?Q?+8FmkyGDFsHj+pyJG4UsV6dM8PCnidEmzx1i7gOFpastYq1oWcy9E7uh4s6C?= =?us-ascii?Q?2PG36vdZZvlCYihYdAsTJl/gooaebT48lk4hjhFJ1flxG5dYgN4G4m7unUfM?= =?us-ascii?Q?N+oRANroAbdvLi8pNmdc/1hUslK7SrHg2UDfM0mLV4QUZPranIhPH5yHAJcG?= =?us-ascii?Q?09WBa7DPTxlQZfaPU9G5rpNOLHQvg67qN+RvWYbVr3g66WRuwRUid6m+6o+k?= =?us-ascii?Q?yD2ExwzbhpFQ0jWORDC4KXNH2tYl1vT9lszjPujreVwmpG4a/jIHFRyCE3FY?= =?us-ascii?Q?Bl6AmxRU8OABIZsqXkWN7y47sqm4kLjErILVN7G3IVXqvt4V48ldWLVG1EhT?= =?us-ascii?Q?qz6iECm29DX///uvckBLyo3phMI/RBUossnuKVuoqZB8GlamoQnCU0R3a7my?= =?us-ascii?Q?UiSj0rZ4lK9595wBesn8g1DBpGAOyBBWH0i9XNSmP6ZWQp4Pl9pK0FWV9MP5?= =?us-ascii?Q?/YquZX5q1iQqwyZCoZ/aX4xrGgPdZ8oAxHuFKB105ZO5puw+F+d3peLRVvQP?= =?us-ascii?Q?6fqDQJop9qoLWFrwId2zUNxiD6Yt2p9ZEduNDkUjH/SFr5qLsv8clGkMl05Y?= =?us-ascii?Q?2hhnTJMuZpB1cGvIKx77uhmlvtXxSA2lJKU1EVRtnV546CiUAsTuxqTN+bRA?= =?us-ascii?Q?ZLY9OmRU1mW+K129EEcdvMmDCcUVGI+Q1F9j9OEl+3811GA97oKKuXxvd3bS?= =?us-ascii?Q?sTS0Mfk6DcMjh3WcyVYOcc7cTfOTJrnK8oTlzXBneuP+cjdpjlU7GlSwz/jr?= =?us-ascii?Q?1cNWJMET5ZXgGh8TfZAmz1H/mcJRu20QwFewn7fbequ/mGAcpAXyXaDaurfm?= =?us-ascii?Q?BXM3p613hL4CypQAnd5QbNbYYT7s5l5u4tLPYlIDIVSAfco/H6686bw1TAZ5?= =?us-ascii?Q?Ahuo95vdqhG2OqXegh0xqZUEzu3fySu8vBi0aeGBZk9pRckQEsrcWwIoGot5?= =?us-ascii?Q?qpeMFfAvl3nJIU9tSEwrmvFqCuXrRwwZ3VgIsNMZnRuSma73oHqnKwfsIpY0?= =?us-ascii?Q?n6GequwB07KcVjCkRzZgMfzprvVwBRXEebBAZLJVPVVkyWAzmXaF3Hfq2JYS?= =?us-ascii?Q?0qIYJGdc6Lt3rfs2cA2mcvWBzWx6PrJSpS/pwWpbvPXyi6w1LXvE2BCj/b8r?= =?us-ascii?Q?iqbMqih/olv+xyUZo1mL0IWB8HtnsqGCFQoAptw11Li7VUnxfIu4weutV0OS?= =?us-ascii?Q?gwbW1CSG2gDFylXLzzoLWMEW/BhSc2h/DbfU6ZWCqUet1x+/dhvj3I7jMAZI?= =?us-ascii?Q?RxYGZCoHVEu4ibkTJBU8bzhmZXxqM+a49makPAwSo2CpYr7hwWRM7N+u654A?= =?us-ascii?Q?MAuo6fsVy08KmGEWAdHDFSwcvdYD+1ZReqh57aEv1L0r9R1yz2q8vmmLdeLA?= =?us-ascii?Q?UUpfqQ27M/bD2ZStrfE9KsGEOQA7th48zlHIgv9gfHt81kjDBTGkqUdTPc4p?= =?us-ascii?Q?ZEPKNtBoTPRC1seR90ZF9EW3I0vYmgfZbD5E1Of4cyMK48wkLRir6tg3I5/z?= =?us-ascii?Q?Bz/uHpAT1g=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c422a527-a891-4bff-87a5-08da4a5a486c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2022 20:54:44.8774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aRKTVHfVQpMbjbUqznSyhr/1Hsy98biTnceWSbQdkcT31y8C83RznWQw6xr5n+W+g8acmy6Ett/r6ZMygovkrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3164 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as c546cc01f1..2a236ae742 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Wednesday, June 8, 2022 2:53 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/P= chPolicyPpi: Fix binary structure layout Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, June 7, 2022 4:49 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPo= licyPpi: Fix binary structure layout V2: Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2 V1:=20 Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definiti= ons such that compilers generate same binary layouts. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/Pc= hPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Inclu= de/PchPolicyCommon.h index 0e10d0b8f0..11057a3ace 100644 --- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicy= Common.h +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPol +++ icyCommon.h @@ -1351,7 +1351,9 @@ typedef struct { **/ UINT32 DmiAspm : 1; UINT32 PwrOptEnable : 1; ///< 0: Disable; 1: Enable = DMI Power Optimizer on PCH side. - BOOLEAN DmiStopAndScreamEnable : 1; + UINT32 Rsvdbits1 : 30; + UINT8 DmiStopAndScreamEnable : 1; + UINT8 Rsvdbits2 : 7; UINT32 DmiLinkDownHangBypass : 1; UINT32 Rsvdbits : 29; UINT32 Rsvd0[6]; ///< Reserved bytes @@ -1447,6 +1449,7 @@ typedef struct { TRACE_HUB_CONFIG TraceHub; UINT32 AetEnableMode : 2; UINT32 PchTraceHubHide : 1; + UINT32 Rsvdbits : 29; } PCH_TRACE_HUB_CONFIG; =20 =20 -- 2.36.1.windows.1