From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.7307.1661996914259130692 for ; Wed, 31 Aug 2022 18:48:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Fey1TkEy; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661996914; x=1693532914; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=n5Nj+omItBchWUryg4Umg/f7Eoxj2GMrg+sQMgb80Xs=; b=Fey1TkEyqRo3oW3o4TklLaVi9ehsN4PdHgmabSjNVDO8r8zrhXH8FnyE HFIluciS1wAbYZS/2WtNZ8KmyLNwLw0pnvGGsZXca50NyZFbrbERYJfEc 1j7oT8dFx9+R0lgqjK3YmigmmiX51JI7y5BT8x6JTsTs9KGY41niCIng9 U5yTA9DriAod50cJxTvTS+Q4nOQIAd860kDU05kC+HiNje5wNP9CD93L2 yFKzBCQQKis/PntgBI9ud48G5B3cHXSYrz5NfjnpoXBSsbedxVJtiTmnV JJdQh0PqkSCGaz9fPVMtNiwx7i7nAUE3KCGh2iiYuYjrxHdM68SiT4qP6 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="296376929" X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="296376929" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 18:48:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="680651283" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 31 Aug 2022 18:48:33 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 18:48:32 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 18:48:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 18:48:32 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 18:48:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AdaWvhRqRyXJe31ZmFehPgZngNEvX6Xorq6Ywsq9fUeT2edJxD6UbJ+5DwRsRiWftCs0J3yqTS0xvfipWke6+Etd3xNBjrQGXSbkC98mJL2XaJTged0acsncJlI9O3mRhLS5t5g1K8cA3bwWtjDJZpTmQmqny6DVFEyeT4sAZJPrHgDkj0pvM/hSJuwZIYDvgC5l3UW/0nckTPJj0VKlXRFivzmZPEyz4/A+uc7dbbcHRp2JnWAu10pkejPWY518mguqVUAJYWJXLQo7Kpx6sp0NTcT7E+7WXThlvlEXxKVku8FWC1IB7YtnY7VKYsKmtRNotcyU/LLMu2esar+8eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t3Rx19wCSKgX/i/v9lI8h5KBiRZdeVlVZuep2VLbEOc=; b=j61LGwXQOv+grQm+i7JvYx4jFQpNQVZWAeOzzjhlCLhd/90Yv8St7LO6TtR5n7iPtregjeX3c+VkDNdPuTWpWqS6ghXdVIxt0yqLgWnoxcERHrHykb0bUmeoSTM1VZ4KErARTL7lEdSzaXZ6r51fgJ2v7ggF8F8rv0i/Np5wE3nlcelPfVfWUS3wP2NYvQO1j+i61QFXhodWTUFE+xtq+X25PQLRazAFNJPgx6hPbkzcCjvi174HfK6mAVFabmHOlNAZ/39VZRQrszi8voD3Ug1f4c3T5NSUx0TgnescPR+4Z8OuXFdUxO/ShP2zdw8LYNf3WtfqmTszF/fsNBYIMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SJ0PR11MB4799.namprd11.prod.outlook.com (2603:10b6:a03:2ae::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 01:48:25 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3%5]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 01:48:25 +0000 From: "Isaac Oram" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Gao, Liming" , "Dong, Eric" , "Chaganty, Rangasai V" , "Luo, Heng" , "Kethi Reddy, Deepika" , "Esakkithevar, Kathappan" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Thread-Index: AQHYnftiFnUtvQIGGUCzLaPggbzU1a3J/wsAgAAOqMA= Date: Thu, 1 Sep 2022 01:48:25 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab5014f9-8c20-46f5-ac0f-08da8bbc0f24 x-ms-traffictypediagnostic: SJ0PR11MB4799:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n4zVcAixCPn5XyVuzKo8HhMpJnbomD2nGyh4RG1OI9a3/1NJJKxBTrOfdV89CsJJlo5UN5icejjnw/aTgJ0qPF1oOeOo7urNMDOGtOFIWauFgR3usJwcJXLJuge69zG1wNnw5OtTx5ROe9GBlqUSe4dUAoca8wQ1RJQmTiRG6fC6wkJtoRZMDJl/5Tx2JvuRhXK2+U3bKJbu/Gjjlcpn7mnIrx9vkSGC735DismgJDLn3KTyDs2pHYUqeIZkOpqI5spSXkDgt7JgRmgXBffGV9hTLFuaxLTUkqj5YG4btw+NJ72ENKTWpv//ywVR36BDh0817Hpm+89qiqRIaO0ilxnQg3jLZZ8fTwpMXpb39Vm8Yhkw0aKe2wXJxuIr5jptZ8gDn0dsZlJllvWm88T7YrmVg4KikijP45AMIskmiffZrJPC8jhQqx7+KYVOs6JwgRaGaZnoVqey11mqj8o3J1VjHyPbPFhGPin9SM/9VUh/Ux3j+Ziun6qydIomOh9CMDRC0Dwlb4uiWW3jEbQiGRRY6Yzk+cCBgSMkmw4mAnWe2ENKGUgCwQYk4KhTbMk9VSLFqn1V99poEHf0qrEb8SLJG0wQjxeq+gKP+mbOOftHJs31UFb8u72eOI5ZaN9FjvNjUX8ZlpZqOS1SoqCyeS07vzLpqR/ujO+1nunWKfSIZogl711ikr+HOE2LAU2a1FGzJJn+vOiuzV8p8j3UoWiXr+Is/eLVyy0YBslhWiRAiXSAH1UtWsrKzxmiP2BhgcDiTaS8/GobxVDjx7/Z7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(396003)(366004)(39860400002)(5660300002)(41300700001)(186003)(122000001)(52536014)(8936002)(38070700005)(55016003)(107886003)(9686003)(53546011)(7696005)(6506007)(83380400001)(54906003)(26005)(71200400001)(110136005)(33656002)(19627235002)(2906002)(76116006)(38100700002)(66446008)(8676002)(66556008)(86362001)(4326008)(82960400001)(66476007)(66946007)(64756008)(478600001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6PFGOJtINBb8yKCGkuvkN3Y2h7aALNUQEVIpw/lyGVXKQnyIKnJeEOSlcKTq?= =?us-ascii?Q?qR46VyxGO281VcTCgAOV89l2KDqz5C3l650nz1AVv3SzYz9qzwBk5+LJczH9?= =?us-ascii?Q?XKMPZ5oDpLjTmJgRDOfq3j8zIxtGQb6A2p2JK+ded34zU1yme1ZiKoLKs0VA?= =?us-ascii?Q?zkMdpGCBGDhRebRd9HPpDYE0g/hVE26WorfjabnzOHKUlNg2MAAlomCPTon9?= =?us-ascii?Q?b5PWgJY4I7JGGTjEanTBOqjCF6Et17gYtzzCXiBQjzVrMsrIXMOg3ORMdLRp?= =?us-ascii?Q?egOSoRxcDS3Z0CoWieLWYCkgjbf/+2f2Se/DA5wcTcQaxTTUPEXH9EuEQlGE?= =?us-ascii?Q?4v3fjXpfUHYpzAa0etEHy16leCd3zwzficy97sAxSgH2tQhGWA3v9fbdOSuv?= =?us-ascii?Q?D7nYmDu4r20pETom5CQp23VK+W2/Cdhivqp8CZAOpP9HM/wX+aLb+cqkKAYN?= =?us-ascii?Q?956R0LR+EaAkmI2ICZQ8RMzm9VH/lofOLz557KHTO0CSeSR4/Gknhe1Q2RTU?= =?us-ascii?Q?+Zu3Gp1uZmr2ruIRulyST+2i8YSDJ0t5/kXgoBM/u9tL4zjFVHLO7zI7Qj3B?= =?us-ascii?Q?toYkbRlWk1vSH+hjkyv28sfZ7zHd2J7mOE9kwPLoAFRbcExrI3jvE5jzDXxO?= =?us-ascii?Q?Hu00BVeujkPDN2FdeX94fCLvLfPTldVUacUtXGm1BJbjDrmrrWT3FzPh2Q0z?= =?us-ascii?Q?1Y5/tLwxXCFfnKaH1uWm6e8lbxJOT44/l0/RZxg0aQ4UNnjSsSGROA/hmKZf?= =?us-ascii?Q?wAj3KwULBhlFQTrBbdo1s8pks0wG7jh4M6TqdK7Bwl8gYrxVplUO3TYdT3g6?= =?us-ascii?Q?qBYyPtBbIvmXSxZluo1R4G4gsaeuE7Scgo0mJhsStZ3Av5jQhaRr/0v3e+N0?= =?us-ascii?Q?e6TVndAVMHdL65xE37yuj6WH6hUvdhbUqyI+g50ySrKvMBigYH1/3QSnsrNp?= =?us-ascii?Q?1i0U4APtIotuxiZCsSl/0YS4ZfItUjtDM2GkYubXSSpPBDvanCo3brFQ+6gj?= =?us-ascii?Q?HTGl2RiwQx68g3DVG2Z6h4lWv6GB3s0RLvsZ0lofno7iRP0E58HkNjS95QN7?= =?us-ascii?Q?mAQesr1FXt8NphX0D9lAj8KKqskq94K8YxR/m4TCs4ILrLpUGN4CGau+gkxv?= =?us-ascii?Q?u+nmWYdfm4Anep8Qdh/wc273yhEKN0TrDwTfj7X5WCSFskYJw7V4JBnF3i7S?= =?us-ascii?Q?PuB5r35VizOMxBWITfD9l7fakq1SYLu8OM7JKMUxXN2UPVeOndtpYA8xw/Mq?= =?us-ascii?Q?tYu2eSbDTHwumogTwRlsrK/+eax+jZgn67vgGoh2yUixDtFCYclcnf7+1T3z?= =?us-ascii?Q?28R++FmX9VB/L6v89exJrwQ5Psktr0uzkyJeUodADPZj1sNw095LFVSMW0M3?= =?us-ascii?Q?ghfppoArHKXJVORi6EVD6ktdShE72NSZdIs6YwpfxuHxpInL2UwoTXcWxSTc?= =?us-ascii?Q?iMOicgSmDjlX02bnk7aBtjOk6TGY6DFxbUs+r8pSEe+JoGk2A+CnVxnes2Iq?= =?us-ascii?Q?Js1pZ8ItrjyNGRd34jwh57fKT0VfcUIN0GCSuH879DGniBJczyilwCBMQGkv?= =?us-ascii?Q?17lG9zXOcR6GshMaV0OtQqRZUPOSivZ9OinDMRmP?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab5014f9-8c20-46f5-ac0f-08da8bbc0f24 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 01:48:25.0208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPxF9oXtTNZgz+Z1vw/Um8LLxRa9g9XvmqsGvwOQzbrjwRhymjgkGgcqPuy1om5BjmOCOv18aBzlf4PriZZXPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4799 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 3c3b116801..d9994fa7e1 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Wednesday, August 31, 2022 5:55 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel ; Gao, Liming ; Dong, Eric ; Chaganty, Rangasai V ; Luo, Heng ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board po= rting Hi Isaac, Good cleanup! For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Friday, July 22, 2022 11:46 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming = ; Dong, Eric ; Chaganty, Ran= gasai V ; Luo, Heng ; Ke= thi Reddy, Deepika ; Esakkithevar, Kathappan= Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board portin= g These changes simplify the logic for board porting by creating common inclu= de files for initializing PCD and for some stage specific logic commonly im= plemented. Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpa= ceGuid.PcdPerformanceEnable only. Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure. Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disabl= e handler profiling on RELEASE builds. The net result is removal of unnecessary or duplicate options and the reduc= tion in duplicate code with increases in comments. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Sai Chaganty Cc: Heng Luo Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Isaac Oram (13): MinPlatformPkg/Include: Simplify board creation WhitleyOpenBoardPkg/Build: Reduce duplicate code Features/Intel: Reduce duplicate code WhitleyOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg/Include: Simplify build logic BoardModulePkg/Include: Add include for stage behavior logic WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code TigerLakeOpenBoardPkg/Build: Reduce unnecessary code SimicsOpenBoardPkg/Build: Reduce unnecessary code PurleyOpenBoardPkg/Build: Reduce unnecessary code KabylakeOpenBoardPkg/Build: Reduce unnecessary code CometlakeOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg: Remove unnecessary feature controls .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++-- .../AcpiDebugFeaturePkg.dsc | 12 ++-- .../BeepDebugFeaturePkg.dsc | 15 ++-- .../PostCodeDebugFeaturePkg.dsc | 15 ++-- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++-- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++-- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++-- .../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++-- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++-- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++-- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++-- .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++-- .../VirtualKeyboardFeaturePkg.dsc | 13 ++-- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++++++++++ .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 ++++---------- .../GalagoPro3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Include/Dsc/CoreCommonLib.dsc | 6 +- .../Include/Dsc/CoreDxeInclude.dsc | 23 +++--- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 25 +++++++ .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++-- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 ++++-------- .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 ++++--------- .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 ++++--------- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 ++++---------- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 ++++--------- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Aowanda/PlatformPkg.dsc | 3 - .../BoardPortTemplate/PlatformPkg.dsc | 50 +++++++++++++ ...blePerformanceMonitoringInfrastructure.dsc | 5 +- ...anceMonitoringIn= frastructurePostMemory.fdf | 5 +- ...manceMonitoringInfrastructurePreMemo= ry.fdf | 2 +- .../JunctionCity/PlatformPkg.dsc | 3 - .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++++++------------- ..= ./WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 39 files changed, 382 insertions(+), 645 deletions(-) create mode 100644 = Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFe= aturesPcd.dsc.inc -- 2.36.1.windows.1