From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.1586.1672878634179598315 for ; Wed, 04 Jan 2023 16:30:34 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KWA3XzQ3; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672878634; x=1704414634; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bxSO2YCsI+4Z6T8PeMS/xKFZmWWGEnRRaHMMCHL4yCY=; b=KWA3XzQ3g4g4XGhntrnqkCB17h39rBS6czj6Fj0hE7jxrWSTlMeNLXS1 fMxpu/wkJ06FqOLErMkKP9F0IWZSj9orNdZfx4iQZlWsb0YqIDOLA9G1y yA0ZSagZFv4/OZjelSY9YcZxH3fr7zj95zak2eY6zelBvEqmw3kBS4bY2 SzP4W0weRaUYzfZUx7ZaZCxm1ScpdsHFxfFedMWN4AVgjO6iv12fevV4w K9RN2vPkCOE8za3mKp8EhYFyJejalKTp/dx/YU6q/hTGBdhbOYDsAvLOn Dbr9v9ddgDrLUhxpgzFEXqPN3F4rAGzHgBRGSy+hBraO+DU1cVHxeR+wg A==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="386518348" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="386518348" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 16:30:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="797718674" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="797718674" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2023 16:30:33 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 16:30:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 16:30:32 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 4 Jan 2023 16:30:32 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 4 Jan 2023 16:30:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8apOCAIu/6gM1Z1DQCh8AUFnQvaV64hIsYlpgT1fTzCiwZ6NSLKnDY7c8aRW7b5Z7++Srq4+N/LKTnpOuVuLi/fE+XPpJf7T1gYr19OJA3jeXUxWTWExgkwMLg30zCbagKVNyrTGnJHexqb+9Rpr4tgCHyGAFOKtbJFiR8zIQID2G8wBs2zfF9ymxvVEgSnLZetLJpgpZ/HpZnrtBd3Wii1w4Do/o1Yv6mfUoEyiD2PYNjJ+IQOsGyqynZ5xJoicvA5lG51hadaunJvohC+b2p3sp8dvIAExx6UOgEbc57GOVceLxah7gnsz7L+u3a7bF7lO/lO/xsZWprB/7P0rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YgqlHb0BNmAbtS/tyLCogp5F1XaKbsdNCnrsCBIIAXM=; b=G7JVA7etuzSItnQ9ONUtJ8MdjP7W5mgBcdX9N2r6niLroeQkVyfAr5DJ0Kr9h0aBWkOBZM+Lm9GJ6wbEmrlstsheuPRaAsu0kPNpsjdMeemN7Y9czhjR6cL/4WAulU4AKseaTO36MOhzZpPnw7DDoggQXNgACED4MelmuOB9b/Cy/AYw7/dQN0fuOEsJ+pusfT4mHoYR42JIjwnY0uxwE1PrdnjjDZnl50wqpDaJAZlF5teXgzBCYsGt7thzZqwc/FM5+xGYrjOZYNl4aXCZoUrPY+KAx7OOJRTXJIjy2/BjaTkzACSKDswFAaEy5CMgA4juTv1nBdFL4ARWpauU/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DS0PR11MB7529.namprd11.prod.outlook.com (2603:10b6:8:141::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 00:30:29 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 00:30:29 +0000 From: "Isaac Oram" To: "S, Ashraf Ali" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v2] FIX MinPlatformPkg PCIE Base typecasting error. Thread-Topic: [PATCH v2] FIX MinPlatformPkg PCIE Base typecasting error. Thread-Index: AQHZGPAtyil1GzLqok27GA2QJo+42K6PBRnA Date: Thu, 5 Jan 2023 00:30:29 +0000 Message-ID: References: <3f8e35db6103443d095d33ed2efde6f8449de2cf.1672034725.git.ashraf.ali.s@intel.com> In-Reply-To: <3f8e35db6103443d095d33ed2efde6f8449de2cf.1672034725.git.ashraf.ali.s@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|DS0PR11MB7529:EE_ x-ms-office365-filtering-correlation-id: e32ad1be-9c5a-4b93-f649-08daeeb40c8d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jIA44jGsP4GUdz+qUSTyE2gAmENBcffEoGZvOnSJ2KynzKru1so7jk2ZVPuhtKDzhIAy/pHjfWzi2EblzZOojSNVuzoWtVtJP3Lszv6PNG2NBQIWX0iJhABLvdFOZzhu6tUhIvZ/eLQaW73IudG+A0wIDx5aLgZVI8cF9SDvVIh6x0JRZld3EJgLMoM5IOXaxYZV91c05MJQ8ynXPxQCBAi3UHvkPez6Gf8DAcOcIbUfC4F24KwgWta4WQb/bpiOeH7x5YZeos+m5YO2pCWit5tCwQAZ6MkyBxYTaIQakzkwhi5IxlTexCEx4xcYJJ3l6Fqp3YsyTrvpEJnVcrC4229FOsFRk4SQTTWaL4OMl5UPJlRltqkR8u7eiQ7nqvcrCVe3v3U3W9laEDA04PcGGQSN14tJ91HCETqXzRBW7GpAqRXdJacBmVSH2TTLWnfuhQTYt4jPG/1Qjqx2ewyws+zGKcbT4R3AKfzodXkLUoymLPk5XqzhwSnxinORrHFYHfmEqwoTcebFs3jWvWcSXBqsJDFmnxm07rKR1wwbUWKf+39QYBmePvM3hAVzo3YI4dtoRYqsK1/x7x29ECN48aLXBctycHfo9nU4AQhOthb+n+4DakE+Zeg12WR/PLS+FewfO8eS4OteWdR4NrcZ4B1lNSObk/g+1ofEkXxXhppdsqz6I+wec4fPG5U7TnWrGd12t94wiDL/b8qkV5DBooBivQh2TKV8zgzIpSaj4Ko= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199015)(86362001)(83380400001)(38100700002)(2906002)(82960400001)(38070700005)(122000001)(52536014)(8936002)(41300700001)(5660300002)(19627235002)(9686003)(55016003)(66446008)(6506007)(107886003)(478600001)(186003)(26005)(316002)(8676002)(53546011)(64756008)(4326008)(76116006)(66946007)(966005)(66476007)(71200400001)(54906003)(7696005)(66556008)(110136005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xhW/b1uJf8sTy98LVAWU18nH1onWfeGzF3AirblrT70wJqDh5k9UxS8LaDHp?= =?us-ascii?Q?V18lCS35F2PemcfdT7mJYOLz0NHeN6ezCFHJ9qXIQEhHJqmtuqQ7TNVDRCN4?= =?us-ascii?Q?Yre22rnrCJ30JhdkPiPadDLGXn2J96BHSlmVu0jmblAO7I0UTGmnWLrpxUkq?= =?us-ascii?Q?dxHwG9tzJUIFDbxwN7+mlltKWGHw76CCZAXwejYTo8vWoLJgh6h4YynA4s8y?= =?us-ascii?Q?Cs7PA7GtUZFCIVprUtGcZka+RYF+orGb0+zY7VS8FOuOAy9jgo1AWv1DBRQ6?= =?us-ascii?Q?e1IbdGAOCfiSQfzDaeu/sLYbuGFgZdclBAJ2b1RPVxpJanFDhT+WHM/aWC9/?= =?us-ascii?Q?WMp2iPotQ5QizL4epp2rVokZhI5wMR814nYUK+WldpMkmJe57Twc5JTyjQNp?= =?us-ascii?Q?H4LVvjgMTv2soFYkWOvU3eBH9nBKNFyllqbRQB1I4+9iN4G9NuBPdBmOFWE2?= =?us-ascii?Q?LxPt+jvT2o+JOIdQwWXlGVRCjtmapramKRetgg/VkWCY5b3fTpg/5IkR8TKT?= =?us-ascii?Q?AF90YwGF/jXUapPMb0hX7QgIzPYVsIAl/cx9BhBBARtef9HUa/ciBCNig9qb?= =?us-ascii?Q?iAwhxh9tnYGCa07ygAJXCnqGNp7oF5wK3XJez02YZDxkkx+OPP6+a8rWVwpq?= =?us-ascii?Q?04LGIsTZVm32DxfHgXc0TQxYcU93u+v75e4ozRtHjNO5jt36P0q6MVDZ/DOI?= =?us-ascii?Q?8pdFL2oTEjn63i6RncXWZwCqomZpdyP/BGYYF6uMTHEYiYqGaaNl+Zilp6xw?= =?us-ascii?Q?y8G4MIW+HAuLXJONTuVaL1s5kLVAUKy6UIVthQD7iimWkKe+3E8uArRygFGH?= =?us-ascii?Q?qcGXrDfHQjB21aevPnlJa5H71Vkx0UIEQKw9euMm2KTE90K44NSOr62IHUhH?= =?us-ascii?Q?/Blm2e2kNt+RtpNkTyK4WtL/EHbkryH9P8BfMq1eZbRt/2hiD4juy+I5iVZD?= =?us-ascii?Q?p1/QY7+37uCN8E2UeKttUxt7nWhrCsEyn17D8gL4jOYMxa+5RP4ZKs+RxfKi?= =?us-ascii?Q?TknZW4vc/D3+UfOM6T4LE/jItx0J/uQWNvBDBPmyuA/JlrH15oSLx9qVTcxY?= =?us-ascii?Q?G5YHBkO5u58rlBggvXdlAw74TEWLJKi63ozsyjS/O/PgC5hdG+AHTb7AZXqN?= =?us-ascii?Q?id7L4sy/Z9kN3sLRELx4dm3HgK0HV69cXZp5eStDzmOnS3DGkbas6c3RDQaL?= =?us-ascii?Q?exOtCP6Xn5MdNFV+zPrzBPvT4r6uuaF4Omi1y4+VIIpSx3AjtN1hh+XZVmup?= =?us-ascii?Q?/YbM/NbolaGLRJcoGB0PHVbkrNfre2SywGxRdyDEmWjOWcWBUqUpUMChiUZa?= =?us-ascii?Q?IOFUh/7AdvrNi46CfSofylJWgAnpg2oSOajpWGeCQA23RbIEEfQQrBlJr2MH?= =?us-ascii?Q?L5WJfGaVMIV1DVubftZ52k87VPYTSJZXxz4Hr4/ZP9U0vBTvyjzEohjumYbZ?= =?us-ascii?Q?n+H/HjG7yskruh2XRKoSxNmNT83dZ6AZ0QaYc9w6tQ65grXqTqirvNlsa2Lx?= =?us-ascii?Q?TiR2JXxGf+1rZhewZNPdoFA/+SOHV9/06jq4cAjK0U0uXtRH1gWr+mQe8Ta7?= =?us-ascii?Q?blztMuL12BEmKINBjUxPR2BJju1r2rX0W4MNUfd4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e32ad1be-9c5a-4b93-f649-08daeeb40c8d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 00:30:29.8344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MplpogkqOmXHkvRPrB29iuzK1lui7oq1weSpsU6o7vS0+Y18XhhVf/Unp0E62+YWRidT3P+NyG0REx0g5Dl0NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7529 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram Note I had to fix your author format from S, Ashraf Ali to match convention= /use. I believe that you can fix this in your groups.io settings since you= r signoff is correct implies git is correct. -----Original Message----- From: S, Ashraf Ali =20 Sent: Sunday, December 25, 2022 10:06 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Ni, Ray ; Cha= ganty, Rangasai V ; Oram, Isaac W ; Chiu, Chasel ; Desimone, Nathaniel L= ; Gao, Liming ; = Dong, Eric Subject: [PATCH v2] FIX MinPlatformPkg PCIE Base typecasting error. PCIE Base Address is 64bit PCD and the Mem Limit UINT64. so typecasting to 32bit is not needed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4068 Signed-off-by: Ashraf Ali S Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong --- .../Pci/Library/PciHostBridgeLibSimple/PciHostBridgeLibSimple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciHostBridgeLibSimp= le/PciHostBridgeLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/Pci= HostBridgeLibSimple/PciHostBridgeLibSimple.c index 0e3fee28b5..e38975eee5 100644 --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciH= ostBridgeLibSimple.c +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciH= ostBridgeLibSimple.c @@ -90,7 +90,7 @@ PciHostBridgeGetRootBridges ( if (PcdGet32(PcdPciReservedMemLimit) !=3D 0) { mRootBridgeTemplate.Mem.Limit =3D PcdGet32 (PcdPciReservedMemLimit); } else { - mRootBridgeTemplate.Mem.Limit =3D (UINT32) PcdGet64 (PcdPciExpressBase= Address) - 1; + mRootBridgeTemplate.Mem.Limit =3D PcdGet64 (PcdPciExpressBaseAddress) = - 1; } =20 mRootBridgeTemplate.MemAbove4G.Base =3D PcdGet64 (PcdPciReservedMemAbove= 4GBBase); --=20 2.33.0.windows.1