From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.10471.1678233696853971937 for ; Tue, 07 Mar 2023 16:01:37 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KYOHPCRi; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678233696; x=1709769696; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7c3bPKoE3TxjhFIUdYA6cv5DZ7ZgjA/mK2spWB8V3LQ=; b=KYOHPCRihrNEmu2u2L2JNEM/ONnPQXd4pIGVrebveI+eR1n18jlLQF/G INigFMrej5bybFXta3wXN3+4PIWqYXV7poXT82qdDePO4fSK5dVuWnCMq kp2O9KIvCHdwsH4nUbWWHs2iWC9rjj3oZV3iFMTfUwpdJDE/cD04l9sg3 ECa+duXUxoUhNxuWaIVhZXczaV4IZ0MmaaqUKfRGODN8Suu6f1KFju3cC N9PiFa9u3J0jNoOTFvt9iwNi2hSFYCc8zoQoNjBW1IX2PEScpDimjf00c 9NIzmnk5++jrDNeiuw0y+1SKzBHvzw/ScxvKRWL8En71jyOGT4O/8bwes w==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="338334458" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="338334458" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 16:01:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="740904031" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="740904031" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 07 Mar 2023 16:01:35 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 7 Mar 2023 16:01:34 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 7 Mar 2023 16:01:34 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 7 Mar 2023 16:01:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hn0Og2laOIRKXKc3C5ijHdrezmKfqkecrk8tctynBC6AX/fYsG4PLw9P1mBQdos7BeW60rGCDpQeESzd93nYMOaASjdOfVK7ED5qdf/5wbTeNMXLVhYQMBMpSFJkXKZH0fesBoknoFaN9u05g4PpISOx7brAPL1IGPqfVJs1dsTS9yEAjb4mkHswBflcGS4c4ZsDqwtLVcYgix3rvOnzE5naH5GmkruS9Cw24Pno3mbCv8/4Yrn9kQJOgRqAjiqAbjvT8ksA3ChGLvXiYAFqsw8WmRmdm3/S4nQ39pG2k9Qh/lmoBgMqU2LWgUaUyoQeKlZlcu2yWl6pXxKtkHeUZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+OnJVIf+9ajzbTIEgwHPrUnG+Qg4Eky7lZCCbn2cec=; b=CnnzZ9L/FdW2f/y6/WAkgAyZrAWzuiuhLcgw1d+4ORE1NxVmUd+P/ttcfKJdh/tmWyHbHhChLqxa6CIcuuPBqF33k9zRcgN4s4dJH7M5AObEo3qqEm/6eCU6Dqwq669zMME0NssXjQfFFHd2486R9tGsfSmgHRVKcn/jil5/z3JiEI77uDeUbWtsu6YcfW50fiOnXyRYpZhMDOCwYXeRtjMTIOpzplWf74Op1H+S0xQbWoVCQoxpaV9e1FYSWI4KkhhXVu2dQmdgOF19VMtNLiPk+Epvj4No5kahFIE0K0cyBzAWzwVl3oAWNXWkpza5jiuHIdcg5w2zNNHPgkky3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by CO1PR11MB5009.namprd11.prod.outlook.com (2603:10b6:303:9e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.23; Wed, 8 Mar 2023 00:01:31 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::2319:e5ae:6470:462e]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::2319:e5ae:6470:462e%3]) with mapi id 15.20.6156.028; Wed, 8 Mar 2023 00:01:31 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Nickle Wang" , Igor Kulchytskyy , "Abdul Lateef Attar" Subject: Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions Thread-Topic: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions Thread-Index: AQHZTX662fdalc4TIk+erj9uvbYLEa7wByCQ Date: Wed, 8 Mar 2023 00:01:31 +0000 Message-ID: References: <20230303031709.1481-1-abner.chang@amd.com> In-Reply-To: <20230303031709.1481-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|CO1PR11MB5009:EE_ x-ms-office365-filtering-correlation-id: fd7cf25b-b5e1-4038-d9f8-08db1f684627 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bYknqbp7uxa1m3U8li+P9W02uzYWTnBxzQpTFcxtM0IHHVOXUrEKtG7Egmjfb18oWOyND5jeaumQqQQt+idwuJy4QGMzDwFOFYjbZtZLcTuGmv7NqQvW/MjOWcQTgZwRTJhx+Z5StFgCpGeJFGk7hjoWSMVOhRG1wWWceM+o3+MBHCWpFRG82I/hmNRs7n20ZPtRq3dCXQfySbK61iFDqhPpszNtwoIdqGX9vtqPsAPgkXj3OEAdKssZa2hodhKEs/Qmorkq2Iipj7lhoIJNpu65RvGsLnGZDDxb8FbqFmLPcpc4gwlqhutezZ25fyKzxcy4UGRZ5UXdEY8Ur6MmLbk/XfLuTsd9MFKX7I0JlwB9CPvjXmd7/g8LaaYU5Yi5huXz8ClaRLl8B+LrtP0xQIRyQ8B/P4MFZLq1FR3HgOI0v6kayJwyse0S1oKWVVs8wYbcVSWq7TswHC4e7vbk75jb2Kuq1819WjDMtfoHT/8R/5Uo5K4jmbxWpJ6iXyLsdJv1c8a6vVDUzQlnVxAzDg1j6qBI7EBVXmk6uZqw1un1fxkaNu17QyQ4wDyD6PbtsRsrqVUxdfNYWKRR2bvtIlaO2QQUQhSz8r1OaGZrbGNsH/zeklLRhDXZGVwDuV/SGvAsQudUA6iKf/9BI3EpoG2panRO078EqyZBJ31IquYvK1fqSrt3CRyCFTuCzGXJgopvzvLTK7YnD3knevC7NygPaVtmLeAX3K2EMObQRS0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199018)(316002)(33656002)(83380400001)(478600001)(7696005)(966005)(2906002)(8936002)(6506007)(186003)(53546011)(9686003)(71200400001)(66476007)(66946007)(41300700001)(52536014)(4326008)(66446008)(66556008)(76116006)(26005)(5660300002)(86362001)(64756008)(8676002)(82960400001)(38100700002)(38070700005)(54906003)(55016003)(110136005)(122000001)(66899018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fXYW216IdHyLonCu8CpsMREXdWwYxQvCaGoFWYm+RBkrvlMqtCyFQkIJlXmB?= =?us-ascii?Q?kyA/mNa6C9UvUdMy/6MvMWVdRLWidrKc3qeP7Yms1fSK+HIpHGM2frWh9xCa?= =?us-ascii?Q?OcbEft/br4GOjW0r7cyVPXy10sME4CFje1aF1IUGk/TWt7dDqMDcYNAp7hLb?= =?us-ascii?Q?hhtWRuqtIjYa5gyNXNWeQqn3vmxF7wQ7sj69opZz4YSvfxENnSLHT9ijH97c?= =?us-ascii?Q?tZmEct7eKdH5J25RJnA+n1oSz0DpEmtYpns+qRazDiDNPrwkHY8e8F4P5l4B?= =?us-ascii?Q?eqN5RkXLWWcdK5Lln47273DZEDlSxgS5hnYIcYOmBE1zwX2bbnZOejs9V5Jl?= =?us-ascii?Q?bmUWwSrbfd8BJ5rbYQiG5W4sceki4uXcTA17ULg9Gbyb/5sX9PRTT/NOIOfj?= =?us-ascii?Q?66KN1+IH/lhJvNWYj8UKZAVNCgm+AQL+i6eBND2zhRhrE9OolUXTviGmLd0X?= =?us-ascii?Q?rKJlnAsrUoBCisPKcuVYsPnlQmciKUyRhTKdppr5pk8DlkLfKtG3qwsBDWIW?= =?us-ascii?Q?dsbDq6Kevj22EOwSQJTyHrGg7h1D3UlSkqYnUoRzE/plhXW2W07hWNML4PpX?= =?us-ascii?Q?Jpa7CVo3XLj7BYGKAyEiNTTbyegmqV6o0waOJcK0anKCCCFLa3R7tUbYrPta?= =?us-ascii?Q?7kwERZMv2sMx5eexTx2VPDoZVDbzkVzX0EaScRN9WJ5tJDwJaribQa4J7+QY?= =?us-ascii?Q?+VKkUfrztc2f4BztqilrAar9lX8PXLNtbNDo66UPf1BlqssiBluOMvWivQPV?= =?us-ascii?Q?d1SWIQVeIjJKJ7yc0EIyP4dhdd97YOmYlfcTmFPSb7cZB6NFBMysIWRf/5FL?= =?us-ascii?Q?1IHaJ3WbRlAjmhN9+Rrh4LabWu0xod0Tg+B0X6j0jw8LpyT0C91+/gTRk+H1?= =?us-ascii?Q?xiCKsTjMjMlf//mEi/mcy6liPJ7N3pzCH8H5k67tblidnE9DE8rEGaHspn34?= =?us-ascii?Q?8HuLPjpoApmmUXABVYaVDux41jVnq/jdLW/9f/P+F9TtO8hRftVrzn3juE6k?= =?us-ascii?Q?f2nbxURgcLbG2rkqZQjvwBU+NcjW98eeRY98kIFvNrNB4gbG81iHa0625etZ?= =?us-ascii?Q?FxhV/YF0bw5rtYYUtbNa7kK9P9sn0jQIahGSYVw6UAOSD9ixF7tqh91a+igR?= =?us-ascii?Q?McPOJipvvgPlaCOic1cS8t6ahRLzktu8oGSpSIc5bB5oWPhNKAT3qmB03ONN?= =?us-ascii?Q?Ee9BWfVWCNVwfF7BwAuEmKwPHwyrP/bHvFAFREu/JfaCm+OFRFvwgdRWZn2V?= =?us-ascii?Q?cf/1/MpXZehM7Qphgcp23pJTU0RTgWakRnpA35zjuEJSU23rzVIMj3B7mqkc?= =?us-ascii?Q?OE43v8MUM/rNOo++M7SIhYo9jHiK/VseS4kApbPo5/V5LBODNvSU97n+JClA?= =?us-ascii?Q?Z/HgRD4TElcJR5GY/5hv147t7HmNZdqvXKZmc3FIHLVx8v6QBaNKqemdEZdC?= =?us-ascii?Q?lAJtpDnQVxvzHRqc8rtq5BNBPjIHzd71ds07p19FDUlyyinutKk3iqn1WReh?= =?us-ascii?Q?wqqsFgVXCfdZ1oy4JN1CZtHYhj89MxYpPrgbsJ8tqEhD4J4Cfp4/rqfDhYCa?= =?us-ascii?Q?2HEbTDPJw8qn3ydSv/WgoVxYwz2oTrFYkhpU2fHN?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd7cf25b-b5e1-4038-d9f8-08db1f684627 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2023 00:01:31.6977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PU5dk8OkvnlCpsW1d3MJVdaGKsFQRHpNN2+lMh+peDd6lacuJDzLJ8FM4VsdtE5qHyP6DwhqJZ/yO14bIm4YXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5009 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chang, Abner= via groups.io Sent: Thursday, March 2, 2023 7:17 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy ; Oram, Isaac W ; Abdul Lateef Attar Subject: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Spec ref: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-sec= ond-gen-interface-spec-v2-rev1-1.html Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Isaac Oram Cc: Abdul Lateef Attar --- MdePkg/MdePkg.dec | 5 ++ MdePkg/Include/IndustryStandard/IpmiKcs.h | 77 +++++++++++++++++++++++ 2 files changed, 82 insertions(+) create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 3d08f20d15b..0ed03= 3983bf 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -9,6 +9,7 @@ # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP
= # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights = reserved.
# Copyright (c) 2021 - 2022, Arm Limited. All rights reserve= d.
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2332,6 +2333,10 @@ # @Prompt Memory Address of GuidedExtractHandler Table. gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000000|U= INT64|0x30001015 =20 + ## This value is the IPMI KCS Interface I/O base address used to transmi= t IPMI commands. + # @Prompt IPMI KCS Interface I/O Base Address + =20 + gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsBaseAddress|0xca2|UINT16|0x00000031 + [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## This value is used to set the base address of PCI express hierarchy. # @Prompt PCI Express Base Address. diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h b/MdePkg/Include/Ind= ustryStandard/IpmiKcs.h new file mode 100644 index 00000000000..6533135dcde --- /dev/null +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h @@ -0,0 +1,77 @@ +/** @file + IPMI KCS Register Definitions + + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights=20 + reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + + @par Revision Reference: + IPMI Specification + Version 2.0, Rev. 1.1 + =20 +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi +-second-gen-interface-spec-v2-rev1-1.html +**/ + +#ifndef IPMI_KCS_H_ +#define IPMI_KCS_H_ + +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1 +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1 +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0 +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0 + +/// +/// IPMI KCS Interface Status Bits +/// +#define IPMI_KCS_OBF BIT0 +#define IPMI_KCS_IBF BIT1 +#define IPMI_KCS_SMS_ATN BIT2 +#define IPMI_KCS_COMMAND_DATA BIT3 +#define IPMI_KCS_OEM1 BIT4 +#define IPMI_KCS_OEM2 BIT5 +#define IPMI_KCS_S0 BIT6 +#define IPMI_KCS_S1 BIT7 + +/// +/// IPMI KCS Interface Control Codes +/// +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60 +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61 +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62 +#define IPMI_KCS_CONTROL_CODE_READ 0x68 + +/// +/// Status Codes +/// +#define IPMI_KCS_STATUS_NO_ERROR 0x00 +#define IPMI_KCS_STATUS_ABORT 0x01 +#define IPMI_KCS_STATUS_ILLEGAL 0x02 +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06 +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF + +/// +/// KCS Interface State Bit +/// +typedef enum { + IPMI_KCS_IDLE_STATE =3D 0, + IPMI_KCS_READ_STATE, + IPMI_KCS_WRITE_STATE, + IPMI_KCS_ERROR_STATE +} IPMI_KCS_STATE; + +/// +/// IPMI KCS Interface Request Format +/// +typedef struct { + UINT8 NetFunc; + UINT8 Command; + UINT8 Data[0]; +} IPMI_KCS_RESQUEST_HEADER; + +/// +/// IPMI KCS Interface Response Format +/// +typedef struct { + UINT8 NetFunc; + UINT8 Command; + UINT8 CompletionCode; +} IPMI_KCS_RESPONSE_HEADER; +#endif -- 2.37.1.windows.1