From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.2648.1659985750346005612 for ; Mon, 08 Aug 2022 12:09:11 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XQBFElSA; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659985750; x=1691521750; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=f7Dk9lyf64ndY99lL0fips7Z2Nu7uNvy1yPUgTeMGnk=; b=XQBFElSAWjrEGAW1Slhixl25iqCVqnvQpKEnWDlogTuHM5WmVQkmuVMJ c/y/LsaCnNMvAHChIb8B3YyrxL0nzlMDpZT7UlpPipDIJzTYsNdSMkFLB JhBTvgp0VSnrD9bEjbXD3jsnWCvZPJjVG2XfDQAMUwbzb0BYsKKF4rmTY bYerUY3AHps2OKIgTuxdXjjn6NY5L4Ukt5VIMpldOZyZ/Dtm+lLUGprnY PjmyxOaCtkKohpde9rrpIf/spx9FgM3GrVEqM38nbdaEqPjmh5PBn92Wh kYSUzhq4tXGCKPY6WN48FswGRiyJeYaI6hctTCBcTAAACVwtzr2S5RZXo w==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="354673480" X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="354673480" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 12:09:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="664094126" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 08 Aug 2022 12:09:03 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 12:09:02 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 12:09:02 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 8 Aug 2022 12:09:02 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 8 Aug 2022 12:09:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLBDtUnay2EdyecIrra4OxcNtqMmqeff6o7myfdn3MxAm8n+JEyD8aFoKKbDXScxO2H8TImw8IRbBOXtW0RXs4yXHk2+mpsy0oUhS0npz/FWdBQSXsk6X8Hkt/IHpCUPcnPYYjIhhvNE13Kqxbv9uZq06n0BhB4FaL8aYgJUPsvQyLmOZgj3rAugQbHgVgro/Wi5fcPj71DdCJp64V3kBXgBX7WUt2JdwyghPp2jKZXWotVJT18YlI4nYcwZ56NF6+hrCjbikLTwdc0b9QqNG/ecVmwPAh0V+wVntkFFFbdXV5N359PnVyz/Ri7y2FA6rTOhK9UBrTeNNvcPCTqFOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=phKUhKy4COZMkFo5KbYH2DLkgoXqfwNVMEJnPrfuL5A=; b=GpddrG/5rqvOD2tL5xPXfoh9xenFe0LoKhzezWdyb5tB0hbG70GKskJUvN8o+CAaWBryLyZFy0YDh7eHZX+KP71JzXSz52oOyIR3Q/JoBf6tpaSl+v+xWBSfrklTEGGRbI3XRU5ksSCUZyVVSCKMbQC82qPFqBo3125whC1ibvH3dUONJnTt4CJLWnFqMElhWzFDsiMyXbeEWtBW8P1/DsWKltkT0uvtCYqqCELKpOHt6b7Uc3suyEPqvMw5Ms+R4LALnAv1uj1dgxyKmQAILooX24z4ebxCFzGRIFEbANC4T4epY+q8BOkwbVsNyaP+R+sS2Okcpe6P3UCgq7smMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM8PR11MB5621.namprd11.prod.outlook.com (2603:10b6:8:38::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 19:08:59 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe%9]) with mapi id 15.20.5504.016; Mon, 8 Aug 2022 19:08:59 +0000 From: "Oram, Isaac W" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Thread-Index: AQHYqPWVetpvGGDXDUu9xY/8CdvRba2gxSLAgASdhrA= Date: Mon, 8 Aug 2022 19:08:59 +0000 Message-ID: References: <20220805180213.944-1-mikuback@linux.microsoft.com> <17088D791A06027C.21918@groups.io> In-Reply-To: <17088D791A06027C.21918@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e964248-879e-46b2-3333-08da797172fe x-ms-traffictypediagnostic: DM8PR11MB5621:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xqQEvCxi39bEUPR8Z1uE0nMUKR22Tymhp9D/J2bo4OFONwZvQkt4nz2a3chxQ5RNYFUqBvSYRwRzSIJzQnHJv/bE4wuGOcB6oD1bHNYYjqMxVyNmPBTksdM1AwI9F+d0RvlFDJruD3lSyU10O3l0sq08ARgWZAGfKVpyUGW9ExcJ2hKCdZ3bow1sDq7/QAQXdpWs941HoTIBxfDCrRL7NCJZh9BnpJ5I+WQXuxaLA3l9XRYDUsyqkO521qmvCzjjM+ov0ta6s+YO8338INJgGN9VHdZxCoaPbndjKMY/4R3CagjEI6yTkxzK34xmbLtvQRT7c7dGRux2HbszQE6u1txhbliw/ao/9ccK/OOs1S+uyeqldoMWeOzEY4k4oQTJq4u7NlRCioRdu4rDZ6nTVUFmHYPF5X+IKMf0JWoYoU/8ZYQ/cxk2GgxYHWYQA85sJ0rFPTqwARZEPWbFRLJVoYmkdCScxV5UP2v0nmwt2n3+XBx0QSB33hczhomc2/oEDGeyBR1aQjRUlN+Zq1lLYURvArIPEBURUAxyg5AAL9kmFKYWJQ/wH4PYnW084xCawxK2qsqX3gMEgRl1J8hEI/xAkxjdaEkEGxKSNm3ZvLb3BwwHADib57JGWVWW9yOJOxFV0gVXAaA97fGGiqh6rfnfz78FNCi3gMsnCBJU2fs2DrB4r/BIV7a+YAkGuMeHjyWMy4g/znF9sQzpMUhO50+StzOyNlH6681A/u88S2X5pwWxGMIKxOyGf7Hn/sFlkPXdYrv0s+YarpsPvztEnyLgZ8Cf2NFK8W2uhE3PX2KLbV1ADwUicouDBbHHbAOTVsNILcZ8ryvUUzJaijWKE66U5alNtue3KAiZ4XMVumQEHPv3O3YBA7PIiLFEa5m0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(376002)(396003)(136003)(366004)(8936002)(8676002)(71200400001)(55016003)(4326008)(316002)(966005)(54906003)(5660300002)(110136005)(478600001)(76116006)(66476007)(66556008)(66946007)(66446008)(64756008)(41300700001)(52536014)(53546011)(6506007)(7696005)(82960400001)(2906002)(38070700005)(86362001)(186003)(33656002)(107886003)(122000001)(38100700002)(83380400001)(9686003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?13cX2lYN9WG0Bxofogs0pkOh6hC9rjNdzf399Fx+PUynY3+4Ias1rLHLSgYV?= =?us-ascii?Q?OQd4ZI7fSQnmBVNRgBsN10uSyH9Dwf8pdLDk65E2GvDq6/Xy7CzNeLosAvzv?= =?us-ascii?Q?U8dXWWCm5cRO5RzdLEvTxBCiRIZdGcTj0U4ytk8OIactR61/807Aa59vJgIY?= =?us-ascii?Q?2iubGQ+Wb/dQUyb0pRjd4GMBlhlLtrj9KoYqwuQ5GDHpX6ZRSS4nUM6KuVZB?= =?us-ascii?Q?cgoX40GLA9C40rz6FTjQ1R67cdWQDYxk9Cu4RFGZKH1FHjbVf3SA6zoCJwK5?= =?us-ascii?Q?K4tev2O6+SMPuTMpWGGI391zm5w5WJoyfD9kxDxtWZxR/OSRQZWwI1yWY7Fd?= =?us-ascii?Q?Jml/iXA14UjPs4GjXqNMIJYF8DX5vf2idocciO1NcSZHXY4lBN7SHsDrn8su?= =?us-ascii?Q?VjleuONBq4JwfGlwvTuie4ap18caW0PTqYGJIGT9R9wFBf4MW5eyM+6H6n6B?= =?us-ascii?Q?juN1yJKtLCR3LnK3ZWmnnIqAG8/QX7k00Sl9Z06AquxMJUC/U/r5B9zDWH2+?= =?us-ascii?Q?IHybGQOEnfNMvelPSQnwwjy6DB3ctPu5XqwDefZ8lh40y77IVBFtvo9aLsY/?= =?us-ascii?Q?cFANenk9lW1JeRBJ6XBwYlMSlN2fgdJ5tdP+nPyuidMr2wxZQXVbGlRDWsJO?= =?us-ascii?Q?p/gWYlQAjliQp62QzU2NqeUp5+WsHK32Y/jMoNMcu7qtGOtX3YKl2cFPx142?= =?us-ascii?Q?vTwXwVl/9zGHUTiYLfnOUdc9LdflGx2+TTRcl5DZBcC/S/TKkAeBL8UfdFM/?= =?us-ascii?Q?deYXM3JXYv5rut+E/6XaFjC4Md2gJqoQ73nkQhTkqA+Z8futhYsqKDv38AX8?= =?us-ascii?Q?C6lAxK3VmfOtO6SydTT8AUHGLUuTfw5RXwR9P3cHEdAlbYQHzA46DiUAD4ra?= =?us-ascii?Q?RovSB8wudUIGqObwIF04IjRWS8xvCscKc54RU8mCoYjSDG5CapJbzIkqfc+d?= =?us-ascii?Q?tT8wpgjmMazhw27TooiTyOiaF17MUdwAX02md7R9rjTXwVNagnyAyghqn6mH?= =?us-ascii?Q?+NQ3lQgCvHvsmOw4Uo1VhJKW887HMEoSv9v1nK0ORYllyRybOsBNcxgtgcX6?= =?us-ascii?Q?XAKrfPTdfSFu7WOJ2DBupNjX599oFL94cqrg7zgefmeV/YSt9DxIzEyLpjs2?= =?us-ascii?Q?sDgZ0hyLsFk81Q4tF+gtLT7uLBSM/d/SFpC5yEGIZH0/TWV8qQWP8StkUPCa?= =?us-ascii?Q?Pli46f9O6VuDr5LCldHdx4FdYthph/LSXRTJ9PNofuayhQnaGBrRXi2hcpoh?= =?us-ascii?Q?NgxXPdkt4dnnux2D/MK8nkg/ZFKcd86VOji+CTF4Vt9cTXDT1oLsfQwZAQAx?= =?us-ascii?Q?iUaOMeJ4c9QpSYEZboHromIufuRGTB4HyIj7V5YZBFJ9AK34sLS3A5hybOnO?= =?us-ascii?Q?pIBQy/8osguXpRmEUD/mW7O4VSgdgpP8pgxijQQ0ze0AvtT0cXd3eAeeET11?= =?us-ascii?Q?72JkRYIAduKzFIwzObDmpOl6jHfyLV5QCRrWLB+7wxRfWJzOzZX3WFchIksL?= =?us-ascii?Q?0Rpi4J092+H6VW/eXNqyKHhBkiO8Uat7bhUDYdK9m138inceWhZcu/0dLcn8?= =?us-ascii?Q?/FTWZP8Zp5+5Ii4KfJn5o96fY5DR+nSn0+u2WyO4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e964248-879e-46b2-3333-08da797172fe X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 19:08:59.3561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dyqDxfBM8qaeE2CA+WgdcfZ4BC8vglb4e3HSseDss26VAxBP0mQ98gdrsUHqIAMiPKlczXhdxV553BPBeOuIyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5621 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as ea2a520c83..60053f3077 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oram, Isaac = W Sent: Friday, August 5, 2022 1:40 PM To: mikuback@linux.microsoft.com; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/Tes= tPointCheckLib: Remove unnecessary GetVariable2() call Reviewed-by: Isaac Oram -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, August 5, 2022 11:02 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: R= emove unnecessary GetVariable2() call From: Michael Kubacki The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemor= yTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library= /TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; =20 DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation - = Enter\n")); CurrentMemoryTypeInformation =3D NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } =20 - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation !=3D NULL) && (PreviousMemoryTypeInfor= mation !=3D NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemory= TypeInformation); } --=20 2.28.0.windows.1