From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.1945.1681334424218275565 for ; Wed, 12 Apr 2023 14:20:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YJXuUYAJ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681334424; x=1712870424; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UFkqU4Cc6NGM5e2y4A5gQF+A11LJ36dZ+rsXmMlU9h8=; b=YJXuUYAJ9/luYoFEVvYyqXWktqloYQ5K+ogxnd4NLZ1cEVMIdzvCizOZ 6qQdt3YXJLWrG5zlqzsGmz0GR76xkfEx+8r6FHSqG5B15AV1hmvRPuN9e qNsORSNuRbcwNTOFY99H+DR+AFAqwNmB//i7gduY/2WSoRRGI6XKv/huV bt/4s29Wpo0U7tPEgfboJBPLB3sPic/6k3xlz+CfjLE82EDOt6c6ZiFq+ Y6W+XD4vpca1idm7xN+Elu5KMKfvN1En4cMToxoidPPmPaYVLBXqsMm88 Cjj3Xl4OB5VuEVCwGKYgMk1Ii0XXQxldWZ7NaTQ8w7ZDr163co0O3E/2O g==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="328139719" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="328139719" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 14:20:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="689059335" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="689059335" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 12 Apr 2023 14:20:23 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 14:20:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 14:20:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 14:20:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 12 Apr 2023 14:20:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZSHcYrBpKY7P608eukSHS+j865O7iFoX61DOQ3926ZWNcXPPHpSTfKG26dOe7XOyLvW1n2z4bipAAVt6INXkwfXcLOqhOh8Y/vAh3q+qeTAXSjUBFV0GpzQfBH+zzOdJtd+9BNSNpQefNcZ8WOxUXth82K9SQy1Yedot2AkoTVcjwmB2W6GCj/rWLWucf1088BBU3iJX04hLnmx9BtMLDJ7xlNUwE9fLv/QV0T51iWXlMSFshnBoGhx0cf8va1buGh1pCoMOaqHDYPNY6fCetCXeg8G7fZkxTVFChu7tQnHqPlPb7skYgJQKMhVa4n76pfnupnreAP8sxlfAf6liw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0BY/SYcOMTH1cNRXfRNkEtm+g5JsYxtFX/ld5SFDULU=; b=G3GgWnQGHOaz8UpEbKhEGBj/udVgi1Otbo2Fm4FCVt13nUhXTgYdSMlZPhmily6Rrs4aKLV2F42NLpOrAsS6imXt3z4ZSQuhIVcDyqyRKOHZ7THW8aZhcrf6We+zJCYFeStnDvdlb3fpmIJGE9iI4UEGnzm+2HkKtkizyeQ3h8/fHSJf28rnxkXJUnQaikaHrT6zKb0xUZj5wtLAFJ6JyQ4lvvAZw9q6qycCExYyTeViYYFfUgfO0pPwf1QHVqpKy4+bc8FKknXTA2F8ySMJW/ungMH6k8w2jtdp+1JjxHx4qXR6Xii53wlme41iiL0Mf0lD43ZFkU1ZSXesiI8BZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by CH0PR11MB5522.namprd11.prod.outlook.com (2603:10b6:610:d5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 21:20:18 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6298.028; Wed, 12 Apr 2023 21:20:18 +0000 From: "Isaac Oram" To: "Chiu, Chasel" , "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" , "Sinha, Ankit" Subject: Re: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Topic: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Index: AQHZbVudaPqxklMvOEiyGITWbNBYwq8n4GYAgABN+TA= Date: Wed, 12 Apr 2023 21:20:18 +0000 Message-ID: References: <20230412162648.308-1-aryeh.chen@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|CH0PR11MB5522:EE_ x-ms-office365-filtering-correlation-id: 8ab83f9b-007d-4a44-fa5f-08db3b9bb75c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xi7Vq1FfUwViXvIaW/fzC9SsYb8bQmpciYEysJSTVMgktPYp9Jj4kdXhQEdNbwrPNohURTtki+cGxLoIu3/2LDsrPWN80WtDgxzcZyvu3Il3/ZoKmuJShpkaEIfUZEYurhQE6B5boo5gIIHAImoc5zBJFPf34k42jynFikS6Zhgmc6c22fhaPOgGkZnl4kja8OgVm1k0zt7jIGKXUgXQPjZ0khYuG81KvTOJB5KFmAlgtiplCLdcLOki2F+4udcKZorSK+j9nnbMm9KnuDHOMhoIN5rd02uBoVzcFx3612o50R3sb604gDLPsGiJWLa/lyKBAhUHUlSuAt+bzjumcX1luy5Lrr7MuCb/alx4EoBlA8Fs7YoWxmuh9Kx1nl7sCwkGtPZSYp8KCP2btEgLu2kdrHmETSFz/bFAHVJJS8agB/ZDnCouF2BzJL6qBNgIt6mlN+FH6CT7Tox4eGRj8RxHhDljaqrmNfqynKYvNzqqe4nKiaR4IHgKJz28cW3jpj/4VdGkUNhcpwi8r7to19DrJD6Fgsqiz5vrpC9nk/C2PH8x2aQSrcw1N4UP6akaEoC3koLC4uA7G5FtYyk+6fewv715ovLI3gB6MCPhjYA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(376002)(346002)(396003)(451199021)(82960400001)(66556008)(76116006)(66446008)(66476007)(66946007)(64756008)(8936002)(5660300002)(38100700002)(4326008)(8676002)(122000001)(52536014)(41300700001)(15650500001)(38070700005)(83380400001)(110136005)(316002)(54906003)(478600001)(2906002)(53546011)(7696005)(55016003)(186003)(86362001)(33656002)(6506007)(26005)(71200400001)(9686003)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z3FKp92kH7BrQerrSjv9uRbUN12jnc7X2QwfHpz0vIQVNwx4+QXHO1rOCI0i?= =?us-ascii?Q?OtLIJlqLyDNLdXdhBHyZmsWFWp2sVMLQY4DqZpIb9vydOFhFgOct75Vl7OIE?= =?us-ascii?Q?rzPsOOQydTfLYMHYxphROKmTRlh40XNteQslmoA2xjmq3LzTxnXJM48bea4G?= =?us-ascii?Q?pQ/3h5OpyKIJR6BjOapnb4kNdgW32y0iqpru3TAo0XNYNiEYpEycMYFhV+lU?= =?us-ascii?Q?ePg5odPD8L+kKOVtcsv1EwpoWZA8UOBNkre1006AdCqAC61kkOb9yzCZuI2e?= =?us-ascii?Q?aPa/Dz3U5HyG4zkIIdORGBGXsu8GhB/9hCynnHPXfWGbBmOiG+rFnvtxj7/B?= =?us-ascii?Q?TceM4fT817mpaM5qKi9WdDiTEjpdk18SJofL1hhTAq2PnMF3+B/fgzfHxs8m?= =?us-ascii?Q?1VGwjcS/lO8eI/kVoeW3Bladw35lZd/yl70uXkAjTfCrSmehh5kz31v2SC0j?= =?us-ascii?Q?UdGjfJ9KT+9NdPxgwhJt0LNmWYjPeqxVthMlazp18zMAiOf2KHxvWwaBtch7?= =?us-ascii?Q?W6ESmKD5SHuDooEMW3Ud8Xs/OINZul3pjawaNHC6fAbXNtu87z2qYj2Egim3?= =?us-ascii?Q?N/rayR1YYX0GrHrJ6EtyPOCjMll/lcuo+jX5Xr7jS+W5H51N9XQxOgz34VBx?= =?us-ascii?Q?XzVhH8HUtm2368YIMVJMOC3cEuG/On6TO2cPa2HJbVN6ra32qnJnl3jR3zdw?= =?us-ascii?Q?bI64aHQ21z2Ori0BfsR3PuPTuaRxQZzPmT5SxCRyX2u2HynwXw/WTpcIgzuv?= =?us-ascii?Q?vlZC156Mr5HqbMdZ4bFJTYJ80qug9FEcZi5SFip+wQXdxPzHEOOz5BK4HPov?= =?us-ascii?Q?Vbg9hmYjOi4cFFFkspYwSIpgfwcPkoFzP08WoLmVVlKpqpJ1lQoz113ParBV?= =?us-ascii?Q?NKXE80+3cQSAPioCquuaZnf+iO+WKkeMoNO7EePybnVyf2x1onc4CyOuOPKa?= =?us-ascii?Q?NPQx3+HoOURnYJJYNyKWnPNuQJoSO0DYeFjYTdA7d5tdL/SUVVNujJy+z1mw?= =?us-ascii?Q?96SKoquM4al2PzPsunXH8ff1m9YPIsLbSlK7Vw0vbG0CI1fXg3oz5Ekd62b9?= =?us-ascii?Q?/MsK/CMbVhNbGX1N89jNkOMU3QbmiBc/PvBpUAKTuiFwZzP7DJEgo7akKzmZ?= =?us-ascii?Q?RLKyL6Gh16YRAVht0ZTticu0zb7LOVlJLJHjgEXsRyV4VingGqiwAhzGOg7i?= =?us-ascii?Q?r2rzyfnbDYZPPe4j4xWyEy2Ex4C3RvGc2ZY9cEwPfosCfkkb3MLAPsiXVVQv?= =?us-ascii?Q?cVF0meG5+9eRITHx+RM00k2TeBCneyvNGDkG89FPt8cTkQoG/XBMUM8ynB/G?= =?us-ascii?Q?3lxSrsAZTioJD1iNSa4MSYcISCaRulz62WwFG8tbwdsRv79Q0EhJhNxKOABu?= =?us-ascii?Q?Jbgxj1GhsYmLZ+EYqJd6MPEUSN5opkaEdacoycnZXcIUlmiZCWh4E2gD/i/w?= =?us-ascii?Q?m0Gm+qkT2sHFeH5eTky7dFh/dH9xupMcc0ZhDKkDvpKKLUs65X+zVxt+0Sur?= =?us-ascii?Q?u1ppWG92MXDtEzn2ESn5RUA/4poy/jRos+4PLU0qgvONRPZ8C+eHAdQvmjxo?= =?us-ascii?Q?wDjr/OM0ZegacmHoYB2B837yBwjuFOayUREE3tHN?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ab83f9b-007d-4a44-fa5f-08db3b9bb75c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 21:20:18.4971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aBiGnhZTr07zVOhzeDC6u+cT9YiAzs9OsHhXJAL/nxWkE2bk3hmpxOdONEuOZBkgPOX7RU9wFuMGYqFVub/vrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5522 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: Chiu, Chasel =20 Sent: Wednesday, April 12, 2023 9:41 AM To: Chen, Aryeh ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W <= isaac.w.oram@intel.com>; Gao, Liming ; Dong, Eric= Subject: RE: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR= REVISION to update FADT entries from board package. Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel=20 > ; Desimone, Nathaniel L=20 > ; Oram, Isaac W=20 > ; Gao, Liming ;=20 > Dong, Eric > Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and=20 > MINOR REVISION to update FADT entries from board package. >=20 > From: Aryeh Chen >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4409 >=20 > Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries=20 > from board package. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 ++ > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++ > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 ++ > 3 files changed, 6 insertions(+) >=20 > diff --git=20 > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 6e57b638e0..e967031a3b 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -1096,6 +1096,7 @@ PlatformUpdateTables ( > case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE: > FadtHeader =3D (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; + > FadtHeader->Header.Revision =3D PcdGet8 (PcdFadtMajorVe= rsion); > FadtHeader->PreferredPmProfile =3D PcdGet8 > (PcdFadtPreferredPmProfile); FadtHeader->IaPcBootArch = =3D > PcdGet16 (PcdFadtIaPcBootArch); FadtHeader->Flags = =3D > PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables ( > FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiG= pe1BlockAddress); > FadtHeader->Gpe1BlkLen =3D PcdGet8 (PcdAcpiGpe1Blo= ckLength); > FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpiGpe1Bas= e);+ > FadtHeader->MinorVersion =3D PcdGet8 (PcdFadtMinorVe= rsion); > FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); FadtHeader->XPm1bEvtBlk.Address > =3D PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git=20 > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > index 451034fb8a..694492112b 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > @@ -67,6 +67,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git=20 > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..784abb828e 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -346,6 +346,8 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 > 0000025 > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900 > 00026 > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000 > 027+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x900000 > 30+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x900000 > 31 [PcdsFixedAtBuild] -- > 2.26.2.windows.1